[GitHub] [pulsar-client-go] xujianhai666 commented on a change in pull request #65: [Issue 64] fix bug: type assert cause panic

2019-09-30 Thread GitBox
xujianhai666 commented on a change in pull request #65: [Issue 64] fix bug: type assert cause panic URL: https://github.com/apache/pulsar-client-go/pull/65#discussion_r329888718 ## File path: pulsar/impl_partition_producer.go ## @@ -293,14 +293,17 @@ func (p

[GitHub] [pulsar-client-go] xujianhai666 opened a new pull request #69: [ISSUE #68][feat]add Option for new producer (#68)

2019-09-30 Thread GitBox
xujianhai666 opened a new pull request #69: [ISSUE #68][feat]add Option for new producer (#68) URL: https://github.com/apache/pulsar-client-go/pull/69 Change-Id: I85a9c9f20e61e126b617eab919d2405a3ebda087 Master Issue: #68 ### Motivation simple initialization of

[GitHub] [pulsar] massakam commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-30 Thread GitBox
massakam commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#issuecomment-536830065 rerun cpp tests rerun integration tests

[GitHub] [pulsar] rdhabalia commented on issue #5298: [pulsar-broker] Fix: invalidate cache on zk-cache timeout

2019-09-30 Thread GitBox
rdhabalia commented on issue #5298: [pulsar-broker] Fix: invalidate cache on zk-cache timeout URL: https://github.com/apache/pulsar/pull/5298#issuecomment-536821310 @merlimat i have added a test which simulates the exact scenario and fails without this change and it invalidates cache

[GitHub] [pulsar-client-go] xujianhai666 opened a new issue #68: Use ConfigOption withxxxx for simple usage

2019-09-30 Thread GitBox
xujianhai666 opened a new issue #68: Use ConfigOption with for simple usage URL: https://github.com/apache/pulsar-client-go/issues/68 **Is your feature request related to a problem? Please describe.** now, when we use client 、producer、consumer, we must provide CleintOption

[GitHub] [pulsar] tuteng commented on issue #5292: [Doc] Add *Solr sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on issue #5292: [Doc] Add *Solr sink connector guide* URL: https://github.com/apache/pulsar/pull/5292#issuecomment-536807186 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-client-go] xujianhai666 opened a new pull request #67: refactor: remove extra timeout param

2019-09-30 Thread GitBox
xujianhai666 opened a new pull request #67: refactor: remove extra timeout param URL: https://github.com/apache/pulsar-client-go/pull/67 Change-Id: I9d5d544808a6f739d79776a4f154d7caceaa133c ### Motivation remove extra timeout param on UnackedMessageTracker#handlerCmd ###

[GitHub] [pulsar] rdhabalia opened a new pull request #5298: [pulsar-broker] Fix: invalidate cache on zk-cache timeout

2019-09-30 Thread GitBox
rdhabalia opened a new pull request #5298: [pulsar-broker] Fix: invalidate cache on zk-cache timeout URL: https://github.com/apache/pulsar/pull/5298 ### Motivation Right now, while creating producer/consumer, broker tries to authorize them by fetching namespace policies using

[GitHub] [pulsar] merlimat commented on issue #5297: Don't attempt to append on read-only cursor ledger

2019-09-30 Thread GitBox
merlimat commented on issue #5297: Don't attempt to append on read-only cursor ledger URL: https://github.com/apache/pulsar/pull/5297#issuecomment-536751955 run integration tests This is an automated message from the Apache

[GitHub] [pulsar] jerrypeng commented on issue #5271: Improve error handling logic for effectively once

2019-09-30 Thread GitBox
jerrypeng commented on issue #5271: Improve error handling logic for effectively once URL: https://github.com/apache/pulsar/pull/5271#issuecomment-536747819 rerun integration tests This is an automated message from the

[GitHub] [pulsar] rdhabalia commented on issue #5276: Fixed race condition while triggering message redelivery after an ack-timeout event

2019-09-30 Thread GitBox
rdhabalia commented on issue #5276: Fixed race condition while triggering message redelivery after an ack-timeout event URL: https://github.com/apache/pulsar/pull/5276#issuecomment-536719899 rerun java8 tests This is an

[GitHub] [pulsar] vzhikserg commented on issue #5205: [doc] Fix broken links to the info about schemas and Schema Registry

2019-09-30 Thread GitBox
vzhikserg commented on issue #5205: [doc] Fix broken links to the info about schemas and Schema Registry URL: https://github.com/apache/pulsar/pull/5205#issuecomment-536692594 run integration tests This is an automated

[GitHub] [pulsar] merlimat commented on a change in pull request #5276: Fixed race condition while triggering message redelivery after an ack-timeout event

2019-09-30 Thread GitBox
merlimat commented on a change in pull request #5276: Fixed race condition while triggering message redelivery after an ack-timeout event URL: https://github.com/apache/pulsar/pull/5276#discussion_r329706992 ## File path:

[GitHub] [pulsar] merlimat opened a new pull request #5297: Don't attempt to append on read-only cursor ledger

2019-09-30 Thread GitBox
merlimat opened a new pull request #5297: Don't attempt to append on read-only cursor ledger URL: https://github.com/apache/pulsar/pull/5297 ### Motivation When the cursor is recovered from a ledger, the ledgerHandle is kept open so that we can delete that ledger after we update

[GitHub] [pulsar] rdhabalia commented on a change in pull request #5276: Fixed race condition while triggering message redelivery after an ack-timeout event

2019-09-30 Thread GitBox
rdhabalia commented on a change in pull request #5276: Fixed race condition while triggering message redelivery after an ack-timeout event URL: https://github.com/apache/pulsar/pull/5276#discussion_r329693205 ## File path:

[GitHub] [pulsar] merlimat commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-30 Thread GitBox
merlimat commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329680805 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication

[GitHub] [pulsar] merlimat commented on issue #5276: Fixed race condition while triggering message redelivery after an ack-timeout event

2019-09-30 Thread GitBox
merlimat commented on issue #5276: Fixed race condition while triggering message redelivery after an ack-timeout event URL: https://github.com/apache/pulsar/pull/5276#issuecomment-536646537 rerun java8 tests This is

[GitHub] [pulsar] merlimat commented on issue #5295: [Doc]to fix syntax err in the sample code: close producer async

2019-09-30 Thread GitBox
merlimat commented on issue #5295: [Doc]to fix syntax err in the sample code: close producer async URL: https://github.com/apache/pulsar/pull/5295#issuecomment-536646113 run integration tests run cpp tests This is an

[GitHub] [pulsar] codelipenghui commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-30 Thread GitBox
codelipenghui commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#issuecomment-536610573 retest this please This is an automated

[pulsar] branch master updated: Update io-cdc-canal.md (#5266)

2019-09-30 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new da04dbe Update io-cdc-canal.md (#5266)

[GitHub] [pulsar] jiazhai merged pull request #5266: Update io-cdc-canal.md

2019-09-30 Thread GitBox
jiazhai merged pull request #5266: Update io-cdc-canal.md URL: https://github.com/apache/pulsar/pull/5266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] tomix1337 commented on issue #5266: Update io-cdc-canal.md

2019-09-30 Thread GitBox
tomix1337 commented on issue #5266: Update io-cdc-canal.md URL: https://github.com/apache/pulsar/pull/5266#issuecomment-536583001 @tuteng can we merge? Everything should be ready. This is an automated message from the Apache

[GitHub] [pulsar] Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#issuecomment-536547443 run cpp tests run integration tests This is an automated message from the

[GitHub] [pulsar] Anonymitaet commented on issue #5290: [Doc] Add *RabbitMQ sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on issue #5290: [Doc] Add *RabbitMQ sink connector guide* URL: https://github.com/apache/pulsar/pull/5290#issuecomment-536547125 run integration tests This is an automated message from the Apache Git

[GitHub] [pulsar] Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#issuecomment-536547076 run cpp tests run integration tests run java8 tests This is an

[GitHub] [pulsar] Anonymitaet removed a comment on issue #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet removed a comment on issue #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#issuecomment-536546908 retest This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#issuecomment-536546908 retest This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] yittg commented on issue #5165: [PIP-43] Support producer to send msg with different schema

2019-09-30 Thread GitBox
yittg commented on issue #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#issuecomment-536546873 @sijie @codelipenghui @congbobo184 May I take up some more of your time to PUSH this PR on.

[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall

2019-09-30 Thread GitBox
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-536545980 @tuteng could you please help review? Thank you This is an automated message

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-09-30 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 I've created the following PRs to resolve this issue: # Overview * https://github.com/apache/pulsar/pull/5183 *

[GitHub] [pulsar] Anonymitaet opened a new pull request #5296: [Doc] Update connector guide overall

2019-09-30 Thread GitBox
Anonymitaet opened a new pull request #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296 Fix https://github.com/apache/pulsar/issues/5015 This is an automated message from the Apache

[GitHub] [pulsar] xujianhai666 commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-30 Thread GitBox
xujianhai666 commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329529524 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication

[GitHub] [pulsar] xujianhai666 commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-30 Thread GitBox
xujianhai666 commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329529414 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication

[GitHub] [pulsar] xujianhai666 commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-30 Thread GitBox
xujianhai666 commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329526225 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication

[GitHub] [pulsar] tuteng edited a comment on issue #5294: Getting errors when creating JWT

2019-09-30 Thread GitBox
tuteng edited a comment on issue #5294: Getting errors when creating JWT URL: https://github.com/apache/pulsar/issues/5294#issuecomment-536501144 Can you write more detailed information, such as the version of the pulsar, whether there are exceptions thrown, and if so, what are the

[GitHub] [pulsar] tuteng commented on issue #5292: [Doc] Add *Solr sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on issue #5292: [Doc] Add *Solr sink connector guide* URL: https://github.com/apache/pulsar/pull/5292#issuecomment-536501819 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] tuteng commented on issue #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on issue #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#issuecomment-536501577 run cpp tests This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] tuteng commented on issue #5294: Getting errors when creating JWT

2019-09-30 Thread GitBox
tuteng commented on issue #5294: Getting errors when creating JWT URL: https://github.com/apache/pulsar/issues/5294#issuecomment-536501144 Can you write more detailed information, such as the version of the pulsar, whether there are exceptions thrown, and if so, what are the exceptions?

[GitHub] [pulsar] kevenYLi opened a new pull request #5295: [Doc]to fix syntax err in the sample code: close producer async

2019-09-30 Thread GitBox
kevenYLi opened a new pull request #5295: [Doc]to fix syntax err in the sample code: close producer async URL: https://github.com/apache/pulsar/pull/5295 ### Motivation * to fix syntax err in the sample code: 'Close operations can also be asynchronous’, the error are as below:

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#discussion_r329503528 ## File path: site2/docs/io-redis-sink.md ## @@ -0,0 +1,69 @@ +--- +id: io-redis-sink +title: Redis sink

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#discussion_r329503528 ## File path: site2/docs/io-redis-sink.md ## @@ -0,0 +1,69 @@ +--- +id: io-redis-sink +title: Redis sink

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5289#discussion_r329502787 ## File path: site2/docs/io-mongo-sink.md ## @@ -0,0 +1,51 @@ +--- +id: io-mongo-sink +title: MongoDB

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide*

2019-09-30 Thread GitBox
Anonymitaet commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5289#discussion_r329502771 ## File path: site2/docs/io-mongo-sink.md ## @@ -0,0 +1,51 @@ +--- +id: io-mongo-sink +title: MongoDB

[GitHub] [pulsar] tuteng commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#discussion_r329502037 ## File path: site2/docs/io-redis-sink.md ## @@ -0,0 +1,69 @@ +--- +id: io-redis-sink +title: Redis sink

[GitHub] [pulsar] tuteng commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on a change in pull request #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#discussion_r329502060 ## File path: site2/docs/io-redis-sink.md ## @@ -0,0 +1,69 @@ +--- +id: io-redis-sink +title: Redis sink

[GitHub] [pulsar] tuteng commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5289#discussion_r329497951 ## File path: site2/docs/io-mongo-sink.md ## @@ -0,0 +1,51 @@ +--- +id: io-mongo-sink +title: MongoDB sink

[GitHub] [pulsar] tuteng commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide*

2019-09-30 Thread GitBox
tuteng commented on a change in pull request #5289: [Doc] Add *MongoDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5289#discussion_r329497914 ## File path: site2/docs/io-mongo-sink.md ## @@ -0,0 +1,51 @@ +--- +id: io-mongo-sink +title: MongoDB sink

[GitHub] [pulsar] Loghijiaha opened a new issue #5294: Getting errors when creating JWT

2019-09-30 Thread GitBox
Loghijiaha opened a new issue #5294: Getting errors when creating JWT URL: https://github.com/apache/pulsar/issues/5294 **Describe the bug** I created private/public key pairs using : `$ bin/pulsar tokens create-key-pair --output-private-key my-private.key --output-public-key

[GitHub] [pulsar] volfco commented on issue #5274: geo replicated subscribers

2019-09-30 Thread GitBox
volfco commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-536420130 The one thing I thought of in the background is that messages would have to be replicated with origin DC and origin ID or part of an Avro schema- as

[GitHub] [pulsar] pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-30 Thread GitBox
pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329418689 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication

[GitHub] [pulsar] pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-30 Thread GitBox
pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329417867 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication