[pulsar-dotpulsar] branch master updated: [Test] Add integration test (#76)

2021-06-21 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 3ed77ff [Test] Add integratio

[GitHub] [pulsar] congbobo184 commented on a change in pull request #10995: [issue 10989 ] Java Client: KeyValueSchema with AutoConsume component - make it work if the topic schema is still not set

2021-06-21 Thread GitBox
congbobo184 commented on a change in pull request #10995: URL: https://github.com/apache/pulsar/pull/10995#discussion_r655892250 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleSchemaTest.java ## @@ -555,7 +555,16 @@ public void testAutoKeyValueCon

[GitHub] [pulsar] merlimat opened a new pull request #11012: PIP-45: Migrate OwnershipCache to use MetadataStore

2021-06-21 Thread GitBox
merlimat opened a new pull request #11012: URL: https://github.com/apache/pulsar/pull/11012 ### Motivation Migrate OwnershipCache logic for acquiring and watching bundles ownership to use ResourceLocks from the MetadataStore interface. -- This is an automated message from the Apac

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655913864 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] newur commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-21 Thread GitBox
newur commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865635305 > You can "batch and replace" all occurrences with just a few clicks. Can you please tell me more about this? :) -- This is an automated message from the Apache Git S

[GitHub] [pulsar] newur commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-21 Thread GitBox
newur commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865634749 @BewareMyPower what characterizes the difference? What value does it add to keep the `while` example? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pulsar] zhucanyi commented on issue #10998: K8S environment sending message connection exception

2021-06-21 Thread GitBox
zhucanyi commented on issue #10998: URL: https://github.com/apache/pulsar/issues/10998#issuecomment-865630890 Is it possible that only pod can send messages in K8S? Or there may be other solutions that enable local access to pulsar in K8s -- This is an automated message from the Apache G

[GitHub] [pulsar] congbobo184 commented on a change in pull request #10995: [issue 10989 ] Java Client: KeyValueSchema with AutoConsume component - make it work if the topic schema is still not set

2021-06-21 Thread GitBox
congbobo184 commented on a change in pull request #10995: URL: https://github.com/apache/pulsar/pull/10995#discussion_r655892250 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleSchemaTest.java ## @@ -555,7 +555,16 @@ public void testAutoKeyValueCon

[GitHub] [pulsar-client-go] freeznet commented on pull request #548: regenerate the certs & tokens to work with Java 11

2021-06-21 Thread GitBox
freeznet commented on pull request #548: URL: https://github.com/apache/pulsar-client-go/pull/548#issuecomment-865622358 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655891576 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupNamespaceConfigListener.java ## @@ -0,0 +1,162 @@ +/** +

[GitHub] [pulsar] hsaputra commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-21 Thread GitBox
hsaputra commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655770860 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupNamespaceConfigListener.java ## @@ -0,0 +1,162 @@ +/** +

[GitHub] [pulsar-client-go] freeznet opened a new pull request #548: regenerate the certs & tokens to work with Java 11

2021-06-21 Thread GitBox
freeznet opened a new pull request #548: URL: https://github.com/apache/pulsar-client-go/pull/548 ### Motivation Pulsar 2.8.0 moves to JDK 11 and no longer support SHA1 signature algorithm. ref: "[JEP 288: Disable SHA-1 Certificates](https://openjdk.java.net/jeps/288)". To mak

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655886394 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceUsageTopicTransportManager.java ## @@ -0,0 +1,275 @@ +/** + *

[GitHub] [pulsar] Shoothzj commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-21 Thread GitBox
Shoothzj commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865525655 > Only need to change docs? Sorry to push the wrong commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655861542 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java ## @@ -142,6 +142,7 @@ public static final Pat

[GitHub] [pulsar] Anonymitaet commented on pull request #11011: [Doc] Add explanations for inactive topics

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #11011: URL: https://github.com/apache/pulsar/pull/11011#issuecomment-865511376 @MarvinCai could you please help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Anonymitaet opened a new pull request #11011: [Doc] Add explanations for inactive topics

2021-06-21 Thread GitBox
Anonymitaet opened a new pull request #11011: URL: https://github.com/apache/pulsar/pull/11011 Fix https://github.com/apache/pulsar/issues/10932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[pulsar] branch master updated (ae03e51 -> 96b293a)

2021-06-21 Thread linlin
This is an automated email from the ASF dual-hosted git repository. linlin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from ae03e51 Do not expose meaningless stats for consumer. (#11005) add 96b293a Fix flaky test testEnableAndDisable

[GitHub] [pulsar] 315157973 merged pull request #11009: Fix flaky test testEnableAndDisableTopicDelayedDelivery

2021-06-21 Thread GitBox
315157973 merged pull request #11009: URL: https://github.com/apache/pulsar/pull/11009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] gaoran10 commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-21 Thread GitBox
gaoran10 commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865504984 Only need to change docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pulsar] gaoran10 commented on a change in pull request #10999: [Issue 9173] [Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-06-21 Thread GitBox
gaoran10 commented on a change in pull request #10999: URL: https://github.com/apache/pulsar/pull/10999#discussion_r655852937 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -863,8 +863,19 @@ public void unloadNamespaceBundle

[GitHub] [pulsar] wolfstudy opened a new pull request #11010: Add 2.8.1 docs for repo

2021-06-21 Thread GitBox
wolfstudy opened a new pull request #11010: URL: https://github.com/apache/pulsar/pull/11010 Signed-off-by: xiaolongran Fixes #10994 ### Motivation Add 2.8.1 docs for repo ### Modification - Add 2.7.3 docs in versioned_docs - Add sidebars in

[pulsar] branch master updated (99c84c4 -> ae03e51)

2021-06-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 99c84c4 Fix incorrect port of advertisedListener (#10961) add ae03e51 Do not expose meaningless stats for consu

[GitHub] [pulsar] sijie merged pull request #11005: Do not expose meaningless stats for consumer.

2021-06-21 Thread GitBox
sijie merged pull request #11005: URL: https://github.com/apache/pulsar/pull/11005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] Shoothzj commented on a change in pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-21 Thread GitBox
Shoothzj commented on a change in pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#discussion_r655847450 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -560,12 +560,9 @@ public void negativeAcknow

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners

2021-06-21 Thread GitBox
gaoran10 commented on a change in pull request #11006: URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842912 ## File path: docker-compose/kitchen-sink/docker-compose.yml ## @@ -377,6 +377,9 @@ services: zookeeperServers: zk1:2181,zk2:2181,zk3:2181

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners

2021-06-21 Thread GitBox
gaoran10 commented on a change in pull request #11006: URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842848 ## File path: docker-compose/kitchen-sink/docker-compose.yml ## @@ -377,6 +377,9 @@ services: zookeeperServers: zk1:2181,zk2:2181,zk3:2181

[GitHub] [pulsar] wolfstudy commented on issue #10994: [Doc] generate 2.8.1 doc set

2021-06-21 Thread GitBox
wolfstudy commented on issue #10994: URL: https://github.com/apache/pulsar/issues/10994#issuecomment-865491172 I will process it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar-client-go] uiot-stack opened a new issue #547: panic: connection error

2021-06-21 Thread GitBox
uiot-stack opened a new issue #547: URL: https://github.com/apache/pulsar-client-go/issues/547 System configuration **Pulsar version**: 2.7.2 **Pulsar client version**: 0.5.0 `{"consumerID":13,"error":"connection error","level":"error","msg":"[Failed to create consume

[GitHub] [pulsar] fengtao1998 commented on pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-21 Thread GitBox
fengtao1998 commented on pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#issuecomment-865484229 > @fengtao1998 can you take a look at suggestions and resolve them as needed? Sorry for the delay. I have revised these suggestions. Thank you for your suggestion -

[pulsar] branch master updated (e3a97ee -> 99c84c4)

2021-06-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e3a97ee [Broker] Fix the backlog issue with --precise-backlog=true (#10966) add 99c84c4 Fix incorrect port of

[GitHub] [pulsar] sijie merged pull request #10961: Fix incorrect port of advertisedListener

2021-06-21 Thread GitBox
sijie merged pull request #10961: URL: https://github.com/apache/pulsar/pull/10961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] sijie closed issue #10951: Function worker uses raw webService Port against adverisedListener and advertisedAddress

2021-06-21 Thread GitBox
sijie closed issue #10951: URL: https://github.com/apache/pulsar/issues/10951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865476822 @codelipenghui https://github.com/apache/pulsar/pull/11009 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pulsar] 315157973 opened a new pull request #11009: Fix flaky test testEnableAndDisableTopicDelayedDelivery

2021-06-21 Thread GitBox
315157973 opened a new pull request #11009: URL: https://github.com/apache/pulsar/pull/11009 ### Motivation When `admin.topics().getDelayedDeliveryPolicy(topicName)` is executed, topicPolicies may not be initialized yet This problem occurs when only a single unit test is execu

[GitHub] [pulsar] Shoothzj commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-21 Thread GitBox
Shoothzj commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865475498 > @Shoothzj thanks for your contribution. For this PR, do we need to update docs? We don't need to update docs. Cause user can't not call `unsubscribe` and `close` at t

[GitHub] [pulsar] codelipenghui commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
codelipenghui commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865472781 @Anonymitaet No, this is a bug fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] BewareMyPower commented on pull request #10982: [docs] Replace endless while loops with MessageListener

2021-06-21 Thread GitBox
BewareMyPower commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865472623 Using `receive`/`receiveAsync` and using `MessageListener` are two different ways for consumer, I think it's better to add a section for the example code that uses `Messa

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865472594 > ``` > Error: Tests run: 19, Failures: 5, Errors: 0, Skipped: 11, Time elapsed: 19.023 s <<< FAILURE! - in Master branch also has this problem -- This is an au

[GitHub] [pulsar] Anonymitaet commented on pull request #10997: [Issue 10996] release multiTopicsConsumerImpl when unsubscribe

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #10997: URL: https://github.com/apache/pulsar/pull/10997#issuecomment-865470913 @Shoothzj thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] fengtao1998 commented on a change in pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-21 Thread GitBox
fengtao1998 commented on a change in pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#discussion_r655828390 ## File path: site2/docs/client-libraries-python.md ## @@ -62,7 +62,7 @@ The complete Python API reference is available at [api/python](/api/python)

[GitHub] [pulsar] fengtao1998 commented on a change in pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-21 Thread GitBox
fengtao1998 commented on a change in pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#discussion_r655828390 ## File path: site2/docs/client-libraries-python.md ## @@ -62,7 +62,7 @@ The complete Python API reference is available at [api/python](/api/python)

[GitHub] [pulsar] Anonymitaet commented on pull request #10978: [docs] use offical postgres docker image for debezium

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #10978: URL: https://github.com/apache/pulsar/pull/10978#issuecomment-865470254 @tuteng any feedback on this? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Anonymitaet commented on pull request #10999: [Issue 9173] [Persistent Topics] Auto-create partitions even when the auto-creation is disabled

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #10999: URL: https://github.com/apache/pulsar/pull/10999#issuecomment-865469960 Hi @Jason918 thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Anonymitaet commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865469387 @codelipenghui thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the messag

[pulsar-manager] branch master updated: Multi bookie cluster Support (#388)

2021-06-21 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 2b0671a Multi bookie cluster Support

[GitHub] [pulsar] 315157973 removed a comment on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 removed a comment on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865468882 I will fix this flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[pulsar-manager] branch master updated (46f9e0a -> 9d9c52e)

2021-06-21 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git. from 46f9e0a Upgrade to java 1.8.0_292 (#398) add 9d9c52e Fixed the bug that admin roles cannot be delet

[pulsar-manager] branch master updated (4796f0c -> 46f9e0a)

2021-06-21 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git. from 4796f0c Use the Apache Pulsar Helm chart (#384) add 46f9e0a Upgrade to java 1.8.0_292 (#398) No ne

[GitHub] [pulsar] 315157973 commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
315157973 commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865468882 I will fix this flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10961: Fix incorrect port of advertisedListener

2021-06-21 Thread GitBox
Anonymitaet commented on a change in pull request #10961: URL: https://github.com/apache/pulsar/pull/10961#discussion_r655826338 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1360,10 +1360,13 @@ public ShutdownService getShutdownS

[GitHub] [pulsar] Anonymitaet commented on pull request #10984: [Docs]Update docs for Client libraries Python

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #10984: URL: https://github.com/apache/pulsar/pull/10984#issuecomment-865468050 @fengtao1998 can you take a look at suggestions and resolve them as needed? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] Anonymitaet commented on pull request #10982: [docs] Replace endless while loops with MessageListner

2021-06-21 Thread GitBox
Anonymitaet commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865464250 Yes, all versioned docs are stored in [pulsar/site2/website/versioned_docs/](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs). You can "batch and

[GitHub] [pulsar] codelipenghui commented on pull request #11003: Fix potential data lost on the system topic when topic compaction have not triggered yet

2021-06-21 Thread GitBox
codelipenghui commented on pull request #11003: URL: https://github.com/apache/pulsar/pull/11003#issuecomment-865452526 ``` Error: Tests run: 19, Failures: 5, Errors: 0, Skipped: 11, Time elapsed: 19.023 s <<< FAILURE! - in org.apache.pulsar.broker.service.persistent.DelayedDeliveryTes

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655801162 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java ## @@ -142,6 +142,7 @@ public static final Pat

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655801162 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java ## @@ -142,6 +142,7 @@ public static final Pat

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655800495 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java ## @@ -142,6 +142,7 @@ public static final Pat

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655798215 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] hsaputra commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-21 Thread GitBox
hsaputra commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655791860 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java ## @@ -128,7 +130,7 @@ public ResourceGroup(Resourc

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655786267 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655777199 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655774547 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java ## @@ -414,7 +414,7 @@ private int consumeFromWebSocket(S

[GitHub] [pulsar] hsaputra commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-21 Thread GitBox
hsaputra commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655770860 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupNamespaceConfigListener.java ## @@ -0,0 +1,162 @@ +/** +

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655770306 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java ## @@ -414,7 +414,7 @@ private int consumeFromWebSocket(S

[GitHub] [pulsar] hsaputra commented on a change in pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-21 Thread GitBox
hsaputra commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655770029 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java ## @@ -0,0 +1,150 @@ +/** + * License

[pulsar] branch master updated (2f8c175 -> e3a97ee)

2021-06-21 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2f8c175 [Broker] Fix create partitioned topic in replicated namespace (#10963) add e3a97ee [Broker] Fix the

[GitHub] [pulsar] codelipenghui merged pull request #10966: [Broker] Fix the backlog issue with --precise-backlog=true

2021-06-21 Thread GitBox
codelipenghui merged pull request #10966: URL: https://github.com/apache/pulsar/pull/10966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[pulsar] branch master updated (87bcee3 -> 2f8c175)

2021-06-21 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 87bcee3 Include common-io in java function instance (#10939) add 2f8c175 [Broker] Fix create partitioned topi

[GitHub] [pulsar] codelipenghui merged pull request #10963: [Broker] Fix create partitioned topic in replicated namespace

2021-06-21 Thread GitBox
codelipenghui merged pull request #10963: URL: https://github.com/apache/pulsar/pull/10963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655768064 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655767044 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BaseResource.java ## @@ -282,4 +282,5 @@ public static String

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
jerrypeng commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655765724 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiHealthCheckTest.java ## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apa

[pulsar] branch master updated (1017fe1 -> 87bcee3)

2021-06-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1017fe1 [Issue 10990] Fix the default value of httpServerPort in reference conf (#10992) add 87bcee3 Include c

[GitHub] [pulsar] sijie closed issue #10938: pulsar-function-instance has dependency on pulsar-common-io, but the dependency is not captured in pom.xml

2021-06-21 Thread GitBox
sijie closed issue #10938: URL: https://github.com/apache/pulsar/issues/10938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [pulsar] sijie merged pull request #10939: [Issue 10938] [pulsar-functions] Include common-io in java function instance

2021-06-21 Thread GitBox
sijie merged pull request #10939: URL: https://github.com/apache/pulsar/pull/10939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] hsaputra commented on pull request #10939: [Issue 10938] [pulsar-functions] Include common-io in java function instance

2021-06-21 Thread GitBox
hsaputra commented on pull request #10939: URL: https://github.com/apache/pulsar/pull/10939#issuecomment-865385690 @sijie - could you review this to unblock the merge request? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
aahmed-se commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655738605 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicVersion.java ## @@ -0,0 +1,24 @@ +/** + * Licensed to the Apac

[GitHub] [pulsar] cckellogg commented on a change in pull request #10962: Support new topic format for broker admin healthcheck endpoint

2021-06-21 Thread GitBox
cckellogg commented on a change in pull request #10962: URL: https://github.com/apache/pulsar/pull/10962#discussion_r655724390 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicVersion.java ## @@ -0,0 +1,24 @@ +/** + * Licensed to the Apac

[GitHub] [pulsar] nlu90 commented on pull request #10631: [Functions] reorganize the context hierarchy for functions

2021-06-21 Thread GitBox
nlu90 commented on pull request #10631: URL: https://github.com/apache/pulsar/pull/10631#issuecomment-865359519 @sijie I rebased the master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pulsar] lanwen edited a comment on issue #5059: [Feature request] Per key cleanup for the GDPR requirements

2021-06-21 Thread GitBox
lanwen edited a comment on issue #5059: URL: https://github.com/apache/pulsar/issues/5059#issuecomment-865199980 @rcusters we offload everything to a database on an event gateway (see https://github.com/bsideup/liiklus) with a custom plugin and keep only references and meta information in

[pulsar-dotpulsar] branch master updated: Minor cleanup and updated the changelog

2021-06-21 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 1622e28 Minor cleanup and upd

[GitHub] [pulsar] klevy-toast opened a new issue #11008: Java client: consumer listener does not respect receiver queue size

2021-06-21 Thread GitBox
klevy-toast opened a new issue #11008: URL: https://github.com/apache/pulsar/issues/11008 **Describe the bug** When using a consumer on a shared subscription with `messageListener`, messages are queued up to the consumer beyond what the `receiverQueueSize` should allow. As a result, a 2

[pulsar-dotpulsar] branch master updated: Minor cleanup and updated NuGet package

2021-06-21 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 1c0ed27 Minor cleanup and upd

[pulsar-dotpulsar] branch master updated: Basic partitioned producer (#71)

2021-06-21 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 85c2f70 Basic partitioned pro

[GitHub] [pulsar] newur edited a comment on issue #10971: [Doc] Transaction

2021-06-21 Thread GitBox
newur edited a comment on issue #10971: URL: https://github.com/apache/pulsar/issues/10971#issuecomment-865272604 @Anonymitaet I would say so, yes. For me transactions are all about the boundaries, so I want to know where does it start and till which point can it rollback. And pictures are

[GitHub] [pulsar] newur edited a comment on issue #10971: [Doc] Transaction

2021-06-21 Thread GitBox
newur edited a comment on issue #10971: URL: https://github.com/apache/pulsar/issues/10971#issuecomment-865272604 @Anonymitaet I would say so, yes. For me transactions are all about the boundaries, so I want to know where does it start and till which point can it rollback. And pictures are

[GitHub] [pulsar] newur commented on issue #10971: [Doc] Transaction

2021-06-21 Thread GitBox
newur commented on issue #10971: URL: https://github.com/apache/pulsar/issues/10971#issuecomment-865272604 @Anonymitaet I would say so, yes. For me transaction are all about the boundaries, so I want to know where does it start and till which point can it rollback. And pictures are pretty

[GitHub] [pulsar] newur edited a comment on pull request #10982: [docs] Replace endless while loops with MessageListner

2021-06-21 Thread GitBox
newur edited a comment on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865246513 @Anonymitaet the versioned docs are the content in `site2/website/versioned_docs`? Sure I would update them when the change gets approval. How far back do you norma

[GitHub] [pulsar] newur commented on pull request #10982: [docs] Replace endless while loops with MessageListner

2021-06-21 Thread GitBox
newur commented on pull request #10982: URL: https://github.com/apache/pulsar/pull/10982#issuecomment-865246513 @Anonymitaet the versioned docs are the content in `site2/website/versioned_docs`? Sure I would update them when the change gets approval. How far back do you normally por

[GitHub] [pulsar-client-go] dferstay commented on a change in pull request #535: Fix data race while accessing connection in partitionConsumer

2021-06-21 Thread GitBox
dferstay commented on a change in pull request #535: URL: https://github.com/apache/pulsar-client-go/pull/535#discussion_r655573130 ## File path: pulsar/consumer_partition.go ## @@ -21,6 +21,7 @@ import ( "fmt" "math" "sync" + syncAtomic "sync/atom

[GitHub] [pulsar-client-go] dferstay commented on a change in pull request #535: Fix data race while accessing connection in partitionConsumer

2021-06-21 Thread GitBox
dferstay commented on a change in pull request #535: URL: https://github.com/apache/pulsar-client-go/pull/535#discussion_r655572053 ## File path: pulsar/consumer_partition.go ## @@ -1113,6 +1114,17 @@ func (pc *partitionConsumer) discardCorruptedMessage(msgID *pb.MessageIdData

[GitHub] [pulsar] lanwen commented on issue #5059: [Feature request] Per key cleanup for the GDPR requirements

2021-06-21 Thread GitBox
lanwen commented on issue #5059: URL: https://github.com/apache/pulsar/issues/5059#issuecomment-865199980 @rcusters we offload everything to a database on an event gateway (see github.com/bsideup/liiklus) with a custom plugin and keep only references and meta information in pulsar. Then if

[GitHub] [pulsar] Zhen-hao opened a new issue #11007: add direct support for message values already serialized in Apache Avro

2021-06-21 Thread GitBox
Zhen-hao opened a new issue #11007: URL: https://github.com/apache/pulsar/issues/11007 Maybe this is two requests in one post. **Background**: I want to integrate Pulsar with an existing event store in Cassandra (used by an event-sourced application). The events are already s

[GitHub] [pulsar] BewareMyPower edited a comment on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-21 Thread GitBox
BewareMyPower edited a comment on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-865158870 @liangyepianzhou What's the need to run `source conf/standalone.conf`? `conf/standalone.conf` is just the configuration file that is read by pulsar standalone star

[GitHub] [pulsar] BewareMyPower commented on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-06-21 Thread GitBox
BewareMyPower commented on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-865158870 @liangyepianzhou What's the need to run `source conf/standalone.conf`? `conf/standalone.conf` is just the configuration file that is read by pulsar standalone starter. Fo

[GitHub] [pulsar] mipper opened a new pull request #11006: Update SQL config to use composed contaiiners

2021-06-21 Thread GitBox
mipper opened a new pull request #11006: URL: https://github.com/apache/pulsar/pull/11006 ### Motivation When we use docker-compose to create multiple service containers we need to override the configuration of each of these containers to use the correct URLs for the other container

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10981: [python-client] Fixed crash when using Python logger

2021-06-21 Thread GitBox
BewareMyPower commented on a change in pull request #10981: URL: https://github.com/apache/pulsar/pull/10981#discussion_r655484022 ## File path: pulsar-client-cpp/python/src/config.cc ## @@ -110,21 +112,29 @@ class LoggerWrapper: public Logger { public: -LoggerWrapp

[GitHub] [pulsar] kjaggann commented on issue #10021: Websocket Encryption

2021-06-21 Thread GitBox
kjaggann commented on issue #10021: URL: https://github.com/apache/pulsar/issues/10021#issuecomment-865108954 The recent change to the pulsar websocket allows the encrypted payload to be passed thru to the client. However, it does not appear that the (aes) encrypted data key is included

[GitHub] [pulsar] kjaggann removed a comment on issue #10021: Websocket Encryption

2021-06-21 Thread GitBox
kjaggann removed a comment on issue #10021: URL: https://github.com/apache/pulsar/issues/10021#issuecomment-844133130 Is this change in pulsar 2.7.1 version. however we have upgraded the websocket version to 2.7.1 in our websocket proxies but still the user is unable to connect the when

[GitHub] [pulsar] dinghram commented on issue #10433: NPE in broker: EntryImpl.getLength()

2021-06-21 Thread GitBox
dinghram commented on issue #10433: URL: https://github.com/apache/pulsar/issues/10433#issuecomment-865107202 @lhotari Thanks for the feedback. We tested with the -Dio.netty.recycler.maxCapacityPerThread=0 option and saw no negative performance impact. In fact, the CPU usage was lower with

  1   2   >