[GitHub] [pulsar] eolivelli merged pull request #11316: When delete a topic, delete the topic policy together.

2021-07-19 Thread GitBox
eolivelli merged pull request #11316: URL: https://github.com/apache/pulsar/pull/11316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] eolivelli closed issue #11308: [Topic Policy] Delete the topic policy for the topic when the topic been deleted.

2021-07-19 Thread GitBox
eolivelli closed issue #11308: URL: https://github.com/apache/pulsar/issues/11308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-19 Thread GitBox
lhotari commented on pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#issuecomment-883085533 > > I'm fine with doing that change if it's a showstopper for accepting the PR. > > I think we should at least separate the PR. I'll do that. -- This is an

[GitHub] [pulsar] eolivelli commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-19 Thread GitBox
eolivelli commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r667031125 ## File path: pulsar-functions/runtime-all/pom.xml ## @@ -86,6 +86,15 @@ org.apache.logging.log4j log4j-core + + + +

[GitHub] [pulsar] eolivelli commented on pull request #11378: Fix bug when check batch source config

2021-07-19 Thread GitBox
eolivelli commented on pull request #11378: URL: https://github.com/apache/pulsar/pull/11378#issuecomment-883079561 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] eolivelli commented on issue #11338: [Pulsar Functions and IO] Cannot upgrade Function built for Pulsar 2.7 to Pulsar 2.8

2021-07-19 Thread GitBox
eolivelli commented on issue #11338: URL: https://github.com/apache/pulsar/issues/11338#issuecomment-883078756 @nlu90 that's exactly the same problem that I found. Thanks for your time in reproducing the issue. As discussed in the mailing list we have to add a note in the release

[GitHub] [pulsar] equanz opened a new pull request #11382: [broker] Fixed Replicated Subscription isn't replicate new subscription when remote producer is closed

2021-07-19 Thread GitBox
equanz opened a new pull request #11382: URL: https://github.com/apache/pulsar/pull/11382 ### Motivation If replicated subscription is enabled, broker will create new subscription in remote cluster at below.

[GitHub] [pulsar] Technoboy- commented on pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
Technoboy- commented on pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#issuecomment-883050007 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscri

2021-07-19 Thread GitBox
Technoboy- commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672802693 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1030,55 @@ protected void

[GitHub] [pulsar] sijie commented on pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-19 Thread GitBox
sijie commented on pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#issuecomment-883043755 > I'm fine with doing that change if it's a showstopper for accepting the PR. I think we should at least separate the PR. -- This is an automated message from the Apache

[pulsar-client-node] branch master updated: Use Buffer::Copy instead of Buffer::New (#163)

2021-07-19 Thread massakam
This is an automated email from the ASF dual-hosted git repository. massakam pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/master by this push: new f34c23b Use Buffer::Copy instead

[pulsar] annotated tag v2.7.3-candidate-1 updated (f9475fe -> 1b686e3f)

2021-07-19 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a change to annotated tag v2.7.3-candidate-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git. *** WARNING: tag v2.7.3-candidate-1 was modified! *** from f9475fe (commit) to 1b686e3f (tag)

[GitHub] [pulsar] sijie commented on pull request #11238: [Issue 11007] add a version of AUTO_PRODUCE_BYTES that doesn't validate the message in `encode`

2021-07-19 Thread GitBox
sijie commented on pull request #11238: URL: https://github.com/apache/pulsar/pull/11238#issuecomment-883023197 @Zhen-hao looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] sijie commented on pull request #11316: When delete a topic, delete the topic policy together.

2021-07-19 Thread GitBox
sijie commented on pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#issuecomment-883022052 @eolivelli Can you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] sijie commented on a change in pull request #11303: [tools] Pulsar Client: add ability to produce KV messages

2021-07-19 Thread GitBox
sijie commented on a change in pull request #11303: URL: https://github.com/apache/pulsar/pull/11303#discussion_r672778409 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdProduce.java ## @@ -114,6 +120,15 @@ @Parameter(names = { "-k",

[GitHub] [pulsar-client-go] wolfstudy edited a comment on pull request #560: Encryption support producer

2021-07-19 Thread GitBox
wolfstudy edited a comment on pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#issuecomment-883021526 > @wolfstudy what is your timeframe for a new release? What I want is to start the release process after merging the change related to this function. If

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #560: Encryption support producer

2021-07-19 Thread GitBox
wolfstudy commented on pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#issuecomment-883021526 > @wolfstudy what is your timeframe for a new release? What I want is to start the release process after merging the change related to this function. -- This

[GitHub] [pulsar] sijie commented on pull request #11172: [broker] fix `GetTopicsOfNamespace` with binary lookup service not check auth

2021-07-19 Thread GitBox
sijie commented on pull request #11172: URL: https://github.com/apache/pulsar/pull/11172#issuecomment-883018587 @eolivelli Can you review this again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch master updated: [python functions] fix tls_validate_hostname is not supported in python functions runtime (#11087)

2021-07-19 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a14f1c5 [python functions] fix

[GitHub] [pulsar] sijie merged pull request #11087: [python functions] fix `tls_validate_hostname` is not supported in python functions runtime

2021-07-19 Thread GitBox
sijie merged pull request #11087: URL: https://github.com/apache/pulsar/pull/11087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: Pulsar IO: allow Sinks to use native AVRO and JSON (#11322)

2021-07-19 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f35766f Pulsar IO: allow Sinks to use native

[GitHub] [pulsar] sijie merged pull request #11322: Pulsar IO: allow Sinks to use native AVRO and JSON

2021-07-19 Thread GitBox
sijie merged pull request #11322: URL: https://github.com/apache/pulsar/pull/11322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on pull request #11368: make maxEnsembleChangeSize can be config from pulsar broker

2021-07-19 Thread GitBox
Anonymitaet commented on pull request #11368: URL: https://github.com/apache/pulsar/pull/11368#issuecomment-883013511 Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] Anonymitaet commented on pull request #11357: [Transaction] Transaction coordinator fence mechanism.

2021-07-19 Thread GitBox
Anonymitaet commented on pull request #11357: URL: https://github.com/apache/pulsar/pull/11357#issuecomment-883013623 Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] Anonymitaet commented on pull request #11378: Fix bug when check batch source config

2021-07-19 Thread GitBox
Anonymitaet commented on pull request #11378: URL: https://github.com/apache/pulsar/pull/11378#issuecomment-883013210 Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar-client-go] cckellogg commented on pull request #560: Encryption support producer

2021-07-19 Thread GitBox
cckellogg commented on pull request #560: URL: https://github.com/apache/pulsar-client-go/pull/560#issuecomment-883012868 @wolfstudy what is your timeframe for a new release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Anonymitaet commented on pull request #11345: [Security] Upgrade commons-compress to 1.21

2021-07-19 Thread GitBox
Anonymitaet commented on pull request #11345: URL: https://github.com/apache/pulsar/pull/11345#issuecomment-883011093 @eolivelli thanks for labeling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch branch-2.7 updated: Branch-2.7 fix Delayed Messages (#11374)

2021-07-19 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new f9475fe Branch-2.7 fix Delayed

[GitHub] [pulsar] congbobo184 merged pull request #11374: Branch-2.7 fix Delayed Messages

2021-07-19 Thread GitBox
congbobo184 merged pull request #11374: URL: https://github.com/apache/pulsar/pull/11374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] suiyuzeng commented on pull request #11148: Increase the rate of topic creation

2021-07-19 Thread GitBox
suiyuzeng commented on pull request #11148: URL: https://github.com/apache/pulsar/pull/11148#issuecomment-883006464 @315157973 @eolivelli thanks,i will Optimize the code and add some test about this function. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Jennifer88huang opened a new issue #11381: The info for TLS security is not clear

2021-07-19 Thread GitBox
Jennifer88huang opened a new issue #11381: URL: https://github.com/apache/pulsar/issues/11381 **Is your enhancement request related to a problem? Please describe.** The information on [TLS page](https://pulsar.apache.org/docs/en/security-tls-authentication) is not clear, and hard

[GitHub] [pulsar] Jennifer88huang opened a new issue #11380: Not clear about the message TTL info

2021-07-19 Thread GitBox
Jennifer88huang opened a new issue #11380: URL: https://github.com/apache/pulsar/issues/11380 **Is your enhancement request related to a problem? Please describe.** ![image](https://user-images.githubusercontent.com/47805623/106427770-e71f4d80-64a2-11eb-8fc3-a467b1e9c6b8.png) Not

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message

2021-07-19 Thread GitBox
BewareMyPower commented on a change in pull request #8173: URL: https://github.com/apache/pulsar/pull/8173#discussion_r672757430 ## File path: pulsar-client-cpp/include/pulsar/c/message.h ## @@ -200,6 +200,12 @@ PULSAR_PUBLIC const char

[GitHub] [pulsar] freeznet commented on pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-19 Thread GitBox
freeznet commented on pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#issuecomment-882976426 @jerrypeng I have created an issue https://github.com/apache/pulsar/issues/11379 with my observation, and I have provided steps to reproduce, PTAL, thanks. -- This is an

[GitHub] [pulsar] freeznet opened a new issue #11379: Directory facing race condition on NarUnpacker

2021-07-19 Thread GitBox
freeznet opened a new issue #11379: URL: https://github.com/apache/pulsar/issues/11379 **Describe the bug** This issue is an extension for #11340. When users create functions with `parallelism` larger than the number of functions-worker, the directory race condition can be observed.

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subs

2021-07-19 Thread GitBox
Demogorgon314 commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672726190 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1032,52 @@ protected void

[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-19 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r672699904 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-19 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r672699904 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] dlg99 commented on pull request #11154: Fixing Debezium integration tests

2021-07-19 Thread GitBox
dlg99 commented on pull request #11154: URL: https://github.com/apache/pulsar/pull/11154#issuecomment-882907228 @nlu90 I don't have permissions to merge; I hope @codelipenghui / @sijie / @merlimat / @eolivelli or other committer can merge. -- This is an automated message from the Apache

[GitHub] [pulsar] nlu90 commented on pull request #11154: Fixing Debezium integration tests

2021-07-19 Thread GitBox
nlu90 commented on pull request #11154: URL: https://github.com/apache/pulsar/pull/11154#issuecomment-882899243 @dlg99 Let me know when you merge this PR, I will continue look into the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] nlu90 edited a comment on issue #11338: [Pulsar Functions and IO] Cannot upgrade Function built for Pulsar 2.7 to Pulsar 2.8

2021-07-19 Thread GitBox
nlu90 edited a comment on issue #11338: URL: https://github.com/apache/pulsar/issues/11338#issuecomment-882894305 I did some check. If function compiled with 2.7.1 is submitted to a Pulsar 2.8.0 cluster directly, the following error is reported: ``` 14:50:51.313

[GitHub] [pulsar] nlu90 commented on issue #11338: [Pulsar Functions and IO] Cannot upgrade Function built for Pulsar 2.7 to Pulsar 2.8

2021-07-19 Thread GitBox
nlu90 commented on issue #11338: URL: https://github.com/apache/pulsar/issues/11338#issuecomment-882894305 I did some check. If function compiled with 2.7.1 is submitted to a Pulsar 2.8.0 cluster directly, the following error is reported: ``` 14:50:51.313 [public/default/Fun1-0]

[GitHub] [pulsar] david-streamlio commented on pull request #11378: Fix bug when check batch source config

2021-07-19 Thread GitBox
david-streamlio commented on pull request #11378: URL: https://github.com/apache/pulsar/pull/11378#issuecomment-882876284 Got it. I was trying to catch any class name typos, etc hear before we try to run the Batch Source, but I guess we can t really do that without the triggerer class

[GitHub] [pulsar] migmit commented on a change in pull request #8173: [Issue 8154] [Python client] Expose schema version (of writerSchema) in Message

2021-07-19 Thread GitBox
migmit commented on a change in pull request #8173: URL: https://github.com/apache/pulsar/pull/8173#discussion_r672596775 ## File path: pulsar-client-cpp/include/pulsar/c/message.h ## @@ -200,6 +200,12 @@ PULSAR_PUBLIC const char

[GitHub] [pulsar] jerrypeng commented on pull request #11378: Fix bug when check batch source config

2021-07-19 Thread GitBox
jerrypeng commented on pull request #11378: URL: https://github.com/apache/pulsar/pull/11378#issuecomment-882769896 @david-streamlio please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] jerrypeng opened a new pull request #11378: Fix bug when check batch source config

2021-07-19 Thread GitBox
jerrypeng opened a new pull request #11378: URL: https://github.com/apache/pulsar/pull/11378 ### Motivation We shouldn't try to use reflection to load any classes in batch sources since we don't load any JARs or NARs at runtime in the pulsar admin CLI tool. The lines I

[pulsar] 01/01: Fix bug when check batch source config

2021-07-19 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch jerrypeng-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4a085ec4cb4c5dc3304a7b134135f1c1542a1a42 Author: Boyang Jerry Peng AuthorDate: Mon Jul 19 11:28:58 2021

[pulsar] branch jerrypeng-patch-1 created (now 4a085ec)

2021-07-19 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch jerrypeng-patch-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at 4a085ec Fix bug when check batch source config This branch includes the following new commits:

[GitHub] [pulsar] jerrypeng commented on pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-19 Thread GitBox
jerrypeng commented on pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#issuecomment-882745912 @lhotari @freeznet If the error is easily reproducible, can you provide steps to reproduce? What are the errors you see when this issue happens? > the tmp

[pulsar] branch master updated (3ba8d20 -> 73404bf)

2021-07-19 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3ba8d20 [tests] use Awaitility replace Thread.sleep for pulsar-broker. (#11281) add 73404bf [Security]

[GitHub] [pulsar] merlimat merged pull request #11345: [Security] Upgrade commons-compress to 1.21

2021-07-19 Thread GitBox
merlimat merged pull request #11345: URL: https://github.com/apache/pulsar/pull/11345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subs

2021-07-19 Thread GitBox
codelipenghui commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672470079 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1030,55 @@ protected void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subs

2021-07-19 Thread GitBox
codelipenghui commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672462760 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1032,52 @@ protected void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subs

2021-07-19 Thread GitBox
codelipenghui commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672462760 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1032,52 @@ protected void

[pulsar] branch branch-2.7 updated: Fix typo in version 2.7.3-SNAPSHOT (#11375)

2021-07-19 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 29bb338 Fix typo in version

[GitHub] [pulsar] lhotari merged pull request #11375: Fix typo in version 2.7.3-SNAPSHOT

2021-07-19 Thread GitBox
lhotari merged pull request #11375: URL: https://github.com/apache/pulsar/pull/11375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-19 Thread GitBox
lhotari commented on pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#issuecomment-882649599 > Overall I approve this PR since I am facing the same issue when having a single broker+function-worker with any functions that parallelism>1, the tmp directory will facing

[GitHub] [pulsar-client-go] cckellogg edited a comment on issue #565: Send gorutine blocked

2021-07-19 Thread GitBox
cckellogg edited a comment on issue #565: URL: https://github.com/apache/pulsar-client-go/issues/565#issuecomment-882645102 This code `bq.isNotFull` is a conditional variable (https://pkg.go.dev/sync#Cond.Wait) so it should already be releasing the lock when wait is called. ```

[GitHub] [pulsar-client-go] cckellogg commented on issue #565: Send gorutine blocked

2021-07-19 Thread GitBox
cckellogg commented on issue #565: URL: https://github.com/apache/pulsar-client-go/issues/565#issuecomment-882645102 This code `bq.isNotFull` is a conditional variable (https://pkg.go.dev/sync#Cond.Wait) so it should already be releasing the lock when wait is called. ```

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscri

2021-07-19 Thread GitBox
Technoboy- commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672382875 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1032,52 @@ protected void

[GitHub] [pulsar] Shoothzj commented on issue #11377: From 2.7.2 upgrade to 2.8.0, there are continously http request not respond without any error.

2021-07-19 Thread GitBox
Shoothzj commented on issue #11377: URL: https://github.com/apache/pulsar/issues/11377#issuecomment-882614869 I tried to rollback jetty and Jersey version, doesnot works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Shoothzj opened a new issue #11377: From 2.7.2 upgrade to 2.8.0, there are continously http request not respond without any error.

2021-07-19 Thread GitBox
Shoothzj opened a new issue #11377: URL: https://github.com/apache/pulsar/issues/11377 **Describe the bug** After upgrading pulsar 2.8.0, there are continously http request not respond without any error. And then the client timeout in 60 seconds. Downgrade to 2.7.2, everything

[GitHub] [pulsar] Shoothzj commented on pull request #11347: Avoid infinite waiting for consumer close

2021-07-19 Thread GitBox
Shoothzj commented on pull request #11347: URL: https://github.com/apache/pulsar/pull/11347#issuecomment-882604623 > thanks for addressing my comments. > > did you see this problem in production or do you have a stacktrace with an NPE to show ? Yes, I noticed the problem in

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subs

2021-07-19 Thread GitBox
Demogorgon314 commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672355732 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1032,52 @@ protected void

[GitHub] [pulsar] congbobo184 commented on pull request #11068: Fix the NotAllowedException when general metric data.

2021-07-19 Thread GitBox
congbobo184 commented on pull request #11068: URL: https://github.com/apache/pulsar/pull/11068#issuecomment-882589909 @yangl Could you please add some test for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
Technoboy- commented on a change in pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#discussion_r672341974 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java ## @@ -50,10 +57,8 @@ public RackAwareTest() {

[pulsar] branch master updated: [tests] use Awaitility replace Thread.sleep for pulsar-broker. (#11281)

2021-07-19 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3ba8d20 [tests] use Awaitility replace

[GitHub] [pulsar] eolivelli commented on pull request #11281: [tests] use Awaitility replace Thread.sleep for pulsar-broker.

2021-07-19 Thread GitBox
eolivelli commented on pull request #11281: URL: https://github.com/apache/pulsar/pull/11281#issuecomment-882582027 committed to master branch, thank you @yangl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] eolivelli merged pull request #11281: [tests] use Awaitility replace Thread.sleep for pulsar-broker.

2021-07-19 Thread GitBox
eolivelli merged pull request #11281: URL: https://github.com/apache/pulsar/pull/11281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] eolivelli commented on pull request #11347: Avoid infinite waiting for consumer close

2021-07-19 Thread GitBox
eolivelli commented on pull request #11347: URL: https://github.com/apache/pulsar/pull/11347#issuecomment-882577328 thanks for addressing my comments. did you see this problem in production or do you have a stacktrace with an NPE to show ? -- This is an automated message from the

[GitHub] [pulsar] codelipenghui opened a new pull request #11376: Disable replicate system topic across clusters.

2021-07-19 Thread GitBox
codelipenghui opened a new pull request #11376: URL: https://github.com/apache/pulsar/pull/11376 ### Motivation Currently, we are not able to use the topic policy for a geo-replicated schema. The root cause is we do not support replicate schema to the remote cluster but the

[GitHub] [pulsar] eolivelli opened a new pull request #11375: Fix typo in version 2.7.3-SNAPSHOT

2021-07-19 Thread GitBox
eolivelli opened a new pull request #11375: URL: https://github.com/apache/pulsar/pull/11375 Fix a typo in pom files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] eolivelli commented on pull request #11374: Branch-2.7 fix Delayed Messages

2021-07-19 Thread GitBox
eolivelli commented on pull request #11374: URL: https://github.com/apache/pulsar/pull/11374#issuecomment-882566975 @codelipenghui for reference

[GitHub] [pulsar] eolivelli opened a new pull request #11374: Branch-2.7 fix Delayed Messages

2021-07-19 Thread GitBox
eolivelli opened a new pull request #11374: URL: https://github.com/apache/pulsar/pull/11374 Cherry-picking https://github.com/apache/pulsar/pull/10762 broke the Delayed messages feature in branch-2.7. This patch restores the method that has been dropped -- This is an automated

[GitHub] [pulsar] eolivelli commented on a change in pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
eolivelli commented on a change in pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#discussion_r672295547 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java ## @@ -62,7 +67,7 @@ protected void setup() throws

[GitHub] [pulsar] mantuliu closed pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf

2021-07-19 Thread GitBox
mantuliu closed pull request #11078: URL: https://github.com/apache/pulsar/pull/11078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- commented on pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
Technoboy- commented on pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#issuecomment-882538007 > Please check my comment at [#11349 (comment)](https://github.com/apache/pulsar/issues/11349#issuecomment-882449466) . Yes, I re-post the pull request refers to

[GitHub] [pulsar] BewareMyPower commented on pull request #11078: [Issue 10975][config]add 'brokerDeleteInactivePartitionedTopicMetadataEnabled' in conf/standalone.conf

2021-07-19 Thread GitBox
BewareMyPower commented on pull request #11078: URL: https://github.com/apache/pulsar/pull/11078#issuecomment-882530603 @mantuliu Can you process the suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Technoboy- commented on pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
Technoboy- commented on pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#issuecomment-882525402 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Technoboy- opened a new issue #11373: Flaky-test: [ResourceGroupRateLimiterTest].[createResourceGroup]

2021-07-19 Thread GitBox
Technoboy- opened a new issue #11373: URL: https://github.com/apache/pulsar/issues/11373 ResourceGroupRateLimiterTest is flaky. The createResourceGroup test method fails sporadically. ``` Error: Tests run: 4, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 26.159 s <<< FAILURE! -

[GitHub] [pulsar] ronfarkash opened a new pull request #11372: [ISSUE 11351] Parallel Precise Publish Rate Limiting Fix

2021-07-19 Thread GitBox
ronfarkash opened a new pull request #11372: URL: https://github.com/apache/pulsar/pull/11372 ## Master Issue: ### Motivation Hello, as far as I'm concerned it is well known that precise publish rate limiting does not

[GitHub] [pulsar] Shoothzj commented on a change in pull request #11347: Avoid infinite waiting for consumer close

2021-07-19 Thread GitBox
Shoothzj commented on a change in pull request #11347: URL: https://github.com/apache/pulsar/pull/11347#discussion_r672255854 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -926,7 +925,7 @@ public void

[GitHub] [pulsar] Shoothzj commented on a change in pull request #11347: Avoid infinite waiting for consumer close

2021-07-19 Thread GitBox
Shoothzj commented on a change in pull request #11347: URL: https://github.com/apache/pulsar/pull/11347#discussion_r672255093 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -1968,9 +1965,7 @@ public boolean

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11355: [Issue 11339] Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subs

2021-07-19 Thread GitBox
codelipenghui commented on a change in pull request #11355: URL: https://github.com/apache/pulsar/pull/11355#discussion_r672253045 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -1030,34 +1032,52 @@ protected void

[pulsar] branch branch-2.7 updated: Issue #11037: Fix flaky test PrimitiveSchemaTest (#11038)

2021-07-19 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new e657e36 Issue #11037: Fix flaky

[GitHub] [pulsar] baomingyu commented on pull request #11368: make maxEnsembleChangeSize can be config from pulsar broker

2021-07-19 Thread GitBox
baomingyu commented on pull request #11368: URL: https://github.com/apache/pulsar/pull/11368#issuecomment-882501849 > There seems this param not works, did you miss some commits or classes? no , all code is committed. Add this parameter to make is possible to config

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11341: [Broker] Add multi roles support for authorization

2021-07-19 Thread GitBox
codelipenghui commented on a change in pull request #11341: URL: https://github.com/apache/pulsar/pull/11341#discussion_r672235245 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/MultiRolesTokenAuthorizationProvider.java ## @@ -0,0

[GitHub] [pulsar] lhotari commented on issue #11371: [Pulsar Client Tool] Add support for creating a replicated subscription in pulsar-client consume

2021-07-19 Thread GitBox
lhotari commented on issue #11371: URL: https://github.com/apache/pulsar/issues/11371#issuecomment-882497344 There's a separate feature request for pulsar-admin: #11366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] lhotari opened a new issue #11371: [Pulsar Client Tool] Add support for creating a replicated subscription in pulsar-client consume

2021-07-19 Thread GitBox
lhotari opened a new issue #11371: URL: https://github.com/apache/pulsar/issues/11371 **Is your feature request related to a problem? Please describe.** `pulsar-client consume` doesn't currently support creating replicated subscriptions. **Describe the solution you'd

[GitHub] [pulsar] 315157973 commented on a change in pull request #11148: Increase the rate of topic creation

2021-07-19 Thread GitBox
315157973 commented on a change in pull request #11148: URL: https://github.com/apache/pulsar/pull/11148#discussion_r672227978 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java ## @@ -742,19 +742,28 @@ protected void

[GitHub] [pulsar] 315157973 commented on a change in pull request #11148: Increase the rate of topic creation

2021-07-19 Thread GitBox
315157973 commented on a change in pull request #11148: URL: https://github.com/apache/pulsar/pull/11148#discussion_r672227978 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java ## @@ -742,19 +742,28 @@ protected void

[GitHub] [pulsar] lhotari edited a comment on issue #11349: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
lhotari edited a comment on issue #11349: URL: https://github.com/apache/pulsar/issues/11349#issuecomment-882449466 I also took a look at the test. There's a problem in the RackAwareTest itself in setup and cleanup. These are the required changes for fixing setup and cleaup: ```

[GitHub] [pulsar] suiyuzeng commented on pull request #11148: Increase the rate of topic creation

2021-07-19 Thread GitBox
suiyuzeng commented on pull request #11148: URL: https://github.com/apache/pulsar/pull/11148#issuecomment-882474234 @codelipenghui hi, can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] lhotari commented on issue #11349: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
lhotari commented on issue #11349: URL: https://github.com/apache/pulsar/issues/11349#issuecomment-882467790 It looks like there are multiple thread-safety issues in org.apache.pulsar.zookeeper.ZkBookieRackAffinityMapping . It's not a dead lock that is happening. I can see the

[GitHub] [pulsar] lhotari removed a comment on issue #11349: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
lhotari removed a comment on issue #11349: URL: https://github.com/apache/pulsar/issues/11349#issuecomment-882467790 It looks like there are multiple thread-safety issues in org.apache.pulsar.zookeeper.ZkBookieRackAffinityMapping . It's not a dead lock that is happening. I can see the

[GitHub] [pulsar] 315157973 closed pull request #10729: PIP 81: Split the individual acknowledgments into multiple entries

2021-07-19 Thread GitBox
315157973 closed pull request #10729: URL: https://github.com/apache/pulsar/pull/10729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari edited a comment on pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
lhotari edited a comment on pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#issuecomment-882448712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] lhotari commented on issue #11349: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
lhotari commented on issue #11349: URL: https://github.com/apache/pulsar/issues/11349#issuecomment-882449466 I also took a look at the test. There's a problem in the RackAwareTest itself in setup and cleanup. These are the required changes for fixing setup and cleaup: ```

[GitHub] [pulsar] lhotari commented on issue #11366: [Pulsar Admin] Add support for creating replicated subscriptions

2021-07-19 Thread GitBox
lhotari commented on issue #11366: URL: https://github.com/apache/pulsar/issues/11366#issuecomment-882444588 @Technoboy- One of the challenges in making the changes is keeping the interfaces in Pulsar Admin Java API backwards compatible. Please consider that when doing the changes. --

[GitHub] [pulsar] lhotari commented on pull request #11370: Flaky-test: RackAwareTest.testPlacement

2021-07-19 Thread GitBox
lhotari commented on pull request #11370: URL: https://github.com/apache/pulsar/pull/11370#issuecomment-882448712 I also took a look at the test. There's a problem in the RackAwareTest itself in setup and cleanup. These are the required changes for fixing setup and cleaup: ```

  1   2   >