[GitHub] [pulsar] Technoboy- commented on a change in pull request #12634: Add missing cmds on pulsar-admin document page.

2021-11-04 Thread GitBox
Technoboy- commented on a change in pull request #12634: URL: https://github.com/apache/pulsar/pull/12634#discussion_r743401210 ## File path: site2/tools/pulsar-admin-doc-gen.sh ## @@ -32,11 +32,17 @@ $ROOT_DIR/bin/pulsar-admin documents generate broker-stats >

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12633: [Doc] Add explanations for setting geo-replication at topic level

2021-11-04 Thread GitBox
Technoboy- commented on a change in pull request #12633: URL: https://github.com/apache/pulsar/pull/12633#discussion_r743399727 ## File path: site2/website/versioned_docs/version-2.8.2/administration-geo.md ## @@ -144,12 +156,22 @@ producer.newMessage() Topic stats

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12633: [Doc] Add explanations for setting geo-replication at topic level

2021-11-04 Thread GitBox
Technoboy- commented on a change in pull request #12633: URL: https://github.com/apache/pulsar/pull/12633#discussion_r743399650 ## File path: site2/website/versioned_docs/version-2.8.2/administration-geo.md ## @@ -144,12 +156,22 @@ producer.newMessage() Topic stats

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12634: Add missing cmds on pulsar-admin document page.

2021-11-04 Thread GitBox
Technoboy- commented on a change in pull request #12634: URL: https://github.com/apache/pulsar/pull/12634#discussion_r743399272 ## File path: site2/tools/pulsar-admin-doc-gen.sh ## @@ -32,11 +32,17 @@ $ROOT_DIR/bin/pulsar-admin documents generate broker-stats >

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12396: Fix NPE when create OpEntry

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12396: URL: https://github.com/apache/pulsar/pull/12396#discussion_r743393903 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -622,9 +622,11 @@ public void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12630: [Broker] Check topic exists when executing postSchema

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12630: URL: https://github.com/apache/pulsar/pull/12630#discussion_r743394564 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -306,6 +308,29 @@ private static

[pulsar] branch master updated: [Doc] Update Pulsar SQL document. (#12613)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3964c6d [Doc] Update Pulsar SQL document.

[GitHub] [pulsar] codelipenghui merged pull request #12613: [Doc] Update Pulsar SQL document.

2021-11-04 Thread GitBox
codelipenghui merged pull request #12613: URL: https://github.com/apache/pulsar/pull/12613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12396: Fix NPE when create OpEntry

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12396: URL: https://github.com/apache/pulsar/pull/12396#discussion_r743393903 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -622,9 +622,11 @@ public void

[GitHub] [pulsar] yuruguo commented on a change in pull request #12630: [Broker] Check topic exists when executing postSchema

2021-11-04 Thread GitBox
yuruguo commented on a change in pull request #12630: URL: https://github.com/apache/pulsar/pull/12630#discussion_r743393179 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -306,6 +308,29 @@ private static void

[GitHub] [pulsar] yuruguo closed pull request #12630: [Broker] Check topic exists when executing postSchema

2021-11-04 Thread GitBox
yuruguo closed pull request #12630: URL: https://github.com/apache/pulsar/pull/12630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo commented on a change in pull request #12630: [Broker] Check topic exists when executing postSchema

2021-11-04 Thread GitBox
yuruguo commented on a change in pull request #12630: URL: https://github.com/apache/pulsar/pull/12630#discussion_r743392893 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -306,6 +308,29 @@ private static void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12630: [Broker] Check topic exists when executing postSchema

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12630: URL: https://github.com/apache/pulsar/pull/12630#discussion_r743392431 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -306,6 +308,29 @@ private static

[GitHub] [pulsar] Anonymitaet opened a new issue #12637: PIP 87: Upgrade Pulsar Website Framework

2021-11-04 Thread GitBox
Anonymitaet opened a new issue #12637: URL: https://github.com/apache/pulsar/issues/12637 Design proposal, solution, implementation progress, and all details are available [here](https://docs.google.com/document/d/1bQfZkSu5nG1tNycpmXXtUFn-Z5-h-uqHv6IXsCEySQ8/edit). -- This is an

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r743373563 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -1141,6 +1144,53 @@ public long

[GitHub] [pulsar] tuteng commented on pull request #12634: Add missing cmds on pulsar-admin document page.

2021-11-04 Thread GitBox
tuteng commented on pull request #12634: URL: https://github.com/apache/pulsar/pull/12634#issuecomment-961607374 I think in the frontend also need some updates, @urfreespace can help to do this -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] liangyepianzhou opened a new pull request #12636: Stop tb recovering with exception

2021-11-04 Thread GitBox
liangyepianzhou opened a new pull request #12636: URL: https://github.com/apache/pulsar/pull/12636 ### Motivation When TransactionBuffer recoversing, if any ledger was deleted from bookkeeper, or ManagerLedger was fenced, TtransactionBuffer will not stop recovering and continue to

[GitHub] [pulsar] tuteng commented on a change in pull request #12634: Add missing cmds on pulsar-admin document page.

2021-11-04 Thread GitBox
tuteng commented on a change in pull request #12634: URL: https://github.com/apache/pulsar/pull/12634#discussion_r743373893 ## File path: site2/tools/pulsar-admin-doc-gen.sh ## @@ -32,11 +32,17 @@ $ROOT_DIR/bin/pulsar-admin documents generate broker-stats >

[pulsar] branch master updated: [website][upgrade]feat: docs migration - 2.7.1 / deploy (#12608)

2021-11-04 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 81f26d6 [website][upgrade]feat: docs migration

[GitHub] [pulsar] Anonymitaet closed issue #11766: [website] website upgrade

2021-11-04 Thread GitBox
Anonymitaet closed issue #11766: URL: https://github.com/apache/pulsar/issues/11766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #12608: [website][upgrade]feat: docs migration - 2.7.1 / deploy

2021-11-04 Thread GitBox
Anonymitaet merged pull request #12608: URL: https://github.com/apache/pulsar/pull/12608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] huangdx0726 opened a new issue #12635: why double check topicTickTimeMs in setupTopicPublishRateLimiterMonitor method of BrokerService?

2021-11-04 Thread GitBox
huangdx0726 opened a new issue #12635: URL: https://github.com/apache/pulsar/issues/12635 ```java public synchronized void setupTopicPublishRateLimiterMonitor() { // set topic PublishRateLimiterMonitor long topicTickTimeMs =

[GitHub] [pulsar] yuruguo commented on pull request #12630: [Broker] Check topic exists for schema

2021-11-04 Thread GitBox
yuruguo commented on pull request #12630: URL: https://github.com/apache/pulsar/pull/12630#issuecomment-961602966 > @yuruguo We have an option is delete the topic but do not delete the schema, so the new check will break the behavior. Thanks for your reply, I see :) If the topic

[GitHub] [pulsar] Anonymitaet edited a comment on issue #12595: PIP 109: Introduce Bot to Improve Efficiency of Developing Docs

2021-11-04 Thread GitBox
Anonymitaet edited a comment on issue #12595: URL: https://github.com/apache/pulsar/issues/12595#issuecomment-961601449 Since we [have 3 binding +1](https://lists.apache.org/thread/56oogrtqrpnwc442oljgfv33l3n2obd2), I'll close this issue and move the proposal to "accepted". -- This is

[GitHub] [pulsar] Anonymitaet commented on issue #12595: PIP 109: Introduce Bot to Improve Efficiency of Developing Docs

2021-11-04 Thread GitBox
Anonymitaet commented on issue #12595: URL: https://github.com/apache/pulsar/issues/12595#issuecomment-961601449 Since we have 3 binding +1, I'll close this issue and move the proposal to "accepted". -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Anonymitaet closed issue #12595: PIP 109: Introduce Bot to Improve Efficiency of Developing Docs

2021-11-04 Thread GitBox
Anonymitaet closed issue #12595: URL: https://github.com/apache/pulsar/issues/12595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on issue #12596: python read AVRO topic has error

2021-11-04 Thread GitBox
Anonymitaet commented on issue #12596: URL: https://github.com/apache/pulsar/issues/12596#issuecomment-961601157 @gaoran10 as we discussed just now, can you help look into this issue? And then we can verify whether it is a doc-related issue, thanks. -- This is an automated message from

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743356923 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743365098 ## File path: pulsar/negative_acks_tracker.go ## @@ -105,15 +158,13 @@ func (t *negativeAcksTracker) track() {

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743363997 ## File path: pulsar/negative_acks_tracker.go ## @@ -76,14 +95,48 @@ func (t *negativeAcksTracker) Add(msgID messageID) {

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743363658 ## File path: pulsar/negative_acks_tracker.go ## @@ -35,22 +35,41 @@ type negativeAcksTracker struct { doneOnce sync.Once

[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #12633: [Doc] Add explanations for setting geo-replication at topic level

2021-11-04 Thread GitBox
Huanli-Meng commented on a change in pull request #12633: URL: https://github.com/apache/pulsar/pull/12633#discussion_r743360743 ## File path: site2/docs/administration-geo.md ## @@ -113,11 +115,21 @@ $ bin/pulsar-admin namespaces set-clusters my-tenant/my-namespace \

[GitHub] [pulsar] frankxieke commented on a change in pull request #12567: doc optimization for issue #12488

2021-11-04 Thread GitBox
frankxieke commented on a change in pull request #12567: URL: https://github.com/apache/pulsar/pull/12567#discussion_r743360581 ## File path: site2/website-next/versioned_docs/version-2.7.3/deploy-bare-metal.md ## @@ -243,7 +243,7 @@ $

[GitHub] [pulsar] frankxieke commented on a change in pull request #12567: doc optimization for issue #12488

2021-11-04 Thread GitBox
frankxieke commented on a change in pull request #12567: URL: https://github.com/apache/pulsar/pull/12567#discussion_r743359429 ## File path: site2/website-next/versioned_docs/version-2.7.3/deploy-bare-metal.md ## @@ -243,7 +243,7 @@ $

[GitHub] [pulsar] LeBW commented on pull request #12523: add a metric to get earliest time in the backlog

2021-11-04 Thread GitBox
LeBW commented on pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#issuecomment-961588405 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Technoboy- commented on pull request #12634: Add missing cmds on pulsar-admin document page.

2021-11-04 Thread GitBox
Technoboy- commented on pull request #12634: URL: https://github.com/apache/pulsar/pull/12634#issuecomment-961587610 @tuteng Please help review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Technoboy- opened a new pull request #12634: Add missing cmds on pulsar-admin document page.

2021-11-04 Thread GitBox
Technoboy- opened a new pull request #12634: URL: https://github.com/apache/pulsar/pull/12634 ### Motivation For [pulsar-admin](https://pulsar.apache.org/tools/pulsar-admin/2.7.0-SNAPSHOT) document page , we miss some cmds. ### Documentation Check the box below and

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743356899 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743354627 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743354627 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352255 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352676 ## File path: pulsar/negative_acks_tracker.go ## @@ -35,22 +35,41 @@ type negativeAcksTracker struct { doneOnce sync.Once

[GitHub] [pulsar] Anonymitaet opened a new pull request #12633: [Doc] Add explanations for setting geo-replication at topic level

2021-11-04 Thread GitBox
Anonymitaet opened a new pull request #12633: URL: https://github.com/apache/pulsar/pull/12633 Add docs for https://github.com/apache/pulsar/pull/12136 This PR adds doc for 2.8.1 and master. Will add docs for 2.9.1 once the doc set is generated. Preview looks good:

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352353 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352255 ## File path: pulsar/negative_backoff_policy.go ## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352175 ## File path: pulsar/consumer.go ## @@ -158,6 +158,17 @@ type ConsumerOptions struct { // Decryption decryption related fields to

[GitHub] [pulsar] Jason918 commented on a change in pull request #12632: [pulsar-broker] support to get list of topics under a namespace bundle

2021-11-04 Thread GitBox
Jason918 commented on a change in pull request #12632: URL: https://github.com/apache/pulsar/pull/12632#discussion_r743347792 ## File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java ## @@ -889,7 +889,7 @@ public void topics()

[GitHub] [pulsar] shibd closed pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
shibd closed pull request #11986: URL: https://github.com/apache/pulsar/pull/11986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] frankxieke commented on issue #12596: python read AVRO topic has error

2021-11-04 Thread GitBox
frankxieke commented on issue #12596: URL: https://github.com/apache/pulsar/issues/12596#issuecomment-961561644 It looks like scala and python have different behavior in encoding message. I will have a test of this case. -- This is an automated message from the Apache Git Service. To

[pulsar] branch master updated (a6b1b34 -> 7e078aa)

2021-11-04 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a6b1b34 [Compaction] Do not move the non-durable cursor position when trimming ledgers while topic with

[GitHub] [pulsar] hangc0276 closed issue #12423: Multi-topic subscription requires tenant admin access

2021-11-04 Thread GitBox
hangc0276 closed issue #12423: URL: https://github.com/apache/pulsar/issues/12423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] hangc0276 merged pull request #12600: [#12423] allow `GetTopicsOfNamespace` op with `consume` permission

2021-11-04 Thread GitBox
hangc0276 merged pull request #12600: URL: https://github.com/apache/pulsar/pull/12600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] shibd commented on a change in pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
shibd commented on a change in pull request #11986: URL: https://github.com/apache/pulsar/pull/11986#discussion_r743324351 ## File path: site2/docs/admin-api-topics.md ## @@ -1138,12 +1138,18 @@ $ pulsar-admin topics get-partitioned-topic-metadata \ ``` Review comment:

[GitHub] [pulsar] casuallc commented on a change in pull request #12396: Fix NPE when create OpEntry

2021-11-04 Thread GitBox
casuallc commented on a change in pull request #12396: URL: https://github.com/apache/pulsar/pull/12396#discussion_r743321006 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -622,9 +622,11 @@ public void

[GitHub] [pulsar] codelipenghui commented on pull request #12606: [ML] Avoid passing OpAddEntry across a thread boundary in asyncAddEntry

2021-11-04 Thread GitBox
codelipenghui commented on pull request #12606: URL: https://github.com/apache/pulsar/pull/12606#issuecomment-961540500 @merlimat Please help review this PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
cckellogg commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743310068 ## File path: pulsar/negative_acks_tracker.go ## @@ -35,22 +35,41 @@ type negativeAcksTracker struct { doneOnce sync.Once

[GitHub] [pulsar] Anonymitaet commented on pull request #12632: [pulsar-broker] support to get list of topics under a namespace bundle

2021-11-04 Thread GitBox
Anonymitaet commented on pull request #12632: URL: https://github.com/apache/pulsar/pull/12632#issuecomment-961536006 @rdhabalia do we need to add docs [here](https://pulsar.apache.org/docs/en/next/admin-api-topics/)? -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-client-go] cckellogg commented on issue #659: Some partition topics' consumer stop consuming news while other partition's consumer of this topic is reconnecting

2021-11-04 Thread GitBox
cckellogg commented on issue #659: URL: https://github.com/apache/pulsar-client-go/issues/659#issuecomment-961534658 @baomingyu a few questions. * Client version? * Server version? * Number of partitions? * Is this a single consumer, regex, or multitopic? * How often is

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #660: Support nack backoff policy for SDK

2021-11-04 Thread GitBox
cckellogg commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743308255 ## File path: pulsar/negative_acks_tracker.go ## @@ -35,22 +35,41 @@ type negativeAcksTracker struct { doneOnce sync.Once

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
Anonymitaet commented on a change in pull request #11986: URL: https://github.com/apache/pulsar/pull/11986#discussion_r743303124 ## File path: site2/docs/admin-api-topics.md ## @@ -1138,12 +1138,18 @@ $ pulsar-admin topics get-partitioned-topic-metadata \ ``` +When topic

[GitHub] [pulsar] github-actions[bot] commented on pull request #12632: [pulsar-broker] support to get list of topics under a namespace bundle

2021-11-04 Thread GitBox
github-actions[bot] commented on pull request #12632: URL: https://github.com/apache/pulsar/pull/12632#issuecomment-961476371 @rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] rdhabalia opened a new pull request #12632: [pulsar-broker] support to get list of topics under a namespace bundle

2021-11-04 Thread GitBox
rdhabalia opened a new pull request #12632: URL: https://github.com/apache/pulsar/pull/12632 ### Motivation Right now, broker-admin api allows user to get list of topics under a namespace but sometime user also needs a list of topics under a given namespace bundle. so, add support to

[GitHub] [pulsar] nlu90 opened a new issue #12631: [Function Worker] Http Server Fails on generating metrics

2021-11-04 Thread GitBox
nlu90 opened a new issue #12631: URL: https://github.com/apache/pulsar/issues/12631 **Describe the bug** Functions on one cluster got into a weird state where all http server failed on generating metrics. Because generating metrics would check isLeader.get() is a blocking call depends

[pulsar] branch master updated (11cfbe4 -> a6b1b34)

2021-11-04 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 11cfbe4 add additional error handling in auto partition update task MultiTopicsConsumerImpl (#12620) add

[GitHub] [pulsar] merlimat merged pull request #12602: [Compaction] Do not move the non-durable cursor position when trimming ledgers while topic with compaction

2021-11-04 Thread GitBox
merlimat merged pull request #12602: URL: https://github.com/apache/pulsar/pull/12602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] BewareMyPower commented on pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
BewareMyPower commented on pull request #11986: URL: https://github.com/apache/pulsar/pull/11986#issuecomment-961196210 @MarvinCai @gaoran10 PTAL again. I think the comments are all addressed now. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] BewareMyPower commented on pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
BewareMyPower commented on pull request #11986: URL: https://github.com/apache/pulsar/pull/11986#issuecomment-961190700 This PR is too late to review. I'm afraid it could not be included in Pulsar 2.9.0 now. This PR adds a new overridden of `getPartitionedTopicMetadataAsync` to

[GitHub] [pulsar] lhotari commented on a change in pull request #12606: [ML] Avoid passing OpAddEntry across a thread boundary in asyncAddEntry

2021-11-04 Thread GitBox
lhotari commented on a change in pull request #12606: URL: https://github.com/apache/pulsar/pull/12606#discussion_r742986699 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -699,10 +699,14 @@ public void

[GitHub] [pulsar] yuruguo removed a comment on pull request #12630: [Broker] Check topic exists for schema

2021-11-04 Thread GitBox
yuruguo removed a comment on pull request #12630: URL: https://github.com/apache/pulsar/pull/12630#issuecomment-961075076 @merlimat @eolivelli @codelipenghui @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] syhily edited a comment on pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
syhily edited a comment on pull request #11986: URL: https://github.com/apache/pulsar/pull/11986#issuecomment-961164123 @BewareMyPower This issue blocks the pulsar-flink-connector. Can you help me review this MR? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] syhily commented on pull request #11986: [pulsar admin] getPartitionedTopicMetada method support setting auto create topic

2021-11-04 Thread GitBox
syhily commented on pull request #11986: URL: https://github.com/apache/pulsar/pull/11986#issuecomment-961164123 @BewareMyPower This issue block the pulsar-flink-connector. Can you help me review this MR? -- This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated (cb48152 -> 11cfbe4)

2021-11-04 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cb48152 [ISSUE-12291][Client] 'StartMessageId' and 'RollbackDuration' not working in MultiTopicsReader for

[GitHub] [pulsar] nodece commented on pull request #12625: [Sink] Fix miss cleanupSubscription field

2021-11-04 Thread GitBox
nodece commented on pull request #12625: URL: https://github.com/apache/pulsar/pull/12625#issuecomment-961152377 @codelipenghui yeap, I will continue to debug with terraform-provider-pulsar to improve this and make a test for this. -- This is an automated message from the Apache Git

[GitHub] [pulsar] yuruguo edited a comment on pull request #12535: [pulsar-admin] Add --all option to get all version schema of topic

2021-11-04 Thread GitBox
yuruguo edited a comment on pull request #12535: URL: https://github.com/apache/pulsar/pull/12535#issuecomment-958493296 @eolivelli @aahmed-se @codelipenghui @congbobo184 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] merlimat merged pull request #12620: Add additional error handling in auto partition update task MultiTopicsConsumerImpl

2021-11-04 Thread GitBox
merlimat merged pull request #12620: URL: https://github.com/apache/pulsar/pull/12620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (2ca96e4 -> cb48152)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2ca96e4 Fix invalid firstSentAt value (#12588) add cb48152 [ISSUE-12291][Client] 'StartMessageId' and

[pulsar] branch master updated (04ddc9b -> 2ca96e4)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 04ddc9b Support for setting geo-replication clusters on topic level (#12136) add 2ca96e4 Fix invalid

[GitHub] [pulsar] codelipenghui merged pull request #12308: [ISSUE-12291][Client] 'StartMessageId' and 'RollbackDuration' not working in MultiTopicsReader for non-partitioned topics

2021-11-04 Thread GitBox
codelipenghui merged pull request #12308: URL: https://github.com/apache/pulsar/pull/12308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui closed issue #12291: Multi-topic reader ignore .startMessageId(MessageId.earliest).

2021-11-04 Thread GitBox
codelipenghui closed issue #12291: URL: https://github.com/apache/pulsar/issues/12291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo edited a comment on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-04 Thread GitBox
yuruguo edited a comment on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-955837143 @eolivelli @codelipenghui PTAL, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] codelipenghui merged pull request #12588: Fix invalid firstSentAt in log message when timeout first time

2021-11-04 Thread GitBox
codelipenghui merged pull request #12588: URL: https://github.com/apache/pulsar/pull/12588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on pull request #12625: [Sink] Fix miss cleanupSubscription field

2021-11-04 Thread GitBox
codelipenghui commented on pull request #12625: URL: https://github.com/apache/pulsar/pull/12625#issuecomment-961141964 @nodece Could you please help add a test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo commented on a change in pull request #12322: [pulsar-admin] Add corresponding get command for namespace

2021-11-04 Thread GitBox
yuruguo commented on a change in pull request #12322: URL: https://github.com/apache/pulsar/pull/12322#discussion_r742932703 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java ## @@ -2322,6 +2382,7 @@ public CmdNamespaces(Supplier

[GitHub] [pulsar] codelipenghui commented on pull request #12355: [pulsar-broker] Additional mTLS Logging and Metrics

2021-11-04 Thread GitBox
codelipenghui commented on pull request #12355: URL: https://github.com/apache/pulsar/pull/12355#issuecomment-961137660 @wmccarley Sorry for the late response, added milestone 2.10 and left some comments, please take a look. -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12355: [pulsar-broker] Additional mTLS Logging and Metrics

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12355: URL: https://github.com/apache/pulsar/pull/12355#discussion_r742930955 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderTls.java ## @@ -36,7 +87,50 @@

[pulsar] branch master updated: Support for setting geo-replication clusters on topic level (#12136)

2021-11-04 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 04ddc9b Support for setting geo-replication

[GitHub] [pulsar] hangc0276 merged pull request #12136: Support for setting geo-replication clusters on topic level

2021-11-04 Thread GitBox
hangc0276 merged pull request #12136: URL: https://github.com/apache/pulsar/pull/12136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] hangc0276 commented on a change in pull request #12322: [pulsar-admin] Add corresponding get command for namespace

2021-11-04 Thread GitBox
hangc0276 commented on a change in pull request #12322: URL: https://github.com/apache/pulsar/pull/12322#discussion_r742926735 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java ## @@ -2322,6 +2382,7 @@ public CmdNamespaces(Supplier

[pulsar] branch master updated (086906d -> 15a2303)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 086906d Fix collection get bug in ResourceGroupService (#12499) add 15a2303 [Transaction] Merge

[GitHub] [pulsar] codelipenghui merged pull request #12358: [Transaction] Merge transactionBuffer exception into a class

2021-11-04 Thread GitBox
codelipenghui merged pull request #12358: URL: https://github.com/apache/pulsar/pull/12358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] hangc0276 commented on a change in pull request #12136: Support for setting geo-replication clusters on topic level

2021-11-04 Thread GitBox
hangc0276 commented on a change in pull request #12136: URL: https://github.com/apache/pulsar/pull/12136#discussion_r742921906 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1334,33 +1335,36 @@ public void

[pulsar] branch master updated: Fix collection get bug in ResourceGroupService (#12499)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 086906d Fix collection get bug in

[GitHub] [pulsar] codelipenghui merged pull request #12499: Fix collection get bug in ResourceGroupService

2021-11-04 Thread GitBox
codelipenghui merged pull request #12499: URL: https://github.com/apache/pulsar/pull/12499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12136: Support for setting geo-replication clusters on topic level

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12136: URL: https://github.com/apache/pulsar/pull/12136#discussion_r742869242 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1334,33 +1335,36 @@ public void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12396: Fix NPE when create OpEntry

2021-11-04 Thread GitBox
codelipenghui commented on a change in pull request #12396: URL: https://github.com/apache/pulsar/pull/12396#discussion_r742915605 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -622,9 +622,11 @@ public void

[pulsar] branch master updated (65e5b49 -> 938dd54)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 65e5b49 doc optimization for initialize-cluster-metadata (#12567) add 938dd54 [docs] Fix doc for

[GitHub] [pulsar] codelipenghui commented on pull request #12541: [pulsar-broker] Add git branch information for PulsarVersion

2021-11-04 Thread GitBox
codelipenghui commented on pull request #12541: URL: https://github.com/apache/pulsar/pull/12541#issuecomment-961100612 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] codelipenghui merged pull request #12542: [docs] Fix doc for pulsar-admin bookies cmd

2021-11-04 Thread GitBox
codelipenghui merged pull request #12542: URL: https://github.com/apache/pulsar/pull/12542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (6afbee6 -> 65e5b49)

2021-11-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6afbee6 fix log typo in NamespaceService#checkHeartbeatNamespace and NamespaceService#checkHeartbeatNamespaceV2

[GitHub] [pulsar] codelipenghui merged pull request #12567: doc optimization for issue #12488

2021-11-04 Thread GitBox
codelipenghui merged pull request #12567: URL: https://github.com/apache/pulsar/pull/12567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >