[GitHub] [pulsar] Shoothzj commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963894734 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Shoothzj removed a comment on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj removed a comment on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963806923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] nodece commented on pull request #12625: [Sink] Fix the parse the cleanupSubscription and processingGuarantees fields

2021-11-08 Thread GitBox
nodece commented on pull request #12625: URL: https://github.com/apache/pulsar/pull/12625#issuecomment-963892169 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (8992712 -> 24b0f4f)

2021-11-08 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8992712 [website][upgrade]feat: docs migration - 2.7.1 / Admin API (#12676) add 24b0f4f [tools] fix

[GitHub] [pulsar] rdhabalia merged pull request #12675: [tools] fix TestRunMain test

2021-11-08 Thread GitBox
rdhabalia merged pull request #12675: URL: https://github.com/apache/pulsar/pull/12675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gaozhangmin commented on pull request #12366: expose broker bundles metrics to prometheus

2021-11-08 Thread GitBox
gaozhangmin commented on pull request #12366: URL: https://github.com/apache/pulsar/pull/12366#issuecomment-963880635 @hangc0276 PTAL again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] yuruguo commented on pull request #12688: [website] Update team page to add new committer

2021-11-08 Thread GitBox
yuruguo commented on pull request #12688: URL: https://github.com/apache/pulsar/pull/12688#issuecomment-963872437 @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] yuruguo opened a new pull request #12688: [website] Update team page to add new committer

2021-11-08 Thread GitBox
yuruguo opened a new pull request #12688: URL: https://github.com/apache/pulsar/pull/12688 ### Motivation Add one new committers to the team page There are 47 pulsar committers util November 9, 2021 see [ASF Committers by ID](http://people.apache.org/committer-index.html)

[GitHub] [pulsar] Shoothzj commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963871436 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] nodece removed a comment on pull request #12625: [Sink] Fix the parse the cleanupSubscription and processingGuarantees fields

2021-11-08 Thread GitBox
nodece removed a comment on pull request #12625: URL: https://github.com/apache/pulsar/pull/12625#issuecomment-963757843 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Jason918 opened a new pull request #12687: [Broker] Apply PolicyHierarchyValue to inactiveTopicPolicies

2021-11-08 Thread GitBox
Jason918 opened a new pull request #12687: URL: https://github.com/apache/pulsar/pull/12687 ### Motivation #12658 introduced `PolicyHierarchyValue` to cache broker/namespace/topic level policy value. This pull request applied `PolicyHierarchyValue` to

[GitHub] [pulsar] yuruguo closed pull request #12686: Fix test fail in TestRunMain

2021-11-08 Thread GitBox
yuruguo closed pull request #12686: URL: https://github.com/apache/pulsar/pull/12686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo edited a comment on pull request #12686: Fix test fail in TestRunMain

2021-11-08 Thread GitBox
yuruguo edited a comment on pull request #12686: URL: https://github.com/apache/pulsar/pull/12686#issuecomment-963840185 > @yuruguo I think it's duplicated with #12675 ? Yes, thanks for your reminder :) I will close this PR -- This is an automated message from the Apache Git

[GitHub] [pulsar] codelipenghui commented on pull request #12685: [Issue 12672][test] Reduce unnecessary message send in testPeekWithSubscriptionNameNotExist

2021-11-08 Thread GitBox
codelipenghui commented on pull request #12685: URL: https://github.com/apache/pulsar/pull/12685#issuecomment-963840835 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #12686: Fix test fail in TestRunMain

2021-11-08 Thread GitBox
yuruguo commented on pull request #12686: URL: https://github.com/apache/pulsar/pull/12686#issuecomment-963840185 > @yuruguo I think it's duplicated with #12675 ? Yes, thanks for your reminder :) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] codelipenghui commented on pull request #12686: Fix test fail in TestRunMain

2021-11-08 Thread GitBox
codelipenghui commented on pull request #12686: URL: https://github.com/apache/pulsar/pull/12686#issuecomment-963839406 @yuruguo I think it's duplicated with https://github.com/apache/pulsar/pull/12675 ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] yuruguo opened a new pull request #12686: Fix test fail in TestRunMain

2021-11-08 Thread GitBox
yuruguo opened a new pull request #12686: URL: https://github.com/apache/pulsar/pull/12686 ### Motivation This test `runMainNoArguments` in TestRunMain will fail because actual not equals expected value

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #12680: [website][upgrade]feat: docs migration - 2.7.1 / Reference

2021-11-08 Thread GitBox
Anonymitaet edited a comment on pull request #12680: URL: https://github.com/apache/pulsar/pull/12680#issuecomment-963835224 Incorrect: There are some tables not shown correctly (below are just a few examples)

[GitHub] [pulsar] Anonymitaet commented on pull request #12680: [website][upgrade]feat: docs migration - 2.7.1 / Reference

2021-11-08 Thread GitBox
Anonymitaet commented on pull request #12680: URL: https://github.com/apache/pulsar/pull/12680#issuecomment-963835224 Incorrect: There are some tables not shown correctly (below are just a few examples)

[GitHub] [pulsar] Anonymitaet commented on pull request #12679: [website][upgrade]feat: docs migration - 2.7.1 / Development

2021-11-08 Thread GitBox
Anonymitaet commented on pull request #12679: URL: https://github.com/apache/pulsar/pull/12679#issuecomment-963833268 Incorrect: https://deploy-preview-57--pulsar-next.netlify.app/docs/2.7.1/develop-tools

[pulsar] branch master updated: [website][upgrade]feat: docs migration - 2.7.1 / Admin API (#12676)

2021-11-08 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8992712 [website][upgrade]feat: docs migration

[GitHub] [pulsar] Anonymitaet merged pull request #12676: [website][upgrade]feat: docs migration - 2.7.1 / Admin API

2021-11-08 Thread GitBox
Anonymitaet merged pull request #12676: URL: https://github.com/apache/pulsar/pull/12676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: commit chapter Pulsar SQL (#12591)

2021-11-08 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3344a41 commit chapter Pulsar SQL (#12591)

[GitHub] [pulsar] Anonymitaet merged pull request #12591: [website][upgrade]feat: docs migration - version-2.7.2 Pulsar SQL

2021-11-08 Thread GitBox
Anonymitaet merged pull request #12591: URL: https://github.com/apache/pulsar/pull/12591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Shoothzj removed a comment on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj removed a comment on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963758419 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Shoothzj commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963806923 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on a change in pull request #12663: Optimize isValidPath check in MetadataStore

2021-11-08 Thread GitBox
Jason918 commented on a change in pull request #12663: URL: https://github.com/apache/pulsar/pull/12663#discussion_r745270913 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LocalMemoryMetadataStoreTest.java ## @@ -92,4 +75,15 @@ public void

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
cckellogg commented on a change in pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#discussion_r745270617 ## File path: pulsar/internal/connection.go ## @@ -327,8 +327,8 @@ func (c *connection) doHandshake() bool { } func (c *connection)

[GitHub] [pulsar] Jason918 opened a new pull request #12685: [Issue 12672][test] Reduce unnecessary message send in testPeekWithSubscriptionNameNotExist

2021-11-08 Thread GitBox
Jason918 opened a new pull request #12685: URL: https://github.com/apache/pulsar/pull/12685 Fixes #12672 ### Motivation See #12672 ### Modifications Reduced the message send in this test. ### Verifying this change - [ ] Make sure that

[GitHub] [pulsar] lordcheng10 opened a new issue #12684: Restart the upgrade in rotation, should not quarantine the bookie node

2021-11-08 Thread GitBox
lordcheng10 opened a new issue #12684: URL: https://github.com/apache/pulsar/issues/12684 **Is your feature request related to a problem? Please describe.** When I restarted and upgraded pulsar and bookkeeper in rotation, I found that all bookie nodes were quarantine, which caused the

[GitHub] [pulsar] yuruguo removed a comment on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-08 Thread GitBox
yuruguo removed a comment on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-963787282 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] lordcheng10 opened a new pull request #12683: Restart the upgrade in rotation, should not quarantine the bookie node

2021-11-08 Thread GitBox
lordcheng10 opened a new pull request #12683: URL: https://github.com/apache/pulsar/pull/12683 ### Motivation When I restarted and upgraded pulsar and bookkeeper in rotation, I found that all bookie nodes were quarantine, which caused the client to be abnormal for a long time:

[GitHub] [pulsar] yuruguo commented on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-08 Thread GitBox
yuruguo commented on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-963787282 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on issue #12672: Flaky-test: PersistentTopicsTest.testPeekWithSubscriptionNameNotExist

2021-11-08 Thread GitBox
Jason918 commented on issue #12672: URL: https://github.com/apache/pulsar/issues/12672#issuecomment-963786103 +1, I think it's because it sends too many messages, not necessary though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] Jason918 commented on pull request #12654: Remove unused listeners if it have no listeners.

2021-11-08 Thread GitBox
Jason918 commented on pull request #12654: URL: https://github.com/apache/pulsar/pull/12654#issuecomment-963784721 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on issue #12668: Protocol Handlers and Proxy Extensions: ability to use a dedicated EventLoopGroup for IO

2021-11-08 Thread GitBox
Jason918 commented on issue #12668: URL: https://github.com/apache/pulsar/issues/12668#issuecomment-963783628 +1 I am working on another protocol handlers. I worked around this by setup a new netty server in `ProtocolHandler#start` to make thread isolation. It will be great we can

[GitHub] [pulsar] Jason918 commented on a change in pull request #12663: Optimize isValidPath check in MetadataStore

2021-11-08 Thread GitBox
Jason918 commented on a change in pull request #12663: URL: https://github.com/apache/pulsar/pull/12663#discussion_r745257972 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LocalMemoryMetadataStoreTest.java ## @@ -92,4 +75,15 @@ public void

[GitHub] [pulsar] Jason918 commented on pull request #12663: Optimize isValidPath check in MetadataStore

2021-11-08 Thread GitBox
Jason918 commented on pull request #12663: URL: https://github.com/apache/pulsar/pull/12663#issuecomment-963774847 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui commented on pull request #12681: [Transaction] Fix transaction flaky test testMaxReadPositionForNormal…

2021-11-08 Thread GitBox
codelipenghui commented on pull request #12681: URL: https://github.com/apache/pulsar/pull/12681#issuecomment-963772366 @congbobo184 could you please add more context about the flaky test and how it will be fixed by this PR? -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] Jason918 commented on issue #12616: [BUG]KOP failed to get partition offset

2021-11-08 Thread GitBox
Jason918 commented on issue #12616: URL: https://github.com/apache/pulsar/issues/12616#issuecomment-963770988 > Reopen this issue since it might also be a bug at Pulsar side. +1, it seems that lastConfirmedEntry is not updated in ManagedLedgerImpl#internalTrimLedgers. --

[pulsar] branch master updated (f9d16ca -> f44f6a0)

2021-11-08 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f9d16ca [Doc] Add explanations for setting geo-replication at topic level (#12633) add f44f6a0 Add docs for

[GitHub] [pulsar] wolfstudy merged pull request #12660: Add docs for nack backoff policy

2021-11-08 Thread GitBox
wolfstudy merged pull request #12660: URL: https://github.com/apache/pulsar/pull/12660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wmfxly opened a new issue #12682: Pulsar Transaction msg stop application throw executor not accepting a task

2021-11-08 Thread GitBox
wmfxly opened a new issue #12682: URL: https://github.com/apache/pulsar/issues/12682 Describe the bug: I use pulsar 2.8.1 version, open the transaction message, after sending the message, stop the service, and receive an exception. The exception information is as follows:

[GitHub] [pulsar] Shoothzj removed a comment on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj removed a comment on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963713886 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Shoothzj commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963758419 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12663: Optimize isValidPath check in MetadataStore

2021-11-08 Thread GitBox
codelipenghui commented on a change in pull request #12663: URL: https://github.com/apache/pulsar/pull/12663#discussion_r745242068 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/LocalMemoryMetadataStoreTest.java ## @@ -92,4 +75,15 @@ public void

[GitHub] [pulsar] nodece commented on pull request #12625: [Sink] Fix the parse the cleanupSubscription and processingGuarantees fields

2021-11-08 Thread GitBox
nodece commented on pull request #12625: URL: https://github.com/apache/pulsar/pull/12625#issuecomment-963757843 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] github-actions[bot] commented on pull request #12681: [Transaction] Fix transaction flaky test testMaxReadPositionForNormal…

2021-11-08 Thread GitBox
github-actions[bot] commented on pull request #12681: URL: https://github.com/apache/pulsar/pull/12681#issuecomment-963757355 @congbobo184:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] github-actions[bot] commented on pull request #12681: [Transaction] Fix transaction flaky test testMaxReadPositionForNormal…

2021-11-08 Thread GitBox
github-actions[bot] commented on pull request #12681: URL: https://github.com/apache/pulsar/pull/12681#issuecomment-963757211 @congbobo184:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] congbobo184 opened a new pull request #12681: [Transaction] Fix transaction flaky test testMaxReadPositionForNormal…

2021-11-08 Thread GitBox
congbobo184 opened a new pull request #12681: URL: https://github.com/apache/pulsar/pull/12681 ## Motivation fix flaky test https://github.com/apache/pulsar/issues/12671 Does this pull request potentially affect one of the following parts: If yes was chosen, please highlight

[GitHub] [pulsar-client-go] BewareMyPower commented on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
BewareMyPower commented on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963751704 The current `waitUntilReady` implementation is ```go func (c *connection) waitUntilReady() error { c.Lock() defer c.Unlock()

[GitHub] [pulsar-client-go] BewareMyPower commented on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
BewareMyPower commented on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963745752 I agree that we should call `c.Broadcast()` after `c.Wait()`, but the code here is not like the example in

[GitHub] [pulsar] urfreespace opened a new pull request #12679: [website][upgrade]feat: docs migration - 2.7.1 / Development

2021-11-08 Thread GitBox
urfreespace opened a new pull request #12679: URL: https://github.com/apache/pulsar/pull/12679 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #12680: [website][upgrade]feat: docs migration - 2.7.1 / Reference

2021-11-08 Thread GitBox
urfreespace opened a new pull request #12680: URL: https://github.com/apache/pulsar/pull/12680 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #12678: [website][upgrade]feat: docs migration - 2.7.1 / Cookbooks

2021-11-08 Thread GitBox
urfreespace opened a new pull request #12678: URL: https://github.com/apache/pulsar/pull/12678 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #12677: [website][upgrade]feat: docs migration - 2.7.1 / Adapters

2021-11-08 Thread GitBox
urfreespace opened a new pull request #12677: URL: https://github.com/apache/pulsar/pull/12677 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] urfreespace opened a new pull request #12676: [website][upgrade]feat: docs migration - 2.7.1 / Admin API

2021-11-08 Thread GitBox
urfreespace opened a new pull request #12676: URL: https://github.com/apache/pulsar/pull/12676 Signed-off-by: LiLi *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #11766 *(or if this PR is one task of a github issue, please add `Master Issue:

[GitHub] [pulsar-client-go] BewareMyPower commented on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
BewareMyPower commented on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963735350 Sorry I gave a wrong example. The `c.Wait()` is not called because `flag` is already true. It's right if my example was modified from ```go for !flag

[GitHub] [pulsar-client-go] BewareMyPower edited a comment on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
BewareMyPower edited a comment on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963732361 https://github.com/apache/pulsar-client-go/blob/fe3b7c4e445b3de42974ca692574229ad9099a45/pulsar/internal/connection.go#L212 And see

[GitHub] [pulsar-client-go] BewareMyPower commented on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
BewareMyPower commented on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963732361 https://github.com/apache/pulsar-client-go/blob/fe3b7c4e445b3de42974ca692574229ad9099a45/pulsar/internal/connection.go#L212 And see

[GitHub] [pulsar] codelipenghui commented on issue #12671: Flaky-test: TransactionTest.testMaxReadPositionForNormalPublish

2021-11-08 Thread GitBox
codelipenghui commented on issue #12671: URL: https://github.com/apache/pulsar/issues/12671#issuecomment-963720477 @congbobo184 Could you please help check this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] BewareMyPower commented on issue #12616: [BUG]KOP failed to get partition offset

2021-11-08 Thread GitBox
BewareMyPower commented on issue #12616: URL: https://github.com/apache/pulsar/issues/12616#issuecomment-963716529 Reopen this issue since it might also be a bug at Pulsar side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Shoothzj commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963713886 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Shoothzj removed a comment on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj removed a comment on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963677677 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Anonymitaet commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Anonymitaet commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963712465 Doc changes LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet commented on pull request #12675: [tools] fix TestRunMain test

2021-11-08 Thread GitBox
Anonymitaet commented on pull request #12675: URL: https://github.com/apache/pulsar/pull/12675#issuecomment-963710732 Hi @rdhabalia do we need to update docs for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[pulsar] branch master updated (4de4597 -> f9d16ca)

2021-11-08 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4de4597 commit chapter Tiered Storage (#12592) add f9d16ca [Doc] Add explanations for setting

[GitHub] [pulsar] codelipenghui merged pull request #12633: [Doc] Add explanations for setting geo-replication at topic level

2021-11-08 Thread GitBox
codelipenghui merged pull request #12633: URL: https://github.com/apache/pulsar/pull/12633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (eb85b22 -> 4de4597)

2021-11-08 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from eb85b22 [pulsar-admin] Add remove-subscription-types-enabled command for namespace (#12392) add 4de4597

[GitHub] [pulsar] Anonymitaet merged pull request #12592: [website][upgrade]feat: docs migration - version-2.7.2 Tiered Storage

2021-11-08 Thread GitBox
Anonymitaet merged pull request #12592: URL: https://github.com/apache/pulsar/pull/12592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Shoothzj commented on pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj commented on pull request #12669: URL: https://github.com/apache/pulsar/pull/12669#issuecomment-963677677 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] rdhabalia commented on a change in pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

2021-11-08 Thread GitBox
rdhabalia commented on a change in pull request #12674: URL: https://github.com/apache/pulsar/pull/12674#discussion_r745156894 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java ## @@ -424,4 +424,22 @@ public void

[GitHub] [pulsar] rdhabalia commented on a change in pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

2021-11-08 Thread GitBox
rdhabalia commented on a change in pull request #12674: URL: https://github.com/apache/pulsar/pull/12674#discussion_r745156071 ## File path: pulsar-client-tools/src/test/java/org/apache/pulsar/admin/cli/TestRunMain.java ## @@ -31,7 +31,7 @@ public void

[GitHub] [pulsar-client-go] bschofield edited a comment on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
bschofield edited a comment on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963433544 @cckellogg @BewareMyPower I think this relates to your discussion in https://github.com/apache/pulsar-client-go/pull/631/files#r723350028, would appreciate it

[GitHub] [pulsar] github-actions[bot] commented on pull request #12675: [tools] fix TestRunMain test

2021-11-08 Thread GitBox
github-actions[bot] commented on pull request #12675: URL: https://github.com/apache/pulsar/pull/12675#issuecomment-963596226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] rdhabalia opened a new pull request #12675: [tools] fix TestRunMain test

2021-11-08 Thread GitBox
rdhabalia opened a new pull request #12675: URL: https://github.com/apache/pulsar/pull/12675 ### Motivation [PulsarAdminTool](https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java#L297) returns with exist-code

[GitHub] [pulsar] eolivelli commented on a change in pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

2021-11-08 Thread GitBox
eolivelli commented on a change in pull request #12674: URL: https://github.com/apache/pulsar/pull/12674#discussion_r745088490 ## File path: pulsar-client-tools/src/test/java/org/apache/pulsar/admin/cli/TestRunMain.java ## @@ -31,7 +31,7 @@ public void

[GitHub] [pulsar] eolivelli commented on a change in pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

2021-11-08 Thread GitBox
eolivelli commented on a change in pull request #12674: URL: https://github.com/apache/pulsar/pull/12674#discussion_r745087873 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java ## @@ -424,4 +424,22 @@ public void

[GitHub] [pulsar] github-actions[bot] commented on pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

2021-11-08 Thread GitBox
github-actions[bot] commented on pull request #12674: URL: https://github.com/apache/pulsar/pull/12674#issuecomment-963439410 @rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] rdhabalia opened a new pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

2021-11-08 Thread GitBox
rdhabalia opened a new pull request #12674: URL: https://github.com/apache/pulsar/pull/12674 ### Motivation Add pending-queue size metrics to producer stats to create monitoring at client side and monitor various scenarios : timeout, high latency, memory, etc.. ### Modification

[GitHub] [pulsar-client-go] bschofield edited a comment on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
bschofield edited a comment on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963433544 @cckellogg @BewareMyPower I think this relates to your discussion in https://github.com/apache/pulsar-client-go/pull/631/files#r723350028, would appreciate it

[GitHub] [pulsar-client-go] bschofield edited a comment on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
bschofield edited a comment on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963433544 @cckellogg @BewareMyPower I think this relates to your discussion in https://github.com/apache/pulsar-client-go/pull/631/files#r723350028, would appreciate it

[GitHub] [pulsar-client-go] bschofield commented on pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
bschofield commented on pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663#issuecomment-963433544 @cckellogg @BewareMyPower I think this relates to your discussion in https://github.com/apache/pulsar-client-go/pull/631/files#r723350028, would appreciate it if you

[GitHub] [pulsar] jadireddi commented on pull request #12439: [Issue 12271][Modernizer] Add Maven Modernizer plugin to pulsar-metadata module

2021-11-08 Thread GitBox
jadireddi commented on pull request #12439: URL: https://github.com/apache/pulsar/pull/12439#issuecomment-963399123 @codelipenghui , Rebased on the latest master. Could you please review and approve the workflow to run, as it's my first PR. -- This is an automated message from the

[GitHub] [pulsar-client-go] bschofield opened a new pull request #663: [Issue 662] Fix race in connection.go waitUntilReady()

2021-11-08 Thread GitBox
bschofield opened a new pull request #663: URL: https://github.com/apache/pulsar-client-go/pull/663 Fixes #662 ### Motivation As described in #662, there appears to be a potential race condition in connection.go function _waitUntilReady()_: the `cond.Broadcast()` can occur

[GitHub] [pulsar] eolivelli commented on pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

2021-11-08 Thread GitBox
eolivelli commented on pull request #12673: URL: https://github.com/apache/pulsar/pull/12673#issuecomment-963329000 @codelipenghui @merlimat I would commit this to branch-2.9 before cutting the new RC also we should add this to branch-2.8 and get this to next release out of that

[GitHub] [pulsar] eolivelli opened a new pull request #12673: Pulsar Client: restore SchemaInfo.builder() API

2021-11-08 Thread GitBox
eolivelli opened a new pull request #12673: URL: https://github.com/apache/pulsar/pull/12673 Fixes #12670 ### Motivation In 2.8.0 we dropped SchemaInfo.builder() API and so it is no more possible to create a SchemaInfo instance without using SchemaInfoImpl internal class.

[GitHub] [pulsar] zeo1995 commented on pull request #12591: [website][upgrade]feat: docs migration - version-2.7.2 Pulsar SQL

2021-11-08 Thread GitBox
zeo1995 commented on pull request #12591: URL: https://github.com/apache/pulsar/pull/12591#issuecomment-963325347 @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] zeo1995 commented on pull request #12592: [website][upgrade]feat: docs migration - version-2.7.2 Tiered Storage

2021-11-08 Thread GitBox
zeo1995 commented on pull request #12592: URL: https://github.com/apache/pulsar/pull/12592#issuecomment-963324842 @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] eolivelli commented on issue #12670: Java Client Schema API: SchemaInfo.builder() is no more present in Pulsar 2.8.x

2021-11-08 Thread GitBox
eolivelli commented on issue #12670: URL: https://github.com/apache/pulsar/issues/12670#issuecomment-963303980 It is actually not possible to preserve binary compatibility with Pulsar 2.7.x but we should at least provide the Builder -- This is an automated message from the Apache Git

[GitHub] [pulsar-client-go] bschofield edited a comment on issue #662: newPartitionProducer() occasionally hangs, waiting for a ready connection

2021-11-08 Thread GitBox
bschofield edited a comment on issue #662: URL: https://github.com/apache/pulsar-client-go/issues/662#issuecomment-963286629 In this code: ``` for c.getState() != connectionReady { c.log.Debugf("Wait until connection is ready state=%s",

[GitHub] [pulsar-client-go] bschofield edited a comment on issue #662: newPartitionProducer() occasionally hangs, waiting for a ready connection

2021-11-08 Thread GitBox
bschofield edited a comment on issue #662: URL: https://github.com/apache/pulsar-client-go/issues/662#issuecomment-963286629 In this code: ``` for c.getState() != connectionReady { c.log.Debugf("Wait until connection is ready state=%s",

[GitHub] [pulsar-client-go] bschofield commented on issue #662: newPartitionProducer() occasionally hangs, waiting for a ready connection

2021-11-08 Thread GitBox
bschofield commented on issue #662: URL: https://github.com/apache/pulsar-client-go/issues/662#issuecomment-963286629 In this code: ``` for c.getState() != connectionReady { c.log.Debugf("Wait until connection is ready state=%s", c.getState().String())

[GitHub] [pulsar-client-go] bschofield opened a new issue #662: newPartitionProducer() occasionally hangs, waiting for a ready connection

2021-11-08 Thread GitBox
bschofield opened a new issue #662: URL: https://github.com/apache/pulsar-client-go/issues/662 Expected behavior When creating a partitioned producer, producers for all partitions should be created. Actual behavior I am writing to a topic with six partitions.

[GitHub] [pulsar] lhotari opened a new issue #12672: Flaky-test: PersistentTopicsTest.testPeekWithSubscriptionNameNotExist

2021-11-08 Thread GitBox
lhotari opened a new issue #12672: URL: https://github.com/apache/pulsar/issues/12672 PersistentTopicsTest is flaky. The testPeekWithSubscriptionNameNotExist test method fails sporadically. [example

[GitHub] [pulsar] lhotari opened a new issue #12671: Flaky-test: TransactionTest.testMaxReadPositionForNormalPublish

2021-11-08 Thread GitBox
lhotari opened a new issue #12671: URL: https://github.com/apache/pulsar/issues/12671 TransactionTest is flaky. The testMaxReadPositionForNormalPublish test method fails sporadically. [example

[GitHub] [pulsar] eolivelli commented on issue #12670: Java Client Schema API: SchemaInfo.builder() is no more present in Pulsar 2.8.x

2021-11-08 Thread GitBox
eolivelli commented on issue #12670: URL: https://github.com/apache/pulsar/issues/12670#issuecomment-963247039 @merlimat FYI I will send a patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] eolivelli opened a new issue #12670: Java Client Schema API: SchemaInfo.builder() is no more present in Pulsar 2.8.x

2021-11-08 Thread GitBox
eolivelli opened a new issue #12670: URL: https://github.com/apache/pulsar/issues/12670 **Describe the bug** SchemaInfo.builder() is no more available in Pulsar 2.8.x, so there is no way to use the pure public API to build a SchemaInfo object. **Suggestion** This is a breaking

[GitHub] [pulsar] Shoothzj opened a new pull request #12669: Fix the typo of BookKeeper, missing k/K

2021-11-08 Thread GitBox
Shoothzj opened a new pull request #12669: URL: https://github.com/apache/pulsar/pull/12669 ### Motivation There are several typo of `BookKeeper`, missing k/K ### Documentation Check the box below and label this PR (if you have committer privilege). Need to update

[GitHub] [pulsar] eolivelli opened a new issue #12668: Protocol Handlers and Proxy Extensions: ability to use a dedicated EventLoopGroup for IO

2021-11-08 Thread GitBox
eolivelli opened a new issue #12668: URL: https://github.com/apache/pulsar/issues/12668 Currently (Pulsar 2.9) the Broker Protocol Handlers (and Proxy Extensions) share the same EventLoopGroup among Pulsar Server connection handlers and the custom Protocol Handlers. We have two

  1   2   >