[GitHub] [pulsar] xiaobing0508 commented on issue #13664: Get topics list Timeout

2022-01-06 Thread GitBox
xiaobing0508 commented on issue #13664: URL: https://github.com/apache/pulsar/issues/13664#issuecomment-1007198779 I don't know what happened,yesterday evening my bookies is read only,because phycical disk is full. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] mattisonchao commented on issue #13664: Get topics list Timeout

2022-01-06 Thread GitBox
mattisonchao commented on issue #13664: URL: https://github.com/apache/pulsar/issues/13664#issuecomment-1007197738 @xiaobing0508 could you give us more information to reproduce it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] gaozhangmin commented on issue #13661: [PIP] Pulsar consumer support auto acknowledge.

2022-01-06 Thread GitBox
gaozhangmin commented on issue #13661: URL: https://github.com/apache/pulsar/issues/13661#issuecomment-1007195650 > One Preliminary question: > > * If user set `autoAckEnabled=ture` and then user invoke `negative ack`, what things will happen ? We should avoid this, We forbid

[GitHub] [pulsar] xiaobing0508 opened a new issue #13664: Get topics list Timeout

2022-01-06 Thread GitBox
xiaobing0508 opened a new issue #13664: URL: https://github.com/apache/pulsar/issues/13664 My pulsar version is 2.9.1. Now,faild for read and write. Error is "errorMsg":"Failed due to too many pending lookup requests". -- This is an automated message from the Apache Git Service. To

[pulsar] branch master updated (2704f1f -> e5159ce)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2704f1f Avoid repeatly set startMessageIdData to null for ConsumerImpl (#13606) add e5159ce [Doc] Fix doc

[GitHub] [pulsar] codelipenghui commented on pull request #1063: ENH: Add code formatter for Java

2022-01-06 Thread GitBox
codelipenghui commented on pull request #1063: URL: https://github.com/apache/pulsar/pull/1063#issuecomment-1007194552 Close the PR since inactive for a long time, and it's not a critical issue fix or a new feature. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] codelipenghui closed pull request #1063: ENH: Add code formatter for Java

2022-01-06 Thread GitBox
codelipenghui closed pull request #1063: URL: https://github.com/apache/pulsar/pull/1063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (f6f46ec -> 2704f1f)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f6f46ec Enable CheckStyle Plugin in Pulsar client api (#13638) add 2704f1f Avoid repeatly set

[pulsar] branch master updated (9484f81 -> f6f46ec)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9484f81 Fix code example of producer for delay message (#13647) add f6f46ec Enable CheckStyle Plugin in

[GitHub] [pulsar] liudezhi2098 commented on pull request #13619: Enable CheckStyle Plugin in managed-ledger module

2022-01-06 Thread GitBox
liudezhi2098 commented on pull request #13619: URL: https://github.com/apache/pulsar/pull/13619#issuecomment-1007192735 @codelipenghui PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #13609: Fix bug :Infinity value for CPU or Bandwidth usage

2022-01-06 Thread GitBox
lordcheng10 commented on pull request #13609: URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1007192612 @codelipenghui PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (33491bc -> 9484f81)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 33491bc [issue #13439][backlogQuota] Allow both limit and limitsize be null (#13557) add 9484f81 Fix code

[GitHub] [pulsar] codelipenghui merged pull request #13598: [Doc] Fix doc for chunked message related stats.

2022-01-06 Thread GitBox
codelipenghui merged pull request #13598: URL: https://github.com/apache/pulsar/pull/13598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13606: Avoid repeatly set startMessageIdData to null for ConsumerImpl

2022-01-06 Thread GitBox
codelipenghui merged pull request #13606: URL: https://github.com/apache/pulsar/pull/13606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13638: Enable CheckStyle Plugin in Pulsar client api

2022-01-06 Thread GitBox
codelipenghui merged pull request #13638: URL: https://github.com/apache/pulsar/pull/13638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (b38d850 -> 33491bc)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b38d850 Healthcheck v2 failed (#13525) add 33491bc [issue #13439][backlogQuota] Allow both limit and

[GitHub] [pulsar] codelipenghui merged pull request #13647: Fix code example of producer for delay message

2022-01-06 Thread GitBox
codelipenghui merged pull request #13647: URL: https://github.com/apache/pulsar/pull/13647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13557: [issue #13439][backlogQuota] Allow both limit and limitsize be null

2022-01-06 Thread GitBox
codelipenghui merged pull request #13557: URL: https://github.com/apache/pulsar/pull/13557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui closed issue #13439: Regression creating a namespace with "null" in "backlog_quota_map" causes a NullPointerException on 2.9.1, but not 2.9.0 or earlier

2022-01-06 Thread GitBox
codelipenghui closed issue #13439: URL: https://github.com/apache/pulsar/issues/13439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (07f131f -> b38d850)

2022-01-06 Thread massakam
This is an automated email from the ASF dual-hosted git repository. massakam pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 07f131f Fix reader skipped remaining compacted data during the topic unloading. (#13629) add b38d850

[GitHub] [pulsar] massakam merged pull request #13525: Healthcheck v2 failed

2022-01-06 Thread GitBox
massakam merged pull request #13525: URL: https://github.com/apache/pulsar/pull/13525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] massakam closed issue #13520: Broker health check with `TopicVersion.V2` failed

2022-01-06 Thread GitBox
massakam closed issue #13520: URL: https://github.com/apache/pulsar/issues/13520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wenbingshen commented on pull request #13655: fix no response to client when handleSubscribe because PendingAckHandleImpl init fail

2022-01-06 Thread GitBox
wenbingshen commented on pull request #13655: URL: https://github.com/apache/pulsar/pull/13655#issuecomment-1007176310 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] suiyuzeng commented on pull request #13623: maxSubscriptionsPerTopic support cross multiple clusters

2022-01-06 Thread GitBox
suiyuzeng commented on pull request #13623: URL: https://github.com/apache/pulsar/pull/13623#issuecomment-1007174048 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Jason918 commented on pull request #13599: [PIP 131] Resolve produce chunk messages failed when topic level maxMessageSize is set

2022-01-06 Thread GitBox
Jason918 commented on pull request #13599: URL: https://github.com/apache/pulsar/pull/13599#issuecomment-1007163984 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 opened a new issue #13663: Flaky-test: org.apache.pulsar.metadata.LockManagerTest.updateValue

2022-01-06 Thread GitBox
Jason918 opened a new issue #13663: URL: https://github.com/apache/pulsar/issues/13663 org.apache.pulsar.metadata.LockManagerTest is flaky. The updateValue test method fails sporadically. [example

[pulsar] branch master updated (fd3ba55 -> 07f131f)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fd3ba55 Fix issues 11964, deadlock bug when use key_shared mode (#11965) add 07f131f Fix reader skipped

[GitHub] [pulsar] codelipenghui merged pull request #13629: Fix reader skipped remaining compacted data during the topic unloading.

2022-01-06 Thread GitBox
codelipenghui merged pull request #13629: URL: https://github.com/apache/pulsar/pull/13629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] k2la commented on pull request #13662: [Python] Support is_connected in Python Client

2022-01-06 Thread GitBox
k2la commented on pull request #13662: URL: https://github.com/apache/pulsar/pull/13662#issuecomment-1007151045 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #13611: [ Issue 13479 ] Fixed internal topic effect by InactiveTopicPolicy.

2022-01-06 Thread GitBox
mattisonchao commented on pull request #13611: URL: https://github.com/apache/pulsar/pull/13611#issuecomment-1007150897 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] mattisonchao edited a comment on issue #13661: [PIP] Pulsar consumer support auto acknowledge.

2022-01-06 Thread GitBox
mattisonchao edited a comment on issue #13661: URL: https://github.com/apache/pulsar/issues/13661#issuecomment-1007150553 One Preliminary question: - If user set ``autoAckEnabled=ture`` and then user invoke ``negative ack``, what things will happen ? -- This is an automated

[GitHub] [pulsar] mattisonchao commented on issue #13661: [PIP] Pulsar consumer support auto acknowledge.

2022-01-06 Thread GitBox
mattisonchao commented on issue #13661: URL: https://github.com/apache/pulsar/issues/13661#issuecomment-1007150553 One Preliminary question: - If user set ``autoAckEnabled=ture`` and then user invoke negative ack, what things will happen ? -- This is an automated message from the

[GitHub] [pulsar] github-actions[bot] commented on pull request #13662: [Python] Support is_connected in Python Client

2022-01-06 Thread GitBox
github-actions[bot] commented on pull request #13662: URL: https://github.com/apache/pulsar/pull/13662#issuecomment-1007150300 @k2la:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] github-actions[bot] commented on pull request #13662: [Python] Support is_connected in Python Client

2022-01-06 Thread GitBox
github-actions[bot] commented on pull request #13662: URL: https://github.com/apache/pulsar/pull/13662#issuecomment-1007149958 @k2la:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] codelipenghui commented on pull request #12507: Broker: remove duplicate code in searchForCandidateBroker

2022-01-06 Thread GitBox
codelipenghui commented on pull request #12507: URL: https://github.com/apache/pulsar/pull/12507#issuecomment-1007149761 @letterwuyu Could you please help resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] k2la opened a new pull request #13662: [Python] Support is_connected in Python Client

2022-01-06 Thread GitBox
k2la opened a new pull request #13662: URL: https://github.com/apache/pulsar/pull/13662 ### Motivation We would like to use `is_connected()` in Python Client. ### Modifications - Add `is_connected()` to producer/consumer/reader - Add tests ### Verifying this change - [

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12520: [pulsar-client] Add conf backoff values

2022-01-06 Thread GitBox
codelipenghui commented on a change in pull request #12520: URL: https://github.com/apache/pulsar/pull/12520#discussion_r780032615 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -884,9 +884,9 @@ public void reloadLookUp()

[GitHub] [pulsar] gaozhangmin opened a new issue #13661: Pulsar consumer support auto acknowledge.

2022-01-06 Thread GitBox
gaozhangmin opened a new issue #13661: URL: https://github.com/apache/pulsar/issues/13661 ## Motivation Pulsar should support auto commit offset by client itself like what KAFKA did. ## Goal Consumer support config `autoAckEnabled` and `autoAckIntervalMs` which

[GitHub] [pulsar] codelipenghui commented on pull request #12919: [Broker] Change create topic return error to Status.BAD_REQUEST

2022-01-06 Thread GitBox
codelipenghui commented on pull request #12919: URL: https://github.com/apache/pulsar/pull/12919#issuecomment-1007145654 @congbobo184 Could you please check the comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] codelipenghui commented on pull request #13298: [11646][Pulsar Java client] Fix ConfigurationDataUtils loadConf strategy

2022-01-06 Thread GitBox
codelipenghui commented on pull request #13298: URL: https://github.com/apache/pulsar/pull/13298#issuecomment-1007145128 @mgrenonville You can left a comment with content `/pulsarbot run-failure-checks` to trigger to rerun the failed tests. -- This is an automated message from the

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13337: Fix delete namespace with 'Cannot delete non empty bundle' issue.

2022-01-06 Thread GitBox
codelipenghui commented on a change in pull request #13337: URL: https://github.com/apache/pulsar/pull/13337#discussion_r780030164 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java ## @@ -262,29 +262,39 @@ protected void

[GitHub] [pulsar] mattisonchao commented on a change in pull request #13589: Change ``ContextClassLoader`` to ``NarClassLoader`` in BrokerInterceptor

2022-01-06 Thread GitBox
mattisonchao commented on a change in pull request #13589: URL: https://github.com/apache/pulsar/pull/13589#discussion_r780028816 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/intercept/BrokerInterceptorWithClassLoaderTest.java ## @@ -18,14 +18,26 @@ */

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13589: Change ``ContextClassLoader`` to ``NarClassLoader`` in BrokerInterceptor

2022-01-06 Thread GitBox
codelipenghui commented on a change in pull request #13589: URL: https://github.com/apache/pulsar/pull/13589#discussion_r780027408 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/intercept/BrokerInterceptorWithClassLoaderTest.java ## @@ -18,14 +18,26 @@

[pulsar] branch master updated (3abf813 -> fd3ba55)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3abf813 [doc] add notes on worker threads (#13636) add fd3ba55 Fix issues 11964, deadlock bug when use

[GitHub] [pulsar] codelipenghui merged pull request #11965: fix issues 11964, deadlock bug when use key_shared mode

2022-01-06 Thread GitBox
codelipenghui merged pull request #11965: URL: https://github.com/apache/pulsar/pull/11965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui closed issue #11964: key_shared mode maybe deadlock and with a lot of CLOSE_WAIT

2022-01-06 Thread GitBox
codelipenghui closed issue #11964: URL: https://github.com/apache/pulsar/issues/11964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wenbingshen commented on pull request #13655: fix no response to client when handleSubscribe because PendingAckHandleImpl init fail

2022-01-06 Thread GitBox
wenbingshen commented on pull request #13655: URL: https://github.com/apache/pulsar/pull/13655#issuecomment-1007135054 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Anonymitaet commented on pull request #13646: [Doc] add explanations for entry filter

2022-01-06 Thread GitBox
Anonymitaet commented on pull request #13646: URL: https://github.com/apache/pulsar/pull/13646#issuecomment-1007126010 @Huanli-Meng incorporated your comments, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13646: [Doc] add explanations for entry filter

2022-01-06 Thread GitBox
Anonymitaet commented on a change in pull request #13646: URL: https://github.com/apache/pulsar/pull/13646#discussion_r780015046 ## File path: site2/docs/develop-plugin.md ## @@ -0,0 +1,123 @@ +--- +id: develop-plugin +title: Pulsar plugin development +sidebar_label: Plugin

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13646: [Doc] add explanations for entry filter

2022-01-06 Thread GitBox
Anonymitaet commented on a change in pull request #13646: URL: https://github.com/apache/pulsar/pull/13646#discussion_r780014281 ## File path: site2/docs/develop-plugin.md ## @@ -0,0 +1,123 @@ +--- +id: develop-plugin +title: Pulsar plugin development +sidebar_label: Plugin

[GitHub] [pulsar] Jason918 commented on issue #13643: NamespaceIsolationPolicies may need support priority

2022-01-06 Thread GitBox
Jason918 commented on issue #13643: URL: https://github.com/apache/pulsar/issues/13643#issuecomment-1007119574 > users may write regex pattern,r1, and r2,may match the same pattern, I am not sure whether we should encourage this. This may make the isolation policies too

[GitHub] [pulsar] urfreespace opened a new pull request #13660: [website][upgrade] feat: cli pages migration

2022-01-06 Thread GitBox
urfreespace opened a new pull request #13660: URL: https://github.com/apache/pulsar/pull/13660 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] Jason918 commented on pull request #13599: [PIP 131] Resolve produce chunk messages failed when topic level maxMessageSize is set

2022-01-06 Thread GitBox
Jason918 commented on pull request #13599: URL: https://github.com/apache/pulsar/pull/13599#issuecomment-1007116822 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Jason918 commented on pull request #13599: [PIP 131] Resolve produce chunk messages failed when topic level maxMessageSize is set

2022-01-06 Thread GitBox
Jason918 commented on pull request #13599: URL: https://github.com/apache/pulsar/pull/13599#issuecomment-1007114617 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] wenbingshen commented on a change in pull request #13655: fix no response to client when handleSubscribe because PendingAckHandleImpl init fail

2022-01-06 Thread GitBox
wenbingshen commented on a change in pull request #13655: URL: https://github.com/apache/pulsar/pull/13655#discussion_r780003416 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java ## @@ -141,6 +142,9 @@

[GitHub] [pulsar] yuruguo removed a comment on pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
yuruguo removed a comment on pull request #13650: URL: https://github.com/apache/pulsar/pull/13650#issuecomment-1007016111 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] mattisonchao closed issue #13628: [ PIP 134 ] Support Pulsar system event.

2022-01-06 Thread GitBox
mattisonchao closed issue #13628: URL: https://github.com/apache/pulsar/issues/13628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (8f26b39 -> 3abf813)

2022-01-06 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8f26b39 Enable checkstyle in pulsar-client-tools module (#13650) add 3abf813 [doc] add notes on worker threads

[GitHub] [pulsar] Anonymitaet merged pull request #13636: [doc] add notes on worker threads

2022-01-06 Thread GitBox
Anonymitaet merged pull request #13636: URL: https://github.com/apache/pulsar/pull/13636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- removed a comment on pull request #13636: [doc] add notes on worker threads

2022-01-06 Thread GitBox
Technoboy- removed a comment on pull request #13636: URL: https://github.com/apache/pulsar/pull/13636#issuecomment-1007095315 > @Technoboy- can you review this PR from the tech perspective? Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Technoboy- commented on pull request #13636: [doc] add notes on worker threads

2022-01-06 Thread GitBox
Technoboy- commented on pull request #13636: URL: https://github.com/apache/pulsar/pull/13636#issuecomment-1007095315 > @Technoboy- can you review this PR from the tech perspective? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] Technoboy- closed pull request #13636: [doc] add notes on worker threads

2022-01-06 Thread GitBox
Technoboy- closed pull request #13636: URL: https://github.com/apache/pulsar/pull/13636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] equanz commented on pull request #13644: Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

2022-01-06 Thread GitBox
equanz commented on pull request #13644: URL: https://github.com/apache/pulsar/pull/13644#issuecomment-1007090934 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] gaozhangmin commented on pull request #13525: Healthcheck v2 failed

2022-01-06 Thread GitBox
gaozhangmin commented on pull request #13525: URL: https://github.com/apache/pulsar/pull/13525#issuecomment-1007085348 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] lordcheng10 removed a comment on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-06 Thread GitBox
lordcheng10 removed a comment on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1006249035 @Jason918 I think this pull request is ready to merge. PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Demogorgon314 commented on pull request #13634: [pulsar-client] Fix the wrong multi-topic has message available behavior

2022-01-06 Thread GitBox
Demogorgon314 commented on pull request #13634: URL: https://github.com/apache/pulsar/pull/13634#issuecomment-1007084216 Look like the flaky test is not relevant to this PR. If I understand correctly. @codelipenghui Can you help me look at the CI? -- This is an automated message

[GitHub] [pulsar] lordcheng10 commented on pull request #13609: Fix bug :Infinity value for CPU or Bandwidth usage

2022-01-06 Thread GitBox
lordcheng10 commented on pull request #13609: URL: https://github.com/apache/pulsar/pull/13609#issuecomment-1007079648 > scheduleWithFixedDelay In GenericBrokerHostUsageImpl, there is no Infinity problem, but it is better to use scheduleWithFixedDelay. The length of data sampling

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13655: fix no response to client when handleSubscribe because PendingAckHandleImpl init fail

2022-01-06 Thread GitBox
Technoboy- commented on a change in pull request #13655: URL: https://github.com/apache/pulsar/pull/13655#discussion_r779979820 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java ## @@ -141,6 +142,9 @@

[GitHub] [pulsar] liudezhi2098 commented on pull request #13615: [Doc] adjusting md style

2022-01-06 Thread GitBox
liudezhi2098 commented on pull request #13615: URL: https://github.com/apache/pulsar/pull/13615#issuecomment-1007075474 @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet commented on pull request #13652: [Issue 13651][elastic-search] Fix Elasticsearch Sink Invalid type for uuid encoded as logical types

2022-01-06 Thread GitBox
Anonymitaet commented on pull request #13652: URL: https://github.com/apache/pulsar/pull/13652#issuecomment-1007071054 when submitting a PR, can you provide doc-related info (tick the box) in the [PR

[GitHub] [pulsar] Anonymitaet commented on pull request #13652: [Issue 13651][elastic-search] Fix Elasticsearch Sink Invalid type for uuid encoded as logical types

2022-01-06 Thread GitBox
Anonymitaet commented on pull request #13652: URL: https://github.com/apache/pulsar/pull/13652#issuecomment-1007070882 Hi @vroyer does your PR affect docs https://pulsar.apache.org/docs/en/next/io-elasticsearch-sink/#configuration? -- This is an automated message from the Apache Git

[GitHub] [pulsar] github-actions[bot] commented on pull request #13659: [pulsar-client-tools] Support Disable Replication in Pulsar Client Tools

2022-01-06 Thread GitBox
github-actions[bot] commented on pull request #13659: URL: https://github.com/apache/pulsar/pull/13659#issuecomment-1007070015 @k2la:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] github-actions[bot] commented on pull request #13659: [pulsar-client-tools] Support Disable Replication in Pulsar Client Tools

2022-01-06 Thread GitBox
github-actions[bot] commented on pull request #13659: URL: https://github.com/apache/pulsar/pull/13659#issuecomment-1007069805 @k2la:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] k2la opened a new pull request #13659: [pulsar-client-tools] Support Disable Replication in Pulsar Client Tools

2022-01-06 Thread GitBox
k2la opened a new pull request #13659: URL: https://github.com/apache/pulsar/pull/13659 ### Motivation We would like to use disable replication in pulsar-client-tools. ### Modifications Add `--disable-replication` parameter to `produce` (sub command) in pulsar-client-tools

[GitHub] [pulsar] leizhiyuan commented on issue #13643: NamespaceIsolationPolicies may need support priority

2022-01-06 Thread GitBox
leizhiyuan commented on issue #13643: URL: https://github.com/apache/pulsar/issues/13643#issuecomment-1007064882 > Any specific reason for one namespace to have multiple policies? because this rule support regex now, sometimes, users may write regex pattern,r1, and r2,may match the

[GitHub] [pulsar] Anonymitaet commented on pull request #13636: [doc] add notes on worker threads

2022-01-06 Thread GitBox
Anonymitaet commented on pull request #13636: URL: https://github.com/apache/pulsar/pull/13636#issuecomment-1007064790 @kimula You delete the backticks (``) so that Bot can not recognize the info and then labels the PR with `doc-info-missing`. [x] `doc-required` ✅ [x]

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13636: [doc] add notes on worker threads

2022-01-06 Thread GitBox
Anonymitaet commented on a change in pull request #13636: URL: https://github.com/apache/pulsar/pull/13636#discussion_r779968516 ## File path: site2/docs/client-libraries-node.md ## @@ -291,6 +291,13 @@ const consumer = await client.subscribe({ }); ``` +> Note +>

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13543: [Broker] Other old values are still valid when updating resource group

2022-01-06 Thread GitBox
codelipenghui commented on a change in pull request #13543: URL: https://github.com/apache/pulsar/pull/13543#discussion_r779961763 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ResourceGroupsBase.java ## @@ -63,10 +63,18 @@ protected void

[GitHub] [pulsar] wenbingshen commented on pull request #13655: fix no response to client when handleSubscribe because PendingAckHandleImpl init fail

2022-01-06 Thread GitBox
wenbingshen commented on pull request #13655: URL: https://github.com/apache/pulsar/pull/13655#issuecomment-1007053253 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (d2726d2 -> 8f26b39)

2022-01-06 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d2726d2 Remove unmaintained DC/OS deployment example (#13632) add 8f26b39 Enable checkstyle in

[GitHub] [pulsar] Demogorgon314 commented on pull request #13634: [pulsar-client] Fix the wrong multi-topic has message available behavior

2022-01-06 Thread GitBox
Demogorgon314 commented on pull request #13634: URL: https://github.com/apache/pulsar/pull/13634#issuecomment-1007052489 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] codelipenghui merged pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
codelipenghui merged pull request #13650: URL: https://github.com/apache/pulsar/pull/13650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] shibd commented on pull request #13656: Fix getInternalStats occasional lack of LeaderInfo

2022-01-06 Thread GitBox
shibd commented on pull request #13656: URL: https://github.com/apache/pulsar/pull/13656#issuecomment-1007049570 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] mattisonchao commented on pull request #13611: [ Issue 13479 ] Fixed internal topic effect by InactiveTopicPolicy.

2022-01-06 Thread GitBox
mattisonchao commented on pull request #13611: URL: https://github.com/apache/pulsar/pull/13611#issuecomment-1007049322 @codelipenghui @eolivelli @BewareMyPower @ericsyh @Technoboy- PTAL :) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Anonymitaet commented on pull request #13658: [Issue 13657][website] fixes to admin-api-tenants page

2022-01-06 Thread GitBox
Anonymitaet commented on pull request #13658: URL: https://github.com/apache/pulsar/pull/13658#issuecomment-1007048140 @pgier thanks for your contribution! You've provided a pretty clear and concise description. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] equanz commented on pull request #13644: Rename test file name from `*Test2.java` to `*Test.java` to run all tests correctly

2022-01-06 Thread GitBox
equanz commented on pull request #13644: URL: https://github.com/apache/pulsar/pull/13644#issuecomment-1007036252 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo removed a comment on pull request #13543: [Broker] Other old values are still valid when updating resource group

2022-01-06 Thread GitBox
yuruguo removed a comment on pull request #13543: URL: https://github.com/apache/pulsar/pull/13543#issuecomment-1006580645 @merlimat @freeznet PTAL, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] yuruguo removed a comment on pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
yuruguo removed a comment on pull request #13650: URL: https://github.com/apache/pulsar/pull/13650#issuecomment-1006579016 @codelipenghui @315157973 @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] yuruguo removed a comment on pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
yuruguo removed a comment on pull request #13650: URL: https://github.com/apache/pulsar/pull/13650#issuecomment-1006908209 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] yuruguo commented on pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
yuruguo commented on pull request #13650: URL: https://github.com/apache/pulsar/pull/13650#issuecomment-1007016111 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (775c3de -> d2726d2)

2022-01-06 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 775c3de Delete prometheus-dcos dockerfile (#13387) add d2726d2 Remove unmaintained DC/OS deployment

[pulsar] branch master updated (64840ed -> 775c3de)

2022-01-06 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 64840ed [Build] Fix maven warning about buildtools/pom.xml (#13630) add 775c3de Delete prometheus-dcos

[GitHub] [pulsar] michaeljmarshall merged pull request #13632: Remove unmaintained DC/OS deployment example

2022-01-06 Thread GitBox
michaeljmarshall merged pull request #13632: URL: https://github.com/apache/pulsar/pull/13632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall merged pull request #13387: Delete prometheus-dcos dockerfile

2022-01-06 Thread GitBox
michaeljmarshall merged pull request #13387: URL: https://github.com/apache/pulsar/pull/13387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo removed a comment on pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
yuruguo removed a comment on pull request #13650: URL: https://github.com/apache/pulsar/pull/13650#issuecomment-1006687668 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] yuruguo commented on pull request #13650: Enable checkstyle in pulsar-client-tools module

2022-01-06 Thread GitBox
yuruguo commented on pull request #13650: URL: https://github.com/apache/pulsar/pull/13650#issuecomment-1006908209 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] lhotari commented on pull request #13621: [Tests] Fix flaky WrongTypeOfReturnValue Mockito misuse issue in broker tests

2022-01-06 Thread GitBox
lhotari commented on pull request #13621: URL: https://github.com/apache/pulsar/pull/13621#issuecomment-1006873301 > @lhotari I have tried to cherry-pick this PR into branch-2.8, but there are many conflicts with branch-2.8. Do you want to push a PR to branch-2.8 directly?

[GitHub] [pulsar] saumitras commented on issue #7564: Schema properties are not updated if schema definition does not change

2022-01-06 Thread GitBox
saumitras commented on issue #7564: URL: https://github.com/apache/pulsar/issues/7564#issuecomment-1006773843 Looks like

[pulsar] branch master updated (83a983d -> 64840ed)

2022-01-06 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 83a983d Fix raw use of generic types in OwnershipCache (#13592) add 64840ed [Build] Fix maven warning about

[GitHub] [pulsar] lhotari merged pull request #13630: [Build] Fix warning about missing maven-checkstyle-plugin version in buildtools/pom.xml

2022-01-06 Thread GitBox
lhotari merged pull request #13630: URL: https://github.com/apache/pulsar/pull/13630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >