[GitHub] [pulsar] github-actions[bot] commented on pull request #14208: [Broker] Reduce redundant debug log

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14208: URL: https://github.com/apache/pulsar/pull/14208#issuecomment-1034593757 @gaozhangmin:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] github-actions[bot] commented on pull request #14208: [Broker] Reduce redundant debug log

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14208: URL: https://github.com/apache/pulsar/pull/14208#issuecomment-1034593390 @gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] gaozhangmin opened a new pull request #14208: [Broker] Reduce redundant debug log

2022-02-09 Thread GitBox
gaozhangmin opened a new pull request #14208: URL: https://github.com/apache/pulsar/pull/14208 ### Motivation Redundant debug log ### Modifications delete redundant debug log ### Documentation Check the box below or label this PR directly (if you have

[GitHub] [pulsar] mattisonchao closed issue #13979: [PIP-138] Use ``NarClassLoaderManager`` to manage all NarClassLoader.

2022-02-09 Thread GitBox
mattisonchao closed issue #13979: URL: https://github.com/apache/pulsar/issues/13979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] liangyepianzhou opened a new pull request #14207: [Transaction] delete CoordinatorClientStateException

2022-02-09 Thread GitBox
liangyepianzhou opened a new pull request #14207: URL: https://github.com/apache/pulsar/pull/14207 ### Motivation & Modification The state transition in the first line of the `TransactionCoordinatorClientImpl::startAsync` method does not fail. The exception here is redundant. So

[GitHub] [pulsar] Demogorgon314 commented on pull request #14196: [Broker] Change broker producer fence log level

2022-02-09 Thread GitBox
Demogorgon314 commented on pull request #14196: URL: https://github.com/apache/pulsar/pull/14196#issuecomment-1034581458 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] nodece closed pull request #13596: [Broker] Add operation timeout to metadata store

2022-02-09 Thread GitBox
nodece closed pull request #13596: URL: https://github.com/apache/pulsar/pull/13596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece closed pull request #13535: Improve print log when the topic does not exist

2022-02-09 Thread GitBox
nodece closed pull request #13535: URL: https://github.com/apache/pulsar/pull/13535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #13969: [Transaction] Adopt Single_thread to handle TcClient connecting

2022-02-09 Thread GitBox
liangyepianzhou commented on a change in pull request #13969: URL: https://github.com/apache/pulsar/pull/13969#discussion_r803367829 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java ## @@ -98,6 +107,7 @@ public

[GitHub] [pulsar] github-actions[bot] commented on pull request #14204: fix a log error in PulsarAuthorizationProvider

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14204: URL: https://github.com/apache/pulsar/pull/14204#issuecomment-1034558097 @fanjianye:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] gaozhangmin closed pull request #14205: [Flaky-Test] BacklogQuotaManagerTest#testProducerExceptionAndThenUnblockSizeQuota

2022-02-09 Thread GitBox
gaozhangmin closed pull request #14205: URL: https://github.com/apache/pulsar/pull/14205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] github-actions[bot] commented on pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14206: URL: https://github.com/apache/pulsar/pull/14206#issuecomment-1034556218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] momo-jun opened a new pull request #14206: [Doc] [Do-not-Merge] TableView java client: Add a new section and change code example

2022-02-09 Thread GitBox
momo-jun opened a new pull request #14206: URL: https://github.com/apache/pulsar/pull/14206 ## Modifications 1. Add a new section "Registering listeners" 2. Change code example for "Configure TableView" ## Preview

[GitHub] [pulsar] github-actions[bot] commented on pull request #14205: [Flaky-Test] BacklogQuotaManagerTest#testProducerExceptionAndThenUnblockSizeQuota

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14205: URL: https://github.com/apache/pulsar/pull/14205#issuecomment-1034555228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] gaozhangmin opened a new pull request #14205: [Flaky-Test] BacklogQuotaManagerTest#testProducerExceptionAndThenUnblockSizeQuota

2022-02-09 Thread GitBox
gaozhangmin opened a new pull request #14205: URL: https://github.com/apache/pulsar/pull/14205 Fixes #14203 ### Motivation Fix flaky test ### Modifications rolloverStats before `getMsgBacklog` ### Documentation Check the box below or label

[GitHub] [pulsar] github-actions[bot] commented on pull request #14204: fix a log error in PulsarAuthorizationProvider

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14204: URL: https://github.com/apache/pulsar/pull/14204#issuecomment-1034554522 @fanjianye:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] fanjianye opened a new pull request #14204: fix a log error in PulsarAuthorizationProvider

2022-02-09 Thread GitBox
fanjianye opened a new pull request #14204: URL: https://github.com/apache/pulsar/pull/14204

[GitHub] [pulsar] gaozhangmin commented on pull request #14202: [Flaky-test] org.apache.pulsar.broker.service.RackAwareTest#testPlacement

2022-02-09 Thread GitBox
gaozhangmin commented on pull request #14202: URL: https://github.com/apache/pulsar/pull/14202#issuecomment-1034549530 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] gaozhangmin commented on pull request #14000: [Flaky-test] BacklogQuotaManagerTest#testConsumerBacklogEvictionTimeQuota

2022-02-09 Thread GitBox
gaozhangmin commented on pull request #14000: URL: https://github.com/apache/pulsar/pull/14000#issuecomment-1034549422 @Jason918 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] youzipi commented on issue #14190: 请教:event time的应用场景是什么?

2022-02-09 Thread GitBox
youzipi commented on issue #14190: URL: https://github.com/apache/pulsar/issues/14190#issuecomment-1034547766 @startjava event time is introduced here: https://github.com/apache/pulsar/wiki/PIP-5:-Event-time event time is used to clarify the order which event happens in

[GitHub] [pulsar] lhotari closed issue #14180: Client unable to connect after running for a period of time.

2022-02-09 Thread GitBox
lhotari closed issue #14180: URL: https://github.com/apache/pulsar/issues/14180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on issue #14180: Client unable to connect after running for a period of time.

2022-02-09 Thread GitBox
lhotari commented on issue #14180: URL: https://github.com/apache/pulsar/issues/14180#issuecomment-1034544474 > How to maintain a long connection? The Pulsar client reconnects by default if the connection breaks. Did you experience some actual issue? I hope this answers your

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803337976 ## File path: tiered-storage/file-system/src/test/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloaderTest.java

[GitHub] [pulsar] lhotari commented on issue #14183: Topic lookup timeout and can't recover after broker crash

2022-02-09 Thread GitBox
lhotari commented on issue #14183: URL: https://github.com/apache/pulsar/issues/14183#issuecomment-1034542768 > And then one broker OOM crashed as I'm sending message too quickly. Did the broker process restart after the OOM? It should terminated and get started again in the Pulsar

[GitHub] [pulsar] eolivelli commented on a change in pull request #13969: [Transaction] Adopt Single_thread to handle TcClient connecting

2022-02-09 Thread GitBox
eolivelli commented on a change in pull request #13969: URL: https://github.com/apache/pulsar/pull/13969#discussion_r803336699 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/TransactionMetadataStoreService.java ## @@ -98,6 +107,7 @@ public

[GitHub] [pulsar] Demogorgon314 opened a new issue #14203: Flaky-test: BacklogQuotaManagerTest.testProducerExceptionAndThenUnblockSizeQuota

2022-02-09 Thread GitBox
Demogorgon314 opened a new issue #14203: URL: https://github.com/apache/pulsar/issues/14203 BacklogQuotaManagerTest.testProducerExceptionAndThenUnblockSizeQuota is flaky. It fails sporadically. [example

[GitHub] [pulsar] github-actions[bot] commented on pull request #14202: [Flaky-test] org.apache.pulsar.broker.service.RackAwareTest#testPlacement

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14202: URL: https://github.com/apache/pulsar/pull/14202#issuecomment-1034530695 @gaozhangmin:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803326984 ## File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileStoreBackedReadHandleImpl.java ## @@

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803327179 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java ## @@ -160,6 +171,52 @@ private

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803326984 ## File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileStoreBackedReadHandleImpl.java ## @@

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803326724 ## File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java ##

[GitHub] [pulsar] lhotari commented on pull request #14044: [broker][authentication]Support pass http auth status

2022-02-09 Thread GitBox
lhotari commented on pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#issuecomment-1034528382 > @michaeljmarshall Thanks for your review, I don't think it's a feature, I think it's a bug fix because auth state passing for the pulsar protocol was already supported

[GitHub] [pulsar] Huanli-Meng commented on pull request #14102: [#14101] [schema] making schema registry configurable

2022-02-09 Thread GitBox
Huanli-Meng commented on pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#issuecomment-1034528034 @aparajita89 do we also need to update the `broker.config` file? Thanks @Anonymitaet could you or Jun help follow up adding / updating docs about the PR? Thanks. --

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803325711 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloaderMXBean.java ## @@ -0,0 +1,123 @@ +/** + * Licensed to the

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803325598 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloaderMXBean.java ## @@ -0,0 +1,123 @@ +/** + * Licensed to the

[GitHub] [pulsar] github-actions[bot] commented on pull request #14202: [Flaky-test] org.apache.pulsar.broker.service.RackAwareTest#testPlacement

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14202: URL: https://github.com/apache/pulsar/pull/14202#issuecomment-1034526060 @gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] tjiuming commented on a change in pull request #13833: Offloader metrics

2022-02-09 Thread GitBox
tjiuming commented on a change in pull request #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r803324951 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloaderMXBean.java ## @@ -0,0 +1,95 @@ +/** + * Licensed to the

[GitHub] [pulsar] gaozhangmin opened a new pull request #14202: [Flaky-test] org.apache.pulsar.broker.service.RackAwareTest#testPlacement

2022-02-09 Thread GitBox
gaozhangmin opened a new pull request #14202: URL: https://github.com/apache/pulsar/pull/14202 Fixes #14106 ### Motivation Fixed flaky test testPlacement ### Modifications Add a precondition assert `bookies.get(0).isRunning()` ### Documentation

[GitHub] [pulsar] mattisonchao opened a new pull request #14201: Fix Incorrect use of assertNotEquals at BrokerServiceLookupTest.

2022-02-09 Thread GitBox
mattisonchao opened a new pull request #14201: URL: https://github.com/apache/pulsar/pull/14201 ### Motivation Incompatible types are compared 'String' and 'NamespaceBundle' ### Modifications - Invoke ``bundleInBroker1AfterSplit.toString()`` to get bundle key.

[GitHub] [pulsar] michaeljmarshall commented on pull request #13376: Make Docker images non-root, by default, and OpenShift compliant

2022-02-09 Thread GitBox
michaeljmarshall commented on pull request #13376: URL: https://github.com/apache/pulsar/pull/13376#issuecomment-1034522085 @codelipenghui - I haven't yet been able to test the function upgrade scenario that @sijie requested. It'd be great to get this included in branch-2.10, but I want

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

2022-02-09 Thread GitBox
michaeljmarshall commented on a change in pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#discussion_r803299066 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -363,4 +369,63

[GitHub] [pulsar] codelipenghui commented on pull request #14199: [Broker] Adjust topic exists check logic in http lookup process

2022-02-09 Thread GitBox
codelipenghui commented on pull request #14199: URL: https://github.com/apache/pulsar/pull/14199#issuecomment-1034507338 The related change introduced by #13055 and only for the master branch, so don't need to cherry-pick to other branches. And this change is a 2.10 blocker, otherwise,

[GitHub] [pulsar] Jason918 commented on a change in pull request #14200: Broker: support dynamic update log level at runtime

2022-02-09 Thread GitBox
Jason918 commented on a change in pull request #14200: URL: https://github.com/apache/pulsar/pull/14200#discussion_r803283040 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java ## @@ -176,6 +176,19 @@ void run() throws Exception {

[pulsar] 13/13: Fix unack message count for transaction Ack while disabled batch index ack (#14071)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 69de8d7550859854b066927e9e88bff5ce3b3021 Author: lipenghui AuthorDate: Thu Feb 10 10:56:20 2022 +0800 Fix

[pulsar] 12/13: [Transaction] Fix send normal message can't change MaxReadPosition (#14192)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0b516b8672ee9987f8dac791717f170fd4391ca5 Author: congbo <39078850+congbobo...@users.noreply.github.com> AuthorDate:

[pulsar] 11/13: Add test to ensure correct zk children cache invalidation (#14178)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 8a360da29601a849ca15c00d361684e4ccfc7589 Author: Michael Marshall AuthorDate: Wed Feb 9 01:41:24 2022 -0600

[pulsar] 09/13: [Transaction] Fix subscription ack transaction marker. (#14170)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5ebd5b6e56c21ec7f3b12c15dbdef076a21887e6 Author: congbo <39078850+congbobo...@users.noreply.github.com> AuthorDate:

[pulsar] 10/13: [Transaction] Optimize transaction timeout (#14172)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit de5dec4239fbd1c3a595e013a81f26205989 Author: Xiangying Meng <55571188+liangyepianz...@users.noreply.github.com>

[pulsar] 08/13: [Doc] Fix doc for the wrong default value of `maxPendingChunkedMessage` (#14144)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit fafdb6d5cff00201d61ce07ee47b9ef2b319ac48 Author: Zike Yang AuthorDate: Tue Feb 8 15:11:30 2022 +0800 [Doc]

[pulsar] 07/13: fix consume failure when BatchReceivePolicy#maxNumBytes < message size (#14139)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 12ee1a1d6e01e69dda7ce55ea3e304bb78abd6bf Author: JiangHaiting AuthorDate: Tue Feb 8 23:21:22 2022 +0800 fix

[pulsar] 06/13: [Issue 14105] Avoid creating any topics in `NamespaceService#checkTopicExists` during topic lookup. (#14134)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit befdb84fb9466e5b406cc77ea69d7467dbd54a78 Author: JiangHaiting AuthorDate: Tue Feb 8 23:20:48 2022 +0800

[pulsar] 05/13: Fix OpBase.callback is not called in failPendingRequest (#14133)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 33448a74f0357befd8d11056a77757eb08fc3240 Author: JiangHaiting AuthorDate: Mon Feb 7 18:28:41 2022 +0800 Fix

[pulsar] 04/13: Fixed deadlock on txn semaphore permit exhaustion (#14131)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d78e315c01056ab1c3886b19ca3029c2ccaed89a Author: Matteo Merli AuthorDate: Sun Feb 6 23:54:54 2022 -0800 Fixed

[pulsar] 03/13: Updated dependencies to get rid of pulsar-io/jdbc related CVE-2020-13692 (#13753)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit e2c94b8976ecaf6582684cde1584a81c80ef7abd Author: Andrey Yegorov <8622884+dl...@users.noreply.github.com>

[pulsar] 02/13: Upgrade commons-cli to 1.5.0 (#14094)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit dafc8385719c4d7451140290267f86bc52599f01 Author: Lari Hotari AuthorDate: Wed Feb 2 20:29:23 2022 +0200

[pulsar] 01/13: [C++] Fix pulsar client cpp build fail in gcc-4.8.5 (#14053)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 96f6f7b5d2c4011d7f1ba212d137fd5165474208 Author: Kai Wang AuthorDate: Mon Jan 31 23:56:39 2022 +0800 [C++]

[pulsar] branch branch-2.9 updated (be806ea -> 69de8d7)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from be806ea [Proxy] Fix port exhaustion and connection issues in Pulsar Proxy (#14078) new 96f6f7b [C++]

[GitHub] [pulsar] RobertIndie commented on a change in pull request #14162: [Doc] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

2022-02-09 Thread GitBox
RobertIndie commented on a change in pull request #14162: URL: https://github.com/apache/pulsar/pull/14162#discussion_r803282646 ## File path: site2/docs/reference-cli-tools.md ## @@ -655,7 +655,7 @@ Options |`-time`, `--test-duration`|Test duration (in seconds). If this

[GitHub] [pulsar] michaeljmarshall commented on pull request #13376: Make Docker images non-root, by default, and OpenShift compliant

2022-02-09 Thread GitBox
michaeljmarshall commented on pull request #13376: URL: https://github.com/apache/pulsar/pull/13376#issuecomment-1034467666 The conflict was only on white space. No code/configuration was changed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Jason918 commented on pull request #14007: [PIP-132] Include message header size when check maxMessageSize for non-batch message on the client side.

2022-02-09 Thread GitBox
Jason918 commented on pull request #14007: URL: https://github.com/apache/pulsar/pull/14007#issuecomment-1034466978 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition

2022-02-09 Thread GitBox
codelipenghui commented on pull request #14192: URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1034466697 Cool, thanks @nicoloboschi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (a640146 -> 792e264)

2022-02-09 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a640146 Fix unack message count for transaction Ack while disabled batch index ack (#14071) add 792e264

[GitHub] [pulsar] michaeljmarshall merged pull request #13073: [pulsar-broker] Support roll-over ledgers for inactive topics

2022-02-09 Thread GitBox
michaeljmarshall merged pull request #13073: URL: https://github.com/apache/pulsar/pull/13073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy merged pull request #720: [optimize] Stop batchFlushTicker when Disable batching

2022-02-09 Thread GitBox
wolfstudy merged pull request #720: URL: https://github.com/apache/pulsar-client-go/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated: [optimize] Stop batchFlushTicker when Disable batching (#720)

2022-02-09 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 8f8287f [optimize] Stop

[GitHub] [pulsar] ethqunzhong opened a new pull request #14200: Broker: support dynamic update log level at runtime

2022-02-09 Thread GitBox
ethqunzhong opened a new pull request #14200: URL: https://github.com/apache/pulsar/pull/14200 ### Motivation As default, Broker log level set by `log4j2.yaml` with `pulsar.log.level=info`, if developers want to update log level to debug, need to Modify

[GitHub] [pulsar-client-go] Shoothzj commented on a change in pull request #720: [optimize] Stop batchFlushTicker when Disable batching

2022-02-09 Thread GitBox
Shoothzj commented on a change in pull request #720: URL: https://github.com/apache/pulsar-client-go/pull/720#discussion_r803268919 ## File path: pulsar/producer_partition.go ## @@ -126,6 +126,9 @@ func newPartitionProducer(client *client, topic string, options

[GitHub] [pulsar] gaoran10 opened a new pull request #14199: [Broker] Adjust topic exists check logic in http lookup process

2022-02-09 Thread GitBox
gaoran10 opened a new pull request #14199: URL: https://github.com/apache/pulsar/pull/14199 ### Motivation Currently, it's hard to check the non-persistent-non-partitioned topic, because it only exists in the broker cache, it doesn't have metadata. If there is a

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2022-02-09 Thread GitBox
lordcheng10 edited a comment on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-1034435608 Why should the initial value of avgMessagePerEntry be fixed at 1000, instead of using the actual number of messages of an entry obtained by the first push as the

[pulsar] branch master updated (025509c -> a640146)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 025509c [Doc] Deprecate three zookeeper parameters (#14186) add a640146 Fix unack message count for

[GitHub] [pulsar] liangyepianzhou commented on pull request #13957: [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely.

2022-02-09 Thread GitBox
liangyepianzhou commented on pull request #13957: URL: https://github.com/apache/pulsar/pull/13957#issuecomment-1034440696 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] codelipenghui merged pull request #14071: Fix unack message count for transaction Ack while disabled batch index ack

2022-02-09 Thread GitBox
codelipenghui merged pull request #14071: URL: https://github.com/apache/pulsar/pull/14071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #13957: [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely.

2022-02-09 Thread GitBox
liangyepianzhou commented on a change in pull request #13957: URL: https://github.com/apache/pulsar/pull/13957#discussion_r803260953 ## File path: pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java ## @@

[GitHub] [pulsar] github-actions[bot] commented on pull request #14198: remove duplicated filter for UniformLoadShedder#findBundlesForUnloading

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14198: URL: https://github.com/apache/pulsar/pull/14198#issuecomment-1034439945 @aloyszhang:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] aloyszhang opened a new pull request #14198: remove duplicated filter for UniformLoadShedder#findBundlesForUnloading

2022-02-09 Thread GitBox
aloyszhang opened a new pull request #14198: URL: https://github.com/apache/pulsar/pull/14198 ### Motivation remove duplicated filter for UniformLoadShedder#findBundlesForUnloading ### Modifications 1. correct the java doc for UniformLoadShedder 2. remove duplicated

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #13957: [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely.

2022-02-09 Thread GitBox
liangyepianzhou commented on a change in pull request #13957: URL: https://github.com/apache/pulsar/pull/13957#discussion_r803258644 ## File path: pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java ## @@

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2022-02-09 Thread GitBox
lordcheng10 edited a comment on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-1034435608 Why should the initial value of avgMessagePerEntry be fixed at 1000, instead of using the actual number of messages of an entry obtained by the first push as the

[GitHub] [pulsar] flowchartsman edited a comment on issue #14031: Cannot set topic retention policy (error 500)

2022-02-09 Thread GitBox
flowchartsman edited a comment on issue #14031: URL: https://github.com/apache/pulsar/issues/14031#issuecomment-1034436261 ``` maxConcurrentLookupRequest=5 ``` There are multiple brokers, and this is going through the proxy and it _never_ succeeds, so does it make sense that

[GitHub] [pulsar] flowchartsman commented on issue #14031: Cannot set topic retention policy (error 500)

2022-02-09 Thread GitBox
flowchartsman commented on issue #14031: URL: https://github.com/apache/pulsar/issues/14031#issuecomment-1034436261 ``` maxConcurrentLookupRequest=5 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2022-02-09 Thread GitBox
lordcheng10 edited a comment on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-1034435608 ‘The avgMessagePerEntry initial value is 1000.’ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] lordcheng10 commented on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2022-02-09 Thread GitBox
lordcheng10 commented on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-1034435608 ‘The avgMessagePerEntry initial value is 1000.’ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

2022-02-09 Thread GitBox
gaoran10 commented on a change in pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#discussion_r803256700 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/FunctionApiResource.java ## @@ -54,7 +54,7 @@ public

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

2022-02-09 Thread GitBox
gaoran10 commented on a change in pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#discussion_r803256563 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java ## @@ -76,8 +77,15 @@ public void

[GitHub] [pulsar] mattisonchao commented on a change in pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl

2022-02-09 Thread GitBox
mattisonchao commented on a change in pull request #14197: URL: https://github.com/apache/pulsar/pull/14197#discussion_r803256283 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneBuilder.java ## @@ -114,8 +114,8 @@ public PulsarStandalone build() {

[GitHub] [pulsar] github-actions[bot] commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14197: URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1034427228 @gaozhangmin:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] github-actions[bot] commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl

2022-02-09 Thread GitBox
github-actions[bot] commented on pull request #14197: URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1034426842 @gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] gaozhangmin opened a new pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl

2022-02-09 Thread GitBox
gaozhangmin opened a new pull request #14197: URL: https://github.com/apache/pulsar/pull/14197 ### Motivation `zookeeperServers` and `configurationStoreServers` are deprecated. ### Modifications `setZookeeperServers` and `setConfigurationStoreServers ` change to

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

2022-02-09 Thread GitBox
gaoran10 commented on a change in pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#discussion_r803244752 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java ## @@ -76,8 +77,15 @@ public void

[GitHub] [pulsar] Jason918 commented on pull request #14038: [Issue 13756][Broker] Optimize topic policy with HierarchyTopicPolicies about dispatchRate

2022-02-09 Thread GitBox
Jason918 commented on pull request #14038: URL: https://github.com/apache/pulsar/pull/14038#issuecomment-1034420408 @codelipenghui PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

2022-02-09 Thread GitBox
gaoran10 commented on a change in pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#discussion_r803244752 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java ## @@ -76,8 +77,15 @@ public void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13957: [Transaction] Set TC state is Ready after open MLTransactionMetadataStore completely.

2022-02-09 Thread GitBox
codelipenghui commented on a change in pull request #13957: URL: https://github.com/apache/pulsar/pull/13957#discussion_r803238846 ## File path: pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java ## @@

[pulsar] branch master updated (3d50dcd -> 025509c)

2022-02-09 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3d50dcd Support graceful shutdown for Broker (#14114) add 025509c [Doc] Deprecate three zookeeper parameters

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13355: [PIP-124] Create init subscription before sending message to DLQ

2022-02-09 Thread GitBox
codelipenghui commented on a change in pull request #13355: URL: https://github.com/apache/pulsar/pull/13355#discussion_r803237303 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1160,8 +1162,14 @@ protected void

[pulsar] branch master updated (d460f09 -> 3d50dcd)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d460f09 [Broker] Set default value of applied to false on topic policy (#14181) add 3d50dcd Support

[GitHub] [pulsar] Anonymitaet merged pull request #14186: [Doc] Deprecate 3 zookeeper parameters

2022-02-09 Thread GitBox
Anonymitaet merged pull request #14186: URL: https://github.com/apache/pulsar/pull/14186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nicoloboschi commented on pull request #14098: [test] Replace PowerMockito#mockStatic usages with mockito-inline

2022-02-09 Thread GitBox
nicoloboschi commented on pull request #14098: URL: https://github.com/apache/pulsar/pull/14098#issuecomment-1034404693 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] codelipenghui commented on pull request #13376: Make Docker images non-root, by default, and OpenShift compliant

2022-02-09 Thread GitBox
codelipenghui commented on pull request #13376: URL: https://github.com/apache/pulsar/pull/13376#issuecomment-1034404221 @michaeljmarshall Could you please help resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] nicoloboschi commented on pull request #14192: [Transaction] Fix send normal message can't change MaxReadPosition

2022-02-09 Thread GitBox
nicoloboschi commented on pull request #14192: URL: https://github.com/apache/pulsar/pull/14192#issuecomment-1034404082 before approving the PR I've rerun the same integration test @eolivelli was talking about (it was also failing against master) and now it passes correctly @codelipenghui

[pulsar] branch master updated (0287f7f -> d460f09)

2022-02-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0287f7f [Transaction] Fix send normal message can't change MaxReadPosition (#14192) add d460f09 [Broker]

[GitHub] [pulsar] codelipenghui merged pull request #14114: Support graceful shutdown for Broker

2022-02-09 Thread GitBox
codelipenghui merged pull request #14114: URL: https://github.com/apache/pulsar/pull/14114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >