[GitHub] [pulsar] AnonHxy commented on pull request #15002: [broker]Mark sure resetCursorInProgress update even if throw exceptions

2022-04-05 Thread GitBox
AnonHxy commented on PR #15002: URL: https://github.com/apache/pulsar/pull/15002#issuecomment-1089837459 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] aparajita89 commented on a diff in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-04-05 Thread GitBox
aparajita89 commented on code in PR #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r843474794 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1285,6 +1286,13 @@ private SchemaStorage createAndStartSchemaStorage() throws

[GitHub] [pulsar] Demogorgon314 opened a new issue, #15037: PIP-151: Use the system topic to store the bundle load data

2022-04-05 Thread GitBox
Demogorgon314 opened a new issue, #15037: URL: https://github.com/apache/pulsar/issues/15037 ## Motivation Currently, Pulsar LoadManager is using Zookeeper to store the bundle load data, when we have many bundles, this might put a lot of pressure on Zookeeper. ## Goal

[GitHub] [pulsar] Lannnnh commented on a diff in pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
Lah commented on code in PR #15020: URL: https://github.com/apache/pulsar/pull/15020#discussion_r843470072 ## pulsar-client-cpp/lib/ConsumerConfiguration.cc: ## @@ -214,6 +214,19 @@ ConsumerConfiguration& ConsumerConfiguration::setProperties( return *this; }

[GitHub] [pulsar] BewareMyPower opened a new issue, #15036: [C++] Schema version not added to a message

2022-04-05 Thread GitBox
BewareMyPower opened a new issue, #15036: URL: https://github.com/apache/pulsar/issues/15036 **Describe the bug** When a message was sent to a topic with protobuf native schema by C++ client, the message won't have a schema version. **To Reproduce** First, run the C++ unit test

[GitHub] [pulsar] lordcheng10 commented on pull request #14985: Add a cache eviction policy:Evicting cache data by the slowest markDeletedPosition

2022-04-05 Thread GitBox
lordcheng10 commented on PR #14985: URL: https://github.com/apache/pulsar/pull/14985#issuecomment-1089809997 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] nodece commented on issue #13734: Websocket Client TLS not supported on Win7/8 (handshake failure)

2022-04-05 Thread GitBox
nodece commented on issue #13734: URL: https://github.com/apache/pulsar/issues/13734#issuecomment-1089808555 Activate this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] BewareMyPower opened a new issue, #15035: [Doc] Java client examples for protobuf native schema

2022-04-05 Thread GitBox
BewareMyPower opened a new issue, #15035: URL: https://github.com/apache/pulsar/issues/15035 ### What issue do you find in Pulsar docs? The [ProtobufNative example of Java client](https://pulsar.apache.org/docs/en/client-libraries-java/#protobufnativeschema-example) links to

[GitHub] [pulsar] nodece commented on pull request #13740: [improve][broker] Full-support set ssl provider, ciphers and protocols for web service

2022-04-05 Thread GitBox
nodece commented on PR #13740: URL: https://github.com/apache/pulsar/pull/13740#issuecomment-1089770804 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] nodece commented on pull request #14569: [Broker] Full-support ssl provider, ciphers and protocols for broker service and proxy service

2022-04-05 Thread GitBox
nodece commented on PR #14569: URL: https://github.com/apache/pulsar/pull/14569#issuecomment-1089767546 @codelipenghui I made a PR https://github.com/apache/pulsar/pull/15034 to branch-2.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] yuruguo commented on pull request #14608: Ensure the deletion consistency of topic and schema

2022-04-05 Thread GitBox
yuruguo commented on PR #14608: URL: https://github.com/apache/pulsar/pull/14608#issuecomment-1089757468 @codelipenghui @315157973 @hangc0276 @Jason918 PTAL when you hava a moment, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar-client-go] branch master updated: Fix ack timeout cause reconnect (#756)

2022-04-05 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 85d7661 Fix ack timeout cause reconnect

[GitHub] [pulsar-client-go] wolfstudy merged pull request #756: Fix ack timeout cause reconnect

2022-04-05 Thread GitBox
wolfstudy merged PR #756: URL: https://github.com/apache/pulsar-client-go/pull/756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
BewareMyPower commented on code in PR #15020: URL: https://github.com/apache/pulsar/pull/15020#discussion_r843425729 ## pulsar-client-cpp/lib/ConsumerConfiguration.cc: ## @@ -214,6 +214,19 @@ ConsumerConfiguration& ConsumerConfiguration::setProperties( return *this; }

[GitHub] [pulsar] nodece opened a new pull request, #15034: [feat][broker] Full-support set ssl provider, ciphers and protocols for branch-2.8

2022-04-05 Thread GitBox
nodece opened a new pull request, #15034: URL: https://github.com/apache/pulsar/pull/15034 Signed-off-by: Zixuan Liu ### Motivation Cherry-pick #14569 to branch-2.8. ### Documentation Need to update docs? - [x] `doc-required` -- This is an

[GitHub] [pulsar] Lannnnh commented on pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
Lah commented on PR #15020: URL: https://github.com/apache/pulsar/pull/15020#issuecomment-1089739973 @BewareMyPower ok, I have been added a test in ConsumerConfigurationTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] Lannnnh closed pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
Lah closed pull request #15020: [client-cpp] add subscription properties to consumer for cpp URL: https://github.com/apache/pulsar/pull/15020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Lannnnh commented on pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
Lah commented on PR #15020: URL: https://github.com/apache/pulsar/pull/15020#issuecomment-1089737811 > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] Lannnnh commented on a diff in pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
Lah commented on code in PR #15020: URL: https://github.com/apache/pulsar/pull/15020#discussion_r843424346 ## pulsar-client-cpp/lib/ConsumerConfiguration.cc: ## @@ -214,6 +214,19 @@ ConsumerConfiguration& ConsumerConfiguration::setProperties( return *this; }

[GitHub] [pulsar] Lannnnh commented on a diff in pull request #15020: [client-cpp] add subscription properties to consumer for cpp

2022-04-05 Thread GitBox
Lah commented on code in PR #15020: URL: https://github.com/apache/pulsar/pull/15020#discussion_r843423094 ## pulsar-client-cpp/lib/Commands.cc: ## @@ -308,6 +309,14 @@ SharedBuffer Commands::newSubscribe(const std::string& topic, const std::string&

[GitHub] [pulsar] poorbarcode commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
poorbarcode commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1089708621 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tjiuming opened a new pull request, #15033: [client-producer] avoid too large memory preallocation for batch message.

2022-04-05 Thread GitBox
tjiuming opened a new pull request, #15033: URL: https://github.com/apache/pulsar/pull/15033 Fixes (https://github.com/apache/pulsar/issues/14943) ### Motivation Allocate small memory for batch message first, and let it grow(with no memory resizes and memory copies).

[GitHub] [pulsar] wangjialing218 commented on pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-04-05 Thread GitBox
wangjialing218 commented on PR #14702: URL: https://github.com/apache/pulsar/pull/14702#issuecomment-1089703150 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tjiuming commented on issue #14943: maxBatchSize preallocated memory may be thousands of times larger than actual message length

2022-04-05 Thread GitBox
tjiuming commented on issue #14943: URL: https://github.com/apache/pulsar/issues/14943#issuecomment-1089684951 How about use `CompositeByteBuf`, allocate small memory and let it grow. @codelipenghui Could you please assign it to me? -- This is an automated message from the Apache Git

[GitHub] [pulsar] tjiuming commented on issue #15027: Having two KeyValue classes is confusing

2022-04-05 Thread GitBox
tjiuming commented on issue #15027: URL: https://github.com/apache/pulsar/issues/15027#issuecomment-1089675906 maybe change `io.core.KeyValue`'s class name to `io.core.Tuple2` is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] tjiuming commented on issue #15032: [Monitoring - Broker] - Need a metric to track how many consumers are connected and consuming from a given subscription

2022-04-05 Thread GitBox
tjiuming commented on issue #15032: URL: https://github.com/apache/pulsar/issues/15032#issuecomment-1089673588 @codelipenghui I’d like to handle the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pulsar-site] 01/01: Merge pull request #47 from apache/feature/local-preview-by-version-script

2022-04-05 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit e568bc75b302155ee631aedaf7dd47800dee4e3e Merge: 69d95136d9 7ac40a7f82 Author: Li Li AuthorDate: Wed Apr 6 10:08:20

[pulsar-site] branch main updated (69d95136d9 -> e568bc75b3)

2022-04-05 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 69d95136d9 Docs sync done from apache/pulsar(#8c7e1d9) add 7ac40a7f82 feat: local preview script new

[pulsar-site] 01/01: feat: local preview script

2022-04-05 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch feature/local-preview-by-version-script in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 7ac40a7f826f2877c1189a0018a3ffe868af1e38 Author: Li Li AuthorDate: Wed Apr 6

[pulsar-site] branch feature/local-preview-by-version-script created (now 7ac40a7f82)

2022-04-05 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch feature/local-preview-by-version-script in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 7ac40a7f82 feat: local preview script This branch includes the following new

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15021: [improve][transaction] Use a global timeout checker to avoid many timeout tasks.

2022-04-05 Thread GitBox
mattisonchao commented on code in PR #15021: URL: https://github.com/apache/pulsar/pull/15021#discussion_r843398234 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferClientTest.java: ## @@ -18,18 +18,22 @@ */ package

[GitHub] [pulsar] github-actions[bot] commented on pull request #14556: Make copies of thread local MessageMetadata when it might be shared

2022-04-05 Thread GitBox
github-actions[bot] commented on PR #14556: URL: https://github.com/apache/pulsar/pull/14556#issuecomment-1089663337 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15021: [improve][transaction] Use a global timeout checker to avoid many timeout tasks.

2022-04-05 Thread GitBox
HQebupt commented on code in PR #15021: URL: https://github.com/apache/pulsar/pull/15021#discussion_r843397412 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferClientTest.java: ## @@ -18,18 +18,22 @@ */ package

[GitHub] [pulsar] wangjialing218 commented on a diff in pull request #14903: [metadata] fix MetadataStore#put may get unexcepted exception

2022-04-05 Thread GitBox
wangjialing218 commented on code in PR #14903: URL: https://github.com/apache/pulsar/pull/14903#discussion_r843397318 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java: ## @@ -386,7 +386,13 @@ private void internalStorePut(OpPut opPut) {

[GitHub] [pulsar] Anonymitaet commented on pull request #14993: Add option to flatten JSON with FULL_MESSAGE_IN_JSON_EXPAND_VALUE format

2022-04-05 Thread GitBox
Anonymitaet commented on PR #14993: URL: https://github.com/apache/pulsar/pull/14993#issuecomment-1089655398 @momo-jun could you please help review the doc updates? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] momo-jun commented on pull request #14993: Add option to flatten JSON with FULL_MESSAGE_IN_JSON_EXPAND_VALUE format

2022-04-05 Thread GitBox
momo-jun commented on PR #14993: URL: https://github.com/apache/pulsar/pull/14993#issuecomment-1089649086 @Anonymitaet The doc changes have been included in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] momo-jun commented on pull request #14930: [improve][tieredstorage] Add API to scan objects on Tiered Storage

2022-04-05 Thread GitBox
momo-jun commented on PR #14930: URL: https://github.com/apache/pulsar/pull/14930#issuecomment-1089639959 Hi @eolivelli , any updates or plans for the follow-up PR that explains the feature and how to set up alerts? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] leizhiyuan commented on issue #7280: Support zero queue consumer for partitioned topic.

2022-04-05 Thread GitBox
leizhiyuan commented on issue #7280: URL: https://github.com/apache/pulsar/issues/7280#issuecomment-1089634233 what is the current status? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] urfreespace closed issue #14837: [Website] Upgrade crowdin cli to latest version

2022-04-05 Thread GitBox
urfreespace closed issue #14837: [Website] Upgrade crowdin cli to latest version URL: https://github.com/apache/pulsar/issues/14837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] poorbarcode commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
poorbarcode commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1089632166 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #15023: [improve][broker] Avoid using blocking calls for the async method ``checkTopicOwnership``

2022-04-05 Thread GitBox
mattisonchao commented on PR #15023: URL: https://github.com/apache/pulsar/pull/15023#issuecomment-1089628053 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] horizonzy commented on a diff in pull request #15019: [fix][client-producer] tweak the timeout msg before opMsg flush.

2022-04-05 Thread GitBox
horizonzy commented on code in PR #15019: URL: https://github.com/apache/pulsar/pull/15019#discussion_r843382826 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -1408,9 +1408,11 @@ void sendComplete(final Exception e) {

[GitHub] [pulsar] mattisonchao closed pull request #14940: [fix][transaction] Remove single thread pool and fix the concurrent problem to avoid performance issues

2022-04-05 Thread GitBox
mattisonchao closed pull request #14940: [fix][transaction] Remove single thread pool and fix the concurrent problem to avoid performance issues URL: https://github.com/apache/pulsar/pull/14940 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] mattisonchao commented on pull request #14940: [fix][transaction] Remove single thread pool and fix the concurrent problem to avoid performance issues

2022-04-05 Thread GitBox
mattisonchao commented on PR #14940: URL: https://github.com/apache/pulsar/pull/14940#issuecomment-1089599273 I chose to use ``Ordered-Executor`` to ensure thread-safe. so, close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15005: [improve][workflow] Add PR guideline info to PR template

2022-04-05 Thread GitBox
Anonymitaet commented on code in PR #15005: URL: https://github.com/apache/pulsar/pull/15005#discussion_r843375267 ## .github/PULL_REQUEST_TEMPLATE.md: ## @@ -1,9 +1,7 @@

[GitHub] [pulsar] mattisonchao commented on pull request #14920: [fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-``

2022-04-05 Thread GitBox
mattisonchao commented on PR #14920: URL: https://github.com/apache/pulsar/pull/14920#issuecomment-1089594250 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #15021: [improve][transaction] Use a global timeout checker to avoid many timeout tasks.

2022-04-05 Thread GitBox
mattisonchao commented on PR #15021: URL: https://github.com/apache/pulsar/pull/15021#issuecomment-1089593846 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #15023: [improve][broker] Avoid using blocking calls for the async method ``checkTopicOwnership``

2022-04-05 Thread GitBox
mattisonchao commented on PR #15023: URL: https://github.com/apache/pulsar/pull/15023#issuecomment-1089592185 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet commented on pull request #14929: Add FULL_MESSAGE_IN_JSON_EXPAND_VALUE message format to Kinesis sink

2022-04-05 Thread GitBox
Anonymitaet commented on PR #14929: URL: https://github.com/apache/pulsar/pull/14929#issuecomment-1089585994 @momo-jun exactly. I've changed the label to `doc`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] Anonymitaet commented on pull request #15000: [improve][broker]Expose Netty threads num config to bookkeeper.conf

2022-04-05 Thread GitBox
Anonymitaet commented on PR #15000: URL: https://github.com/apache/pulsar/pull/15000#issuecomment-1089584940 @momo-jun a soft reminder: here is a PR targeted at 2.11 w/ doc-required  label, could u pls follow up? Thanks -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Anonymitaet commented on pull request #14930: [improve][tieredstorage] Add API to scan objects on Tiered Storage

2022-04-05 Thread GitBox
Anonymitaet commented on PR #14930: URL: https://github.com/apache/pulsar/pull/14930#issuecomment-1089583756 @momo-jun this PR is merged. Can you work with @eolivelli to update docs? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Anonymitaet commented on pull request #15011: [improve][transaction] support configurable ``transactionBufferClientOperationTimeoutInMills``

2022-04-05 Thread GitBox
Anonymitaet commented on PR #15011: URL: https://github.com/apache/pulsar/pull/15011#issuecomment-1089582642 @momo-jun a soft reminder: here is a PR w/ doc-required label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Anonymitaet commented on pull request #14993: Add option to flatten JSON with FULL_MESSAGE_IN_JSON_EXPAND_VALUE format

2022-04-05 Thread GitBox
Anonymitaet commented on PR #14993: URL: https://github.com/apache/pulsar/pull/14993#issuecomment-1089582952 @momo-jun a soft reminder: here is a PR w/ doc-required label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Anonymitaet closed issue #12488: Documentation falsely says that metadata needs to be initialized from a machine in the "zookeeper cluster".

2022-04-05 Thread GitBox
Anonymitaet closed issue #12488: Documentation falsely says that metadata needs to be initialized from a machine in the "zookeeper cluster". URL: https://github.com/apache/pulsar/issues/12488 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[pulsar] branch master updated: [fix][doc] Update description about the initialization of cluster metadata (#14908)

2022-04-05 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 14260ac1efe [fix][doc] Update description about

[GitHub] [pulsar] Anonymitaet merged pull request #14908: [fix][doc] Update description about the initialization of cluster metadata

2022-04-05 Thread GitBox
Anonymitaet merged PR #14908: URL: https://github.com/apache/pulsar/pull/14908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Shoothzj commented on a diff in pull request #14993: Add option to flatten JSON with FULL_MESSAGE_IN_JSON_EXPAND_VALUE format

2022-04-05 Thread GitBox
Shoothzj commented on code in PR #14993: URL: https://github.com/apache/pulsar/pull/14993#discussion_r843362215 ## pulsar-io/kinesis/pom.xml: ## @@ -84,6 +84,12 @@ ${avro.version} + + com.github.wnameless.json + json-flattener + 0.13.0 Review

[GitHub] [pulsar] mattisonchao commented on pull request #15011: [improve][transaction] support configurable ``transactionBufferClientOperationTimeoutInMills``

2022-04-05 Thread GitBox
mattisonchao commented on PR #15011: URL: https://github.com/apache/pulsar/pull/15011#issuecomment-1089547715 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #15023: [improve][broker] Avoid using blocking calls for the async method ``checkTopicOwnership``

2022-04-05 Thread GitBox
mattisonchao commented on PR #15023: URL: https://github.com/apache/pulsar/pull/15023#issuecomment-1089494364 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] michaeljmarshall closed issue #11269: [Docker Images] Default Pulsar docker images to run as a non-root user

2022-04-05 Thread GitBox
michaeljmarshall closed issue #11269: [Docker Images] Default Pulsar docker images to run as a non-root user URL: https://github.com/apache/pulsar/issues/11269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] michaeljmarshall commented on issue #11269: [Docker Images] Default Pulsar docker images to run as a non-root user

2022-04-05 Thread GitBox
michaeljmarshall commented on issue #11269: URL: https://github.com/apache/pulsar/issues/11269#issuecomment-1089416124 @frankjkelly - the 2.10.0 release will be with a non-root docker image: https://github.com/apache/pulsar/pull/13376. I forgot to close this issue when we merged that

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #13993: Make Backoff class thread-safe

2022-04-05 Thread GitBox
michaeljmarshall commented on code in PR #13993: URL: https://github.com/apache/pulsar/pull/13993#discussion_r843284476 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/Backoff.java: ## @@ -22,29 +22,59 @@ import java.time.Clock; import java.util.Random; import

[GitHub] [pulsar] michaeljmarshall commented on pull request #14827: Stop building Pulsar Client for Python 2.7

2022-04-05 Thread GitBox
michaeljmarshall commented on PR #14827: URL: https://github.com/apache/pulsar/pull/14827#issuecomment-1089378229 @BewareMyPower - thank you for the additional context! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch master updated: [ML] Fix race condition in updating lastMarkDeleteEntry field (#15031)

2022-04-05 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ad2f397fb9b [ML] Fix race condition in

[GitHub] [pulsar] eolivelli merged pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
eolivelli merged PR #15031: URL: https://github.com/apache/pulsar/pull/15031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch branch-2.9 updated: [fix][client] Fix potentially unfinished CompletableFuture in doReconsumeLater (#14947)

2022-04-05 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new 4a92407226d [fix][client] Fix

[pulsar] branch branch-2.8 updated: [fix][client] Fix potentially unfinished CompletableFuture in doReconsumeLater (#14947)

2022-04-05 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 9925a9d856b [fix][client] Fix

[pulsar] branch branch-2.10 updated: [fix][client] Fix potentially unfinished CompletableFuture in doReconsumeLater (#14947)

2022-04-05 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 52ca27cdde1 [fix][client] Fix

[pulsar] branch master updated: [fix][client] Fix potentially unfinished CompletableFuture in doReconsumeLater (#14947)

2022-04-05 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 64f020cf699 [fix][client] Fix potentially

[GitHub] [pulsar] michaeljmarshall merged pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture in doReconsumeLater

2022-04-05 Thread GitBox
michaeljmarshall merged PR #14947: URL: https://github.com/apache/pulsar/pull/14947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall commented on pull request #14947: [fix][client] Fix potentially unfinished CompletableFuture in doReconsumeLater

2022-04-05 Thread GitBox
michaeljmarshall commented on PR #14947: URL: https://github.com/apache/pulsar/pull/14947#issuecomment-1089155137 All required ci checks have passed, merging now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar] branch master updated (0ccadfe39e5 -> 2944d4c4677)

2022-04-05 Thread ayegorov
This is an automated email from the ASF dual-hosted git repository. ayegorov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 0ccadfe39e5 [Python] Added script to generate Wheel files for MacOS (#15024) add 2944d4c4677 Improve

[GitHub] [pulsar] dlg99 merged pull request #14845: Improve WebSocket producerBuilderTest

2022-04-05 Thread GitBox
dlg99 merged PR #14845: URL: https://github.com/apache/pulsar/pull/14845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] dlg99 commented on pull request #14993: Add option to flatten JSON with FULL_MESSAGE_IN_JSON_EXPAND_VALUE format

2022-04-05 Thread GitBox
dlg99 commented on PR #14993: URL: https://github.com/apache/pulsar/pull/14993#issuecomment-1089073339 @fantapsody @RobertIndie Please take a look too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] poorbarcode commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
poorbarcode commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1089005821 > @poorbarcode by adding the comment "/pulsarbot rerun-failure-checks" you can trigger a retry for the failed jobs. This helps when you face flaky tests. OK Thanks very much.

[GitHub] [pulsar] lordcheng10 commented on pull request #14985: Add a cache eviction policy:Evicting cache data by the slowest markDeletedPosition

2022-04-05 Thread GitBox
lordcheng10 commented on PR #14985: URL: https://github.com/apache/pulsar/pull/14985#issuecomment-1089000627 @eolivelli PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] poorbarcode commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
poorbarcode commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1089000307 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
lhotari commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1088993687 @poorbarcode by adding the comment "/pulsarbot rerun-failure-checks" you can trigger a retry for the failed jobs. This helps when you face flaky tests. -- This is an automated message

[GitHub] [pulsar] lhotari commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
lhotari commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1088990810 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-04-05 Thread GitBox
lhotari commented on PR #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1088989018 > There is an unstable unit test `org.apache.pulsar.broker.service.RackAwareTest ► testPlacement`. Run some times will get one error. log file at the error once: > >

[GitHub] [pulsar] lhotari commented on issue #14106: Flaky-test: RackAwareTest.testPlacement

2022-04-05 Thread GitBox
lhotari commented on issue #14106: URL: https://github.com/apache/pulsar/issues/14106#issuecomment-1088982789 Related to #11433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15019: [fix][client-producer] tweak the timeout msg before opMsg flush.

2022-04-05 Thread GitBox
HQebupt commented on code in PR #15019: URL: https://github.com/apache/pulsar/pull/15019#discussion_r842955211 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -1408,9 +1408,11 @@ void sendComplete(final Exception e) {

[GitHub] [pulsar] eolivelli commented on a diff in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-04-05 Thread GitBox
eolivelli commented on code in PR #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r842947287 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -1285,6 +1286,13 @@ private SchemaStorage createAndStartSchemaStorage() throws

[pulsar] branch branch-2.10 updated: [Python] Added script to generate Wheel files for MacOS (#15024)

2022-04-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 85aab22aa74 [Python] Added script to

[pulsar] branch branch-2.9 updated: [Python] Added script to generate Wheel files for MacOS (#15024)

2022-04-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new aa1fa78a1cc [Python] Added script to

[pulsar] branch master updated: [Python] Added script to generate Wheel files for MacOS (#15024)

2022-04-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0ccadfe39e5 [Python] Added script to generate

[GitHub] [pulsar] merlimat merged pull request #15024: [Python] Added script to generate Wheel files for MacOS

2022-04-05 Thread GitBox
merlimat merged PR #15024: URL: https://github.com/apache/pulsar/pull/15024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari closed pull request #15022: [ML] Fix race condition in updating markDeletePosition

2022-04-05 Thread GitBox
lhotari closed pull request #15022: [ML] Fix race condition in updating markDeletePosition URL: https://github.com/apache/pulsar/pull/15022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on pull request #15022: [ML] Fix race condition in updating markDeletePosition

2022-04-05 Thread GitBox
lhotari commented on PR #15022: URL: https://github.com/apache/pulsar/pull/15022#issuecomment-1088868484 This change wasn't needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pulsar] branch branch-2.8 updated: Bumped version to 2.8.4-SNAPSHOT

2022-04-05 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 4f6e723fa75 Bumped version to

[GitHub] [pulsar] NadirJ opened a new issue, #15032: [Monitoring - Broker] - Need a metric to track how many consumers are connected and consuming from a given subscription

2022-04-05 Thread GitBox
NadirJ opened a new issue, #15032: URL: https://github.com/apache/pulsar/issues/15032 **Describe the bug** I'm monitoring Pulsar and I would like the ability to monitor how many consumers are connected and subscribing from a given subscription. Right this metric already exists

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842895246 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -1796,7 +1796,14 @@ void internalMarkDelete(final MarkDeleteEntry

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842898025 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -2097,6 +2102,22 @@ public void

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842887286 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -2097,6 +2102,22 @@ public void

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842897048 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -1796,7 +1796,14 @@ void internalMarkDelete(final MarkDeleteEntry

[GitHub] [pulsar] eolivelli commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
eolivelli commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842889574 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -1796,7 +1796,14 @@ void internalMarkDelete(final MarkDeleteEntry

[GitHub] [pulsar] lhotari commented on pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on PR #15031: URL: https://github.com/apache/pulsar/pull/15031#issuecomment-1088821940 btw. The problem scenario looked like very similar as in #14261. However there was a difference. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842888222 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -2097,6 +2102,22 @@ public void

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842887686 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -1796,7 +1796,14 @@ void internalMarkDelete(final MarkDeleteEntry

[GitHub] [pulsar] lhotari commented on a diff in pull request #15031: [ML] Fix race condition in updating lastMarkDeleteEntry field

2022-04-05 Thread GitBox
lhotari commented on code in PR #15031: URL: https://github.com/apache/pulsar/pull/15031#discussion_r842887286 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -2097,6 +2102,22 @@ public void

  1   2   >