[GitHub] [pulsar] poorbarcode opened a new pull request, #15736: [cleanup][ledger] Remove unnecessary code in ManagedLedgerImpl

2022-05-23 Thread GitBox
poorbarcode opened a new pull request, #15736: URL: https://github.com/apache/pulsar/pull/15736 ### Motivation The managedLedgerInterceptor member variable is initialized twice within the same method.

[GitHub] [pulsar] poorbarcode commented on pull request #15135: [cleanup] [client] Remove unnecessary code #PersistentAcknowledgments…

2022-05-23 Thread GitBox
poorbarcode commented on PR #15135: URL: https://github.com/apache/pulsar/pull/15135#issuecomment-1135438835 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar-site] branch main updated (6e2bc4ecce4 -> 66a65f224ad)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 6e2bc4ecce4 Merge pull request #91 from apache/fix/watch-files-change-script add 83e17d49d59 optimize watch

[pulsar-site] 01/01: Merge pull request #92 from apache/fix/watch-files-change-script

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 66a65f224ad04512cdada6685c15a9c22c41b7a8 Merge: 6e2bc4ecce4 83e17d49d59 Author: Li Li AuthorDate: Tue May 24

[pulsar-site] 01/01: optimize watch script

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch fix/watch-files-change-script in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 83e17d49d59fde4054586f563be910e4f5fc7ecd Author: Li Li AuthorDate: Tue May 24 13:14:59 2022

[pulsar-site] branch fix/watch-files-change-script updated (3167c514ac3 -> 83e17d49d59)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch fix/watch-files-change-script in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 3167c514ac3 add script for watch files change from pulsar repo add d29c0de1d8b Docs

[GitHub] [pulsar] lhotari commented on pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
lhotari commented on PR #15723: URL: https://github.com/apache/pulsar/pull/15723#issuecomment-1135400975 > @lhotari - sorry, I completely missed the configuration name. Do you think it'll make sense long term to have this separate config? I have been thinking about consolidating client

[GitHub] [pulsar] michaeljmarshall commented on pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
michaeljmarshall commented on PR #15723: URL: https://github.com/apache/pulsar/pull/15723#issuecomment-1135395052 > > It looks like this is only a partial solution. We should configure all clients with the correct configuration. > > @michaeljmarshall It's intentional that this PR

[GitHub] [pulsar] lhotari commented on pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
lhotari commented on PR #15723: URL: https://github.com/apache/pulsar/pull/15723#issuecomment-1135392542 > It looks like this is only a partial solution. We should configure all clients with the correct configuration. It's intentional that this PR addresses only the replication

[GitHub] [pulsar] BewareMyPower merged pull request #15707: [fix][ML]Fix NPE when put value to `RangeCache`.

2022-05-23 Thread GitBox
BewareMyPower merged PR #15707: URL: https://github.com/apache/pulsar/pull/15707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (20a22a023c7 -> b155d84c2ee)

2022-05-23 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 20a22a023c7 [Python] Use async C++ calls to check for Python signals (#15725) add b155d84c2ee [fix][ML]Fix NPE

[pulsar-client-go] branch master updated: fix nil pointer dereference in TopicNameWithoutPartitionPart (#734)

2022-05-23 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new a8270eb fix nil pointer dereference in

[GitHub] [pulsar-client-go] wolfstudy closed issue #718: Panic on `NewReader` - nil pointer dereference in TopicNameWithoutPartitionPart

2022-05-23 Thread GitBox
wolfstudy closed issue #718: Panic on `NewReader` - nil pointer dereference in TopicNameWithoutPartitionPart URL: https://github.com/apache/pulsar-client-go/issues/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-go] wolfstudy merged pull request #734: [Issue 718] Fix nil pointer dereference in TopicNameWithoutPartitionPart

2022-05-23 Thread GitBox
wolfstudy merged PR #734: URL: https://github.com/apache/pulsar-client-go/pull/734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (b60c2a58d11 -> 20a22a023c7)

2022-05-23 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from b60c2a58d11 [feature][website] add script to auto watch md files change and auto … (#15721) add 20a22a023c7

[GitHub] [pulsar] BewareMyPower merged pull request #15725: [Python] Use async C++ calls to check for Python signals

2022-05-23 Thread GitBox
BewareMyPower merged PR #15725: URL: https://github.com/apache/pulsar/pull/15725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] BewareMyPower closed issue #6477: Python client `consumer.receive()` call suspends processing of interrupts within the program

2022-05-23 Thread GitBox
BewareMyPower closed issue #6477: Python client `consumer.receive()` call suspends processing of interrupts within the program URL: https://github.com/apache/pulsar/issues/6477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15726: [C++] Unblock all threads when Pulsar client is closed

2022-05-23 Thread GitBox
BewareMyPower commented on code in PR #15726: URL: https://github.com/apache/pulsar/pull/15726#discussion_r880035306 ## pulsar-client-cpp/lib/ConsumerImpl.cc: ## @@ -722,11 +722,14 @@ Result ConsumerImpl::fetchSingleMessageFromBroker(Message& msg) {

[pulsar] branch master updated: [feature][website] add script to auto watch md files change and auto … (#15721)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b60c2a58d11 [feature][website] add script to

[GitHub] [pulsar] urfreespace merged pull request #15721: [feature][website] add script to auto watch md files change and auto …

2022-05-23 Thread GitBox
urfreespace merged PR #15721: URL: https://github.com/apache/pulsar/pull/15721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mingyifei opened a new issue, #15735: About TripleLongPriorityQueue thread safety.

2022-05-23 Thread GitBox
mingyifei opened a new issue, #15735: URL: https://github.com/apache/pulsar/issues/15735 Don't TripleLongPriorityQueue.add() and TripleLongPriorityQueue.pop() methods have thread safety issues? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15726: [C++] Unblock all threads when Pulsar client is closed

2022-05-23 Thread GitBox
BewareMyPower commented on code in PR #15726: URL: https://github.com/apache/pulsar/pull/15726#discussion_r880033398 ## pulsar-client-cpp/include/pulsar/Result.h: ## @@ -88,6 +88,8 @@ enum Result ResultProducerFenced,/// Producer was fenced by

[pulsar] 01/01: update

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch fix/website-watch-script in repository https://gitbox.apache.org/repos/asf/pulsar.git commit ac645c47b2156f2575cc16be2217df019bfac404 Author: Li Li AuthorDate: Tue May 24 11:49:36 2022 +0800

[pulsar] branch fix/website-watch-script created (now ac645c47b21)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch fix/website-watch-script in repository https://gitbox.apache.org/repos/asf/pulsar.git at ac645c47b21 update This branch includes the following new commits: new ac645c47b21 update

[pulsar-site] 01/01: Merge pull request #91 from apache/fix/watch-files-change-script

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 6e2bc4ecce4b2d0502f0c0e8bf8454e215ba7f68 Merge: d29c0de1d8b 3167c514ac3 Author: Li Li AuthorDate: Tue May 24

[pulsar-site] branch main updated (d29c0de1d8b -> 6e2bc4ecce4)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from d29c0de1d8b Docs sync done from apache/pulsar(#116495c) add 3167c514ac3 add script for watch files change

[pulsar-site] branch fix/watch-files-change-script created (now 3167c514ac3)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch fix/watch-files-change-script in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 3167c514ac3 add script for watch files change from pulsar repo This branch includes the

[pulsar-site] 01/01: add script for watch files change from pulsar repo

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch fix/watch-files-change-script in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 3167c514ac3c1c92268b5b24412ccdc479f4e66e Author: Li Li AuthorDate: Tue May 24 11:45:25 2022

[GitHub] [pulsar] github-actions[bot] commented on pull request #15734: [feature][doc][do-not-merge] Add docs about how to use basic authentication

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #15734: URL: https://github.com/apache/pulsar/pull/15734#issuecomment-1135364719 @momo-jun:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] momo-jun commented on pull request #15734: [feature][doc][do-not-merge] Add docs about how to use basic authentication

2022-05-23 Thread GitBox
momo-jun commented on PR #15734: URL: https://github.com/apache/pulsar/pull/15734#issuecomment-1135364716 Ping @nodece @codelipenghui @Anonymitaet for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] github-actions[bot] commented on pull request #15734: [feature][doc][do-not-merge] Add docs about how to use basic authentication

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #15734: URL: https://github.com/apache/pulsar/pull/15734#issuecomment-1135364352 @momo-jun:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] momo-jun opened a new pull request, #15734: [feature][doc][do-not-merge] Add docs about how to use basic authentication

2022-05-23 Thread GitBox
momo-jun opened a new pull request, #15734: URL: https://github.com/apache/pulsar/pull/15734 Fixes #14661 ### Modifications 1. Add a new topic about how to use basic authentication 2. Sync the topic in the left navigation and security overview The preview looks

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #14371: [fix][txn] Transaction cumulative ack redeliver change

2022-05-23 Thread GitBox
liangyepianzhou commented on code in PR #14371: URL: https://github.com/apache/pulsar/pull/14371#discussion_r812715466 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java: ## @@ -1061,4 +1060,114 @@ public void testTxnTimeOutInClient()

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15729: [improve][txn] Support ack message list for transaction

2022-05-23 Thread GitBox
gaoran10 commented on code in PR #15729: URL: https://github.com/apache/pulsar/pull/15729#discussion_r880019671 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTest.java: ## @@ -997,4 +998,47 @@ public void

[GitHub] [pulsar-client-go] congbobo184 commented on a diff in pull request #776: Support ack response for Go SDK

2022-05-23 Thread GitBox
congbobo184 commented on code in PR #776: URL: https://github.com/apache/pulsar-client-go/pull/776#discussion_r880018280 ## pulsar/consumer_partition.go: ## @@ -525,12 +526,22 @@ func (pc *partitionConsumer) internalAck(req *ackRequest) { EntryId:

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15709: [improve][doc] Add a limitation for key_shared subscription type

2022-05-23 Thread GitBox
Anonymitaet commented on code in PR #15709: URL: https://github.com/apache/pulsar/pull/15709#discussion_r880014617 ## site2/docs/concepts-messaging.md: ## @@ -916,7 +937,9 @@ The other available approach to message deduplication is to ensure that each mes Message

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood

2022-05-23 Thread GitBox
Anonymitaet commented on code in PR #15715: URL: https://github.com/apache/pulsar/pull/15715#discussion_r880012715 ## site2/docs/concepts-messaging.md: ## @@ -906,7 +906,7 @@ Message deduplication is disabled in the scenario shown at the top. Here, a prod In the second

[pulsar] branch master updated (006eb99c4dd -> 74391264a91)

2022-05-23 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 006eb99c4dd [fix][doc] Binary protocol spec: perform topic lookup before creating/connecting a producer/consumer

[GitHub] [pulsar] Anonymitaet merged pull request #15706: [fix][doc] Fixed wrong text in Full Transitive and Full Schema Compatibility docs

2022-05-23 Thread GitBox
Anonymitaet merged PR #15706: URL: https://github.com/apache/pulsar/pull/15706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] zymap commented on a diff in pull request #15710: [feat] [tiered-storage] Add pure S3 provider for the offloader

2022-05-23 Thread GitBox
zymap commented on code in PR #15710: URL: https://github.com/apache/pulsar/pull/15710#discussion_r880009016 ## tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java: ## @@ -409,14 +428,21 @@ public String

[GitHub] [pulsar] hangc0276 commented on a diff in pull request #15710: [feat] [tiered-storage] Add pure S3 provider for the offloader

2022-05-23 Thread GitBox
hangc0276 commented on code in PR #15710: URL: https://github.com/apache/pulsar/pull/15710#discussion_r880005350 ## tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java: ## @@ -409,14 +428,21 @@ public String

[GitHub] [pulsar] Demogorgon314 opened a new pull request, #15733: [fix][admin] Unwrap the completion exception on schemas admin API

2022-05-23 Thread GitBox
Demogorgon314 opened a new pull request, #15733: URL: https://github.com/apache/pulsar/pull/15733 ### Motivation Currently, the schemas admin API Implementation used raw exception to check the exception type, we should unwrap the completion exception. ### Modifications

[GitHub] [pulsar] nodece commented on a diff in pull request #15621: [improve][broker] Make some operation auto topic creation in Namespaces async.

2022-05-23 Thread GitBox
nodece commented on code in PR #15621: URL: https://github.com/apache/pulsar/pull/15621#discussion_r880004483 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java: ## @@ -572,14 +579,26 @@ public void setAutoTopicCreation(@Suspended final

[GitHub] [pulsar] maxsxu commented on issue #15732: Rename doc label (Bot)

2022-05-23 Thread GitBox
maxsxu commented on issue #15732: URL: https://github.com/apache/pulsar/issues/15732#issuecomment-1135335199 > @maxsxu would you like to take care of this issue? Thanks @Anonymitaet Sure, I'll be working on it. Please assign to me. -- This is an automated message from the Apache

[GitHub] [pulsar] Anonymitaet commented on issue #15732: Rename doc label (Bot)

2022-05-23 Thread GitBox
Anonymitaet commented on issue #15732: URL: https://github.com/apache/pulsar/issues/15732#issuecomment-1135333869 @maxsxu would you like to take care of this issue? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Anonymitaet opened a new issue, #15732: Rename doc label (Bot)

2022-05-23 Thread GitBox
Anonymitaet opened a new issue, #15732: URL: https://github.com/apache/pulsar/issues/15732 # Requirement Rename doc label as below https://user-images.githubusercontent.com/50226895/169936714-affd24fe-281e-4717-9571-3b3f9754c284.png;> # References -

[GitHub] [pulsar] Demogorgon314 commented on pull request #15718: [fix][schema] Fix update schema forward compatibility strategy behavior

2022-05-23 Thread GitBox
Demogorgon314 commented on PR #15718: URL: https://github.com/apache/pulsar/pull/15718#issuecomment-1135331097 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao opened a new pull request, #15731: [branch-2.9][Authorization] Optimize the logic of allowing namespace operation.

2022-05-23 Thread GitBox
mattisonchao opened a new pull request, #15731: URL: https://github.com/apache/pulsar/pull/15731 ### Motivation Cherry-pick #13090 ### Modification - Delete `GET_REPLICATED_SUBSCRIPTION_STATUS` in `allowTopicOperationAsync`. because the current version is not supported.

[GitHub] [pulsar] github-actions[bot] commented on issue #15133: [PIP 154] Max active transaction limitation for transaction coordinator

2022-05-23 Thread GitBox
github-actions[bot] commented on issue #15133: URL: https://github.com/apache/pulsar/issues/15133#issuecomment-1135324614 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #15249: pulsar-bug

2022-05-23 Thread GitBox
github-actions[bot] commented on issue #15249: URL: https://github.com/apache/pulsar/issues/15249#issuecomment-1135324485 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #15267: No such ledger exists on Metadata Server

2022-05-23 Thread GitBox
github-actions[bot] commented on issue #15267: URL: https://github.com/apache/pulsar/issues/15267#issuecomment-1135324459 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #14371: [fix][txn] Transaction cumulative ack redeliver change

2022-05-23 Thread GitBox
congbobo184 commented on code in PR #14371: URL: https://github.com/apache/pulsar/pull/14371#discussion_r879996922 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java: ## @@ -1061,4 +1060,72 @@ public void testTxnTimeOutInClient() throws

[GitHub] [pulsar] Shawyeok commented on pull request #15594: [pulsar-client] Throw more meaningful derived exception instead of PulsarClientException

2022-05-23 Thread GitBox
Shawyeok commented on PR #15594: URL: https://github.com/apache/pulsar/pull/15594#issuecomment-1135323367 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on pull request #15730: [branch-2.9] fix:remove the loadbalance/bundle-data node

2022-05-23 Thread GitBox
mattisonchao commented on PR #15730: URL: https://github.com/apache/pulsar/pull/15730#issuecomment-1135322214 @leizhiyuan Could you please help to review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] mattisonchao opened a new pull request, #15730: [branch-2.9] fix:remove the loadbalance/bundle-data node

2022-05-23 Thread GitBox
mattisonchao opened a new pull request, #15730: URL: https://github.com/apache/pulsar/pull/15730 ### Motivation Cherry-pick https://github.com/apache/pulsar/pull/13164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar] branch master updated: [fix][doc] Binary protocol spec: perform topic lookup before creating/connecting a producer/consumer (#15714)

2022-05-23 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 006eb99c4dd [fix][doc] Binary protocol spec:

[GitHub] [pulsar] Anonymitaet merged pull request #15714: [fix][doc] Binary protocol spec: perform topic lookup before creating/connecting a producer/consumer

2022-05-23 Thread GitBox
Anonymitaet merged PR #15714: URL: https://github.com/apache/pulsar/pull/15714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet closed issue #15690: [Doc] Pulsar binary protocol specification, structure

2022-05-23 Thread GitBox
Anonymitaet closed issue #15690: [Doc] Pulsar binary protocol specification, structure URL: https://github.com/apache/pulsar/issues/15690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #15729: [improve][txn] Support ack message list for transaction

2022-05-23 Thread GitBox
liangyepianzhou opened a new pull request, #15729: URL: https://github.com/apache/pulsar/pull/15729 ### Motivation Now, there is ```java doAcknowledgeWithTxn(List messageIdList, AckType ackType, Map properties,

[GitHub] [pulsar] Technoboy- closed pull request #15190: [improve][java-client] Better error message for `reconsumeLater`

2022-05-23 Thread GitBox
Technoboy- closed pull request #15190: [improve][java-client] Better error message for `reconsumeLater` URL: https://github.com/apache/pulsar/pull/15190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15722: [fix][client] Fix changeToReadyState of HandlerState

2022-05-23 Thread GitBox
Technoboy- commented on code in PR #15722: URL: https://github.com/apache/pulsar/pull/15722#discussion_r879983352 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/HandlerState.java: ## @@ -53,7 +53,8 @@ public HandlerState(PulsarClientImpl client, String topic) {

[GitHub] [pulsar] Demogorgon314 commented on pull request #15718: [fix][schema] Fix update schema forward compatibility strategy behavior

2022-05-23 Thread GitBox
Demogorgon314 commented on PR #15718: URL: https://github.com/apache/pulsar/pull/15718#issuecomment-1135302225 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Technoboy- commented on pull request #15190: [improve][java-client] Better error message for `reconsumeLater`

2022-05-23 Thread GitBox
Technoboy- commented on PR #15190: URL: https://github.com/apache/pulsar/pull/15190#issuecomment-1135301107 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15685: [improve][broker] Make some methods of ClusterBase pure async.

2022-05-23 Thread GitBox
mattisonchao commented on code in PR #15685: URL: https://github.com/apache/pulsar/pull/15685#discussion_r879978967 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java: ## @@ -742,38 +735,37 @@ public void deleteNamespaceIsolationPolicy(

[pulsar] branch master updated (116495c901c -> 7bb878cb198)

2022-05-23 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 116495c901c Parse function userConfig to Map (#15669) add 7bb878cb198 Bump snappy zstd version to fix

[GitHub] [pulsar] Technoboy- merged pull request #15698: Bump snappy zstd version to fix CompressorCodecBackwardCompatTest on Apple M1

2022-05-23 Thread GitBox
Technoboy- merged PR #15698: URL: https://github.com/apache/pulsar/pull/15698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao commented on pull request #15621: [improve][broker] Make some operation auto topic creation in Namespaces async.

2022-05-23 Thread GitBox
mattisonchao commented on PR #15621: URL: https://github.com/apache/pulsar/pull/15621#issuecomment-1135296830 @shibd Looks like this fix is missing, is it rebase issue? https://github.com/apache/pulsar/pull/15653 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] shibd commented on pull request #15621: [improve][broker] Make some operation auto topic creation in Namespaces async.

2022-05-23 Thread GitBox
shibd commented on PR #15621: URL: https://github.com/apache/pulsar/pull/15621#issuecomment-1135296394 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] liangyepianzhou commented on pull request #15722: [fix][client] Fix changeToReadyState of HandlerState

2022-05-23 Thread GitBox
liangyepianzhou commented on PR #15722: URL: https://github.com/apache/pulsar/pull/15722#issuecomment-1135280763 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] nlu90 commented on pull request #15728: [Function] provide default error handler

2022-05-23 Thread GitBox
nlu90 commented on PR #15728: URL: https://github.com/apache/pulsar/pull/15728#issuecomment-1135262715 @freeznet @liudezhi2098 Could you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] nlu90 commented on a diff in pull request #15728: [Function] provide default error handler

2022-05-23 Thread GitBox
nlu90 commented on code in PR #15728: URL: https://github.com/apache/pulsar/pull/15728#discussion_r879953842 ## pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/LogAppender.java: ## @@ -47,15 +54,16 @@ public LogAppender(PulsarClient pulsarClient,

[GitHub] [pulsar] nlu90 opened a new pull request, #15728: [Function] provide default error handler

2022-05-23 Thread GitBox
nlu90 opened a new pull request, #15728: URL: https://github.com/apache/pulsar/pull/15728 ### Motivation Fixes #15274 ### Modifications 1. create a DefaultErrorHandler during LogAppender initialization. ### Verifying this change - [ ] Make sure that the

[GitHub] [pulsar] Shoothzj commented on pull request #15698: Bump snappy zstd version to fix CompressorCodecBackwardCompatTest on Apple M1

2022-05-23 Thread GitBox
Shoothzj commented on PR #15698: URL: https://github.com/apache/pulsar/pull/15698#issuecomment-1135238939 @Technoboy- ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] mans2singh opened a new pull request, #15727: [fix][schema-understand][docs] Updated example section

2022-05-23 Thread GitBox
mans2singh opened a new pull request, #15727: URL: https://github.com/apache/pulsar/pull/15727 ### Modifications * The document states that **You** application reads the messages. Updated to state **Your** application reads the messages ### Verifying this change - [ ]

[GitHub] [pulsar] cbornet commented on pull request #15693: [improve][function] Get function class name from the NAR when using built-in functions

2022-05-23 Thread GitBox
cbornet commented on PR #15693: URL: https://github.com/apache/pulsar/pull/15693#issuecomment-1135102916 Added tests so this PR is now ready to be reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] klevy-toast commented on issue #15679: Topic rebalances cause consumers with receiverQueueSize=0 to get stuck

2022-05-23 Thread GitBox
klevy-toast commented on issue #15679: URL: https://github.com/apache/pulsar/issues/15679#issuecomment-1135086108 I have made more accurate local reproduction steps with docker / kotlin which should be straightforward to run with this test file:

[GitHub] [pulsar] nlu90 commented on issue #15274: [Function] Log4jLogger caught java.lang.NullPointerException logging ParameterizedMessage

2022-05-23 Thread GitBox
nlu90 commented on issue #15274: URL: https://github.com/apache/pulsar/issues/15274#issuecomment-1135080576 @liudezhi2098 Based on a discussion with @freeznet, we think it's related to uninitialized error handler in `LogAppender` class -- This is an automated message from the Apache Git

[GitHub] [pulsar] merlimat opened a new pull request, #15726: [C++] Unblock all threads when Pulsar client is closed

2022-05-23 Thread GitBox
merlimat opened a new pull request, #15726: URL: https://github.com/apache/pulsar/pull/15726 ### Motivation All the blocking operations on the C++ client are currently not unblocked when the producer/consumer/client are closed. ### Modifications Introduced new error

[GitHub] [pulsar] github-actions[bot] commented on pull request #15725: [Python] Use async C++ calls to check for Python signals

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #15725: URL: https://github.com/apache/pulsar/pull/15725#issuecomment-1135067111 @merlimat:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] merlimat opened a new pull request, #15725: [Python] Use async C++ calls to check for Python signals

2022-05-23 Thread GitBox
merlimat opened a new pull request, #15725: URL: https://github.com/apache/pulsar/pull/15725 Fix #6477 ### Motivation Currently the Python wrapper is calling blocking methods in the C++ API. That means that the Python interpreter thread is stuck in the blocking call (even if

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
michaeljmarshall commented on code in PR #15723: URL: https://github.com/apache/pulsar/pull/15723#discussion_r879805337 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -1210,6 +1211,11 @@ public PulsarClient getReplicationClient(String

[GitHub] [pulsar] merlimat commented on issue #15585: [python] Pulsar Client 2.10.0 package is missing from PyPi for Macosx 12

2022-05-23 Thread GitBox
merlimat commented on issue #15585: URL: https://github.com/apache/pulsar/issues/15585#issuecomment-1135060867 @ca-simone-chiorazzo @zhavir The version compiled for MacOS 11.0 is supposed to work on any version >= 11.0, including 12.1, 12.2, ... If you do `pip3 debug --verbose`

[GitHub] [pulsar] merlimat commented on a diff in pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
merlimat commented on code in PR #15723: URL: https://github.com/apache/pulsar/pull/15723#discussion_r879791413 ## conf/broker.conf: ## @@ -1211,6 +1211,9 @@ replicationConnectionsPerBroker=16 # Replicator producer queue size replicationProducerQueueSize=1000 +# Replicator

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#116495c)

2022-05-23 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new d29c0de1d8b Docs sync done from

[GitHub] [pulsar] larshp commented on pull request #15714: [fix][doc] Binary protocol spec: perform topic lookup before creating/connecting a producer/consumer

2022-05-23 Thread GitBox
larshp commented on PR #15714: URL: https://github.com/apache/pulsar/pull/15714#issuecomment-1134969097 looks good  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] lhotari commented on a diff in pull request #15724: [Broker] Replicator producer should have blockIfQueueFull=true

2022-05-23 Thread GitBox
lhotari commented on code in PR #15724: URL: https://github.com/apache/pulsar/pull/15724#discussion_r879728693 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java: ## @@ -83,6 +83,7 @@ public AbstractReplicator(String topicName, String

[GitHub] [pulsar] merlimat commented on a diff in pull request #15724: [Broker] Replicator producer should have blockIfQueueFull=true

2022-05-23 Thread GitBox
merlimat commented on code in PR #15724: URL: https://github.com/apache/pulsar/pull/15724#discussion_r879724680 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java: ## @@ -83,6 +83,7 @@ public AbstractReplicator(String topicName, String

[GitHub] [pulsar] merlimat commented on a diff in pull request #15724: [Broker] Replicator producer should have blockIfQueueFull=true

2022-05-23 Thread GitBox
merlimat commented on code in PR #15724: URL: https://github.com/apache/pulsar/pull/15724#discussion_r879722382 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java: ## @@ -83,6 +83,7 @@ public AbstractReplicator(String topicName, String

[GitHub] [pulsar] lhotari commented on pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
lhotari commented on PR #15723: URL: https://github.com/apache/pulsar/pull/15723#issuecomment-1134956664 I also added #15724 to address a problem seen in #15691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] github-actions[bot] commented on pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #15723: URL: https://github.com/apache/pulsar/pull/15723#issuecomment-1134956371 @lhotari:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] lhotari opened a new pull request, #15724: [Broker] Replicator producer should have blockIfQueueFull=true

2022-05-23 Thread GitBox
lhotari opened a new pull request, #15724: URL: https://github.com/apache/pulsar/pull/15724 ### Motivation In #15691, an exception is seen which isn't properly handled. ``` 2022-05-19T18:35:09,916+ [BookKeeperClientWorker-OrderedExecutor-3-0] ERROR

[GitHub] [pulsar] lhotari commented on issue #15691: [Broker] Support configuration of the memory allocated to replication producer

2022-05-23 Thread GitBox
lhotari commented on issue #15691: URL: https://github.com/apache/pulsar/issues/15691#issuecomment-1134950827 @gaozhangmin We are blocked by this issue and since you didn't create a PR, I have created one in #15723. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] github-actions[bot] commented on pull request #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
github-actions[bot] commented on PR #15723: URL: https://github.com/apache/pulsar/pull/15723#issuecomment-1134950650 @lhotari:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] lhotari opened a new pull request, #15723: [Broker] Add replicationClientMemoryLimitBytes setting for configuring replication client memory limit

2022-05-23 Thread GitBox
lhotari opened a new pull request, #15723: URL: https://github.com/apache/pulsar/pull/15723 Fixes #15691 ### Motivation There's a performance regression in 2.10 in geo-replication since the client memory limit is enabled by default in "PIP-120: Enable client memory limit by

[GitHub] [pulsar] Shawyeok commented on pull request #15594: [pulsar-client] Throw more meaningful derived exception instead of PulsarClientException

2022-05-23 Thread GitBox
Shawyeok commented on PR #15594: URL: https://github.com/apache/pulsar/pull/15594#issuecomment-1134914544 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar] branch branch-2.10 updated: [enh] Issue 15455: Pulsar Admin: create subscripion with Properties (PIP-105) (#15503) (#15681)

2022-05-23 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new c7f9ffdf229 [enh] Issue 15455:

[GitHub] [pulsar] eolivelli merged pull request #15681: [enh] Issue 15455: Pulsar Admin: create subscripion with Properties (PIP-105) (#15503)

2022-05-23 Thread GitBox
eolivelli merged PR #15681: URL: https://github.com/apache/pulsar/pull/15681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch branch-2.10 updated: [fix][owasp] Fix false positive google-http-client-gson-1.41.0.jar (#15651)

2022-05-23 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 342f2c7358a [fix][owasp] Fix

[GitHub] [pulsar] nicoloboschi commented on pull request #15431: [feat][elasticsearch-sink] Option to strip out non printable characters

2022-05-23 Thread GitBox
nicoloboschi commented on PR #15431: URL: https://github.com/apache/pulsar/pull/15431#issuecomment-1134829795 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] nicoloboschi commented on pull request #15430: [fix][elasticsearch-sink] Handle Avro collections native types (GenericData.Array and Utf8 map keys)

2022-05-23 Thread GitBox
nicoloboschi commented on PR #15430: URL: https://github.com/apache/pulsar/pull/15430#issuecomment-1134829377 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   >