[GitHub] [pulsar] Jason918 commented on pull request #17242: [feat][broker]PIP-180 ShadowTopic - Part III - Add shadowTopics in TopicPolicy

Jason918 commented on PR #17242: URL: https://github.com/apache/pulsar/pull/17242#issuecomment-1225229196 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on a diff in pull request #17252: [fix][broker] Make timestamp fields thread safe by using volatile to prevent visibility issues

lhotari commented on code in PR #17252: URL: https://github.com/apache/pulsar/pull/17252#discussion_r953376245 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -129,7 +129,7 @@ public class Consumer { private static final double

[GitHub] [pulsar] github-actions[bot] commented on pull request #17252: [fix][broker] Make timestamp fields thread safe by using volatile to prevent visibility issues

github-actions[bot] commented on PR #17252: URL: https://github.com/apache/pulsar/pull/17252#issuecomment-1225222348 @lhotari Please provide a correct documentation label for your PR. Instructions see [Pulsar Documentation Label

[pulsar-client-go] branch master updated: ci: add makefile (#800)

This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 2d5f6fc ci: add makefile (#800)

[GitHub] [pulsar-client-go] michaeljmarshall merged pull request #800: ci: add makefile

michaeljmarshall merged PR #800: URL: https://github.com/apache/pulsar-client-go/pull/800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] h-hy commented on pull request #834: Fixs : NackBackoffPolicy.Next return time.Duration

h-hy commented on PR #834: URL: https://github.com/apache/pulsar-client-go/pull/834#issuecomment-1225218625 @wolfstudy Please check this if you are available. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17252: [fix][broker] Make timestamp fields thread safe by using volatile to prevent visibility issues

michaeljmarshall commented on code in PR #17252: URL: https://github.com/apache/pulsar/pull/17252#discussion_r953364078 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -129,7 +129,7 @@ public class Consumer { private static final

[GitHub] [pulsar] Technoboy- commented on pull request #17236: Remove `internalUpdateOffloadPolicies` to keep the same behavior update topic policy

Technoboy- commented on PR #17236: URL: https://github.com/apache/pulsar/pull/17236#issuecomment-1225195386 > @Technoboy- The failed test `testTopicLevelOffloadNonPartitioned(org.apache.pulsar.broker.admin.AdminApiOffloadTest)` looks like related to this change? fixed -- This is

[GitHub] [pulsar] lhotari opened a new pull request, #17252: [fix][broker] Make timestamp fields thread safe by using volatile to prevent visibility issues

lhotari opened a new pull request, #17252: URL: https://github.com/apache/pulsar/pull/17252 ### Motivation - fixes issue with stats where timestamps might be inconsistent because of visibility issues - most timestamps already are volatile, and it's better to follow this approach

[GitHub] [pulsar-client-go] nodece commented on pull request #831: [log-format] remove redundant "[]" pair in the head and tail of log content

nodece commented on PR #831: URL: https://github.com/apache/pulsar-client-go/pull/831#issuecomment-1225163391 Could you resolve the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] HQebupt opened a new pull request, #17251: fail to update partition meta of topic due to ConflictException: subs

HQebupt opened a new pull request, #17251: URL: https://github.com/apache/pulsar/pull/17251 … ### Motivation For a candidate broker, the addition expression maybe results in out of bounds and causes unexpected result when executing the following code.

[GitHub] [pulsar] HQebupt commented on pull request #17231: [broker][fix]Fix update topic remove properties

HQebupt commented on PR #17231: URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1225162116 > [broker][fix]Fix update topic remove properties Does the PR title naming change ? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] codelipenghui commented on pull request #17236: Remove `internalUpdateOffloadPolicies` to keep the same behavior update topic policy

codelipenghui commented on PR #17236: URL: https://github.com/apache/pulsar/pull/17236#issuecomment-1225156880 @Technoboy- The failed test `testTopicLevelOffloadNonPartitioned(org.apache.pulsar.broker.admin.AdminApiOffloadTest)` looks like related to this change? -- This is an automated

[pulsar-client-go] branch master updated: Add golang 1.19 in tests matrix (#832)

This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new da24461 Add golang 1.19 in tests

[GitHub] [pulsar-client-go] nodece merged pull request #832: Add golang 1.19 in test matrix

nodece merged PR #832: URL: https://github.com/apache/pulsar-client-go/pull/832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun commented on pull request #17250: [improve][doc] Add badges for third-party clients

tisonkun commented on PR #17250: URL: https://github.com/apache/pulsar/pull/17250#issuecomment-1225149500 cc @Anonymitaet @momo-jun @RobertIndie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] nodece commented on pull request #17141: [improve][test] Add integration tests for TLS

nodece commented on PR #17141: URL: https://github.com/apache/pulsar/pull/17141#issuecomment-1225148857 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] nodece commented on pull request #17208: [improve][build] Avoid building image multiple times

nodece commented on PR #17208: URL: https://github.com/apache/pulsar/pull/17208#issuecomment-1225145241 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun opened a new pull request, #17250: [improve][doc] Add badges for third-party clients

tisonkun opened a new pull request, #17250: URL: https://github.com/apache/pulsar/pull/17250 Add last commit badges for third-party clients. Adjust badges colors. This closes #16613. - [x] `doc` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wenbingshen opened a new pull request, #17249: fix unWarp Exception when getPoliciesAsync

wenbingshen opened a new pull request, #17249: URL: https://github.com/apache/pulsar/pull/17249 ### Modifications `getPoliciesAsync` may return an exception wrapped as `CompletionException` ### Documentation - [x ] `doc-not-needed` -- This is an automated message from

[pulsar] branch master updated (117afffce38 -> 3160edcc8a7)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 117afffce38 [improve][test] Add test for checking the customized properties is copied to DLQ (#17217) add

[GitHub] [pulsar] codelipenghui merged pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy

codelipenghui merged PR #17149: URL: https://github.com/apache/pulsar/pull/17149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17238: [broker][admin]Add api for update topic properties

AnonHxy commented on code in PR #17238: URL: https://github.com/apache/pulsar/pull/17238#discussion_r953292080 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -966,6 +966,42 @@ public void getProperties( }); }

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16969: [refactor][client c++] Delete PartitionedConsumerImpl, use MultiTopicsConsumerImpl instead

BewareMyPower commented on code in PR #16969: URL: https://github.com/apache/pulsar/pull/16969#discussion_r953288577 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -363,13 +401,12 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback callback) { auto

[GitHub] [pulsar] michaeljmarshall commented on issue #16584: Add Broker Cache Entry Eviction Rate Metric

michaeljmarshall commented on issue #16584: URL: https://github.com/apache/pulsar/issues/16584#issuecomment-1225127211 @tjiuming - sorry, I missed your comment. I implemented the metrics today. Feel free to review the PR if you have time. -- This is an automated message from the Apache

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #17248: [enh][broker] Add metrics for entry cache insertion, eviction

michaeljmarshall opened a new pull request, #17248: URL: https://github.com/apache/pulsar/pull/17248 Fixes https://github.com/apache/pulsar/issues/16584 ### Motivation With the `RangeCache`, it is hard to reason about its behavior other than cache hits/misses or the cache's

[GitHub] [pulsar] shibd commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

shibd commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r953283238 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -364,13 +366,47 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback callback) { state_ =

[GitHub] [pulsar] shibd commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

shibd commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r953283238 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -364,13 +366,47 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback callback) { state_ =

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #17238: [broker][admin]Add api for update topic properties

Technoboy- commented on code in PR #17238: URL: https://github.com/apache/pulsar/pull/17238#discussion_r953276852 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -966,6 +966,42 @@ public void getProperties( });

[GitHub] [pulsar] tuhaihe opened a new pull request, #17247: Add Pulsar Site Repo link to README

tuhaihe opened a new pull request, #17247: URL: https://github.com/apache/pulsar/pull/17247 ### Motivation Add Pulsar Site repo link to README file. ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ]

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on code in PR #17237: URL: https://github.com/apache/pulsar/pull/17237#discussion_r953274502 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionMessageDispatchThrottlingTest.java: ## @@ -220,6 +220,93 @@ public void

[GitHub] [pulsar] shibd commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

shibd commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r953272208 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -86,11 +86,14 @@ void MultiTopicsConsumerImpl::handleOneTopicSubscribed(Result result, Consumer c if

[GitHub] [pulsar] nodece commented on a diff in pull request #17206: [improve][broker][PIP-149]make deletePersistence method async in Namespaces

nodece commented on code in PR #17206: URL: https://github.com/apache/pulsar/pull/17206#discussion_r953271930 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java: ## @@ -1572,6 +1572,19 @@ private void doUpdatePersistence(PersistencePolicies

[GitHub] [pulsar] hangc0276 opened a new pull request, #17246: [Branch-2.9]Upgrade rocksdb version to 6.16.4 to keep sync with bookkeeper

hangc0276 opened a new pull request, #17246: URL: https://github.com/apache/pulsar/pull/17246 ### Motivation - Pulsar 2.9.x use BookKeeper 4.14.5 - BookKeeper 4.14.5 use RocksDB 6.16.4 - Pulsar 2.9.x uses RocksDB 6.10.2 In Pulsar packaging, it uses RocksDB 6.10.2 override

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17162: [feat][cpp] Support multiple brokers in service URL

BewareMyPower commented on code in PR #17162: URL: https://github.com/apache/pulsar/pull/17162#discussion_r953265166 ## pulsar-client-cpp/tests/ServiceURITest.cc: ## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[pulsar] branch master updated (72a30be939b -> 117afffce38)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 72a30be939b [improve][broker] Avoid using `common-pool` when run async method. (#17229) add 117afffce38

[GitHub] [pulsar] Technoboy- merged pull request #17217: [improve][test] Add test for checking the customized properties is copied to DLQ

Technoboy- merged PR #17217: URL: https://github.com/apache/pulsar/pull/17217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

BewareMyPower commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r953262625 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -364,13 +366,47 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback callback) { state_

[GitHub] [pulsar] github-actions[bot] commented on pull request #16682: [WIP][feature][client]Support batched message using entry filter

github-actions[bot] commented on PR #16682: URL: https://github.com/apache/pulsar/pull/16682#issuecomment-1225091308 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

BewareMyPower commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r953255225 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -86,11 +86,14 @@ void MultiTopicsConsumerImpl::handleOneTopicSubscribed(Result result, Consumer c

[pulsar] 03/04: [improve][broker] Avoid using `common-pool` when run async method. (#17229)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5c2155bf9961e25c829e3229834e433d7a8a8fd9 Author: Qiang Zhao AuthorDate: Wed Aug 24 09:51:43 2022 +0800

[pulsar] branch branch-2.11 updated (35ec5b63671 -> eaf6e885ebb)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 35ec5b63671 [fix][tests] Close producer to avoid create schema again. (#17227) new 345cd8c507b

[pulsar] 01/04: [fix][tool] Using int instead of long in python scriptsc (#17215)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 345cd8c507b5fe962732d12fb8362e052d032368 Author: Yong Zhang AuthorDate: Tue Aug 23 18:57:17 2022 +0800

[pulsar] 02/04: [fix][broker] Fix pulsarLedgerIdGenerator can't delete index path when zk metadata store config rootPath. (#17192)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 29af3ae6d4c2f12f7b61eb58ac4a88501e305be9 Author: Yan Zhao AuthorDate: Wed Aug 24 09:51:21 2022 +0800

[pulsar] 04/04: [improve][broker] Optimize the logic of terminating system topic (#17210)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit eaf6e885ebb2258bd1bcf846954fbefb7c6d844b Author: Ruguo Yu AuthorDate: Tue Aug 23 15:44:15 2022 +0800

[pulsar] branch master updated (9445fa7f9d8 -> 72a30be939b)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 9445fa7f9d8 [fix][broker] Fix pulsarLedgerIdGenerator can't delete index path when zk metadata store config

[GitHub] [pulsar] Technoboy- merged pull request #17229: [improve][broker] Avoid using `common-pool` when run async method.

Technoboy- merged PR #17229: URL: https://github.com/apache/pulsar/pull/17229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: [fix][broker] Fix pulsarLedgerIdGenerator can't delete index path when zk metadata store config rootPath. (#17192)

This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9445fa7f9d8 [fix][broker] Fix

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on code in PR #17237: URL: https://github.com/apache/pulsar/pull/17237#discussion_r953249195 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionMessageDispatchThrottlingTest.java: ## @@ -220,6 +220,93 @@ public void

[GitHub] [pulsar] Technoboy- closed issue #17191: [Bug] PulsarLedgerIdGenerator can't delete the index path when zk metadata store config rootPath.

Technoboy- closed issue #17191: [Bug] PulsarLedgerIdGenerator can't delete the index path when zk metadata store config rootPath. URL: https://github.com/apache/pulsar/issues/17191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Technoboy- merged pull request #17192: [fix][broker] Fix pulsarLedgerIdGenerator can't delete index path when zk metadata store config rootPath.

Technoboy- merged PR #17192: URL: https://github.com/apache/pulsar/pull/17192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] HQebupt commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy

HQebupt commented on PR #17149: URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1225018230 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#8286e8c)

This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 310d7189db8 Docs sync done from

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

michaeljmarshall commented on code in PR #17237: URL: https://github.com/apache/pulsar/pull/17237#discussion_r953131445 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java: ## @@ -332,12 +332,17 @@ public void

[GitHub] [pulsar] heesung-sn commented on issue #16691: PIP-192: New Pulsar Broker Load Balancer

heesung-sn commented on issue #16691: URL: https://github.com/apache/pulsar/issues/16691#issuecomment-1224906801 vote email : https://lists.apache.org/thread/4s0869ndt6ppjzgklqjnjk6bjt3zngkd -- This is an automated message from the Apache Git Service. To respond to the message, please

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#8286e8c)

This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new ed4176e08ad Docs sync done from

[GitHub] [pulsar] rillo-carrillo opened a new issue, #17244: [Bug] Geo Replication failed using Proxy

rillo-carrillo opened a new issue, #17244: URL: https://github.com/apache/pulsar/issues/17244 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.10.0 Environment: 2

[GitHub] [pulsar] AnonHxy commented on pull request #17231: [broker][fix]Fix update topic remove properties

AnonHxy commented on PR #17231: URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1224339058 > Same problem below, please pay attention :) > >

[GitHub] [pulsar-client-go] zzzming commented on pull request #828: [Issue 827][bugfix] fix error delay of default backoff policy

zzzming commented on PR #828: URL: https://github.com/apache/pulsar-client-go/pull/828#issuecomment-1224338187 It's addressed by this PR https://github.com/apache/pulsar-client-go/pull/834 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar-client-go] zzzming commented on pull request #809: [issue #807] dlq topic producer options

zzzming commented on PR #809: URL: https://github.com/apache/pulsar-client-go/pull/809#issuecomment-1224334195 @wolfstudy @michaeljmarshall Can you help review this PR? @ne1llee is asking when to merge this? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] andrasbeni commented on pull request #16936: [improve][doc] Document configuration added by PIP-145

andrasbeni commented on PR #16936: URL: https://github.com/apache/pulsar/pull/16936#issuecomment-1224316760 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-go] h-hy opened a new pull request, #834: Fixs : NackBackoffPolicy.Next return time.Duration

h-hy opened a new pull request, #834: URL: https://github.com/apache/pulsar-client-go/pull/834 NackBackoffPolicy.Next return time.Duration ### Motivation return int64 before is ambiguous . NackBackoffPolicy.Next return time.Duration may be better. ### Modifications

[GitHub] [pulsar] lhotari commented on a diff in pull request #17241: [managed-ledger] prevent sending duplicate reads to BK/offloaders

lhotari commented on code in PR #17241: URL: https://github.com/apache/pulsar/pull/17241#discussion_r952838957 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/RangeEntryCacheImpl.java: ## @@ -256,6 +271,77 @@ public void asyncReadEntry(ReadHandle lh,

[GitHub] [pulsar] nicoloboschi opened a new pull request, #17243: [improve][cli] Pulsar shell: support for Windows

nicoloboschi opened a new pull request, #17243: URL: https://github.com/apache/pulsar/pull/17243 Fixes #16688 TL; DR - now Pulsar shell works on Windows ![Screen Shot 2022-08-23 at 6 02 50

[GitHub] [pulsar-client-go] h-hy merged pull request #825: NackBackoffPolicy.Next return time.Duration

h-hy merged PR #825: URL: https://github.com/apache/pulsar-client-go/pull/825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Jason918 opened a new pull request, #17242: [feat][broker] PIP-180 - ShadowTopic - Part III : Add shadowTopics in TopicPolicy.

Jason918 opened a new pull request, #17242: URL: https://github.com/apache/pulsar/pull/17242 Master Issue: https://github.com/apache/pulsar/issues/16153 ### Motivation Source topic need to know its shadow topic list to start the ShadowReplicators. ###

[GitHub] [pulsar] eolivelli commented on pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

eolivelli commented on PR #17237: URL: https://github.com/apache/pulsar/pull/17237#issuecomment-1224270123 This is very interesting. How did you find this problem ? It doesn't look like a regression of code contributed recently -- This is an automated message from the Apache Git

[GitHub] [pulsar] eolivelli opened a new pull request, #17241: [managed-ledger] prevent sending duplicate reads to BK/offloaders

eolivelli opened a new pull request, #17241: URL: https://github.com/apache/pulsar/pull/17241 ### Motivation When you have many subscriptions on the same topic and they are catching up (for instance after some downtime of the consumer application) Pulsar will start to perform many reads

[GitHub] [pulsar] shibd commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

shibd commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r952805482 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -86,11 +86,14 @@ void MultiTopicsConsumerImpl::handleOneTopicSubscribed(Result result, Consumer c if

[GitHub] [pulsar] shibd commented on a diff in pull request #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

shibd commented on code in PR #17239: URL: https://github.com/apache/pulsar/pull/17239#discussion_r952793882 ## pulsar-client-cpp/lib/MultiTopicsConsumerImpl.cc: ## @@ -364,13 +366,47 @@ void MultiTopicsConsumerImpl::closeAsync(ResultCallback callback) { state_ =

[pulsar] branch branch-2.8 updated: [improve][broker]Add retry for zk operation on connection loss (#17226)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new a9f3664ecc9 [improve][broker]Add retry

[GitHub] [pulsar] codelipenghui merged pull request #17226: [Branch-2.8][improve][broker]Add retry for zk operation on connection loss

codelipenghui merged PR #17226: URL: https://github.com/apache/pulsar/pull/17226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gaoran10 commented on issue #17219: Flaky-test: PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling

gaoran10 commented on issue #17219: URL: https://github.com/apache/pulsar/issues/17219#issuecomment-1224241738 I'll try to fix this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Technoboy- commented on pull request #16672: [improve][broker] Add `keyHashRangeIndex` to distinguish the same hashRanges with the same consumerName

Technoboy- commented on PR #16672: URL: https://github.com/apache/pulsar/pull/16672#issuecomment-1224234881 > > I think this will remove the possibility of having a stable assignment logic. Right now, if you specify the same consumer names, you will be guaranteed to receive the same keys

[GitHub] [pulsar] codelipenghui commented on pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

codelipenghui commented on PR #17237: URL: https://github.com/apache/pulsar/pull/17237#issuecomment-1224226493 @mattisonchao Do you know which PR introduced this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

codelipenghui commented on code in PR #17237: URL: https://github.com/apache/pulsar/pull/17237#discussion_r952765957 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionMessageDispatchThrottlingTest.java: ## @@ -220,6 +220,93 @@ public void

[GitHub] [pulsar] tisonkun commented on pull request #17223: [fix][python client]Fix python producer test run failed.

tisonkun commented on PR #17223: URL: https://github.com/apache/pulsar/pull/17223#issuecomment-1224216360 We may later move them to the `example` folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #17162: [feat][cpp] Support multiple brokers in service URL

Demogorgon314 commented on code in PR #17162: URL: https://github.com/apache/pulsar/pull/17162#discussion_r952743129 ## pulsar-client-cpp/tests/ServiceURITest.cc: ## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [pulsar] mattisonchao commented on pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on PR #17237: URL: https://github.com/apache/pulsar/pull/17237#issuecomment-1224189584 ``` 2022-08-23T22:44:06,869+0800 [broker-topic-workers-OrderedExecutor-4-0] INFO org.apache.pulsar.broker.service.persistent.PersistentDispatcherSingleActiveConsumer -

[GitHub] [pulsar] shibd commented on pull request #17223: [fix][python client]Fix python producer test run failed.

shibd commented on PR #17223: URL: https://github.com/apache/pulsar/pull/17223#issuecomment-1224187933 > Do we have some test coverage for python tests? It's a bit surprising that we fix such an issue on the master branch. This is not a unit test, it is an example code. -- This is

[GitHub] [pulsar] mattisonchao commented on pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on PR #17237: URL: https://github.com/apache/pulsar/pull/17237#issuecomment-1224158414 Because branch-2.10 also has this problem. I don't think it's a release 2.11 blocker. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] tjiuming commented on a diff in pull request #17041: [monitoring][broker][metadata] add metadata store metrics

tjiuming commented on code in PR #17041: URL: https://github.com/apache/pulsar/pull/17041#discussion_r952674026 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java: ## @@ -81,8 +86,8 @@ public abstract class AbstractMetadataStore

[GitHub] [pulsar] tjiuming commented on a diff in pull request #17041: [monitoring][broker][metadata] add metadata store metrics

tjiuming commented on code in PR #17041: URL: https://github.com/apache/pulsar/pull/17041#discussion_r952674026 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java: ## @@ -81,8 +86,8 @@ public abstract class AbstractMetadataStore

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17041: [monitoring][broker][metadata] add metadata store metrics

codelipenghui commented on code in PR #17041: URL: https://github.com/apache/pulsar/pull/17041#discussion_r952670129 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java: ## @@ -81,8 +86,8 @@ public abstract class AbstractMetadataStore

[GitHub] [pulsar] BewareMyPower opened a new pull request, #17239: [fix][cpp] Fix multi-topics consumer close segmentation fault

BewareMyPower opened a new pull request, #17239: URL: https://github.com/apache/pulsar/pull/17239 ### Motivation When a multi-topics consumer fails to create, it will close all internal single consumers. In this case, segmentation fault will happen.

[GitHub] [pulsar] HQebupt commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy

HQebupt commented on PR #17149: URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1224050497 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on pull request #17223: [fix][python client]Fix python producer test run failed.

tisonkun commented on PR #17223: URL: https://github.com/apache/pulsar/pull/17223#issuecomment-1224040182 Do we have some test coverage for python tests? It's a bit surprising that we fix such issue on master branch. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] AnonHxy opened a new pull request, #17238: [broker][admin]Add api for update topic properties

AnonHxy opened a new pull request, #17238: URL: https://github.com/apache/pulsar/pull/17238 ### Motivation * Maybe this modification should be part of https://github.com/apache/pulsar/issues/12629 . As described in the PIP document "These metadata could be set during topic

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#8286e8c)

This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 8c1533c7baa Docs sync done from

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on code in PR #17237: URL: https://github.com/apache/pulsar/pull/17237#discussion_r952509663 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionMessageDispatchThrottlingTest.java: ## @@ -220,6 +220,93 @@ public void

[GitHub] [pulsar] mattisonchao commented on pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on PR #17237: URL: https://github.com/apache/pulsar/pull/17237#issuecomment-1223952655 I will add more information later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on code in PR #17237: URL: https://github.com/apache/pulsar/pull/17237#discussion_r952498972 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStreamingDispatcherSingleActiveConsumer.java: ## @@ -175,14 +175,19 @@ public

[GitHub] [pulsar] mattisonchao commented on pull request #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao commented on PR #17237: URL: https://github.com/apache/pulsar/pull/17237#issuecomment-1223949503 I will add more information later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] mattisonchao opened a new pull request, #17237: [fix][broker] Fix dispatch the duplicated message with `Exclusive` mode.

mattisonchao opened a new pull request, #17237: URL: https://github.com/apache/pulsar/pull/17237 ### Motivation When invoking `readMoreEntries` we have to check if the `havePendingRead` state is `true` to avoid reading the same position many times in the race condition. You

[GitHub] [pulsar] Technoboy- opened a new pull request, #17236: Remove `internalUpdateOffloadPolicies` to keep the same behavior update topic policy

Technoboy- opened a new pull request, #17236: URL: https://github.com/apache/pulsar/pull/17236 Fixes #17086 Master Issue: #17086 ### Motivation #7883 supports topic-level offload, when it sets the policy, it calls `internalUpdateOffloadPolicies` to update the topic that

[pulsar] branch master updated: [fix][tool] Using int instead of long in python scriptsc (#17215)

This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8286e8ccb2e [fix][tool] Using int instead of

[GitHub] [pulsar] codelipenghui merged pull request #17215: [fix][tool] Using int instead of long in python scripts

codelipenghui merged PR #17215: URL: https://github.com/apache/pulsar/pull/17215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-dotpulsar] branch master updated: Updated NuGet packages

This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 116e337 Updated NuGet

[GitHub] [pulsar] coderzc commented on a diff in pull request #17164: [improve][broker] Make cursor properties support modify single value concurrently.

coderzc commented on code in PR #17164: URL: https://github.com/apache/pulsar/pull/17164#discussion_r952435063 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java: ## @@ -86,14 +86,20 @@ enum IndividualDeletedEntries { */ Map

[GitHub] [pulsar] coderzc commented on a diff in pull request #17164: [improve][broker] Make cursor properties support modify single value concurrently.

coderzc commented on code in PR #17164: URL: https://github.com/apache/pulsar/pull/17164#discussion_r952435063 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java: ## @@ -86,14 +86,20 @@ enum IndividualDeletedEntries { */ Map

  1   2   >