[GitHub] [pulsar-site] urfreespace commented on pull request #242: Add back release notes of 2.8.4

2022-10-08 Thread GitBox
urfreespace commented on PR #242: URL: https://github.com/apache/pulsar-site/pull/242#issuecomment-1272463430 @SignorMercurio did you leave it out in your scripts? pls check; thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pulsar-site] 01/01: clean i18n build scripts

2022-10-08 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch clean-i18n in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit 5d127640451a71322ee5b570a614522102bfae7b Author: Li Li AuthorDate: Sun Oct 9 13:51:57 2022 +0800 clean

[pulsar-site] branch clean-i18n created (now 5d127640451)

2022-10-08 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch clean-i18n in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 5d127640451 clean i18n build scripts This branch includes the following new commits: new 5d127640451

[GitHub] [pulsar-translation] tisonkun commented on a diff in pull request #50: Mention the Archived state

2022-10-08 Thread GitBox
tisonkun commented on code in PR #50: URL: https://github.com/apache/pulsar-translation/pull/50#discussion_r990732942 ## README.md: ## @@ -1,3 +1,11 @@ +## :warning: Project Archived :warning: +

[GitHub] [pulsar-translation] tisonkun opened a new pull request, #50: Mention the Archived state

2022-10-08 Thread GitBox
tisonkun opened a new pull request, #50: URL: https://github.com/apache/pulsar-translation/pull/50 This closes https://github.com/apache/pulsar/issues/17973. cc @merlimat @dave2wave @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Shawyeok commented on pull request #17970: [broker] Fix incorrect bundle split count metric

2022-10-08 Thread GitBox
Shawyeok commented on PR #17970: URL: https://github.com/apache/pulsar/pull/17970#issuecomment-1272454567 @hangc0276 Please take a review, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] tisonkun opened a new issue, #17974: Cleanup build script related to Crowdin integration.

2022-10-08 Thread GitBox
tisonkun opened a new issue, #17974: URL: https://github.com/apache/pulsar/issues/17974 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation This is a subtask of #17972.

[GitHub] [pulsar] tisonkun commented on issue #17973: Mention the Archived state in pulsar-translation README

2022-10-08 Thread GitBox
tisonkun commented on issue #17973: URL: https://github.com/apache/pulsar/issues/17973#issuecomment-1272453367 Then archive https://github.com/apache/pulsar-translation repo since now no maintainer is actively working on it. cc @merlimat @dave2wave I don't know whether it requires a

[GitHub] [pulsar] tisonkun opened a new issue, #17973: Mention the Archived state in pulsar-translation README

2022-10-08 Thread GitBox
tisonkun opened a new issue, #17973: URL: https://github.com/apache/pulsar/issues/17973 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation This is a subtask of #17972.

[GitHub] [pulsar] tisonkun opened a new issue, #17972: Tracking issue for Archive Crowdin based translation initiative

2022-10-08 Thread GitBox
tisonkun opened a new issue, #17972: URL: https://github.com/apache/pulsar/issues/17972 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation As discussed in

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
lordcheng10 commented on code in PR #17751: URL: https://github.com/apache/pulsar/pull/17751#discussion_r990728091 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java: ## @@ -116,6 +116,22 @@ public void readEntriesFailed(ManagedLedgerException

[GitHub] [pulsar] Demogorgon314 commented on pull request #15815: [fix][test] Fix schema not found check on unit test

2022-10-08 Thread GitBox
Demogorgon314 commented on PR #15815: URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1272447674 PR #17767 already fixed this issue, so I will close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Demogorgon314 closed pull request #15815: [fix][test] Fix schema not found check on unit test

2022-10-08 Thread GitBox
Demogorgon314 closed pull request #15815: [fix][test] Fix schema not found check on unit test URL: https://github.com/apache/pulsar/pull/15815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
lordcheng10 commented on code in PR #17751: URL: https://github.com/apache/pulsar/pull/17751#discussion_r990727298 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java: ## @@ -116,6 +116,22 @@ public void readEntriesFailed(ManagedLedgerException

[GitHub] [pulsar] Technoboy- opened a new pull request, #17971: [fix][ML] Fix `getPositionAfterN` infinite loop.

2022-10-08 Thread GitBox
Technoboy- opened a new pull request, #17971: URL: https://github.com/apache/pulsar/pull/17971 Fixes #17967 Master Issue: #17967 ### Motivation The root cause is here(line-3365) :

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Refactor SchemaHash to reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990725103 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java: ## @@ -32,10 +32,10 @@ public class BooleanSchema extends AbstractSchema {

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Refactor SchemaHash to reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990725103 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java: ## @@ -32,10 +32,10 @@ public class BooleanSchema extends AbstractSchema {

[GitHub] [pulsar] urfreespace commented on issue #17514: [website][feat] Pulsar All Releases Page

2022-10-08 Thread GitBox
urfreespace commented on issue #17514: URL: https://github.com/apache/pulsar/issues/17514#issuecomment-1272445804 > @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] shibd commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
shibd commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990726024 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -839,7 +839,7 @@ protected boolean canEnqueueMessage(Message message) {

[GitHub] [pulsar] Technoboy- commented on issue #17967: [BUG]Unknown reason causes getPositionAfterN infinite loop

2022-10-08 Thread GitBox
Technoboy- commented on issue #17967: URL: https://github.com/apache/pulsar/issues/17967#issuecomment-1272445066 > > @keyboardbobo What's the value of `startPosition`? Is this issue reproducible? > > @Technoboy- I have restarted the service and can no longer see the value of

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Refactor SchemaHash to reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990725103 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java: ## @@ -32,10 +32,10 @@ public class BooleanSchema extends AbstractSchema {

[GitHub] [pulsar-client-cpp] Demogorgon314 opened a new pull request, #27: Expose start message id inclusive configuration to C API

2022-10-08 Thread GitBox
Demogorgon314 opened a new pull request, #27: URL: https://github.com/apache/pulsar-client-cpp/pull/27 ### Motivation Expose start message id inclusive configuration to C API ### Modifications * Expose `start_message_id_inclusive` to C API. * Add unit tests for C API

svn commit: r57230 - /dev/pulsar/pulsar-client-go-0.9.0-candidate-2/ /release/pulsar/pulsar-client-go-0.9.0/

2022-10-08 Thread penghui
Author: penghui Date: Sun Oct 9 02:50:58 2022 New Revision: 57230 Log: release 0.9.0 Added: release/pulsar/pulsar-client-go-0.9.0/ - copied from r57229, dev/pulsar/pulsar-client-go-0.9.0-candidate-2/ Removed: dev/pulsar/pulsar-client-go-0.9.0-candidate-2/

[GitHub] [pulsar] BewareMyPower commented on issue #4967: Static linking for c/c++ libraries broken for osx

2022-10-08 Thread GitBox
BewareMyPower commented on issue #4967: URL: https://github.com/apache/pulsar/issues/4967#issuecomment-1272440827 Eventually I found the reason. When compiling libcurl from source, some features depend on some other libraries. For static linking, these other libraries must be linked.

[pulsar-client-go] annotated tag v0.9.0 updated (dd63a4c -> 61f494f)

2022-10-08 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to annotated tag v0.9.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git *** WARNING: tag v0.9.0 was modified! *** from dd63a4c (commit) to 61f494f (tag) tagging

[GitHub] [pulsar-client-go] labuladong commented on issue #858: concurrent map iteration and map write

2022-10-08 Thread GitBox
labuladong commented on issue #858: URL: https://github.com/apache/pulsar-client-go/issues/858#issuecomment-1272436037 Can you describe the steps to reproduce this bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Pomelongan commented on pull request #17969: [cleanup][broker]remove methods no longer used in AdminResource #7

2022-10-08 Thread GitBox
Pomelongan commented on PR #17969: URL: https://github.com/apache/pulsar/pull/17969#issuecomment-1272435754 > Please check the unused import, such as `import org.apache.pulsar.broker.PulsarService;` I have updated it.PTAL @HQebupt -- This is an automated message from the Apache Git

[GitHub] [pulsar] github-actions[bot] commented on pull request #15815: [fix][test] Fix schema not found check on unit test

2022-10-08 Thread GitBox
github-actions[bot] commented on PR #15815: URL: https://github.com/apache/pulsar/pull/15815#issuecomment-1272434589 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #17408: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic

2022-10-08 Thread GitBox
github-actions[bot] commented on PR #17408: URL: https://github.com/apache/pulsar/pull/17408#issuecomment-1272434022 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #17534: [improve][txn] The transaction message is integrated with the delay feature

2022-10-08 Thread GitBox
github-actions[bot] commented on issue #17534: URL: https://github.com/apache/pulsar/issues/17534#issuecomment-1272433986 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] HQebupt commented on pull request #17957: [fix][broker]unify time unit at dropping the backlog on a topic

2022-10-08 Thread GitBox
HQebupt commented on PR #17957: URL: https://github.com/apache/pulsar/pull/17957#issuecomment-1272432609 /pulsarbot ready-to-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] shibd commented on issue #16795: Flaky-test: SimpleProducerConsumerTest.testSharedSamePriorityConsumer

2022-10-08 Thread GitBox
shibd commented on issue #16795: URL: https://github.com/apache/pulsar/issues/16795#issuecomment-1272431245 @eolivelli @codelipenghui Can you help reopen it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] shibd commented on issue #16795: Flaky-test: SimpleProducerConsumerTest.testSharedSamePriorityConsumer

2022-10-08 Thread GitBox
shibd commented on issue #16795: URL: https://github.com/apache/pulsar/issues/16795#issuecomment-1272431107 Another one: https://github.com/shibd/pulsar/actions/runs/3210516613/jobs/5248015431 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar-client-go] billowqiu closed pull request #769: [bugfix] fix stuck when ProducerBlockedQuotaExceededException

2022-10-08 Thread GitBox
billowqiu closed pull request #769: [bugfix] fix stuck when ProducerBlockedQuotaExceededException URL: https://github.com/apache/pulsar-client-go/pull/769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990716151 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -839,7 +839,7 @@ protected boolean canEnqueueMessage(Message message) {

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272426813 @HQebupt PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lordcheng10 commented on pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17797: URL: https://github.com/apache/pulsar/pull/17797#issuecomment-1272425448 @AnonHxy PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272425278 @codelipenghui @Technoboy- PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] lordcheng10 commented on pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17797: URL: https://github.com/apache/pulsar/pull/17797#issuecomment-1272425240 @codelipenghui @Technoboy- PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990714601 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java: ## @@ -71,9 +72,13 @@ public void run(Timeout t) throws

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17948: [improve][java-client][issue-17931]Refactor SchemaHash to reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990714308 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java: ## @@ -32,10 +32,10 @@ public class BooleanSchema extends AbstractSchema

[GitHub] [pulsar] keyboardbobo commented on issue #17967: [BUG]Unknown reason causes getPositionAfterN infinite loop

2022-10-08 Thread GitBox
keyboardbobo commented on issue #17967: URL: https://github.com/apache/pulsar/issues/17967#issuecomment-1272424421 > @keyboardbobo What's the value of `startPosition`? Is this issue reproducible? I have restarted the service and can no longer see the value of startPosition. In the

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#08f5766)

2022-10-08 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 3671e00834e Docs sync done from

[GitHub] [pulsar] github-actions[bot] commented on pull request #17970: [broker] Fix incorrect bundle split count metric

2022-10-08 Thread GitBox
github-actions[bot] commented on PR #17970: URL: https://github.com/apache/pulsar/pull/17970#issuecomment-1272375383 @Shawyeok Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ]

[GitHub] [pulsar] Shawyeok opened a new pull request, #17970: [broker] Fix incorrect bundle split count metric

2022-10-08 Thread GitBox
Shawyeok opened a new pull request, #17970: URL: https://github.com/apache/pulsar/pull/17970 ### Motivation Suppose there is a non-partitioned topic has more than 1000 producers (1000 is `loadBalancerNamespaceBundleMaxSessions` default value), `pulsar_lb_bundles_split_count`

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#08f5766)

2022-10-08 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new c7c6451f373 Docs sync done from

[GitHub] [pulsar] Fischchen commented on issue #6220: Python Client for Windows

2022-10-08 Thread GitBox
Fischchen commented on issue #6220: URL: https://github.com/apache/pulsar/issues/6220#issuecomment-1272357504 Are there any plans to port it to windows? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Technoboy- commented on issue #17967: [BUG]Unknown reason causes getPositionAfterN infinite loop

2022-10-08 Thread GitBox
Technoboy- commented on issue #17967: URL: https://github.com/apache/pulsar/issues/17967#issuecomment-1272346706 @keyboardbobo What's the value of `startPosition`? Is this issue reproducible? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] 315157973 closed pull request #17911: [fix][broker]Fix mutex never released when trimming

2022-10-08 Thread GitBox
315157973 closed pull request #17911: [fix][broker]Fix mutex never released when trimming URL: https://github.com/apache/pulsar/pull/17911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272327967 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] HQebupt closed pull request #17957: [fix][broker]unify time unit at dropping the backlog on a topic

2022-10-08 Thread GitBox
HQebupt closed pull request #17957: [fix][broker]unify time unit at dropping the backlog on a topic URL: https://github.com/apache/pulsar/pull/17957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] 315157973 commented on a diff in pull request #17911: [fix][broker]Fix mutex never released when trimming

2022-10-08 Thread GitBox
315157973 commented on code in PR #17911: URL: https://github.com/apache/pulsar/pull/17911#discussion_r990644224 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -2652,15 +2659,19 @@ public void operationFailed(MetaStoreException

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990642223 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,123 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990641937 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,123 @@ public static SchemaHash of(SchemaData

[GitHub] [pulsar-client-cpp] shibd commented on pull request #21: [feat] Consumer support batch receive messages.

2022-10-08 Thread GitBox
shibd commented on PR #21: URL: https://github.com/apache/pulsar-client-cpp/pull/21#issuecomment-1272316750 This PR ci has passed. https://github.com/shibd/pulsar-client-cpp/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] shibd commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
shibd commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990634402 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -839,7 +839,7 @@ protected boolean canEnqueueMessage(Message message) {

[GitHub] [pulsar] lordcheng10 commented on pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17797: URL: https://github.com/apache/pulsar/pull/17797#issuecomment-1272313341 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272313335 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990637827 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,123 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] merlimat commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
merlimat commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990636497 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,123 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] Huanli-Meng commented on pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule

2022-10-08 Thread GitBox
Huanli-Meng commented on PR #17956: URL: https://github.com/apache/pulsar/pull/17956#issuecomment-1272308419 @dave2wave could you please help confirm whether docs in other releases also need to be updated? Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] Huanli-Meng commented on pull request #17958: [Improve][doc] Insist about default behaviour for retention.

2022-10-08 Thread GitBox
Huanli-Meng commented on PR #17958: URL: https://github.com/apache/pulsar/pull/17958#issuecomment-1272307884 @AlvaroStream thanks for your contribution. Could you please help whether docs in other releases also need to be updated? Thanks. -- This is an automated message from the Apache

[GitHub] [pulsar] Huanli-Meng commented on a diff in pull request #17958: [Improve][doc] Insist about default behaviour for retention.

2022-10-08 Thread GitBox
Huanli-Meng commented on code in PR #17958: URL: https://github.com/apache/pulsar/pull/17958#discussion_r990636171 ## site2/docs/cookbooks-retention-expiry.md: ## @@ -58,7 +58,7 @@ When a retention limit on a topic is exceeded, the oldest message is marked for ### Defaults

[GitHub] [pulsar] Huanli-Meng commented on pull request #17963: [Doc][Improve] Add images to /assets

2022-10-08 Thread GitBox
Huanli-Meng commented on PR #17963: URL: https://github.com/apache/pulsar/pull/17963#issuecomment-1272307117 @DaveDuggins do you want to reference these images in the Messaging doc? If yes, you need to update the related image links in the Messaging MD file. -- This is an automated

[GitHub] [pulsar] shibd commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
shibd commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990634402 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java: ## @@ -839,7 +839,7 @@ protected boolean canEnqueueMessage(Message message) {

[GitHub] [pulsar] HQebupt commented on pull request #17954: [clean][pom]remove unused scala-library.version from pom.xml

2022-10-08 Thread GitBox
HQebupt commented on PR #17954: URL: https://github.com/apache/pulsar/pull/17954#issuecomment-1272303565 Please rebase the latest code to solve some test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#08f5766)

2022-10-08 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 76615766e0a Docs sync done from

[GitHub] [pulsar] HQebupt commented on pull request #17969: [cleanup][broker]remove methods no longer used in AdminResource #7

2022-10-08 Thread GitBox
HQebupt commented on PR #17969: URL: https://github.com/apache/pulsar/pull/17969#issuecomment-1272302959 Please check the unused import, such as `import org.apache.pulsar.broker.PulsarService;` -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272301962 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17797: URL: https://github.com/apache/pulsar/pull/17797#issuecomment-1272301972 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] shibd commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
shibd commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990629222 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java: ## @@ -71,9 +72,13 @@ public void run(Timeout t) throws Exception {

[GitHub] [pulsar] shibd commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
shibd commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990629222 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java: ## @@ -71,9 +72,13 @@ public void run(Timeout t) throws Exception {

[GitHub] [pulsar] shibd commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
shibd commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990629222 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java: ## @@ -71,9 +72,13 @@ public void run(Timeout t) throws Exception {

[GitHub] [pulsar] AnonHxy commented on pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on PR #17948: URL: https://github.com/apache/pulsar/pull/17948#issuecomment-1272295834 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

2022-10-08 Thread GitBox
tisonkun commented on PR #17968: URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272287220 @youzipi OK. I think we can narrow the scope to what that issue originally has. We can (you can! of course :)) create a new issue to track new effort. IIRC @MarvinCai has lees time to

[GitHub] [pulsar] youzipi commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

2022-10-08 Thread GitBox
youzipi commented on PR #17968: URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272284939 > Cool! I think this PR actually closes #16991 and #12271? yes, we can close these issues. but there are still some modules not having this check, the list was made one year

[GitHub] [pulsar] Pomelongan opened a new pull request, #17969: [cleanup][broker]remove methods no longer used in AdminResource #7

2022-10-08 Thread GitBox
Pomelongan opened a new pull request, #17969: URL: https://github.com/apache/pulsar/pull/17969 ### Motivation `org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadataCheckAllowAutoCreation` and

[GitHub] [pulsar] Technoboy- commented on issue #17967: [BUG]Unknown reason causes getPositionAfterN infinite loop

2022-10-08 Thread GitBox
Technoboy- commented on issue #17967: URL: https://github.com/apache/pulsar/issues/17967#issuecomment-1272281513 > @Technoboy- Should the condition of `lastLedger` be modified to : if (currentLedger != null && currentLedgerId **`>=`** currentLedger.getId()) Yes, I think so. --

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990619989 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] HQebupt commented on pull request #17957: [fix][broker]unify time unit at dropping the backlog on a topic

2022-10-08 Thread GitBox
HQebupt commented on PR #17957: URL: https://github.com/apache/pulsar/pull/17957#issuecomment-1272277339 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Pomelongan commented on pull request #17946: [improve][broker]add the logic for creating missed subscriptions for createMissedPartitions

2022-10-08 Thread GitBox
Pomelongan commented on PR #17946: URL: https://github.com/apache/pulsar/pull/17946#issuecomment-1272277091 > LGTM, Can we add a unit test to verify this? OK, have update UT, PTAL @Jason918 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17318: [fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17318: URL: https://github.com/apache/pulsar/pull/17318#discussion_r990615227 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageRedeliveryTracker.java: ## @@ -71,9 +72,13 @@ public void run(Timeout t) throws

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272272849 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
poorbarcode commented on code in PR #17751: URL: https://github.com/apache/pulsar/pull/17751#discussion_r990613777 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java: ## @@ -116,6 +116,22 @@ public void readEntriesFailed(ManagedLedgerException

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1272270246 > +1 Agree with @codelipenghui concern. individual ack directly is better than introducing new stuff. OK , I will fixed! -- This is an automated message from the Apache

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1272270194 > checkReadCompletion OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990613617 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,115 @@ public static SchemaHash of(SchemaData

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
codelipenghui commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990613082 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990612875 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] mattisonchao commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
mattisonchao commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1272268736 +1 Agree with Penghui's concern. individual ack directly is better than introducing new stuff. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990612875 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990611948 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990611661 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar-client-go] maolinHu opened a new issue, #858: concurrent map iteration and map write

2022-10-08 Thread GitBox
maolinHu opened a new issue, #858: URL: https://github.com/apache/pulsar-client-go/issues/858 Expected behavior ![企业微信截图_16652163562552](https://user-images.githubusercontent.com/13829665/194698164-671499f1-84e0-4ca9-806c-dd69174f0c71.png) Actual behavior Tell

[GitHub] [pulsar] youzipi commented on pull request #17968: [cleanup][broker][Modernizer] fix violations in pulsar-broker

2022-10-08 Thread GitBox
youzipi commented on PR #17968: URL: https://github.com/apache/pulsar/pull/17968#issuecomment-1272265830 @MarvinCai @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lordcheng10 commented on pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17797: URL: https://github.com/apache/pulsar/pull/17797#issuecomment-1272264210 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #17910: [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17910: URL: https://github.com/apache/pulsar/pull/17910#issuecomment-1272264181 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-10-08 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1272264081 > > For unreadable entries, an entry with the skpped flag will be created. When pushing messages, the entries with the skipped flag as true will be filtered out, and then these

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17948: [improve][java-client][issue-17931]Reduce call of hashFunction in SchemaHash

2022-10-08 Thread GitBox
AnonHxy commented on code in PR #17948: URL: https://github.com/apache/pulsar/pull/17948#discussion_r990610192 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/schema/SchemaHash.java: ## @@ -55,15 +82,118 @@ public static SchemaHash of(SchemaData schemaData) {

[GitHub] [pulsar] SignorMercurio commented on issue #17514: [website][feat] Pulsar All Releases Page

2022-10-08 Thread GitBox
SignorMercurio commented on issue #17514: URL: https://github.com/apache/pulsar/issues/17514#issuecomment-1272262490 Should we close this issue as it's implemented in apache/pulsar-site#227? -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >