[GitHub] [pulsar] eolivelli commented on a diff in pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy

2023-01-22 Thread via GitHub
eolivelli commented on code in PR #19045: URL: https://github.com/apache/pulsar/pull/19045#discussion_r1083715886 ## pulsar-broker/src/test/java/org/apache/pulsar/compaction/ServiceUnitStateCompactionTest.java: ## @@ -0,0 +1,833 @@ +/* + * Licensed to the Apache Software

[GitHub] [pulsar] eolivelli commented on a diff in pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy

2023-01-22 Thread via GitHub
eolivelli commented on code in PR #19045: URL: https://github.com/apache/pulsar/pull/19045#discussion_r1083715660 ## pulsar-broker/src/main/java/org/apache/pulsar/compaction/StrategicTwoPhaseCompactor.java: ## @@ -385,6 +385,7 @@ private void phaseTwoLoop(String topic,

[GitHub] [pulsar] eolivelli commented on a diff in pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy

2023-01-22 Thread via GitHub
eolivelli commented on code in PR #19045: URL: https://github.com/apache/pulsar/pull/19045#discussion_r1083715317 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateCompactionStrategy.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed

[pulsar] branch master updated: [improve][ci] CI code coverage collecting improvements (#19303)

2023-01-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e0f79bf2a49 [improve][ci] CI code coverage

[GitHub] [pulsar] lhotari merged pull request #19303: [improve][ci] CI code coverage collecting improvements

2023-01-22 Thread via GitHub
lhotari merged PR #19303: URL: https://github.com/apache/pulsar/pull/19303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] heesung-sn commented on pull request #19045: [improve][broker] PIP-192 Added ServiceUnitStateCompactionStrategy

2023-01-22 Thread via GitHub
heesung-sn commented on PR #19045: URL: https://github.com/apache/pulsar/pull/19045#issuecomment-1399827591 @Technoboy- Hi, can you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] poorbarcode commented on pull request #19302: [improve] [admin] Make the default value of param --get-subscription-backlog-size of admin API topics stats true

2023-01-22 Thread via GitHub
poorbarcode commented on PR #19302: URL: https://github.com/apache/pulsar/pull/19302#issuecomment-1399825592 @gaoran10 > the calculation uses the data in memory, no IO operations, and maybe we can return -1 when the option param --get-subscription-backlog-size is false. Good

[GitHub] [pulsar-client-node] k2la commented on pull request #278: [improve][client] Add schema typing to consumer and producer

2023-01-22 Thread via GitHub
k2la commented on PR #278: URL: https://github.com/apache/pulsar-client-node/pull/278#issuecomment-1399814455 @romainbrancourt I think this can be better if you add tests about `consumer`. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] github-actions[bot] commented on pull request #16353: [StructuredEventLog] Added support for Log4j2 structured logging if available

2023-01-22 Thread github-actions
github-actions[bot] commented on PR #16353: URL: https://github.com/apache/pulsar/pull/16353#issuecomment-1399690059 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #18336: [feat][authentication] Add JWKS support for AuthenticationProviderToken

2023-01-22 Thread github-actions
github-actions[bot] commented on PR #18336: URL: https://github.com/apache/pulsar/pull/18336#issuecomment-1399689320 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #18316: [improve][client] PIP-218: Consumer batchReceive() single partition every receive

2023-01-22 Thread github-actions
github-actions[bot] commented on PR #18316: URL: https://github.com/apache/pulsar/pull/18316#issuecomment-1399689358 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] codecov-commenter commented on pull request #19303: [improve][ci] CI code coverage collecting improvements

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #19303: URL: https://github.com/apache/pulsar/pull/19303#issuecomment-1399672862 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19303?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on pull request #19303: [improve][ci] CI code coverage collecting improvements

2023-01-22 Thread via GitHub
lhotari commented on PR #19303: URL: https://github.com/apache/pulsar/pull/19303#issuecomment-1399550227 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari opened a new pull request, #19303: [improve][ci] CI code coverage collecting improvements

2023-01-22 Thread via GitHub
lhotari opened a new pull request, #19303: URL: https://github.com/apache/pulsar/pull/19303 ### Motivation Code coverage for master branch need pulsar-ci-flaky to run with a scheduled job since flaky tests are also part of the coverage. ### Modifications -

[GitHub] [pulsar-site] asafm commented on a diff in pull request #349: [doc][improve] Improve landing page 3 first sections

2023-01-22 Thread via GitHub
asafm commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1083426955 ## src/pages/index.js: ## @@ -191,7 +190,9 @@ export default function Home() { /> https://news.apache.org/foundation/entry/apache-in-2021-by-the,

[GitHub] [pulsar-site] asafm commented on a diff in pull request #349: [doc][improve] Improve landing page 3 first sections

2023-01-22 Thread via GitHub
asafm commented on code in PR #349: URL: https://github.com/apache/pulsar-site/pull/349#discussion_r1083424723 ## src/components/HomepageFeatures.js: ## @@ -4,48 +4,48 @@ import ReactMarkdown from "react-markdown"; const FeatureList = (language) => [ { -title: