[GitHub] [pulsar] poorbarcode commented on pull request #19825: [fix] [ml] make the result of delete cursor is success if cursor is deleted

2023-03-21 Thread via GitHub
poorbarcode commented on PR #19825: URL: https://github.com/apache/pulsar/pull/19825#issuecomment-1478989546 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] lordcheng10 opened a new pull request, #19893: [imporve][broker] use shortTermMsgRate and shortTermThroughput for UniformLoadShedder

2023-03-21 Thread via GitHub
lordcheng10 opened a new pull request, #19893: URL: https://github.com/apache/pulsar/pull/19893 ### Motivation In UniformLoadShedder, when selecting overloadedBroker and underloadedBroker, use shortTermThroughput and shortTermMsgRate. ### Modifications In UniformLoad

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19892: [improve][broker] Use consumer's startMessageId as readPosition

2023-03-21 Thread via GitHub
michaeljmarshall opened a new pull request, #19892: URL: https://github.com/apache/pulsar/pull/19892 PIP: #19864 ### Motivation This is a draft PR to show one potential way that we could use feedback from the client to influence how an exclusive and a failover consumer reconn

[GitHub] [pulsar] lordcheng10 opened a new pull request, #19891: [feat][broker] Provide new load balance placement strategy implementation for ModularLoadManagerStrategy

2023-03-21 Thread via GitHub
lordcheng10 opened a new pull request, #19891: URL: https://github.com/apache/pulsar/pull/19891 ### Motivation Add a ModularLoadManagerStrategy used with UniformLoadShedder; LeastLongTermMessageRate only takes msgRate into account, while UniformLoadShedder takes both msgRate and throug

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
heesung-sn commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144271272 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl getNamespaceClient(Clus

[GitHub] [pulsar] lordcheng10 opened a new pull request, #19890: [fix][broker] Fix overloadedBroker and underloadedBroker to select the wrong broker for UniformLoadShedder

2023-03-21 Thread via GitHub
lordcheng10 opened a new pull request, #19890: URL: https://github.com/apache/pulsar/pull/19890 ### Motivation The configuration is as follows: ``` loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold=0 loadBalancerMsgRateDifferenceShedderThreshold=50 ``` I hope

[GitHub] [pulsar] 315157973 commented on a diff in pull request #19874: [fix][client] Fix NPE when acknowledging multiple messages

2023-03-21 Thread via GitHub
315157973 commented on code in PR #19874: URL: https://github.com/apache/pulsar/pull/19874#discussion_r1144268868 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -496,8 +496,13 @@ protected CompletableFuture doAcknowledge(List me

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
heesung-sn commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144258938 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl getNamespaceClient(Clus

[GitHub] [pulsar] lordcheng10 opened a new pull request, #19889: [fix][broker] Fix BrokerData#timeAverageData update is thread safe

2023-03-21 Thread via GitHub
lordcheng10 opened a new pull request, #19889: URL: https://github.com/apache/pulsar/pull/19889 ### Motivation In the updateBundleData method, when the following code is executed: https://github.com/apache/pulsar/blob/30d2469086fea989ac8baf059df8e69c66a68d89/pulsar-broker/src/main/java

[GitHub] [pulsar-client-go] crossoverJie commented on issue #919: The behavior of `Seek` is different with Java Client

2023-03-21 Thread via GitHub
crossoverJie commented on issue #919: URL: https://github.com/apache/pulsar-client-go/issues/919#issuecomment-1478936014 I am interested in implementing this, please assign it to me, thanks. @RobertIndie -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19888: [feat][fn] PIP-257: Support mounting k8s ServiceAccount for OIDC auth

2023-03-21 Thread via GitHub
michaeljmarshall opened a new pull request, #19888: URL: https://github.com/apache/pulsar/pull/19888 PIP: #19771 ### Motivation In order to make OIDC work with functions, we must give them a way to authenticate with the broker using tokens that are able to be validated by an

[GitHub] [pulsar] lordcheng10 opened a new pull request, #19887: [fix][broker] Fix the loss of bundle stats data reported to zookeeper, when the updateStats method is executed

2023-03-21 Thread via GitHub
lordcheng10 opened a new pull request, #19887: URL: https://github.com/apache/pulsar/pull/19887 ### Motivation When the updateStats method is executed periodically, bundleStats will be cleaned up; At this time, call the getBundleStats method to report the bundle stats data to zookeepe

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter

2023-03-21 Thread via GitHub
poorbarcode commented on code in PR #19014: URL: https://github.com/apache/pulsar/pull/19014#discussion_r1057408809 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java: ## @@ -99,10 +99,10 @@ public long getAvailableDispatchRateLim

[GitHub] [pulsar-site] momo-jun commented on pull request #486: [improve][doc] Add schema support for python functions

2023-03-21 Thread via GitHub
momo-jun commented on PR #486: URL: https://github.com/apache/pulsar-site/pull/486#issuecomment-147058 Hi @jiangpengcheng, @freeznet , can you pls review the doc PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-site] momo-jun opened a new pull request, #486: [improve][doc] Add schema support for python functions

2023-03-21 Thread via GitHub
momo-jun opened a new pull request, #486: URL: https://github.com/apache/pulsar-site/pull/486 ### Modification Add docs for https://github.com/apache/pulsar/pull/18432 1. Add a table to show the supportability of schema types for language-specific function instances 2. Add a lin

[GitHub] [pulsar-client-python] RobertIndie commented on issue #107: [feature request] Support Dead Letter Topic

2023-03-21 Thread via GitHub
RobertIndie commented on issue #107: URL: https://github.com/apache/pulsar-client-python/issues/107#issuecomment-1478882308 This is a duplicate of https://github.com/apache/pulsar-client-python/issues/98 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar-client-python] RobertIndie closed issue #107: [feature request] Support Dead Letter Topic

2023-03-21 Thread via GitHub
RobertIndie closed issue #107: [feature request] Support Dead Letter Topic URL: https://github.com/apache/pulsar-client-python/issues/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] tisonkun commented on issue #19877: [Doc] Add API doc for the C# client

2023-03-21 Thread via GitHub
tisonkun commented on issue #19877: URL: https://github.com/apache/pulsar/issues/19877#issuecomment-1478866391 I suggest we pull dotpulsar authors @entvex @blankensteiner for comments and helps :) I'm unfamiliar with C# API doc generation yet. -- This is an automated message from t

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
Technoboy- commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144186547 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1165,8 +1165,14 @@ public CompletableFuture checkTopicOwnership(Top

[GitHub] [pulsar] NiuBlibing opened a new issue, #19886: Metrics: seperate topic-partion into topic and partion

2023-03-21 Thread via GitHub
NiuBlibing opened a new issue, #19886: URL: https://github.com/apache/pulsar/issues/19886 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation `pulsar_msg_backlog` is use tag with

[GitHub] [pulsar] Anonymitaet commented on issue #19876: [Doc] Add API doc for NodeJS client

2023-03-21 Thread via GitHub
Anonymitaet commented on issue #19876: URL: https://github.com/apache/pulsar/issues/19876#issuecomment-1478859322 Similar to https://github.com/apache/pulsar/issues/19877#issuecomment-1478858980 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] Anonymitaet commented on issue #19877: [Doc] Add API doc for the C# client

2023-03-21 Thread via GitHub
Anonymitaet commented on issue #19877: URL: https://github.com/apache/pulsar/issues/19877#issuecomment-1478858980 I've discussed with @RobertIndie, to resolve this issue, we need to finish the following tasks: 1. Generate the API reference doc. We want to generate C# client

[pulsar-site] branch main updated: [feat][doc] Add new configs `skipToLatest` and `compressionType` (#461)

2023-03-21 Thread junma
This is an automated email from the ASF dual-hosted git repository. junma pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 618cfca710c [feat][doc] Add new configs `skipToL

[GitHub] [pulsar-site] momo-jun merged pull request #461: [feat][doc] Add new configs `skipToLatest` and `compressionType`

2023-03-21 Thread via GitHub
momo-jun merged PR #461: URL: https://github.com/apache/pulsar-site/pull/461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
Demogorgon314 commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144182522 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1165,8 +1165,14 @@ public CompletableFuture checkTopicOwnership(

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
Demogorgon314 commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144182109 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl getNamespaceClient(C

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
Technoboy- commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144181575 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1165,8 +1165,14 @@ public CompletableFuture checkTopicOwnership(Top

[GitHub] [pulsar] poorbarcode closed pull request #19825: [fix] [ml] make the result of delete cursor is success if cursor is deleted

2023-03-21 Thread via GitHub
poorbarcode closed pull request #19825: [fix] [ml] make the result of delete cursor is success if cursor is deleted URL: https://github.com/apache/pulsar/pull/19825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] poorbarcode commented on pull request #19841: [fix] [broker] fix infinite HTTP call getSubscriptions caused by wrong topicName

2023-03-21 Thread via GitHub
poorbarcode commented on PR #19841: URL: https://github.com/apache/pulsar/pull/19841#issuecomment-1478851084 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar-site] tisonkun opened a new pull request, #485: Add issue triaging doc

2023-03-21 Thread via GitHub
tisonkun opened a new pull request, #485: URL: https://github.com/apache/pulsar-site/pull/485 ### Documentation - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar-site] Anonymitaet commented on pull request #475: [improve][doc] Add broker level metrics statistics and expose to prometheus

2023-03-21 Thread via GitHub
Anonymitaet commented on PR #475: URL: https://github.com/apache/pulsar-site/pull/475#issuecomment-1478843659 ping @congbobo184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pulsar-client-go] shibd merged pull request #996: [fix]: Fix panic caused by retryAssert()

2023-03-21 Thread via GitHub
shibd merged PR #996: URL: https://github.com/apache/pulsar-client-go/pull/996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[pulsar-client-go] branch master updated: fix: fix retryAssert (#996)

2023-03-21 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 6c3ee77 fix: fix retryAssert (#996) 6c

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
heesung-sn commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144168023 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl getNamespaceClient(Clus

[pulsar-site] branch main updated: Fix docker compose example to work with 0 errors (#441)

2023-03-21 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new db695a43ebd Fix docker compose example to work w

[GitHub] [pulsar-site] tisonkun merged pull request #441: Fix docker compose example to work with 0 errors

2023-03-21 Thread via GitHub
tisonkun merged PR #441: URL: https://github.com/apache/pulsar-site/pull/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19851: [improve][broker] PIP-192: Support delete namespace bundle admin API

2023-03-21 Thread via GitHub
Demogorgon314 commented on code in PR #19851: URL: https://github.com/apache/pulsar/pull/19851#discussion_r1144159792 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -1445,23 +1451,44 @@ public PulsarClientImpl getNamespaceClient(C

[GitHub] [pulsar-site] tisonkun commented on pull request #441: Fix docker compose example to work with 0 errors

2023-03-21 Thread via GitHub
tisonkun commented on PR #441: URL: https://github.com/apache/pulsar-site/pull/441#issuecomment-1478826036 Merging... Thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar-site] branch main updated: [feat] Add canonical link for SEO (#481)

2023-03-21 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new a14ce8e53ab [feat] Add canonical link for SEO (#

[GitHub] [pulsar] tisonkun closed issue #18190: [Bug] It's hard to find latest docs using search engines like Google

2023-03-21 Thread via GitHub
tisonkun closed issue #18190: [Bug] It's hard to find latest docs using search engines like Google URL: https://github.com/apache/pulsar/issues/18190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-site] tisonkun merged pull request #481: [feat] Add canonical link for SEO

2023-03-21 Thread via GitHub
tisonkun merged PR #481: URL: https://github.com/apache/pulsar-site/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar-site] tisonkun commented on pull request #481: [feat] Add canonical link for SEO

2023-03-21 Thread via GitHub
tisonkun commented on PR #481: URL: https://github.com/apache/pulsar-site/pull/481#issuecomment-1478824626 Merging... Let's see if it helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-python] shibd commented on issue #79: [Feature request] New consumer type: TableView

2023-03-21 Thread via GitHub
shibd commented on issue #79: URL: https://github.com/apache/pulsar-client-python/issues/79#issuecomment-1478819404 We need to wait for the CPP client release first, then wrap it on the Python side. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] github-actions[bot] commented on issue #19210: [Bug] BacklogQuota not being enforced when it should be

2023-03-21 Thread via GitHub
github-actions[bot] commented on issue #19210: URL: https://github.com/apache/pulsar/issues/19210#issuecomment-1478814285 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#30d2469)

2023-03-21 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 7b5937a1999 Docs sync done from apache/pulsar (

[GitHub] [pulsar] jiangpengcheng opened a new issue, #19885: [Bug] Function Java Instance failed to infer type class name

2023-03-21 Thread via GitHub
jiangpengcheng opened a new issue, #19885: URL: https://github.com/apache/pulsar/issues/19885 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.11.0 ### Minimal reproduce

[GitHub] [pulsar] rdhabalia opened a new pull request, #19884: [fix][cli] Fix logging noise while admin tool exit

2023-03-21 Thread via GitHub
rdhabalia opened a new pull request, #19884: URL: https://github.com/apache/pulsar/pull/19884 ### Motivation Pulsar admin tool unnecessary logs noise while existing the process which gives bad user experience and should be removed. ``` ./bin/pulsar-admin topics list test1/test2

[GitHub] [pulsar] heesung-sn commented on pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-21 Thread via GitHub
heesung-sn commented on PR #19813: URL: https://github.com/apache/pulsar/pull/19813#issuecomment-1478776148 Rebase is done. Please continue the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-21 Thread via GitHub
heesung-sn commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1144124188 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedderTest.java: ## @@ -134,25 +143,29 @@ public void init() throw

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19813: [improve][broker] PIP-192 Improved Auto Unload Logic

2023-03-21 Thread via GitHub
heesung-sn commented on code in PR #19813: URL: https://github.com/apache/pulsar/pull/19813#discussion_r1144124111 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedderTest.java: ## @@ -567,8 +616,7 @@ private void setIsolation

[pulsar] branch branch-2.11 updated: [fix][io] KCA sink: handle null values with KeyValue schema (#19861)

2023-03-21 Thread ayegorov
This is an automated email from the ASF dual-hosted git repository. ayegorov pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 71b4239872e [fix][io] KCA sink: hand

[pulsar-site] branch main updated: [improve][doc] Add go client configs (#479)

2023-03-21 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new e1db8962aae [improve][doc] Add go client configs

[GitHub] [pulsar-site] Anonymitaet merged pull request #479: [improve][doc] Add go client configs

2023-03-21 Thread via GitHub
Anonymitaet merged PR #479: URL: https://github.com/apache/pulsar-site/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[GitHub] [pulsar] rdhabalia commented on a diff in pull request #19605: [feat] [broker] PIP-188 support blue-green cluster migration [part-2]

2023-03-21 Thread via GitHub
rdhabalia commented on code in PR #19605: URL: https://github.com/apache/pulsar/pull/19605#discussion_r1144077244 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java: ## @@ -1574,13 +1575,19 @@ private void buildProducerAndAddTopic(Topic topic, long p

[GitHub] [pulsar] vineeth1995 commented on pull request #19605: [feat] [broker] PIP-188 support blue-green cluster migration [part-2]

2023-03-21 Thread via GitHub
vineeth1995 commented on PR #19605: URL: https://github.com/apache/pulsar/pull/19605#issuecomment-1478713403 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] rdhabalia opened a new pull request, #19883: [improve][cli] topic offline internal-info provide schema ledger info

2023-03-21 Thread via GitHub
rdhabalia opened a new pull request, #19883: URL: https://github.com/apache/pulsar/pull/19883 ### Motivation There are many cases when a broker is not able to load the topic successfully and it requires examining the metadata of topic/schema/managed-ledger etc for example: https://g

[GitHub] [pulsar] rdhabalia opened a new pull request, #19882: [fix][broker] Fix broker is not able to load topic with broken schema ledger

2023-03-21 Thread via GitHub
rdhabalia opened a new pull request, #19882: URL: https://github.com/apache/pulsar/pull/19882 ### Motivation If due to any operation reason if schema ledger metadata gets deleted then broker is not able to handle that non-recoverable error and not able to load the topic. So, if one o

[GitHub] [pulsar] michaeljmarshall commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-21 Thread via GitHub
michaeljmarshall commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1478690347 For future reference, I checked out some implementations, and below are the claims sections of the JWT created when you specify the expiration and not the audience.

[GitHub] [pulsar] michaeljmarshall commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-21 Thread via GitHub
michaeljmarshall commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1478660624 While testing this out in Azure, I discovered that the azure provider requires authentication to retrieve the public keys while AWS does not. That will mean we need to modi

[GitHub] [pulsar-adapters] swamymavuri commented on a diff in pull request #46: [Issue #45] [pulsar-client-kafka-compat] Handled Kafka record headers…

2023-03-21 Thread via GitHub
swamymavuri commented on code in PR #46: URL: https://github.com/apache/pulsar-adapters/pull/46#discussion_r1144033792 ## pulsar-client-kafka-compat/pulsar-client-kafka/src/test/java/org/apache/kafka/clients/producer/PulsarKafkaProducerTest.java: ## @@ -246,7 +248,13 @@ public v

[GitHub] [pulsar] michaeljmarshall commented on issue #19771: PIP-257: Add Open ID Connect Support to Server Components

2023-03-21 Thread via GitHub
michaeljmarshall commented on issue #19771: URL: https://github.com/apache/pulsar/issues/19771#issuecomment-1478598921 Note: for functions, they will use the `SerializableURITokenSupplier` for the `AuthenticationProviderToken`. This supplier is automatically used when the `file:` prefix sta

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #11592: [fix][broker] cut consumer connection on markDeleteFailed

2023-03-21 Thread via GitHub
michaeljmarshall commented on code in PR #11592: URL: https://github.com/apache/pulsar/pull/11592#discussion_r1143953299 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java: ## @@ -458,10 +458,10 @@ public void markDeleteComplet

[GitHub] [pulsar] michaeljmarshall commented on issue #19866: Verify at least one URL is present for cluster creation

2023-03-21 Thread via GitHub
michaeljmarshall commented on issue #19866: URL: https://github.com/apache/pulsar/issues/19866#issuecomment-1478425788 Sure, thanks @niharrathod -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] niharrathod commented on issue #19866: Verify at least one URL is present for cluster creation

2023-03-21 Thread via GitHub
niharrathod commented on issue #19866: URL: https://github.com/apache/pulsar/issues/19866#issuecomment-1478335242 I can take up this. Could you please assign this to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-client-python] said-acn commented on issue #73: [Feature] PIP 23: Message Tracing By Interceptors

2023-03-21 Thread via GitHub
said-acn commented on issue #73: URL: https://github.com/apache/pulsar-client-python/issues/73#issuecomment-1478327140 Any updates on this now that https://github.com/apache/pulsar-client-cpp/issues/150 has been merged? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pulsar-client-cpp] thps opened a new issue, #227: [Bug] Getting ConnectError when expecting AuthenticationError

2023-03-21 Thread via GitHub
thps opened a new issue, #227: URL: https://github.com/apache/pulsar-client-cpp/issues/227 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version pulsar-all image version 2.10.32 and p

[GitHub] [pulsar] thps opened a new issue, #19881: [Bug] Getting ConnectError when expecting AuthenticationError

2023-03-21 Thread via GitHub
thps opened a new issue, #19881: URL: https://github.com/apache/pulsar/issues/19881 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version pulsar-all image version 2.10.32 and pulsar-a

[GitHub] [pulsar] niharrathod commented on pull request #19842: [fix][test] : PulsarStandaloneTest.testMetadataInitialization

2023-03-21 Thread via GitHub
niharrathod commented on PR #19842: URL: https://github.com/apache/pulsar/pull/19842#issuecomment-1478281408 @tisonkun : Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pulsar] rdhabalia commented on a diff in pull request #19867: [improve][client] add additional logging and stacktrace client encryption failure

2023-03-21 Thread via GitHub
rdhabalia commented on code in PR #19867: URL: https://github.com/apache/pulsar/pull/19867#discussion_r1143698582 ## pulsar-client-messagecrypto-bc/src/main/java/org/apache/pulsar/client/impl/crypto/MessageCryptoBc.java: ## @@ -314,7 +314,7 @@ private void addPublicKeyCipher(Str

[GitHub] [pulsar-site] tisonkun merged pull request #484: [improve][ci] Tidy workflow

2023-03-21 Thread via GitHub
tisonkun merged PR #484: URL: https://github.com/apache/pulsar-site/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar-site] branch main updated: [improve][ci] Tidy workflow (#484)

2023-03-21 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 26af4568413 [improve][ci] Tidy workflow (#484) 2

[GitHub] [pulsar-site] tisonkun opened a new pull request, #484: [improve][ci] Tidy workflow

2023-03-21 Thread via GitHub
tisonkun opened a new pull request, #484: URL: https://github.com/apache/pulsar-site/pull/484 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] cbornet commented on pull request #18995: [fix][broker] forbid uploading BYTES schema with admin API

2023-03-21 Thread via GitHub
cbornet commented on PR #18995: URL: https://github.com/apache/pulsar/pull/18995#issuecomment-1478185222 This is a breaking change. It broke the Flink SQL Connector : https://github.com/streamnative/flink/issues/270 -- This is an automated message from the Apache Git Service. To respon

[pulsar-site] branch main updated: [improve] Add robots.txt file (#483)

2023-03-21 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new ae49f2fb4f3 [improve] Add robots.txt file (#483)

[GitHub] [pulsar] tisonkun closed issue #19107: [Doc] Add robots.txt to the pulsar site

2023-03-21 Thread via GitHub
tisonkun closed issue #19107: [Doc] Add robots.txt to the pulsar site URL: https://github.com/apache/pulsar/issues/19107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-site] tisonkun merged pull request #483: [improve] Add robots.txt file

2023-03-21 Thread via GitHub
tisonkun merged PR #483: URL: https://github.com/apache/pulsar-site/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar-site] tisonkun commented on pull request #483: [improve] Add robots.txt file

2023-03-21 Thread via GitHub
tisonkun commented on PR #483: URL: https://github.com/apache/pulsar-site/pull/483#issuecomment-1478124494 Merging... Further improvement can be follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] nodece commented on issue #19856: Update jaxb and jax-rs libs

2023-03-21 Thread via GitHub
nodece commented on issue #19856: URL: https://github.com/apache/pulsar/issues/19856#issuecomment-1478102538 BTW, the admin still needs compatible with the JDK 8, so `javax.xml.bind:jaxb-api:2.3.1` needs to be fixed into shaded. -- This is an automated message from the Apache

[GitHub] [pulsar] nodece commented on pull request #19797: [cleanup][proxy] Remove authorization config

2023-03-21 Thread via GitHub
nodece commented on PR #19797: URL: https://github.com/apache/pulsar/pull/19797#issuecomment-1478084803 > Does passing unknown key-value pairs cause fatal? I'm afraid that users will continue using existing conf file that contains now removed key value pair. No impact. Users can conti

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19875: [fix][broker] Fix NPE when update topic policy.

2023-03-21 Thread via GitHub
Technoboy- commented on code in PR #19875: URL: https://github.com/apache/pulsar/pull/19875#discussion_r1143554558 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java: ## @@ -240,7 +240,9 @@ protected void updateTopicPolicy(TopicPolicies data) {

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18995: [fix][broker] forbid uploading BYTES schema with admin API

2023-03-21 Thread via GitHub
michaeljmarshall commented on code in PR #18995: URL: https://github.com/apache/pulsar/pull/18995#discussion_r1143544262 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java: ## @@ -114,6 +114,10 @@ public CompletableFuture deleteSchemaAsy

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18995: [fix][broker] forbid uploading BYTES schema with admin API

2023-03-21 Thread via GitHub
michaeljmarshall commented on code in PR #18995: URL: https://github.com/apache/pulsar/pull/18995#discussion_r1143544262 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java: ## @@ -114,6 +114,10 @@ public CompletableFuture deleteSchemaAsy

[GitHub] [pulsar] michaeljmarshall commented on issue #19429: Make Java Client Authentication Asynchronous

2023-03-21 Thread via GitHub
michaeljmarshall commented on issue #19429: URL: https://github.com/apache/pulsar/issues/19429#issuecomment-1478004552 We could make a PIP, though I don't have time to work on it right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] michaeljmarshall commented on pull request #19832: [fix][misc] Change PIP issue template

2023-03-21 Thread via GitHub
michaeljmarshall commented on PR #19832: URL: https://github.com/apache/pulsar/pull/19832#issuecomment-1478002193 > Regarding stateStore, you're basically saying they didn't take into consideration the security aspects of multi-tenancy, since that interface allows consuming any state by any

[GitHub] [pulsar] relief-melone edited a discussion: Should Kafka Source Connector itsself after unrecoverable error?

2023-03-21 Thread GitBox
GitHub user relief-melone edited a discussion: Should Kafka Source Connector itsself after unrecoverable error? This is concerning the pulsar-io/kafka-source. Before I create an issue regarding this topic I would like to have some insight if the current behaviour is actually wrong or if there

[GitHub] [pulsar] poorbarcode closed pull request #19452: [branch-2.10] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors

2023-03-21 Thread via GitHub
poorbarcode closed pull request #19452: [branch-2.10] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors URL: https://github.com/apache/pulsar/pull/19452 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] poorbarcode commented on pull request #19825: [fix] [ml] make the result of delete cursor is success if cursor is deleted

2023-03-21 Thread via GitHub
poorbarcode commented on PR #19825: URL: https://github.com/apache/pulsar/pull/19825#issuecomment-1477975735 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19858: [fix] [cli] Release the orphan producers after the primary consumer is closed

2023-03-21 Thread via GitHub
poorbarcode commented on code in PR #19858: URL: https://github.com/apache/pulsar/pull/19858#discussion_r1143503506 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -1050,7 +1050,19 @@ public CompletableFuture closeAsync() { });

[pulsar] branch master updated: [improve][broker] PIP-192 Excluded bundles with isolation policy or anti-affinity-group policy from topk load bundles (#19742)

2023-03-21 Thread kwang
This is an automated email from the ASF dual-hosted git repository. kwang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 30d2469086f [improve][broker] PIP-192 Excluded bu

[GitHub] [pulsar] Demogorgon314 merged pull request #19742: [improve][broker] PIP-192 Excluded bundles with isolation policy or anti-affinity-group policy from topk load bundles

2023-03-21 Thread via GitHub
Demogorgon314 merged PR #19742: URL: https://github.com/apache/pulsar/pull/19742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar-client-cpp] BewareMyPower commented on issue #163: [feature request] Client support set ServiceUrlProvider

2023-03-21 Thread via GitHub
BewareMyPower commented on issue #163: URL: https://github.com/apache/pulsar-client-cpp/issues/163#issuecomment-1477931961 From the discussion in https://github.com/apache/pulsar-client-cpp/pull/170 and https://lists.apache.org/thread/cojz6qxpc7v0j8vy0w476ttt0f89zr3z, we decide not to impl

[GitHub] [pulsar-client-cpp] BewareMyPower closed issue #163: [feature request] Client support set ServiceUrlProvider

2023-03-21 Thread via GitHub
BewareMyPower closed issue #163: [feature request] Client support set ServiceUrlProvider URL: https://github.com/apache/pulsar-client-cpp/issues/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new issue, #226: [Feature Request] OAuth key file base64 support

2023-03-21 Thread via GitHub
BewareMyPower opened a new issue, #226: URL: https://github.com/apache/pulsar-client-cpp/issues/226 Currently the `private_key` field in the JSON param string of the OAuth2 authentication can only represent the file path to the credential file. We should support configuring a URL for base64

[GitHub] [pulsar-client-python] BewareMyPower opened a new issue, #107: [feature request] Support Dead Letter Topic

2023-03-21 Thread via GitHub
BewareMyPower opened a new issue, #107: URL: https://github.com/apache/pulsar-client-python/issues/107 The C++ client has already implemented the dead letter topic since https://github.com/apache/pulsar-client-cpp/pull/139, which is included in the 3.2.0 release. We should support dead lett

[GitHub] [pulsar-client-cpp] BewareMyPower commented on issue #77: [feature request] C++ and Python client support Dead Letter Topic

2023-03-21 Thread via GitHub
BewareMyPower commented on issue #77: URL: https://github.com/apache/pulsar-client-cpp/issues/77#issuecomment-1477900306 Close it by #139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar-client-cpp] BewareMyPower closed issue #77: [feature request] C++ and Python client support Dead Letter Topic

2023-03-21 Thread via GitHub
BewareMyPower closed issue #77: [feature request] C++ and Python client support Dead Letter Topic URL: https://github.com/apache/pulsar-client-cpp/issues/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] tisonkun merged pull request #19842: [fix][test] : PulsarStandaloneTest.testMetadataInitialization

2023-03-21 Thread via GitHub
tisonkun merged PR #19842: URL: https://github.com/apache/pulsar/pull/19842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[pulsar] branch master updated (905e8ef730c -> a50ecda11f9)

2023-03-21 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 905e8ef730c [improve][meta] Make session notification to be async. (#19869) add a50ecda11f9 [fix][test] PulsarSt

[GitHub] [pulsar] tisonkun closed issue #19838: Flaky-test: PulsarStandaloneTest.testMetadataInitialization

2023-03-21 Thread via GitHub
tisonkun closed issue #19838: Flaky-test: PulsarStandaloneTest.testMetadataInitialization URL: https://github.com/apache/pulsar/issues/19838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] tisonkun commented on pull request #19842: [fix][test] : PulsarStandaloneTest.testMetadataInitialization

2023-03-21 Thread via GitHub
tisonkun commented on PR #19842: URL: https://github.com/apache/pulsar/pull/19842#issuecomment-1477891180 Thanks for your contribution @niharrathod! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

  1   2   >