Re: [PR] Test with k8s 1.32.2 and upgrade tool versions used in CI [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari merged PR #587: URL: https://github.com/apache/pulsar-helm-chart/pull/587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

Re: [PR] [improve][monitor] Add version=0.0.4 to /metrics content type for Prometheus 3.x compatibility [pulsar]

2025-03-05 Thread via GitHub
lhotari merged PR #24060: URL: https://github.com/apache/pulsar/pull/24060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated: [improve][monitor] Add version=0.0.4 to /metrics content type for Prometheus 3.x compatibility (#24060)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3f4515476a5 [improve][monitor] Add version=0.0.

Re: [PR] Use BookKeeper BP-29 metadataServiceUri to configure bookie metadata store, also when using Zookeeper [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari merged PR #585: URL: https://github.com/apache/pulsar-helm-chart/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

[PR] Test with k8s 1.32.2 and upgrade tool versions used in CI [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari opened a new pull request, #587: URL: https://github.com/apache/pulsar-helm-chart/pull/587 ### Motivation - keep up-to-date with k8s and tool version upgrades ### Modifications - kind 0.22.0 -> 0.27.0 - test with k8s 1.32.2 instead of 1.29.2 to ensure c

Re: [PR] Add Broker Cache and Sockets dashboards [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari merged PR #586: URL: https://github.com/apache/pulsar-helm-chart/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

(pulsar-helm-chart) branch master updated: Use BookKeeper BP-29 metadataServiceUri to configure bookie metadata store, also when using Zookeeper (#585)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 80999ff Use BookKeeper BP-29 metada

[PR] Use BookKeeper BP-29 metadataServiceUri to configure bookie metadata store, also when using Zookeeper [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari opened a new pull request, #585: URL: https://github.com/apache/pulsar-helm-chart/pull/585 ### Motivation * `zkServers` and `zkLedgersRootPath` have been deprecated since BookKeeper 4.7.0 release in 2018 ### Modifications * use `metadataServiceUri` to configure b

Re: [PR] [improve][monitor] Add version=0.0.4 to /metrics content type for Prometheus 3.x compatibility [pulsar]

2025-03-05 Thread via GitHub
codecov-commenter commented on PR #24060: URL: https://github.com/apache/pulsar/pull/24060#issuecomment-2702915496 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24060?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
gaoran10 commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982735349 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries, long

Re: [D] DNS [pulsar]

2025-03-05 Thread via GitHub
GitHub user sindhushreem25 added a comment to the discussion: DNS @lhotari with 4.0.3 client also we are seeing same behaviour . i have added the logs and sample program in the gist . GitHub link: https://github.com/apache/pulsar/discussions/24030#discussioncomment-12409454 This is

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982674766 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries,

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982659601 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries,

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982654770 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries,

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982654770 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries,

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982654770 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries,

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982654770 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3811,12 +3811,11 @@ public int applyMaxSizeCap(int maxEntries,

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
BewareMyPower commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982640666 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java: ## @@ -5206,44 +5206,52 @@ public void testEstimateEntryCountBySize()

(pulsar-site) branch dependabot/pip/tools/pytools/jinja2-3.1.6 created (now 64398adeae5)

2025-03-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/tools/pytools/jinja2-3.1.6 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 64398adeae5 Bump jinja2 from 3.1.4 to 3.1.6 in /tools/pytools No new revi

[PR] Bump jinja2 from 3.1.4 to 3.1.6 in /tools/pytools [pulsar-site]

2025-03-05 Thread via GitHub
dependabot[bot] opened a new pull request, #993: URL: https://github.com/apache/pulsar-site/pull/993 Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.6. Release notes Sourced from https://github.com/pallets/jinja/releases";>jinja2's releases. 3.1.6 This i

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
gaoran10 commented on PR #24055: URL: https://github.com/apache/pulsar/pull/24055#issuecomment-2702684945 > Just wondering how it could the result could exceed Integer.MAX_VALUE so that the integer value becomes negative in the current logic. Is it the line result += remainEntriesOfLedger;

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
gaoran10 commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982621617 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSiz

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
gaoran10 commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982621617 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSiz

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
gaoran10 commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982611559 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSiz

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
gaoran10 commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1982611559 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSiz

[PR] Add release note for Python client 3.6.1 [pulsar-site]

2025-03-05 Thread via GitHub
BewareMyPower opened a new pull request, #992: URL: https://github.com/apache/pulsar-site/pull/992 ### ✅ Contribution Checklist - [x] I read the [contribution guide](https://pulsar.apache.org/contribute/document-contribution/) https://github.com/user-attachments/assets/

(pulsar-site) branch release-note-python-3.6.1 created (now fbc21621fec)

2025-03-05 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch release-note-python-3.6.1 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at fbc21621fec Add release note for Python client 3.6.1 This branch includes the following new comm

(pulsar-site) 01/01: Add release note for Python client 3.6.1

2025-03-05 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch release-note-python-3.6.1 in repository https://gitbox.apache.org/repos/asf/pulsar-site.git commit fbc21621fec488f46d3cbbf9b9d212000ef5c8e4 Author: Yunze Xu AuthorDate: Thu Mar 6 10:48:55 2025 +0800

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1982577598 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2303,8 +2305,13 @@ private CompletableFuture> initDeadLetterProducerIfNeeded

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1982547732 ## pip/pip-409.md: ## @@ -33,25 +33,88 @@ retry/dead letter topic. ## Design & Implementation Details -- Add two new configurations in `DeadLetterPolicy`: +- A

(pulsar) 06/06: [improve] Upgrade Netty to 4.1.119.Final (#24049)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 8efc7e2438aa3af42899a0f0860471dd9cabbbcb Author: Lari Hotari AuthorDate: Tue Mar 4 13:18:48 2025 +0200 [improv

[I] 3.6.0 release was removed from PyPi [pulsar-client-python]

2025-03-05 Thread via GitHub
alexrosenfeld10 opened a new issue, #247: URL: https://github.com/apache/pulsar-client-python/issues/247 Why was this release removed? It broke a bunch of CI / users for me. Upgrading to 3.6.1 works fine, but everything was just spontaneously broken for a bit. -- This is an automated mes

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages [pulsar]

2025-03-05 Thread via GitHub
lhotari merged PR #24059: URL: https://github.com/apache/pulsar/pull/24059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated (0cc266d54d6 -> 8303b96c4d4)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 0cc266d54d6 [improve][broker] Support showing client ip address in client stats while using reverse proxy (#23974)

Re: [I] [Bug] message eventtime is reset to 0 on reconsumeLater [pulsar]

2025-03-05 Thread via GitHub
lhotari closed issue #24053: [Bug] message eventtime is reset to 0 on reconsumeLater URL: https://github.com/apache/pulsar/issues/24053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] Discarding Corrupt Message due to apparent decompression failure [pulsar-client-go]

2025-03-05 Thread via GitHub
frankjkelly commented on issue #1331: URL: https://github.com/apache/pulsar-client-go/issues/1331#issuecomment-2701816941 @RobertIndie we are using `CompressionType.LZ4` We have other services consuming the same data that are in Java and they do not report any errors. We gauge it

Re: [I] [Bug] Error while producing messages [pulsar]

2025-03-05 Thread via GitHub
dao-jun commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-2701763543 > Any solution to this? Getting this intermittently. Java Client Version: 3.0.4 Server Version: 3.0.4 Try to upgrade broker and client version, I heard this issue in the early

Re: [PR] [improve][pip] PIP-404: Introduce per ledger properties [pulsar]

2025-03-05 Thread via GitHub
dao-jun commented on PR #23837: URL: https://github.com/apache/pulsar/pull/23837#issuecomment-2701740071 This PIP is approved with 3 bindings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages [pulsar]

2025-03-05 Thread via GitHub
codecov-commenter commented on PR #24059: URL: https://github.com/apache/pulsar/pull/24059#issuecomment-2701635706 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24059?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] [improve][metrics] Add version=0.0.4 to /metrics content type for Prometheus 3.x compatibility [pulsar]

2025-03-05 Thread via GitHub
lhotari opened a new pull request, #24060: URL: https://github.com/apache/pulsar/pull/24060 ### Motivation Prometheus 3.x requires explicit version information in the content type header when scraping metrics. Without this change, Prometheus 3.x would not be able to properly scrape m

(pulsar-site) branch main updated: Update 3.3.5 and 4.0.3 release notes and mention the potential regression.

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 3ef9d1193b1 Update 3.3.5 and 4.0.3 release not

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on PR #24055: URL: https://github.com/apache/pulsar/pull/24055#issuecomment-2701410663 > The estimated entry count may be a negative value in some cases, then the read operation will get an empty result. @gaoran10 Just wondering how it could result could exceed `Int

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1981725310 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSize

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1981719682 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSize

Re: [PR] [fix][ml] Avoid NPE when getCurrentLedger() returns null [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on PR #24058: URL: https://github.com/apache/pulsar/pull/24058#issuecomment-2701362955 Closing this PR since @poorbarcode will create a new PR addressing the root cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [fix][ml] Avoid NPE when getCurrentLedger() returns null [pulsar]

2025-03-05 Thread via GitHub
lhotari closed pull request #24058: [fix][ml] Avoid NPE when getCurrentLedger() returns null URL: https://github.com/apache/pulsar/pull/24058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [fix] Avoid negative estimated entry count [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24055: URL: https://github.com/apache/pulsar/pull/24055#discussion_r1981719682 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3855,7 +3854,8 @@ static long estimateEntryCountBySize(long bytesSize

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24059: URL: https://github.com/apache/pulsar/pull/24059#discussion_r1981635232 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -824,6 +826,13 @@ private MessageImpl getMessageImpl(Message message) {

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24059: URL: https://github.com/apache/pulsar/pull/24059#discussion_r1981631250 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -824,6 +826,13 @@ private MessageImpl getMessageImpl(Message message) {

(pulsar) 02/04: [fix][broker] Add expire check for replicator (#23975)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 40ee0ceb9d8882377f8bc97e32aee803a4e022e9 Author: Zixuan Liu AuthorDate: Fri Feb 28 23:20:03 2025 +0800 [fix][b

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
SantanuKar43 commented on code in PR #24059: URL: https://github.com/apache/pulsar/pull/24059#discussion_r1981614372 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -824,6 +826,13 @@ private MessageImpl getMessageImpl(Message message) {

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
SantanuKar43 commented on code in PR #24059: URL: https://github.com/apache/pulsar/pull/24059#discussion_r1981594016 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -824,6 +826,13 @@ private MessageImpl getMessageImpl(Message message) {

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24059: URL: https://github.com/apache/pulsar/pull/24059#discussion_r1981576337 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -824,6 +826,13 @@ private MessageImpl getMessageImpl(Message message) {

(pulsar) 05/06: [fix][doc] Workaround Go Yaml issue go-yaml/yaml#789 in docker-compose example (#24040)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d4470a9271ce4325f09db42f2f79a8e26f625c5b Author: Lari Hotari AuthorDate: Mon Mar 3 21:05:58 2025 +0200 [fix][d

Re: [I] Please update the rocksdbjni jar to 9.6.1 [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on issue #23402: URL: https://github.com/apache/pulsar/issues/23402#issuecomment-2701141766 Latest progress update: https://github.com/apache/bookkeeper/pull/4422#issuecomment-2701140067 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
github-actions[bot] commented on PR #24059: URL: https://github.com/apache/pulsar/pull/24059#issuecomment-2700917406 @SantanuKar43 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [

Re: [PR] [fix][ml] Avoid NPE when getCurrentLedger() returns null [pulsar]

2025-03-05 Thread via GitHub
codecov-commenter commented on PR #24058: URL: https://github.com/apache/pulsar/pull/24058#issuecomment-2701056250 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24058?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

(pulsar) 03/06: [fix][broker] Fix missing validation when setting retention policy on topic level (#24032)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit d1603ad1f60b0a58f3adeb729dc86bdcf0dd40aa Author: Hao Zhang AuthorDate: Mon Mar 3 09:42:59 2025 +0800 [fix][bro

(pulsar) 04/04: [fix][broker] Fix missing validation when setting retention policy on topic level (#24032)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 50d896730eed3dfe69a54e14da5a950b1f82c0c8 Author: Hao Zhang AuthorDate: Mon Mar 3 09:42:59 2025 +0800 [fix][bro

(pulsar) 01/06: [fix][doc] fix doc related to chunk message feature. (#24023)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 9b71d5f47567eb5d69e5b0972a57aee2a8d4010d Author: Wenzhi Feng <52550727+thetumb...@users.noreply.github.com> AuthorDa

[PR] [fix][client] Copy eventTime to retry letter topic and DLQ messages #1 [pulsar]

2025-03-05 Thread via GitHub
SantanuKar43 opened a new pull request, #24059: URL: https://github.com/apache/pulsar/pull/24059 Fixes #24053 ### Motivation See #24053 ### Modifications copy eventTime to messages sent to retry letter topic and DLQ

Re: [PR] [fix][ml] Avoid NPE when getCurrentLedger() returns null [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on PR #24058: URL: https://github.com/apache/pulsar/pull/24058#issuecomment-2700890339 It seems that `currentLedger` could be null immediately after the ledger has been created, but not after that. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [fix][ml] Avoid NPE when getCurrentLedger() returns null [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on PR #24058: URL: https://github.com/apache/pulsar/pull/24058#issuecomment-2700878748 @poorbarcode In branch-3.0, there are at least 2 tests where this can be seen in the output. org.apache.pulsar.broker.service.ClusterMigrationTest#testClusterMigration is one. The is

Re: [I] [Bug] PR Checks are failing on branch-3.0 [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on issue #24038: URL: https://github.com/apache/pulsar/issues/24038#issuecomment-2700858515 I created #24058 to address the NPE in estimateEntryCountBySize -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(pulsar) branch branch-3.0 updated: Fix presto LICENSE after Netty 4.1.119.Final upgrade

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new ebce3b07eda Fix presto LICENSE after Ne

(pulsar) 03/04: [improve] Upgrade Netty to 4.1.119.Final (#24049)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 92cbc936b6f604bc924de26a9366c90eb057b418 Author: Lari Hotari AuthorDate: Tue Mar 4 13:18:48 2025 +0200 [improv

(pulsar) branch branch-3.0 updated (8437af98eb7 -> 6201525192c)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 8437af98eb7 Bump version to next snapshot version add 5f7e4d22ba3 [fix][doc] fix doc related to chunk messag

(pulsar) branch branch-4.0 updated (2f3dde60d83 -> 8efc7e2438a)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 2f3dde60d83 Bump version to next snapshot version new 9b71d5f4756 [fix][doc] fix doc related to chunk messag

(pulsar) 02/06: [fix][broker] Add expire check for replicator (#23975)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 0b8d24917e692d714e47dd93c914b8a62530d54a Author: Zixuan Liu AuthorDate: Fri Feb 28 23:20:03 2025 +0800 [fix][b

(pulsar) 01/04: [fix][doc] fix doc related to chunk message feature. (#24023)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit dab8744071acff5ac9e85bdd708a9e4c1787411c Author: Wenzhi Feng <52550727+thetumb...@users.noreply.github.com> AuthorDa

(pulsar) branch branch-3.3 updated (d8b8e7af53c -> 50d896730ee)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git from d8b8e7af53c Bump version to next snapshot version new dab8744071a [fix][doc] fix doc related to chunk messag

(pulsar) 04/06: [fix][broker] fix delay queue sequence issue. (#24035)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-4.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit addae4be6aa63a2e6a66e3b6d871cced4e28702e Author: Wenzhi Feng <52550727+thetumb...@users.noreply.github.com> AuthorDa

Re: [I] No data shown in Grafana Dashboards [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari closed issue #468: No data shown in Grafana Dashboards URL: https://github.com/apache/pulsar-helm-chart/issues/468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix][broker] Fix the broker registery cannot recover from the metadata node deletion [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on PR #23359: URL: https://github.com/apache/pulsar/pull/23359#issuecomment-2700791109 I created #24057 which is a similar issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] [Bug] ExtensibleLoadManager's broker registry cannot recover from session expiration / reconnection [pulsar]

2025-03-05 Thread via GitHub
lhotari opened a new issue, #24057: URL: https://github.com/apache/pulsar/issues/24057 _Originally posted by @lhotari in https://github.com/apache/pulsar/issues/23359#issuecomment-2690617306_ In LockManagerImpl, there's handling for session events: https://github.com/lhotari/pulsa

Re: [I] No data shown in Grafana Dashboards [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari commented on issue #468: URL: https://github.com/apache/pulsar-helm-chart/issues/468#issuecomment-2700749303 One detail is that Helm's `--namespace`/`-n` option should be used to set the namespace for the Pulsar deployment, including the kube-prometheus-stack deployment. The Pulsar

Re: [I] No data shown in Grafana Dashboards [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari commented on issue #468: URL: https://github.com/apache/pulsar-helm-chart/issues/468#issuecomment-2700742332 It seems that this problem will be solved in the helm chart release 4.0.0 where #555 is also addressed. If you'd like to use an existing Prometheus instance which isn't de

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981058623 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilderCustomizer.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation

(pulsar-helm-chart) branch master updated: Use PIP-45 metadata store config to replace deprecated ZK config and make PulsarMetadataBookieDriver configurable in BK (#576)

2025-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 9f61859 Use PIP-45 metadata store c

Re: [PR] [improve][client] Add newMessage with schema and transactions [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #23942: URL: https://github.com/apache/pulsar/pull/23942#discussion_r1981260964 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Producer.java: ## @@ -132,6 +132,21 @@ public interface Producer extends Closeable { * @since 2.7

Re: [I] [Bug] pulsar-recovery and pulsar-bookie components do not supply metrics in the standard Prometheus format. [pulsar-helm-chart]

2025-03-05 Thread via GitHub
lhotari commented on issue #555: URL: https://github.com/apache/pulsar-helm-chart/issues/555#issuecomment-2700728290 This issue will be solved in the Helm chart release 4.0.0 with `fallbackScrapeProtocol: PrometheusText0.0.4` in the podmonitors. That's something that the CRDs in the `kube-

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981066870 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilderContext.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981108077 ## pip/pip-409.md: ## @@ -33,25 +33,88 @@ retry/dead letter topic. ## Design & Implementation Details -- Add two new configurations in `DeadLetterPolicy`: +- Add

[PR] [fix][test] Update partitioned topic subscription assertions in IncrementPartitionsTest [pulsar]

2025-03-05 Thread via GitHub
kontotto opened a new pull request, #24056: URL: https://github.com/apache/pulsar/pull/24056 ### Motivation The previous assertion only verified subscriptions for partition 15. This change expands the scope to cover all partitions, ensuring comprehensive validation of subscription be

Re: [I] [Bug] Error while producing messages [pulsar]

2025-03-05 Thread via GitHub
deadcoden commented on issue #19269: URL: https://github.com/apache/pulsar/issues/19269#issuecomment-2700453187 Any solution to this? Getting this intermittently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981105551 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2303,8 +2305,13 @@ private CompletableFuture> initDeadLetterProducerIfNeeded()

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981105551 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2303,8 +2305,13 @@ private CompletableFuture> initDeadLetterProducerIfNeeded()

Re: [PR] Add Node.js 1.13.0 API docs. [pulsar-site]

2025-03-05 Thread via GitHub
shibd merged PR #991: URL: https://github.com/apache/pulsar-site/pull/991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on PR #24020: URL: https://github.com/apache/pulsar/pull/24020#issuecomment-2700430183 > One remaining issue about naming. Commented added. fixed, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] [Bug] message eventtime is reset to 0 on reconsumeLater [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on issue #24053: URL: https://github.com/apache/pulsar/issues/24053#issuecomment-2700438609 @SantanuKar43 Thanks for filing this issue. I fixed a similar issue in the past in #23182 . In that case message keys weren't copied. You might want to take some examples of where t

(pulsar-site) branch main updated (0df29a6242a -> e27f7e2e8c1)

2025-03-05 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git from 0df29a6242a Fix docker-compose examples by working around Go Yaml issue go-yaml/yaml#789 add e27f7e2e8c1 Add t

Re: [PR] Add the release note for Nodejs client 1.13.0 [pulsar-site]

2025-03-05 Thread via GitHub
shibd merged PR #990: URL: https://github.com/apache/pulsar-site/pull/990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981074037 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilderCustomizer.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981051142 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilderContext.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on PR #24020: URL: https://github.com/apache/pulsar/pull/24020#issuecomment-2700391547 > LGTM, good work @thetumbled . Great to see this finally solving many use cases. Thanks for your review and contributions! -- This is an automated message from the Apache Gi

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1981034208 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2294,17 +2295,16 @@ private CompletableFuture> initDeadLetterProducerIfNeeded()

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1980961195 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2294,17 +2295,16 @@ private CompletableFuture> initDeadLetterProducerIfNeede

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
thetumbled commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1980961195 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2294,17 +2295,16 @@ private CompletableFuture> initDeadLetterProducerIfNeede

Re: [PR] [improve][client] PIP-409: support producer configuration for retry/dead letter topic producer [pulsar]

2025-03-05 Thread via GitHub
lhotari commented on code in PR #24020: URL: https://github.com/apache/pulsar/pull/24020#discussion_r1980950149 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2294,17 +2295,16 @@ private CompletableFuture> initDeadLetterProducerIfNeeded()