[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20096: [improve][broker] Harden non-null checker

2023-04-17 Thread via GitHub
BewareMyPower commented on code in PR #20096: URL: https://github.com/apache/pulsar/pull/20096#discussion_r1169428743 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3066,21 +3068,25 @@ boolean shouldCloseLedger(LedgerHandle lh)

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20096: [improve][broker] Harden non-null checker

2023-04-17 Thread via GitHub
BewareMyPower commented on code in PR #20096: URL: https://github.com/apache/pulsar/pull/20096#discussion_r1169408980 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3066,21 +3068,25 @@ boolean shouldCloseLedger(LedgerHandle lh)

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20096: [improve][broker] Harden non-null checker

2023-04-14 Thread via GitHub
BewareMyPower commented on code in PR #20096: URL: https://github.com/apache/pulsar/pull/20096#discussion_r1166737860 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -3066,34 +3068,38 @@ boolean shouldCloseLedger(LedgerHandle lh)