[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1094032298 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1093986856 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -0,0 +1,222 @@ +/* Review Comment: The PR

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1093985988 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1093033235 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1068832278 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1061372645 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,225 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1061321963 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannel.java: ## @@ -51,7 +51,7 @@ public interface

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1061252680 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1061209983 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1061194276 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1061193599 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1060229456 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1060228467 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -171,11 +172,21 @@ public void initialize() { } }

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1059245743 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -925,6 +939,36 @@ public void start() throws PulsarServerException {

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1059232448 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java: ## @@ -242,11 +242,12 @@ public

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1059231314 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1059231154 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1059229901 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java: ## @@ -794,6 +802,12 @@ public void start() throws PulsarServerException {

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1059216341 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the