[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841633526 > @Shoothzj thank you for the great work! > > My take on the connectors - I would recommend avoiding adding more connectors to the Pulsar repo. It becomes really hard

[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841626874 > Personally I believe that we can accept this code here and when we will split the repo the code will go into the new repo for connectors. > > That said, it is your

[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-15 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841619991 > Can you please explain better this problem with 'merge policy' ? @codelipenghui told me that the IO part is going to split with Pulsar main Repo, currently it's not

[GitHub] [pulsar] Shoothzj commented on pull request #10595: [Pulsar IO] Develop Huawei Cloud DIS connector

2021-05-14 Thread GitBox
Shoothzj commented on pull request #10595: URL: https://github.com/apache/pulsar/pull/10595#issuecomment-841585081 For the merge policy, I close this PR, I will commit these codes to https://github.com/streamnative/pulsar-io-huawei-dis -- This is an automated message from the Apache Git