[GitHub] [pulsar] lhotari commented on pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-12 Thread GitBox
lhotari commented on PR #19160: URL: https://github.com/apache/pulsar/pull/19160#issuecomment-1380314133 @nicoloboschi PTAL . I have added a ProtectedObjectMapper class which prevents mutating the shared ObjectMapper config. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] lhotari commented on pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-11 Thread GitBox
lhotari commented on PR #19160: URL: https://github.com/apache/pulsar/pull/19160#issuecomment-1378862088 > @lhotari I see the improvement here, a couple of comments: > > * wouldn't be better to only expose the read/write method + `unsafeGetInstance` ? My concern is that you could