lifepuzzlefun commented on PR #20018:
URL: https://github.com/apache/pulsar/pull/20018#issuecomment-1540043502
@lhotari @codelipenghui @Technoboy- can you take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lifepuzzlefun commented on PR #20018:
URL: https://github.com/apache/pulsar/pull/20018#issuecomment-1527283937
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lifepuzzlefun commented on PR #20018:
URL: https://github.com/apache/pulsar/pull/20018#issuecomment-1518436935
@codelipenghui @Technoboy- can you take a look？：-）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lifepuzzlefun commented on PR #20018:
URL: https://github.com/apache/pulsar/pull/20018#issuecomment-1509711711
@lhotari hi i modified the current unit test to cover this case. please take
a look : - )
--
This is an automated message from the Apache Git Service.
To respond to the message,
lifepuzzlefun commented on PR #20018:
URL: https://github.com/apache/pulsar/pull/20018#issuecomment-1498621664
> Good catch. Please add tests to cover this PR. The test should fail
without the fix and pass with the fix in this PR.
thanks for reply.i'll add one ut
later ^_^
--
