[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #20116: [improve][fn] Allow unknown fields in connectors config

2023-04-26 Thread via GitHub
nicoloboschi commented on code in PR #20116: URL: https://github.com/apache/pulsar/pull/20116#discussion_r1177964071 ## pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java: ## @@ -870,6 +872,56 @@ private void

[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #20116: [improve][fn] Allow unknown fields in connectors config

2023-04-26 Thread via GitHub
nicoloboschi commented on code in PR #20116: URL: https://github.com/apache/pulsar/pull/20116#discussion_r1177963377 ## pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java: ## @@ -870,6 +872,56 @@ private void

[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #20116: [improve][fn] Allow unknown fields in connectors config

2023-04-26 Thread via GitHub
nicoloboschi commented on code in PR #20116: URL: https://github.com/apache/pulsar/pull/20116#discussion_r1177841668 ## pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java: ## @@ -738,6 +738,17 @@ public String

[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #20116: [improve][fn] Allow unknown fields in connectors config

2023-04-18 Thread via GitHub
nicoloboschi commented on code in PR #20116: URL: https://github.com/apache/pulsar/pull/20116#discussion_r1169703460 ## pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java: ## @@ -870,6 +872,56 @@ private void