[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-17 Thread GitBox
nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071891107 ## pulsar-metadata/src/test/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImplTest.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-17 Thread GitBox
nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071870686 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-16 Thread GitBox
nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071869275 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-16 Thread GitBox
nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071868786 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended

[GitHub] [pulsar] nodece commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-16 Thread GitBox
nodece commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1071861855 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +63,39 @@ public static MetadataStoreExtended