[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-15 Thread GitBox
poorbarcode commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1070593242 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
poorbarcode commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068900015 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -214,11 +227,18 @@ public synchronized boolean

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-10 Thread GitBox
poorbarcode commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1066530809 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/CombinedSegmentDelayedIndexQueue.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache