[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159785692 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -577,15 +586,21 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159775613 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -558,10 +559,18 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159775220 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1706,37 +1706,53 @@ private CompletableFuture

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159772007 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -577,15 +586,21 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159767988 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -577,15 +586,21 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159767988 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -577,15 +586,21 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159765202 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -577,15 +586,21 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159518774 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -558,10 +559,10 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159369595 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -558,10 +559,10 @@ public void

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20025: [fix] [broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-06 Thread via GitHub
poorbarcode commented on code in PR #20025: URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159369595 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java: ## @@ -558,10 +559,10 @@ public void