[GitHub] [pulsar] rdhabalia commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-05-08 Thread via GitHub
rdhabalia commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1539437163 @liangyepianzhou @BewareMyPower It seems [this PIP](https://github.com/apache/pulsar/issues/20221) was created before https://github.com/apache/pulsar/issues/20225 . But anyways,

[GitHub] [pulsar] rdhabalia commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-05-03 Thread via GitHub
rdhabalia commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1533933252 @codelipenghui I have created PIP: https://github.com/apache/pulsar/issues/20221 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] rdhabalia commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-11 Thread via GitHub
rdhabalia commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1504687268 > It doesn't look to me to introduce wire protocol changes that without PIP. @codelipenghui where did we discuss this? do you want me to show examples where breaking changes and

[GitHub] [pulsar] rdhabalia commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-11 Thread via GitHub
rdhabalia commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1504154798 @BewareMyPower anyways, I have resolved the conflict to move this PR forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] rdhabalia commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-11 Thread via GitHub
rdhabalia commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1504098249 @BewareMyPower > Could you resolve the conflicts with master? I think https://github.com/apache/pulsar/pull/19414 has changed the MessageId semantics and I am not able