[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-17 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r633199436 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-16 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r633199436 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632284185 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632283014 ## File path: pulsar/consumer_regex.go ## @@ -383,11 +382,14 @@ func subscriber(c *client, topics []string, opts ConsumerOptions, ch chan

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632282800 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632282548 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632281658 ## File path: pulsar/test_helper.go ## @@ -153,15 +153,24 @@ func deleteTopic(topic string) error { func topicStats(topic string)

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632280709 ## File path: pulsar/consumer_regex.go ## @@ -383,11 +382,14 @@ func subscriber(c *client, topics []string, opts ConsumerOptions, ch chan

[GitHub] [pulsar-client-go] EAHITechnology commented on a change in pull request #517: Check ParseTopicName() return err

2021-05-13 Thread GitBox
EAHITechnology commented on a change in pull request #517: URL: https://github.com/apache/pulsar-client-go/pull/517#discussion_r632280079 ## File path: pulsar/producer_impl.go ## @@ -88,12 +88,17 @@ func newProducer(client *client, options *ProducerOptions) (*producer, error)