[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-28 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r251555438 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-28 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r251557946 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-23 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r250433049 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-23 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r250433516 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-23 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r250434110 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-23 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r250433862 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249359401 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249359809 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249358794 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249359198 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249359456 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249359297 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249358540 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-21 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r249358427 ## File path: pulsar-io/hbase/pom.xml ## @@ -0,0 +1,94 @@ + +http://maven.apache.org/POM/4.0.0; +

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248711013 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSinkConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248713240 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248713654 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseGenericRecordSink.java

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248713349 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248712000 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248712974 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248711120 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSinkConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248709697 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248710535 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSinkConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248708289 ## File path: pulsar-io/hbase/pom.xml ## @@ -0,0 +1,94 @@ + +http://maven.apache.org/POM/4.0.0; +

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248712430 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248709079 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-17 Thread GitBox
sijie commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248708863 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ## @@