This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push: new d1b8f94 Java Client - Prevent printing authentication data in INFO logs. (#3377) d1b8f94 is described below commit d1b8f94ec477cf6e262550a88952954b83558219 Author: Jai Asher <j...@ccs.neu.edu> AuthorDate: Thu Jan 17 07:08:58 2019 -0800 Java Client - Prevent printing authentication data in INFO logs. (#3377) ### Motivation Currently, we print auth data in info logs - roleToken, private key info etc. ### Modifications Print ClientConfiguration without authentication field. ### Result We will no longer print sensitive info. --- .../java/org/apache/pulsar/client/impl/ConsumerStatsRecorderImpl.java | 2 +- .../java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsRecorderImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsRecorderImpl.java index e330b57..e40d7ce 100644 --- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsRecorderImpl.java +++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsRecorderImpl.java @@ -100,7 +100,7 @@ public class ConsumerStatsRecorderImpl implements ConsumerStatsRecorder { try { log.info("Starting Pulsar consumer perf with config: {}", w.writeValueAsString(conf)); - log.info("Pulsar client config: {}", w.writeValueAsString(pulsarClient.getConfiguration())); + log.info("Pulsar client config: {}", w.withoutAttribute("authentication").writeValueAsString(pulsarClient.getConfiguration())); } catch (IOException e) { log.error("Failed to dump config info: {}", e); } diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java index 6bea137..cb60a52 100644 --- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java +++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java @@ -99,7 +99,7 @@ public class ProducerStatsRecorderImpl implements ProducerStatsRecorder { try { log.info("Starting Pulsar producer perf with config: {}", w.writeValueAsString(conf)); - log.info("Pulsar client config: {}", w.writeValueAsString(pulsarClient.getConfiguration())); + log.info("Pulsar client config: {}", w.withoutAttribute("authentication").writeValueAsString(pulsarClient.getConfiguration())); } catch (IOException e) { log.error("Failed to dump config info: {}", e); }