[GitHub] JevonQ commented on issue #3303: [Question] A few questions on using Pulsar in different scenarios

2019-01-05 Thread GitBox
JevonQ commented on issue #3303: [Question] A few questions on using Pulsar in different scenarios URL: https://github.com/apache/pulsar/issues/3303#issuecomment-451636602 @sijie Thanks for your reply, but I'm still not clear. For the multi-clusters environment like I given in my

[pulsar] branch master updated: issue #3276 Pulsar IO connector for udp source (#3295)

2019-01-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1d22571 issue #3276 Pulsar IO connector for

[GitHub] sijie closed pull request #3295: issue #3276 Pulsar IO connector for udp source

2019-01-05 Thread GitBox
sijie closed pull request #3295: issue #3276 Pulsar IO connector for udp source URL: https://github.com/apache/pulsar/pull/3295 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie closed issue #3276: Pulsar IO connector for udp source

2019-01-05 Thread GitBox
sijie closed issue #3276: Pulsar IO connector for udp source URL: https://github.com/apache/pulsar/issues/3276 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie edited a comment on issue #3303: [Question] A few questions on using Pulsar in different scenarios

2019-01-05 Thread GitBox
sijie edited a comment on issue #3303: [Question] A few questions on using Pulsar in different scenarios URL: https://github.com/apache/pulsar/issues/3303#issuecomment-451639247 oh sorry, I misunderstood your question. * for multiple cluster case: > Suppose I have a pulsar

[GitHub] sijie commented on issue #3303: [Question] A few questions on using Pulsar in different scenarios

2019-01-05 Thread GitBox
sijie commented on issue #3303: [Question] A few questions on using Pulsar in different scenarios URL: https://github.com/apache/pulsar/issues/3303#issuecomment-451639247 oh sorry, I misunderstood your question. * for multiple cluster case: > Suppose I have a pulsar instance

[GitHub] sijie commented on issue #3249: [client] Issue 3218: Support specifying multiple hosts in pulsar service url and web url

2019-01-05 Thread GitBox
sijie commented on issue #3249: [client] Issue 3218: Support specifying multiple hosts in pulsar service url and web url URL: https://github.com/apache/pulsar/pull/3249#issuecomment-451641370 @merlimat @codelipenghui can you guys help review this?

[GitHub] legendtkl commented on issue #3304: fix issue 3226 Unclosed consumer after calling closeAsync

2019-01-05 Thread GitBox
legendtkl commented on issue #3304: fix issue 3226 Unclosed consumer after calling closeAsync URL: https://github.com/apache/pulsar/pull/3304#issuecomment-451641855 @sijie * that's ok to change order * yes, I have verified that. * I found the integration tests in the path:

[GitHub] JevonQ commented on issue #3303: [Question] A few questions on using Pulsar in different scenarios

2019-01-05 Thread GitBox
JevonQ commented on issue #3303: [Question] A few questions on using Pulsar in different scenarios URL: https://github.com/apache/pulsar/issues/3303#issuecomment-451642334 > * for multiple cluster case: > > > Suppose I have a pulsar instance which consists of 3 pulsar clusters(C1,

[GitHub] JevonQ edited a comment on issue #3303: [Question] A few questions on using Pulsar in different scenarios

2019-01-05 Thread GitBox
JevonQ edited a comment on issue #3303: [Question] A few questions on using Pulsar in different scenarios URL: https://github.com/apache/pulsar/issues/3303#issuecomment-451642334 > * for multiple cluster case: > > > Suppose I have a pulsar instance which consists of 3 pulsar

[GitHub] jiazhai edited a comment on issue #2865: Refactored JCloud Tiered Storage

2019-01-05 Thread GitBox
jiazhai edited a comment on issue #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#issuecomment-451455734 run integration tests @david-streamlio FYI. Test Result (1 failure / +1)

[pulsar] branch master updated: Add logic in the dashboard to handle cases where Bundle, Topic, Subscription, Consumer already exists

2019-01-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2103792 Add logic in the dashboard to handle

[GitHub] sijie closed pull request #3236: Add update for Bundle, Topic, Subscription, Consumer if exist in dashboard

2019-01-05 Thread GitBox
sijie closed pull request #3236: Add update for Bundle,Topic,Subscription,Consumer if exist in dashboard URL: https://github.com/apache/pulsar/pull/3236 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] liketic commented on a change in pull request #3308: Add heartbeat interval for kafka connector

2019-01-05 Thread GitBox
liketic commented on a change in pull request #3308: Add heartbeat interval for kafka connector URL: https://github.com/apache/pulsar/pull/3308#discussion_r245479065 ## File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java ## @@ -69,6

[GitHub] liketic opened a new pull request #3306: Fix typo

2019-01-05 Thread GitBox
liketic opened a new pull request #3306: Fix typo URL: https://github.com/apache/pulsar/pull/3306 ### Motivation ```Fetchs``` should be ```Fetches```. ### Modifications Describe the modifications you've done. ### Result After your change, what will

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245478379 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245472741 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245478448 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSinkConfig.java ## @@

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245472753 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseUtils.java ## @@ -0,0 +1,45

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245478411 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseAbstractSink.java ##

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245478468 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSink.java ## @@ -0,0

[GitHub] sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3291: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3291#discussion_r245478488 ## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/sink/HbaseSink.java ## @@ -0,0

[GitHub] vincent-pli commented on issue #3302: Could Subscription filter message for consumer

2019-01-05 Thread GitBox
vincent-pli commented on issue #3302: Could Subscription filter message for consumer URL: https://github.com/apache/pulsar/issues/3302#issuecomment-451658851 Thanks for your reply, I want to know if creating/delete topic in run time is expensive or not. If it's cheap, I can adopt the

[GitHub] sijie commented on a change in pull request #3308: Add heartbeat interval for kafka connector

2019-01-05 Thread GitBox
sijie commented on a change in pull request #3308: Add heartbeat interval for kafka connector URL: https://github.com/apache/pulsar/pull/3308#discussion_r245478536 ## File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java ## @@ -69,6

[GitHub] liketic opened a new pull request #3308: Add heartbeat interval for kafka connector

2019-01-05 Thread GitBox
liketic opened a new pull request #3308: Add heartbeat interval for kafka connector URL: https://github.com/apache/pulsar/pull/3308 ### Motivation The default value of ```heartbeat.interval.ms``` is 3000 in latest kafka consumer config, which cannot be customized in kafka source

[GitHub] merlimat closed pull request #3306: Fix typo in Go client docs

2019-01-05 Thread GitBox
merlimat closed pull request #3306: Fix typo in Go client docs URL: https://github.com/apache/pulsar/pull/3306 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[pulsar] branch master updated: Fix typo in Go client docs (#3306)

2019-01-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8ab80bb Fix typo in Go client docs (#3306)

[GitHub] liketic opened a new pull request #3307: Remove --global-zookeeper completely

2019-01-05 Thread GitBox
liketic opened a new pull request #3307: Remove --global-zookeeper completely URL: https://github.com/apache/pulsar/pull/3307 ### Motivation Remove option ```--global-zookeeper``` and all related code and documents as we already deprecated it in previous version. This maybe not

[GitHub] foreversunyao commented on issue #2952: Setting topic permission under load

2019-01-05 Thread GitBox
foreversunyao commented on issue #2952: Setting topic permission under load URL: https://github.com/apache/pulsar/issues/2952#issuecomment-451708149 @sijie for this issue, I am considering create a persistent zknode in zk if not exists, zknode name is the namespace name . by this way to

[GitHub] merlimat commented on issue #3230: expect not restart application after more partitions created

2019-01-05 Thread GitBox
merlimat commented on issue #3230: expect not restart application after more partitions created URL: https://github.com/apache/pulsar/issues/3230#issuecomment-451712252 @foreversunyao producers/consumers are not directly connected to ZK. We have on the roadmap to add support for "system"

[GitHub] merlimat edited a comment on issue #3230: expect not restart application after more partitions created

2019-01-05 Thread GitBox
merlimat edited a comment on issue #3230: expect not restart application after more partitions created URL: https://github.com/apache/pulsar/issues/3230#issuecomment-451712252 @foreversunyao producers/consumers are not directly connected to ZK. We have on the roadmap to add

[GitHub] foreversunyao commented on issue #3230: expect not restart application after more partitions created

2019-01-05 Thread GitBox
foreversunyao commented on issue #3230: expect not restart application after more partitions created URL: https://github.com/apache/pulsar/issues/3230#issuecomment-451715304 @merlimat If I am not wrong, your point is in the future , client would subscribe the system topics to get the

[GitHub] foreversunyao commented on issue #3230: expect not restart application after more partitions created

2019-01-05 Thread GitBox
foreversunyao commented on issue #3230: expect not restart application after more partitions created URL: https://github.com/apache/pulsar/issues/3230#issuecomment-451710555 @sijie , for this issue, what I am considering is using zk temporary node when update any partitions for topic,

[GitHub] merlimat opened a new pull request #3309: Separate pulsar client API interfaces in different module

2019-01-05 Thread GitBox
merlimat opened a new pull request #3309: Separate pulsar client API interfaces in different module URL: https://github.com/apache/pulsar/pull/3309 ### Motivation Isolating the API into a separate module will achieve: * Clear separation from implementation. No referencing by

[GitHub] merlimat commented on issue #3230: expect not restart application after more partitions created

2019-01-05 Thread GitBox
merlimat commented on issue #3230: expect not restart application after more partitions created URL: https://github.com/apache/pulsar/issues/3230#issuecomment-451715820 Correct, that will be a general solution for a variety of problems