[GitHub] [pulsar] addisonj edited a comment on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool

2019-10-14 Thread GitBox
addisonj edited a comment on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool URL: https://github.com/apache/pulsar/issues/5383#issuecomment-541929505 ~Okay, after a bit of research, this looks like it likely is mostly a non issue in master with the

[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall

2019-10-14 Thread GitBox
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541984267 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
sijie commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-541914451 @congbobo184 @codelipenghui I see you introduced two settings, one is the flag to control auto update and

[GitHub] [pulsar] merlimat opened a new pull request #5385: Standalone should use crc32c by default as well

2019-10-14 Thread GitBox
merlimat opened a new pull request #5385: Standalone should use crc32c by default as well URL: https://github.com/apache/pulsar/pull/5385 ### Motivation Fixed the default for digest type to match what we're already using in regular broker.

[GitHub] [pulsar] aahmed-se opened a new pull request #5386: Update presto to 0.226

2019-10-14 Thread GitBox
aahmed-se opened a new pull request #5386: Update presto to 0.226 URL: https://github.com/apache/pulsar/pull/5386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar-manager] branch master updated: Make default environment persistent (#197)

2019-10-14 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new fc0c422 Make default environment

[GitHub] [pulsar] addisonj commented on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool

2019-10-14 Thread GitBox
addisonj commented on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool URL: https://github.com/apache/pulsar/issues/5383#issuecomment-541929505 Okay, after a bit of research, this looks like it likely is mostly a non issue in master with the changes

[GitHub] [pulsar] aahmed-se commented on issue #5386: Update presto to 0.226

2019-10-14 Thread GitBox
aahmed-se commented on issue #5386: Update presto to 0.226 URL: https://github.com/apache/pulsar/pull/5386#issuecomment-541970815 run integration tests This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] congbobo184 opened a new pull request #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
congbobo184 opened a new pull request #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227 Master Issue: #4737 ### Motivation Implement of

[GitHub] [pulsar] codelipenghui commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
codelipenghui commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-542009264 @sijie if user set the auto update strategy by new way, we will use the new setting, otherwise will use

[GitHub] [pulsar] MarvinCai commented on a change in pull request #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-10-14 Thread GitBox
MarvinCai commented on a change in pull request #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#discussion_r334733254 ## File path: site2/docs/admin-api-partitioned-topics.md ## @@

[GitHub] [pulsar] k2la opened a new issue #5387: When I create many PulsarClients and Consumers, failed to resolve hostname

2019-10-14 Thread GitBox
k2la opened a new issue #5387: When I create many PulsarClients and Consumers, failed to resolve hostname URL: https://github.com/apache/pulsar/issues/5387 I have use cases that needs to create many `PulsarClient` and `Consumer` instances. ``` List clients = new ArrayList<>();

[GitHub] [pulsar] codelipenghui commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf

2019-10-14 Thread GitBox
codelipenghui commented on issue #5359: Set default ensemble size to 2 in service conf, to match broker.conf URL: https://github.com/apache/pulsar/pull/5359#issuecomment-542007371 run java8 tests This is an automated message

[GitHub] [pulsar] jiazhai commented on issue #5381: [Issue 5380][deployment]Fixing pod anti-affinity rules in Kubernetes files including Helm chart

2019-10-14 Thread GitBox
jiazhai commented on issue #5381: [Issue 5380][deployment]Fixing pod anti-affinity rules in Kubernetes files including Helm chart URL: https://github.com/apache/pulsar/pull/5381#issuecomment-542049773 run cpp tests

[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-542005621 > @congbobo184 @codelipenghui > > I see you introduced two settings, one is the flag to control auto

[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-542005621 > @congbobo184 @codelipenghui > > I see you introduced two settings, one is the flag to

[GitHub] [pulsar] congbobo184 closed pull request #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
congbobo184 closed pull request #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227 This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] MarvinCai commented on a change in pull request #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-10-14 Thread GitBox
MarvinCai commented on a change in pull request #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#discussion_r334737624 ## File path:

[pulsar] branch master updated (7506092 -> 3a9854e)

2019-10-14 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7506092 Update schema-understand.md (#5233) add 3a9854e make skip all messages async. (#5375) No new

[GitHub] [pulsar] codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery

2019-10-14 Thread GitBox
codelipenghui commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-542007258 retest this please This is an automated

[GitHub] [pulsar] codelipenghui merged pull request #5375: [pulsar-admin]make skip all messages async

2019-10-14 Thread GitBox
codelipenghui merged pull request #5375: [pulsar-admin]make skip all messages async URL: https://github.com/apache/pulsar/pull/5375 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-542010745 run Integration Tests run java8 tests

[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-10-14 Thread GitBox
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-542022333 run java8 tests This is an automated

[GitHub] [pulsar] rocketraman commented on issue #5202: Incorrect msgBacklog value

2019-10-14 Thread GitBox
rocketraman commented on issue #5202: Incorrect msgBacklog value URL: https://github.com/apache/pulsar/issues/5202#issuecomment-542044367 I have this issue as well... one of my subscriptions to a partitioned topic is showing a backlog of 1 message, but that is incorrect -- the backlog is

[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall

2019-10-14 Thread GitBox
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541617591 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall

2019-10-14 Thread GitBox
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541619879 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall

2019-10-14 Thread GitBox
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541601493 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334340660 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBase.java

[GitHub] [pulsar] sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334314352 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java

[GitHub] [pulsar] sijie commented on a change in pull request #5356: [TIEREDSTORAGE] Only seek when reading unexpected entry

2019-10-14 Thread GitBox
sijie commented on a change in pull request #5356: [TIEREDSTORAGE] Only seek when reading unexpected entry URL: https://github.com/apache/pulsar/pull/5356#discussion_r334341212 ## File path:

[GitHub] [pulsar] Guchman commented on issue #5366: Deploy function without starting it

2019-10-14 Thread GitBox
Guchman commented on issue #5366: Deploy function without starting it URL: https://github.com/apache/pulsar/issues/5366#issuecomment-541524677 @aahmed-se I mean external control of function, stop and start that with API. Anyway, it's may be useful to deploy full stream pipeline before

[GitHub] [pulsar] sijie commented on issue #5372: Use StandardCharsets.UTF_8 for converting String to bytes

2019-10-14 Thread GitBox
sijie commented on issue #5372: Use StandardCharsets.UTF_8 for converting String to bytes URL: https://github.com/apache/pulsar/pull/5372#issuecomment-541527551 run java8 tests run integration tests This is an automated

[GitHub] [pulsar] yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334362812 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java

[GitHub] [pulsar] sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334314300 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java

[GitHub] [pulsar] sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
sijie commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334339790 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java

[GitHub] [pulsar] yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334352968 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java

[GitHub] [pulsar] sijie commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users

2019-10-14 Thread GitBox
sijie commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users URL: https://github.com/apache/pulsar/pull/5374#issuecomment-541525072 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] sijie commented on issue #5378: Trim messages which less than mark delete position for message redelivery

2019-10-14 Thread GitBox
sijie commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-541524805 run cpp tests run java8 tests This is an

[GitHub] [pulsar] Jennifer88huang commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users

2019-10-14 Thread GitBox
Jennifer88huang commented on issue #5374: [Issue 5362][website]Update logo path for Pulsar users URL: https://github.com/apache/pulsar/pull/5374#issuecomment-541527874 run java8 tests This is an automated message from the

[GitHub] [pulsar] yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334361724 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBase.java

[GitHub] [pulsar] Anonymitaet commented on issue #5296: [Doc] Update connector guide overall

2019-10-14 Thread GitBox
Anonymitaet commented on issue #5296: [Doc] Update connector guide overall URL: https://github.com/apache/pulsar/pull/5296#issuecomment-541545145 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] a1onzo commented on issue #2799: Receiving "Connection Already Closed Error on Creating Producer"

2019-10-14 Thread GitBox
a1onzo commented on issue #2799: Receiving "Connection Already Closed Error on Creating Producer" URL: https://github.com/apache/pulsar/issues/2799#issuecomment-541567106 hi, is the issue above solved? i am confused with that error "Error Checking/Getting Partition Metadata while creating

[GitHub] [pulsar] yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-10-14 Thread GitBox
yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r334355056 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java

[GitHub] [pulsar] boncheff opened a new pull request #5382: Update client-libraries-go.md

2019-10-14 Thread GitBox
boncheff opened a new pull request #5382: Update client-libraries-go.md URL: https://github.com/apache/pulsar/pull/5382 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to

[pulsar-manager] branch master updated (44273c9 -> f250835)

2019-10-14 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git. from 44273c9 Support HerdDB database (#194) add f250835 Use only standard well-known repositories and

[GitHub] [pulsar] jiazhai commented on issue #5376: [Issue 3009][docs] Add presto sql REST APIs doc

2019-10-14 Thread GitBox
jiazhai commented on issue #5376: [Issue 3009][docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#issuecomment-541730453 run integration tests This is an automated message from the Apache Git

[GitHub] [pulsar] jiazhai commented on issue #5381: [Issue 5380][deployment]Fixing pod anti-affinity rules in Kubernetes files including Helm chart

2019-10-14 Thread GitBox
jiazhai commented on issue #5381: [Issue 5380][deployment]Fixing pod anti-affinity rules in Kubernetes files including Helm chart URL: https://github.com/apache/pulsar/pull/5381#issuecomment-541731805 run cpp tests This is

[GitHub] [pulsar-client-go] wolfstudy commented on issue #69: [ISSUE #68][feat]add Option config for init (#68)

2019-10-14 Thread GitBox
wolfstudy commented on issue #69: [ISSUE #68][feat]add Option config for init (#68) URL: https://github.com/apache/pulsar-client-go/pull/69#issuecomment-541742558 ping @merlimat PTAL This is an automated message from the

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #65: [Issue 64] fix bug: type assert cause panic

2019-10-14 Thread GitBox
wolfstudy commented on a change in pull request #65: [Issue 64] fix bug: type assert cause panic URL: https://github.com/apache/pulsar-client-go/pull/65#discussion_r334536144 ## File path: pulsar/impl_partition_producer.go ## @@ -293,14 +293,17 @@ func (p

[GitHub] [pulsar-client-go] wolfstudy commented on issue #65: [Issue 64] fix bug: type assert cause panic

2019-10-14 Thread GitBox
wolfstudy commented on issue #65: [Issue 64] fix bug: type assert cause panic URL: https://github.com/apache/pulsar-client-go/pull/65#issuecomment-541744405 ping @mileschao PTAL This is an automated message from the Apache

[GitHub] [pulsar] wolfstudy commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send

2019-10-14 Thread GitBox
wolfstudy commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send URL: https://github.com/apache/pulsar/pull/4811#issuecomment-541744951 ping @massakam PTAL again thanks This is an automated message

[GitHub] [pulsar] wolfstudy commented on issue #5382: Update client-libraries-go.md

2019-10-14 Thread GitBox
wolfstudy commented on issue #5382: Update client-libraries-go.md URL: https://github.com/apache/pulsar/pull/5382#issuecomment-541747003 run integration tests run java8 tests This is an automated message from the Apache

[GitHub] [pulsar] wolfstudy commented on issue #5376: [Issue 3009][docs] Add presto sql REST APIs doc

2019-10-14 Thread GitBox
wolfstudy commented on issue #5376: [Issue 3009][docs] Add presto sql REST APIs doc URL: https://github.com/apache/pulsar/pull/5376#issuecomment-541747624 run integration tests This is an automated message from the Apache

[GitHub] [pulsar] liangyuanpeng commented on issue #5348: Load tls file fail on Windows

2019-10-14 Thread GitBox
liangyuanpeng commented on issue #5348: Load tls file fail on Windows URL: https://github.com/apache/pulsar/issues/5348#issuecomment-541754848 Update, I confirm that my problem is on configuring TLS transport and can i not use proxy? Actually, I tried to start proxy,but i just

[GitHub] [pulsar] merlimat commented on issue #5348: Load tls file fail on Windows

2019-10-14 Thread GitBox
merlimat commented on issue #5348: Load tls file fail on Windows URL: https://github.com/apache/pulsar/issues/5348#issuecomment-541765194 @liangyuanpeng From the error looks like you're connecting with TLS to a non TLS port. Typically, the TLS port is `6651`, so the URL should

[GitHub] [pulsar] liangyuanpeng commented on issue #5348: Load tls file fail on Windows

2019-10-14 Thread GitBox
liangyuanpeng commented on issue #5348: Load tls file fail on Windows URL: https://github.com/apache/pulsar/issues/5348#issuecomment-541771171 @merlimat Thanks,Just solved the problem, I realized what a fool I was Now,i got the error ``

[GitHub] [pulsar-client-go] xujianhai666 opened a new pull request #73: [ISSUE #64]fix: avoid assert panic

2019-10-14 Thread GitBox
xujianhai666 opened a new pull request #73: [ISSUE #64]fix: avoid assert panic URL: https://github.com/apache/pulsar-client-go/pull/73 ### Motivation when poll return nil, type assert will panic. ### Modifications - add assert check Fixes #64

[GitHub] [pulsar] addisonj opened a new issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool

2019-10-14 Thread GitBox
addisonj opened a new issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool URL: https://github.com/apache/pulsar/issues/5383 **Describe the bug** For unknown reasons, a `deleteSubscription` call can fail and it leaves around a dangling thread in the

[GitHub] [pulsar] Lanayx opened a new issue #5384: Topic compaction fails with 500 error

2019-10-14 Thread GitBox
Lanayx opened a new issue #5384: Topic compaction fails with 500 error URL: https://github.com/apache/pulsar/issues/5384 **Describe the bug** I'm running pulsar 2.4.1 on minikube installed with Helm template. I create topic in `retention` namespace where some retention is set ( in my

[GitHub] [pulsar] jerrypeng commented on issue #5371: fix potential deadlock that can occur in addConsumer

2019-10-14 Thread GitBox
jerrypeng commented on issue #5371: fix potential deadlock that can occur in addConsumer URL: https://github.com/apache/pulsar/pull/5371#issuecomment-541809404 rerun java8 tests rerun integration tests This is an

[GitHub] [pulsar-client-go] xujianhai666 opened a new issue #74: fmt code

2019-10-14 Thread GitBox
xujianhai666 opened a new issue #74: fmt code URL: https://github.com/apache/pulsar-client-go/issues/74 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] fmt code

[GitHub] [pulsar] aahmed-se closed pull request #5354: Test do not merge

2019-10-14 Thread GitBox
aahmed-se closed pull request #5354: Test do not merge URL: https://github.com/apache/pulsar/pull/5354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar-client-go] xujianhai666 opened a new pull request #75: [ISSUE #74]refactor: gofmt code

2019-10-14 Thread GitBox
xujianhai666 opened a new pull request #75: [ISSUE #74]refactor: gofmt code URL: https://github.com/apache/pulsar-client-go/pull/75 Motivation: code is not fmt, should be with gofmt Modifications: - gofmt once Fixes #74