[GitHub] [pulsar] sijie commented on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
sijie commented on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590506885 /pulsarbot run-failure-checks This is an automated message from the Apache Git

[GitHub] [pulsar] sijie commented on issue #6409: Pull Request checks detected documentation changes but it's not

2020-02-24 Thread GitBox
sijie commented on issue #6409: Pull Request checks detected documentation changes but it's not URL: https://github.com/apache/pulsar/issues/6409#issuecomment-590526591 @KannarFr there was an issue about `checkout` actions. I think we already fixed it. I looked at

[GitHub] [pulsar] sijie commented on issue #6192: [deployement] make kubernetes yamls for aws operational

2020-02-24 Thread GitBox
sijie commented on issue #6192: [deployement] make kubernetes yamls for aws operational URL: https://github.com/apache/pulsar/pull/6192#issuecomment-590535502 @psilos labeled for 2.5.1 and 2.4.3. The release manager will do the cherry-pick when creating the bug fix releases.

[GitHub] [pulsar] vzhikserg opened a new pull request #6412: Remove duplicated lombok annotations in the tests module

2020-02-24 Thread GitBox
vzhikserg opened a new pull request #6412: Remove duplicated lombok annotations in the tests module URL: https://github.com/apache/pulsar/pull/6412 ### Modifications This is a simple cleanup to reduce the number of lombok annotations by deleting the duplicated lombok annotations in

[GitHub] [pulsar] sijie commented on a change in pull request #6411: [functions] Allow custom resources for k8s

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6411: [functions] Allow custom resources for k8s URL: https://github.com/apache/pulsar/pull/6411#discussion_r383475206 ## File path:

[GitHub] [pulsar] sijie commented on a change in pull request #6411: [functions] Allow custom resources for k8s

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6411: [functions] Allow custom resources for k8s URL: https://github.com/apache/pulsar/pull/6411#discussion_r383475037 ## File path:

[GitHub] [pulsar] sijie commented on a change in pull request #6411: [functions] Allow custom resources for k8s

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6411: [functions] Allow custom resources for k8s URL: https://github.com/apache/pulsar/pull/6411#discussion_r383475130 ## File path:

[GitHub] [pulsar] sijie commented on issue #6394: Expect an option to disable auto creation of subscriptions

2020-02-24 Thread GitBox
sijie commented on issue #6394: Expect an option to disable auto creation of subscriptions URL: https://github.com/apache/pulsar/issues/6394#issuecomment-590525870 @murong00 the proposal looks good to me +1 This is an

[GitHub] [pulsar] rivernate opened a new pull request #6411: [functions] Allow custom resources for k8s

2020-02-24 Thread GitBox
rivernate opened a new pull request #6411: [functions] Allow custom resources for k8s URL: https://github.com/apache/pulsar/pull/6411 ### Motivation Currently for functions running in kubernetes both the request and limit for cpu and memory are specified by resources arguments. The

[GitHub] [pulsar] sijie commented on issue #6405: Add verification for SchemaDefinitionBuilderImpl.java

2020-02-24 Thread GitBox
sijie commented on issue #6405: Add verification for SchemaDefinitionBuilderImpl.java URL: https://github.com/apache/pulsar/pull/6405#issuecomment-590517434 @codelipenghui I don't think this is a good fix. I think we should verify the schema definition if both schema def and POJO are

[GitHub] [pulsar] sijie commented on a change in pull request #6202: (Flaky-tests) Reduce flakiness of tests

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6202: (Flaky-tests) Reduce flakiness of tests URL: https://github.com/apache/pulsar/pull/6202#discussion_r383485529 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java ## @@ -1646,7

[GitHub] [pulsar] sijie commented on issue #6374: [conf] Amend the default value of `supportedNamespaceBundleSplitAlgorithms`

2020-02-24 Thread GitBox
sijie commented on issue #6374: [conf] Amend the default value of `supportedNamespaceBundleSplitAlgorithms` URL: https://github.com/apache/pulsar/pull/6374#issuecomment-590513510 /pulsarbot run-failure-checks This is an

[GitHub] [pulsar] sijie commented on issue #6404: Issue-6403: Consumer received duplicated deplayed messages upon restart

2020-02-24 Thread GitBox
sijie commented on issue #6404: Issue-6403: Consumer received duplicated deplayed messages upon restart URL: https://github.com/apache/pulsar/pull/6404#issuecomment-590519348 /pulsarbot run-failure-checks This is an

[GitHub] [pulsar] sijie commented on issue #5447: Apache Beam support for Pulsar

2020-02-24 Thread GitBox
sijie commented on issue #5447: Apache Beam support for Pulsar URL: https://github.com/apache/pulsar/issues/5447#issuecomment-590534094 @rfuerst87 - the beam community is doing the work. You can track the progress here - https://issues.apache.org/jira/browse/BEAM-8218 I will follow

[GitHub] [pulsar] sijie commented on a change in pull request #6356: Independent schema is set for each consumer generated by topic

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6356: Independent schema is set for each consumer generated by topic URL: https://github.com/apache/pulsar/pull/6356#discussion_r383462097 ## File path:

[GitHub] [pulsar] sijie commented on issue #4708: standalone mode cannot sync MaxMessageSize to bookkeeper

2020-02-24 Thread GitBox
sijie commented on issue #4708: standalone mode cannot sync MaxMessageSize to bookkeeper URL: https://github.com/apache/pulsar/issues/4708#issuecomment-590509061 @Lanayx - standalone loads `nettyMaxFrameSizeBytes` from standalone.conf for bookkeeper as well. So you don't need to set

[GitHub] [pulsar] sijie merged pull request #6128: Fix broker client tls settings error

2020-02-24 Thread GitBox
sijie merged pull request #6128: Fix broker client tls settings error URL: https://github.com/apache/pulsar/pull/6128 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pulsar] branch master updated (2f42077 -> 739c0dd)

2020-02-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2f42077 Fixed enum package not found (#6401) add 739c0dd removed comma from yaml config (#6402) No new

[GitHub] [pulsar] sijie merged pull request #6402: removed comma from yaml config

2020-02-24 Thread GitBox
sijie merged pull request #6402: removed comma from yaml config URL: https://github.com/apache/pulsar/pull/6402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] devinbost commented on a change in pull request #6202: (Flaky-tests) Reduce flakiness of tests

2020-02-24 Thread GitBox
devinbost commented on a change in pull request #6202: (Flaky-tests) Reduce flakiness of tests URL: https://github.com/apache/pulsar/pull/6202#discussion_r383489485 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java ## @@ -1646,7

[GitHub] [pulsar] sijie commented on issue #6117: FlinkPulsarProducer: Setting topic dynamically based on message content

2020-02-24 Thread GitBox
sijie commented on issue #6117: FlinkPulsarProducer: Setting topic dynamically based on message content URL: https://github.com/apache/pulsar/issues/6117#issuecomment-590533376 @parth-sarathy since the https://github.com/streamnative/pulsar-flink connector is the one that is being

[GitHub] [pulsar] sijie commented on a change in pull request #6365: Add retry when using async method to perform request in AsyncHttpConnector

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6365: Add retry when using async method to perform request in AsyncHttpConnector URL: https://github.com/apache/pulsar/pull/6365#discussion_r383473145 ## File path:

[GitHub] [pulsar] sijie commented on issue #6408: Not able to create a Pulsar function

2020-02-24 Thread GitBox
sijie commented on issue #6408: Not able to create a Pulsar function URL: https://github.com/apache/pulsar/issues/6408#issuecomment-590512876 @vishalananth07 I think this is related to #6365 for a short-term solution, I would suggest updating the service urls in your cluster

[GitHub] [pulsar] sijie commented on issue #6399: [#6228][pulsar-zookeeper-utils] Close ZK before canceling future with exception

2020-02-24 Thread GitBox
sijie commented on issue #6399: [#6228][pulsar-zookeeper-utils] Close ZK before canceling future with exception URL: https://github.com/apache/pulsar/pull/6399#issuecomment-590524906 /pulsarbot rerun-failure-checks This is

[GitHub] [pulsar] sijie commented on issue #6391: [Issue 6168] Fix Unacked Message Tracker by Using Time Partition on C++

2020-02-24 Thread GitBox
sijie commented on issue #6391: [Issue 6168] Fix Unacked Message Tracker by Using Time Partition on C++ URL: https://github.com/apache/pulsar/pull/6391#issuecomment-590524722 /pulsarbot rerun-failure-checks This is an

[GitHub] [pulsar] sijie commented on issue #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

2020-02-24 Thread GitBox
sijie commented on issue #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster URL: https://github.com/apache/pulsar/pull/5985#issuecomment-590530179 @murong00 I thought I reviewed it already. but it turned out that I forgot to click submit button. Here is the

[GitHub] [pulsar] sijie commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

2020-02-24 Thread GitBox
sijie commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster URL: https://github.com/apache/pulsar/pull/5985#discussion_r379878481 ## File path:

[GitHub] [pulsar] KannarFr closed issue #6409: Pull Request checks detected documentation changes but it's not

2020-02-24 Thread GitBox
KannarFr closed issue #6409: Pull Request checks detected documentation changes but it's not URL: https://github.com/apache/pulsar/issues/6409 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] KannarFr commented on issue #6409: Pull Request checks detected documentation changes but it's not

2020-02-24 Thread GitBox
KannarFr commented on issue #6409: Pull Request checks detected documentation changes but it's not URL: https://github.com/apache/pulsar/issues/6409#issuecomment-590530463 Yes. This is an automated message from the Apache

[GitHub] [pulsar] sijie commented on issue #6381: [Issue 6283][Offloaders] Offload policies per ns with deletionLag & threshold

2020-02-24 Thread GitBox
sijie commented on issue #6381: [Issue 6283][Offloaders] Offload policies per ns with deletionLag & threshold URL: https://github.com/apache/pulsar/pull/6381#issuecomment-590474422 /pulsarbot run-failure-checks This is an

[GitHub] [pulsar] sijie commented on issue #6348: [Issue 6170][functions] add custom property option to functions

2020-02-24 Thread GitBox
sijie commented on issue #6348: [Issue 6170][functions] add custom property option to functions URL: https://github.com/apache/pulsar/pull/6348#issuecomment-590505473 /pulsarbot run-failure-checks This is an automated

[GitHub] [pulsar] sijie closed issue #6400: Cpp python test failed

2020-02-24 Thread GitBox
sijie closed issue #6400: Cpp python test failed URL: https://github.com/apache/pulsar/issues/6400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] sijie merged pull request #6401: [Issue 6400][Python Test]Fixed the enum34 package not found

2020-02-24 Thread GitBox
sijie merged pull request #6401: [Issue 6400][Python Test]Fixed the enum34 package not found URL: https://github.com/apache/pulsar/pull/6401 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] sijie commented on a change in pull request #6384: [Issue 4804][Schema] encode null key/value in KeyValue

2020-02-24 Thread GitBox
sijie commented on a change in pull request #6384: [Issue 4804][Schema] encode null key/value in KeyValue URL: https://github.com/apache/pulsar/pull/6384#discussion_r383483473 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/common/schema/KeyValue.java ##

[GitHub] [pulsar] sijie commented on issue #6406: [Issue 3762][Schema] Fix wrong avro schema

2020-02-24 Thread GitBox
sijie commented on issue #6406: [Issue 3762][Schema] Fix wrong avro schema URL: https://github.com/apache/pulsar/pull/6406#issuecomment-590516191 /pulsarbot run-failure-checks This is an automated message from the Apache Git

[pulsar] branch master updated (739c0dd -> 1fcccd6)

2020-02-24 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 739c0dd removed comma from yaml config (#6402) add 1fcccd6 Fix broker client tls settings error (#6128) No

[GitHub] [pulsar] sijie commented on issue #6410: distribute Python client library as a Conda package

2020-02-24 Thread GitBox
sijie commented on issue #6410: distribute Python client library as a Conda package URL: https://github.com/apache/pulsar/issues/6410#issuecomment-590527437 @chairmank I assigned the issue to you. Thank you for volunteering to work on this!

[GitHub] [pulsar] sijie commented on issue #6410: distribute Python client library as a Conda package

2020-02-24 Thread GitBox
sijie commented on issue #6410: distribute Python client library as a Conda package URL: https://github.com/apache/pulsar/issues/6410#issuecomment-590527105 > However, the apache-bookkeeper-client dependency (and its transitive dependencies) may need to be built and released as Conda

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590554046 Here's the chain of events in the logs during the success-case around when the problem occurs: ```

[GitHub] [pulsar] vzhikserg commented on issue #6412: Remove duplicated lombok annotations in the tests module

2020-02-24 Thread GitBox
vzhikserg commented on issue #6412: Remove duplicated lombok annotations in the tests module URL: https://github.com/apache/pulsar/pull/6412#issuecomment-590556640 /pulsarbot run-failure-checks This is an automated message

[GitHub] [pulsar] devinbost removed a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost removed a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590563892 I added a try/catch to the finally block in ParserProxyHandler, and I got a lot more useful

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590563892 I added a try/catch to the finally block in ParserProxyHandler, and I got a lot more useful information!

[GitHub] [pulsar] vzhikserg commented on issue #6412: Remove duplicated lombok annotations in the tests module

2020-02-24 Thread GitBox
vzhikserg commented on issue #6412: Remove duplicated lombok annotations in the tests module URL: https://github.com/apache/pulsar/pull/6412#issuecomment-590573864 /pulsarbot run-failure-checks This is an automated message

[GitHub] [pulsar] vzhikserg commented on issue #6406: [Issue 3762][Schema] Fix wrong avro schema

2020-02-24 Thread GitBox
vzhikserg commented on issue #6406: [Issue 3762][Schema] Fix wrong avro schema URL: https://github.com/apache/pulsar/pull/6406#issuecomment-590557034 /pulsarbot run-failure-checks This is an automated message from the Apache

[GitHub] [pulsar] vzhikserg removed a comment on issue #6412: Remove duplicated lombok annotations in the tests module

2020-02-24 Thread GitBox
vzhikserg removed a comment on issue #6412: Remove duplicated lombok annotations in the tests module URL: https://github.com/apache/pulsar/pull/6412#issuecomment-590556640 /pulsarbot run-failure-checks This is an automated

[GitHub] [pulsar] racorn opened a new issue #6414: High CPU load when PulsarClient (Java) is idle

2020-02-24 Thread GitBox
racorn opened a new issue #6414: High CPU load when PulsarClient (Java) is idle URL: https://github.com/apache/pulsar/issues/6414 **Describe the bug** Running a simple consumer on Windows using the `PulsarClient`, I notice that there is considerable CPU usage when the consumer is just

[GitHub] [pulsar] pl6306 closed issue #6185: persistent://public/default/extract-text-.* does match everything topic starts with extract-text?

2020-02-24 Thread GitBox
pl6306 closed issue #6185: persistent://public/default/extract-text-.* does match everything topic starts with extract-text? URL: https://github.com/apache/pulsar/issues/6185 This is an automated message from the Apache Git

[GitHub] [pulsar] pl6306 commented on issue #6185: persistent://public/default/extract-text-.* does match everything topic starts with extract-text?

2020-02-24 Thread GitBox
pl6306 commented on issue #6185: persistent://public/default/extract-text-.* does match everything topic starts with extract-text? URL: https://github.com/apache/pulsar/issues/6185#issuecomment-590652169 Thanks I get it now. I have to do re.compile first.

[GitHub] [pulsar] pawellozinski commented on issue #6399: [#6228][pulsar-zookeeper-utils] Close ZK before canceling future with exception

2020-02-24 Thread GitBox
pawellozinski commented on issue #6399: [#6228][pulsar-zookeeper-utils] Close ZK before canceling future with exception URL: https://github.com/apache/pulsar/pull/6399#issuecomment-590558711 `AuthPluginTest.testTlsDetectHttpsWithHostNameValidation` must be a fragile test, can't see how

[GitHub] [pulsar] devinbost opened a new issue #6413: [pulsar-proxy] Netty resource leak

2020-02-24 Thread GitBox
devinbost opened a new issue #6413: [pulsar-proxy] Netty resource leak URL: https://github.com/apache/pulsar/issues/6413 I found this resource leak in the logs while debugging this issue: https://github.com/apache/pulsar/issues/6332 ``` 22:02:46.655

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590568494 Interestingly, I'm noticing a little more information in the log now for this test: ``` [ERROR]

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590655883 @jiazhai I added a lot more debugging statements, and I discovered that the

[GitHub] [pulsar] codelipenghui commented on issue #6404: Issue-6403: Consumer received duplicated deplayed messages upon restart

2020-02-24 Thread GitBox
codelipenghui commented on issue #6404: Issue-6403: Consumer received duplicated deplayed messages upon restart URL: https://github.com/apache/pulsar/pull/6404#issuecomment-590669204 /pulsarbot run-failure-checks This is an

[GitHub] [pulsar] rocketraman commented on issue #3762: Shading Avro in pulsar-client

2020-02-24 Thread GitBox
rocketraman commented on issue #3762: Shading Avro in pulsar-client URL: https://github.com/apache/pulsar/issues/3762#issuecomment-590709249 @codelipenghui I notice the issue was closed, but I doubt the fix will handle my situation. While it does at least get the actual underlying schema,

[GitHub] [pulsar] devinbost edited a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost edited a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590708692 At a closer look, that result only occurred after the first failure. During the first failure, the

[GitHub] [pulsar] rocketraman edited a comment on issue #3762: Shading Avro in pulsar-client

2020-02-24 Thread GitBox
rocketraman edited a comment on issue #3762: Shading Avro in pulsar-client URL: https://github.com/apache/pulsar/issues/3762#issuecomment-590709249 @codelipenghui I notice the issue was closed, but I doubt the fix will handle my

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590720016 Sure enough, when I set local breakpoints, I never hit those two methods on ProxyConnection because the

[GitHub] [pulsar] jiazhai commented on a change in pull request #6407: [Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei…

2020-02-24 Thread GitBox
jiazhai commented on a change in pull request #6407: [Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei… URL: https://github.com/apache/pulsar/pull/6407#discussion_r383704326 ## File path:

[GitHub] [pulsar] tuteng commented on issue #6390: fix duplicate key to send propertys

2020-02-24 Thread GitBox
tuteng commented on issue #6390: fix duplicate key to send propertys URL: https://github.com/apache/pulsar/pull/6390#issuecomment-590670866 /pulsarbot run-failure-checks This is an automated message from the Apache Git

[GitHub] [pulsar] murong00 edited a comment on issue #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

2020-02-24 Thread GitBox
murong00 edited a comment on issue #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster URL: https://github.com/apache/pulsar/pull/5985#issuecomment-590674620 @sijie Thanks for the review, PTAL. This

[GitHub] [pulsar] murong00 commented on issue #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

2020-02-24 Thread GitBox
murong00 commented on issue #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster URL: https://github.com/apache/pulsar/pull/5985#issuecomment-590674620 @sijie Thanks for the review, PLAL. This is an

[GitHub] [pulsar] vzhikserg commented on issue #3762: Shading Avro in pulsar-client

2020-02-24 Thread GitBox
vzhikserg commented on issue #3762: Shading Avro in pulsar-client URL: https://github.com/apache/pulsar/issues/3762#issuecomment-590717610 @rocketraman the avro version was changed to 1.9.1 in pulsar 2.5.0 This is an

[GitHub] [pulsar] codelipenghui commented on issue #6390: fix duplicate key to send propertys

2020-02-24 Thread GitBox
codelipenghui commented on issue #6390: fix duplicate key to send propertys URL: https://github.com/apache/pulsar/pull/6390#issuecomment-590722772 /pulsarbot run-failure-checks This is an automated message from the Apache Git

[GitHub] [pulsar] addisonj opened a new issue #6416: In some instances, producers fail to create after a topic is scheduled onto previously used broker

2020-02-24 Thread GitBox
addisonj opened a new issue #6416: In some instances, producers fail to create after a topic is scheduled onto previously used broker URL: https://github.com/apache/pulsar/issues/6416 **Describe the bug** When a topic is unloaded from a broker, a producer can attempt to reconnect

[GitHub] [pulsar] tuteng commented on issue #6356: Independent schema is set for each consumer generated by topic

2020-02-24 Thread GitBox
tuteng commented on issue #6356: Independent schema is set for each consumer generated by topic URL: https://github.com/apache/pulsar/pull/6356#issuecomment-590672843 @congbobo184 Please look at sijie's comment. This is an

[GitHub] [pulsar] tuteng commented on issue #6365: Add retry when using async method to perform request in AsyncHttpConnector

2020-02-24 Thread GitBox
tuteng commented on issue #6365: Add retry when using async method to perform request in AsyncHttpConnector URL: https://github.com/apache/pulsar/pull/6365#issuecomment-590672446 @zymap Please look at the comment of sijie.

[GitHub] [pulsar] jiazhai commented on issue #5716: [Issues 5709]remove the namespace checking

2020-02-24 Thread GitBox
jiazhai commented on issue #5716: [Issues 5709]remove the namespace checking URL: https://github.com/apache/pulsar/pull/5716#issuecomment-590678683 @huangdx0726 Please first test these locally. `mvn test -pl pulsar-broker -Dtest= TopicsConsumerImplTest#multiTopicsInDifferentNameSpace `

[GitHub] [pulsar] yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590058080 /pulsarbot run-failure-checks This is an automated message from the Apache

[GitHub] [pulsar] yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590162413 /pulsarbot run-failure-checks This is an automated message from the Apache

[GitHub] [pulsar] yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590081895 /pulsarbot run-failure-checks This is an automated message from the Apache

[GitHub] [pulsar] yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
yjshen removed a comment on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590062804 /pulsarbot run-failure-checks This is an automated message from the Apache

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590708692 At a closer look, that result only occurred after the first failure. During the first failure, the logs

[GitHub] [pulsar] rocketraman commented on issue #3762: Shading Avro in pulsar-client

2020-02-24 Thread GitBox
rocketraman commented on issue #3762: Shading Avro in pulsar-client URL: https://github.com/apache/pulsar/issues/3762#issuecomment-590718558 @vzhikserg Thanks, that will work for me, though an underlying Avro upgrade probably would have been a good time to uncouple the Avro version from

[GitHub] [pulsar] devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost commented on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590719161 My hypothesis was right. I added these two methods to ProxyConnection: ``` @Override

[GitHub] [pulsar] jiazhai commented on issue #6407: [Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei…

2020-02-24 Thread GitBox
jiazhai commented on issue #6407: [Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei… URL: https://github.com/apache/pulsar/pull/6407#issuecomment-590731397 overall lgtm.

[GitHub] [pulsar] tuteng commented on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
tuteng commented on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590671158 @merlimat if you have time, PTAL This is an automated message from the Apache Git

[GitHub] [pulsar] murong00 commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

2020-02-24 Thread GitBox
murong00 commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster URL: https://github.com/apache/pulsar/pull/5985#discussion_r383649876 ## File path:

[GitHub] [pulsar] rattanjotsingh opened a new issue #6415: Pulsar Multi Cluster on Kubernetes (AWS)

2020-02-24 Thread GitBox
rattanjotsingh opened a new issue #6415: Pulsar Multi Cluster on Kubernetes (AWS) URL: https://github.com/apache/pulsar/issues/6415 **Is your feature request related to a problem? Please describe.** There is no documentation available on how to deploy pulsar on multi cluster on

[GitHub] [pulsar] devinbost edited a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost edited a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590708692 At a closer look, that result only occurred after the first failure. During the first failure, the

[GitHub] [pulsar] devinbost edited a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription

2020-02-24 Thread GitBox
devinbost edited a comment on issue #6332: (Flaky-test) Intermittent failure of ProxyParserTest.testRegexSubscription URL: https://github.com/apache/pulsar/issues/6332#issuecomment-590720016 Sure enough, when I set local breakpoints, I never hit those two methods on ProxyConnection

[GitHub] [pulsar] vishalananth07 opened a new issue #6408: Not able to create a Pulsar function

2020-02-24 Thread GitBox
vishalananth07 opened a new issue #6408: Not able to create a Pulsar function URL: https://github.com/apache/pulsar/issues/6408 **Describe the bug** We are trying to create a Pulsar function and deploy that in a bare-metal cluster we already have. We are creating the Exclamation

[pulsar] branch master updated (dab14ac -> 49c573c)

2020-02-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from dab14ac [Issue 3762][Schema] Fix the problem with parsing of an Avro schema related to shading in pulsar-client.

[GitHub] [pulsar] codelipenghui merged pull request #6412: Remove duplicated lombok annotations in the tests module

2020-02-24 Thread GitBox
codelipenghui merged pull request #6412: Remove duplicated lombok annotations in the tests module URL: https://github.com/apache/pulsar/pull/6412 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] codelipenghui closed issue #3762: Shading Avro in pulsar-client

2020-02-24 Thread GitBox
codelipenghui closed issue #3762: Shading Avro in pulsar-client URL: https://github.com/apache/pulsar/issues/3762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] codelipenghui merged pull request #6406: [Issue 3762][Schema] Fix wrong avro schema

2020-02-24 Thread GitBox
codelipenghui merged pull request #6406: [Issue 3762][Schema] Fix wrong avro schema URL: https://github.com/apache/pulsar/pull/6406 This is an automated message from the Apache Git Service. To respond to the message, please

[pulsar] branch master updated (1fcccd6 -> dab14ac)

2020-02-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1fcccd6 Fix broker client tls settings error (#6128) add dab14ac [Issue 3762][Schema] Fix the problem with

[GitHub] [pulsar] oeegee commented on issue #6342: Korean documentation is not built to the website

2020-02-24 Thread GitBox
oeegee commented on issue #6342: Korean documentation is not built to the website URL: https://github.com/apache/pulsar/issues/6342#issuecomment-590679490 Hi, @sijie. How do i do for this problem? This is an automated

[GitHub] [pulsar] jiazhai commented on a change in pull request #6407: [Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei…

2020-02-24 Thread GitBox
jiazhai commented on a change in pull request #6407: [Java client] MultiTopics discovery is broken due to discovery task scheduled twice instead of pendingBatchRecei… URL: https://github.com/apache/pulsar/pull/6407#discussion_r383703638 ## File path:

[GitHub] [pulsar] tuteng commented on issue #6122: [pulsar-admin] allow tenant admin to manage subscription permission

2020-02-24 Thread GitBox
tuteng commented on issue #6122: [pulsar-admin] allow tenant admin to manage subscription permission URL: https://github.com/apache/pulsar/pull/6122#issuecomment-590300544 ping @sijie @rdhabalia PTAL This is an automated

[GitHub] [pulsar] KannarFr commented on issue #6348: [Issue 6170][functions] add custom property option to functions

2020-02-24 Thread GitBox
KannarFr commented on issue #6348: [Issue 6170][functions] add custom property option to functions URL: https://github.com/apache/pulsar/pull/6348#issuecomment-590310180 @nlu90 oh, there few tests issues, can you check them?

[GitHub] [pulsar] tuteng edited a comment on issue #6203: [functions] Default functionAuthProvider when running in k8s

2020-02-24 Thread GitBox
tuteng edited a comment on issue #6203: [functions] Default functionAuthProvider when running in k8s URL: https://github.com/apache/pulsar/pull/6203#issuecomment-590299963 ping @addisonj Please try rebase master. This is an

[GitHub] [pulsar] tuteng commented on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
tuteng commented on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590301080 @merlimat PTAL This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] tuteng commented on issue #6362: [ClientAPI]Fix hasMessageAvailable()

2020-02-24 Thread GitBox
tuteng commented on issue #6362: [ClientAPI]Fix hasMessageAvailable() URL: https://github.com/apache/pulsar/pull/6362#issuecomment-590300940 /pulsarbot run-failure-checks This is an automated message from the Apache Git

[GitHub] [pulsar] KannarFr commented on issue #6348: [Issue 6170][functions] add custom property option to functions

2020-02-24 Thread GitBox
KannarFr commented on issue #6348: [Issue 6170][functions] add custom property option to functions URL: https://github.com/apache/pulsar/pull/6348#issuecomment-590309484 @sijie can we merge this? This is an automated message

[GitHub] [pulsar] tuteng commented on issue #6203: [functions] Default functionAuthProvider when running in k8s

2020-02-24 Thread GitBox
tuteng commented on issue #6203: [functions] Default functionAuthProvider when running in k8s URL: https://github.com/apache/pulsar/pull/6203#issuecomment-590299963 ping @addisonj This is an automated message from the

[GitHub] [pulsar] avimas opened a new pull request #6407: Java client MultiTopics discovery topic discovery task scheduled twice instead of pendingBatchRecei…

2020-02-24 Thread GitBox
avimas opened a new pull request #6407: Java client MultiTopics discovery topic discovery task scheduled twice instead of pendingBatchRecei… URL: https://github.com/apache/pulsar/pull/6407 I wanted to use the topicPattern feature and found out it is broken due to the discovery task

[GitHub] [pulsar] KannarFr opened a new issue #6409: Pull Request checks detected documentation changes but it's not

2020-02-24 Thread GitBox
KannarFr opened a new issue #6409: Pull Request checks detected documentation changes but it's not URL: https://github.com/apache/pulsar/issues/6409 **Describe the bug** On https://github.com/apache/pulsar/pull/6381, the checks are detected as documentation changes but it's not. So

[GitHub] [pulsar] KannarFr commented on a change in pull request #6381: [Issue 6283][Offloaders] WIP - Offload policies per ns with deletionLag & threshold

2020-02-24 Thread GitBox
KannarFr commented on a change in pull request #6381: [Issue 6283][Offloaders] WIP - Offload policies per ns with deletionLag & threshold URL: https://github.com/apache/pulsar/pull/6381#discussion_r383206446 ## File path:

[GitHub] [pulsar] Lanayx commented on issue #4708: standalone mode cannot sync MaxMessageSize to bookkeeper

2020-02-24 Thread GitBox
Lanayx commented on issue #4708: standalone mode cannot sync MaxMessageSize to bookkeeper URL: https://github.com/apache/pulsar/issues/4708#issuecomment-59025 The issue is still relevant with 2.5.0 - you still need to set nettyMaxFrameSizeBytes to bookeeper.conf and not rely on

[GitHub] [pulsar] KannarFr commented on a change in pull request #6381: [Issue 6283][Offloaders] WIP - Offload policies per ns with deletionLag & threshold

2020-02-24 Thread GitBox
KannarFr commented on a change in pull request #6381: [Issue 6283][Offloaders] WIP - Offload policies per ns with deletionLag & threshold URL: https://github.com/apache/pulsar/pull/6381#discussion_r383205216 ## File path:

  1   2   >