[GitHub] maskit commented on issue #3004: Use boost::once instead of pthread_once

2018-11-17 Thread GitBox
maskit commented on issue #3004: Use boost::once instead of pthread_once URL: https://github.com/apache/pulsar/pull/3004#issuecomment-439670255 Can we use `std::call_once` instead? This is an automated message from the Apache

[GitHub] merlimat opened a new pull request #3008: Remove the original zip when update netty lib name

2018-11-17 Thread GitBox
merlimat opened a new pull request #3008: Remove the original zip when update netty lib name URL: https://github.com/apache/pulsar/pull/3008 ### Motivation When rebuilding the Jar file to rename Netty so files, we need to remove the original file otherwise the `zip` tool is performi

[GitHub] merlimat opened a new pull request #3007: Removed AspectJ runtime agent loader

2018-11-17 Thread GitBox
merlimat opened a new pull request #3007: Removed AspectJ runtime agent loader URL: https://github.com/apache/pulsar/pull/3007 ### Motivation Removed the runtime agent loader for AspectJ since the project was deprecated and it only works in Java 8 with no plans to port to later versi

[GitHub] merlimat opened a new pull request #3006: [java-11] Compilation fixes

2018-11-17 Thread GitBox
merlimat opened a new pull request #3006: [java-11] Compilation fixes URL: https://github.com/apache/pulsar/pull/3006 ### Motivation Fixes to compile Pulsar sources with Java 11. Note: still few more changes are needed to work at runtime. -

[GitHub] srkukarni commented on issue #2985: Update Function Semantics

2018-11-17 Thread GitBox
srkukarni commented on issue #2985: Update Function Semantics URL: https://github.com/apache/pulsar/pull/2985#issuecomment-439651601 @jerrypeng I've addressed your comments. Note that this is pr primarily focuses on the functions front-end and already does some of the optimizations that

[GitHub] srkukarni commented on a change in pull request #2985: Update Function Semantics

2018-11-17 Thread GitBox
srkukarni commented on a change in pull request #2985: Update Function Semantics URL: https://github.com/apache/pulsar/pull/2985#discussion_r234423233 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@ -691,6 +701,23 @@ void

[GitHub] srkukarni commented on a change in pull request #2985: Update Function Semantics

2018-11-17 Thread GitBox
srkukarni commented on a change in pull request #2985: Update Function Semantics URL: https://github.com/apache/pulsar/pull/2985#discussion_r234423231 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java ## @@ -264,7

[GitHub] jerrypeng commented on issue #2985: Update Function Semantics

2018-11-17 Thread GitBox
jerrypeng commented on issue #2985: Update Function Semantics URL: https://github.com/apache/pulsar/pull/2985#issuecomment-439649705 @srkukarni this PR looks mostly good. Though we probably want to think about how a restart operation is carried out. Do we need to re-download the function

[GitHub] jerrypeng commented on a change in pull request #2985: Update Function Semantics

2018-11-17 Thread GitBox
jerrypeng commented on a change in pull request #2985: Update Function Semantics URL: https://github.com/apache/pulsar/pull/2985#discussion_r234420403 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@ -691,6 +701,23 @@ void

[GitHub] jerrypeng commented on a change in pull request #2985: Update Function Semantics

2018-11-17 Thread GitBox
jerrypeng commented on a change in pull request #2985: Update Function Semantics URL: https://github.com/apache/pulsar/pull/2985#discussion_r234420282 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarWorkerAssignmentTest.java ## @@ -264,7

[GitHub] jerrypeng opened a new pull request #3005: Fix bug for not setting resources

2018-11-17 Thread GitBox
jerrypeng opened a new pull request #3005: Fix bug for not setting resources URL: https://github.com/apache/pulsar/pull/3005 I also added unit test. However, I am not sure we are doing the right thing here. The method convertFromDetails is used to convert FunctionDetails to Functio

[GitHub] merlimat commented on issue #2995: Use AbstractCASReferenceCounted to ensure entry.retain() is valid

2018-11-17 Thread GitBox
merlimat commented on issue #2995: Use AbstractCASReferenceCounted to ensure entry.retain() is valid URL: https://github.com/apache/pulsar/pull/2995#issuecomment-439641310 run integration tests This is an automated message fr

[GitHub] jerrypeng commented on issue #3002: moving pulsar-spark tests into its own module

2018-11-17 Thread GitBox
jerrypeng commented on issue #3002: moving pulsar-spark tests into its own module URL: https://github.com/apache/pulsar/pull/3002#issuecomment-439633583 rerun integration tests This is an automated message from the Apache Git

[pulsar] branch master updated: Infer paralellism as well (#2999)

2018-11-17 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2d1db63 Infer paralellism as well (#2999) 2d

[GitHub] srkukarni closed pull request #2999: Infer paralellism as well

2018-11-17 Thread GitBox
srkukarni closed pull request #2999: Infer paralellism as well URL: https://github.com/apache/pulsar/pull/2999 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] merlimat commented on issue #3004: Use boost::once instead of pthread_once

2018-11-17 Thread GitBox
merlimat commented on issue #3004: Use boost::once instead of pthread_once URL: https://github.com/apache/pulsar/pull/3004#issuecomment-439631817 @maskit the idea is to make it possible to compile on Windows. Right now pthread is the only posix specific library we're using directly. --

[GitHub] merlimat commented on issue #3004: Use boost::once instead of pthread_once

2018-11-17 Thread GitBox
merlimat commented on issue #3004: Use boost::once instead of pthread_once URL: https://github.com/apache/pulsar/pull/3004#issuecomment-439631854 run integration tests This is an automated message from the Apache Git Service.

[GitHub] srkukarni commented on issue #2999: Infer paralellism as well

2018-11-17 Thread GitBox
srkukarni commented on issue #2999: Infer paralellism as well URL: https://github.com/apache/pulsar/pull/2999#issuecomment-439629407 rerun integration tests This is an automated message from the Apache Git Service. To respond

[GitHub] srkukarni commented on issue #2999: Infer paralellism as well

2018-11-17 Thread GitBox
srkukarni commented on issue #2999: Infer paralellism as well URL: https://github.com/apache/pulsar/pull/2999#issuecomment-439623871 rerun integration tests This is an automated message from the Apache Git Service. To respond

[GitHub] maskit commented on issue #3004: Use boost::once instead of pthread_once

2018-11-17 Thread GitBox
maskit commented on issue #3004: Use boost::once instead of pthread_once URL: https://github.com/apache/pulsar/pull/3004#issuecomment-439620579 What platforms are we going to support with this change? This is an automated mess

[GitHub] tuteng commented on issue #2998: support mysql binlog sync to pulsar by canal

2018-11-17 Thread GitBox
tuteng commented on issue #2998: support mysql binlog sync to pulsar by canal URL: https://github.com/apache/pulsar/pull/2998#issuecomment-439604156 Please take the time to review my code again. It has been changed and tested locally. ---

[GitHub] merlimat opened a new pull request #3004: Use boost::once instead of pthread_once

2018-11-17 Thread GitBox
merlimat opened a new pull request #3004: Use boost::once instead of pthread_once URL: https://github.com/apache/pulsar/pull/3004 ### Motivation Use `boost::once` instead of `pthread_once` because it's portable across platforms. -