[GitHub] david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-12-04 Thread GitBox
david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r238918485 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLe

[GitHub] codelipenghui edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned

2018-12-04 Thread GitBox
codelipenghui edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444334351 @jai1 > I would suggest to modify UnAckedMessageTracker instead of creating a new class. He

[GitHub] codelipenghui commented on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned

2018-12-04 Thread GitBox
codelipenghui commented on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444334351 @jai1 > I would suggest to modify UnAckedMessageTracker instead of creating a new class. Agree, i

[GitHub] grantwwu opened a new issue #3127: Python Pulsar client appears to throw regular Exceptions instead of Pulsar Exceptions

2018-12-04 Thread GitBox
grantwwu opened a new issue #3127: Python Pulsar client appears to throw regular Exceptions instead of Pulsar Exceptions URL: https://github.com/apache/pulsar/issues/3127 Expected behavior The Python client should throw a subclass of `Exception`, not just `Exception`. A

[GitHub] merlimat closed pull request #3124: Correct instances of 'availble' found

2018-12-04 Thread GitBox
merlimat closed pull request #3124: Correct instances of 'availble' found URL: https://github.com/apache/pulsar/pull/3124 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[pulsar] branch master updated: Correct instances of 'availble' found (#3124)

2018-12-04 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 322f2c6 Correct instances of 'availble' found (

[GitHub] merlimat commented on issue #3124: Correct instances of 'availble' found

2018-12-04 Thread GitBox
merlimat commented on issue #3124: Correct instances of 'availble' found URL: https://github.com/apache/pulsar/pull/3124#issuecomment-444318586 @grantwwu that's a command for Jenkins to re-kick the tests :) This is an a

[GitHub] grantwwu commented on issue #3124: Correct instances of 'availble' found

2018-12-04 Thread GitBox
grantwwu commented on issue #3124: Correct instances of 'availble' found URL: https://github.com/apache/pulsar/pull/3124#issuecomment-444317474 But these are only comment changes... This is an automated message from the Apache

[GitHub] cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444314020 About RegionAwareEnsemblePlacementPolicy vs RackawareEnsemblePlacementPolicy, it seems the former one will order between region

[GitHub] srkukarni closed pull request #3123: Fixed Kubernetes runtime bug

2018-12-04 Thread GitBox
srkukarni closed pull request #3123: Fixed Kubernetes runtime bug URL: https://github.com/apache/pulsar/pull/3123 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[pulsar] branch master updated: Fixed Kubernetes runtime bug (#3123)

2018-12-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e5a9ec3 Fixed Kubernetes runtime bug (#3123)

[GitHub] srkukarni closed pull request #3125: ignore unknown properties in worker config

2018-12-04 Thread GitBox
srkukarni closed pull request #3125: ignore unknown properties in worker config URL: https://github.com/apache/pulsar/pull/3125 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] cbornet edited a comment on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet edited a comment on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444305423 ~~Actually, reading the code, it seems that the client will already use `selectFromNetworkLocation` which will do `selectR

[pulsar] branch master updated: ignore unknown properties in worker config (#3125)

2018-12-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 032df08 ignore unknown properties in worker

[GitHub] merlimat commented on issue #3125: ignore unknown properties in worker config

2018-12-04 Thread GitBox
merlimat commented on issue #3125: ignore unknown properties in worker config URL: https://github.com/apache/pulsar/pull/3125#issuecomment-444309698 @jerrypeng This could be done by always using the preconfigured mapper when deserializing. Eg.: ```java ObjectMapperFactory.getThre

[GitHub] merlimat commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
merlimat commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444306383 > In the case of Pulsar that means I should add rack info for the Broker as if it were a bookie, no ? eg using the /admin/v2/boo

[GitHub] cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444305423 Actually, reading the code, it seems that the client will already use `selectFromNetworkLocation` which will do `selectRandomFrom

[GitHub] srkukarni commented on issue #3095: [Pulsar-Netty] Add Netty Connector Support for Tcp Messages

2018-12-04 Thread GitBox
srkukarni commented on issue #3095: [Pulsar-Netty] Add Netty Connector Support for Tcp Messages URL: https://github.com/apache/pulsar/pull/3095#issuecomment-444303733 @erenavsarogullari I think that it makes more sense to put them into pulsar-io as sources and sinks. That way we keep the c

[GitHub] srkukarni commented on issue #3123: Fixed Kubernetes runtime bug

2018-12-04 Thread GitBox
srkukarni commented on issue #3123: Fixed Kubernetes runtime bug URL: https://github.com/apache/pulsar/pull/3123#issuecomment-444302196 #3122 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] srkukarni commented on issue #3124: Correct instances of 'availble' found

2018-12-04 Thread GitBox
srkukarni commented on issue #3124: Correct instances of 'availble' found URL: https://github.com/apache/pulsar/pull/3124#issuecomment-444302077 run java8 tests This is an automated message from the Apache Git Service. To resp

[GitHub] srkukarni commented on issue #3123: Fixed Kubernetes runtime bug

2018-12-04 Thread GitBox
srkukarni commented on issue #3123: Fixed Kubernetes runtime bug URL: https://github.com/apache/pulsar/pull/3123#issuecomment-444301125 run integration tests This is an automated message from the Apache Git Service. To respond

[GitHub] erenavsarogullari opened a new pull request #3126: [Message Routing] Set CustomPartition when messageRouter is set

2018-12-04 Thread GitBox
erenavsarogullari opened a new pull request #3126: [Message Routing] Set CustomPartition when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126 ### Motivation This PR proposes some refactoring and fixes on message routing logic. ### Modifications - `getMessag

[GitHub] sijie commented on issue #3120: Fix calendar link

2018-12-04 Thread GitBox
sijie commented on issue #3120: Fix calendar link URL: https://github.com/apache/pulsar/pull/3120#issuecomment-444292054 run integration tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
sijie commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444291637 @cbornet : > And it shouldn't be hard to expose. I'll try it and propose a PR if it works. that would be great!

[GitHub] jai1 edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned

2018-12-04 Thread GitBox
jai1 edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444284382 I would suggest to modify UnAckedMessageTracker instead of creating a new class. - Change ConsumerConfig

[GitHub] jai1 edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned

2018-12-04 Thread GitBox
jai1 edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444284382 I would suggest to modify UnAckedMessageTracker instead of creating a new class. - Change ConsumerConfig

[GitHub] jai1 commented on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned

2018-12-04 Thread GitBox
jai1 commented on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444284382 I would suggest to modify UnAckedMessageTracker instead of creating a new class. - Change ConsumerConfig => `se

[GitHub] jerrypeng opened a new pull request #3125: ignore unknown properties in worker config

2018-12-04 Thread GitBox
jerrypeng opened a new pull request #3125: ignore unknown properties in worker config URL: https://github.com/apache/pulsar/pull/3125 ### Motivation Ignore unknown properties declared in worker config file instead for throwing exception. For backwards compatibility purposes so that

[GitHub] jerrypeng commented on issue #3115: JSONSchema should works with generic (parameterized type) POJO/DTO.

2018-12-04 Thread GitBox
jerrypeng commented on issue #3115: JSONSchema should works with generic (parameterized type) POJO/DTO. URL: https://github.com/apache/pulsar/issues/3115#issuecomment-444276155 So we use Avro underneath to generate a schema for the class. Parameterized/generics in Java are currently not s

[GitHub] cbornet edited a comment on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet edited a comment on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444265913 Also it seems the broker BK client has [support for RackawareEnsemblePlacementPolicy](https://github.com/apache/pulsar/blo

[GitHub] cbornet edited a comment on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet edited a comment on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444265913 Also it seems the broker BK client has support for RackawareEnsemblePlacementPolicy but not for RegionAwareEnsemblePlacem

[GitHub] cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444265913 Also it seems the broker BK client has support for RackawareEnsemblePlacementPolicy but not for RegionAwareEnsemblePlacementPolic

[GitHub] cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444263752 @sijie indeed, that looks like exactly it ! As always 😃 ! And it shouldn't be hard to expose. I'll try it and propose a PR if it

[GitHub] grantwwu opened a new pull request #3124: Correct instances of 'available' found

2018-12-04 Thread GitBox
grantwwu opened a new pull request #3124: Correct instances of 'available' found URL: https://github.com/apache/pulsar/pull/3124 Fix another typo The Java one was discovered during `git grep availble`. This is an automa

[GitHub] srkukarni commented on issue #3123: Fixed Kubernetes runtime bug

2018-12-04 Thread GitBox
srkukarni commented on issue #3123: Fixed Kubernetes runtime bug URL: https://github.com/apache/pulsar/pull/3123#issuecomment-444238965 @cckellogg This is an automated message from the Apache Git Service. To respond to the me

[GitHub] srkukarni opened a new pull request #3123: Fixed Kubernetes runtime bug

2018-12-04 Thread GitBox
srkukarni opened a new pull request #3123: Fixed Kubernetes runtime bug URL: https://github.com/apache/pulsar/pull/3123 ### Motivation / are not allowed in labels. ### Modifications Describe the modifications you've done. ### Result After your change, what

[GitHub] sijie commented on issue #3120: Fix calendar link

2018-12-04 Thread GitBox
sijie commented on issue #3120: Fix calendar link URL: https://github.com/apache/pulsar/pull/3120#issuecomment-444234274 run integration tests This is an automated message from the Apache Git Service. To respond to the message

[GitHub] jerrypeng commented on issue #3116: Error pulsar-admin functions localrun with javax validation-api 2.x (standalone)

2018-12-04 Thread GitBox
jerrypeng commented on issue #3116: Error pulsar-admin functions localrun with javax validation-api 2.x (standalone) URL: https://github.com/apache/pulsar/issues/3116#issuecomment-444228351 Interesting. We shade almost everything in the function instance jar but not javax. Not sure if it

[GitHub] cckellogg opened a new issue #3122: kubernetes fucntion labels are not formatted correctly

2018-12-04 Thread GitBox
cckellogg opened a new issue #3122: kubernetes fucntion labels are not formatted correctly URL: https://github.com/apache/pulsar/issues/3122 Kubernetes does not allow "/" in the label or selector values * spec.selector: Invalid value: "public/default/log": a valid label must be an e

[GitHub] sijie commented on issue #3117: [conf] Add annotations for documenting function worker configuration settings

2018-12-04 Thread GitBox
sijie commented on issue #3117: [conf] Add annotations for documenting function worker configuration settings URL: https://github.com/apache/pulsar/pull/3117#issuecomment-444214177 run java8 tests run integration tests Th

[GitHub] sijie commented on issue #3113: [conf] Add annotations for documenting broker configuration settings

2018-12-04 Thread GitBox
sijie commented on issue #3113: [conf] Add annotations for documenting broker configuration settings URL: https://github.com/apache/pulsar/pull/3113#issuecomment-444214033 run java8 tests run integration tests This is an

[GitHub] sijie commented on issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
sijie commented on issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119#issuecomment-444213425 @cbornet I think it should be already available via configuring `reorderReadSequenceEnabled` in bookkeeper client. https://github.

[GitHub] sijie commented on issue #3121: Several issues with the kubernetes generic example

2018-12-04 Thread GitBox
sijie commented on issue #3121: Several issues with the kubernetes generic example URL: https://github.com/apache/pulsar/issues/3121#issuecomment-444211490 copied the conversation from slack to here. I think the main problem is the deployment was changed to using statefulset deployment, bu

[pulsar] branch master updated: Add log dir creation in ProcessRuntime (#3114)

2018-12-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 45b6d73 Add log dir creation in ProcessRunti

[GitHub] sijie commented on issue #3120: Fix calendar link

2018-12-04 Thread GitBox
sijie commented on issue #3120: Fix calendar link URL: https://github.com/apache/pulsar/pull/3120#issuecomment-444209322 run integration tests This is an automated message from the Apache Git Service. To respond to the message

[GitHub] srkukarni closed pull request #3114: Add log dir creation in ProcessRuntime

2018-12-04 Thread GitBox
srkukarni closed pull request #3114: Add log dir creation in ProcessRuntime URL: https://github.com/apache/pulsar/pull/3114 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] pvanderlinden commented on issue #3121: Several issues with the kubernetes generic example

2018-12-04 Thread GitBox
pvanderlinden commented on issue #3121: Several issues with the kubernetes generic example URL: https://github.com/apache/pulsar/issues/3121#issuecomment-444138179 The zookeeper fix might not be needed as kubernetes will just restart the pod and by that time zookeeper should be available

[GitHub] pvanderlinden opened a new issue #3121: Several issues with the kubernetes generic example

2018-12-04 Thread GitBox
pvanderlinden opened a new issue #3121: Several issues with the kubernetes generic example URL: https://github.com/apache/pulsar/issues/3121 Expected behavior It should be able to be adjusted to run more then one bookie. Actual behavior When you adjust the kubernetes

[GitHub] sijie opened a new pull request #3120: Fix calendar link

2018-12-04 Thread GitBox
sijie opened a new pull request #3120: Fix calendar link URL: https://github.com/apache/pulsar/pull/3120 ### Motivation It seems `&` cause calendar doesn't show as expected. This is an automated message from the Apache

[GitHub] cbornet opened a new issue #3119: [Feature request] Make brokers read on closest Bookie

2018-12-04 Thread GitBox
cbornet opened a new issue #3119: [Feature request] Make brokers read on closest Bookie URL: https://github.com/apache/pulsar/issues/3119 Rack-aware policy can be used to place bookies on different racks/AZ/regions. Brokers can be isolated in racks/AZ/regions with a namespace-isolation-

[GitHub] ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-12-04 Thread GitBox
ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r238580622 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOf

[GitHub] ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-12-04 Thread GitBox
ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r238582149 ## File path: tiered-storage/jcloud/pom.xml ## @@ -41,7 +41,7 @@ org.apache.pulsar jclouds-shad

[GitHub] ivankelly commented on issue #2865: Refactored JCloud Tiered Storage

2018-12-04 Thread GitBox
ivankelly commented on issue #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#issuecomment-444032808 rerun integration tests This is an automated message from the Apache Git Service. To r

[GitHub] codelipenghui commented on issue #3118: UnAcked message tracker based on HashedWheelTimer

2018-12-04 Thread GitBox
codelipenghui commented on issue #3118: UnAcked message tracker based on HashedWheelTimer URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444018776 @jiazhai I'm already add a TimePartitionedUnAckedMessage Tracker