[GitHub] [pulsar] yittg commented on issue #4966: [dashboard] integrate peek into messages page
yittg commented on issue #4966: [dashboard] integrate peek into messages page URL: https://github.com/apache/pulsar/pull/4966#issuecomment-521891607 by the way, we may fix other admin request base path in another PR @sijie This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yittg commented on issue #4966: [dashboard] integrate peek into messages page
yittg commented on issue #4966: [dashboard] integrate peek into messages page URL: https://github.com/apache/pulsar/pull/4966#issuecomment-521890799 A sample screenshot here,  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing commented on issue #4963: Add more config for auto-topic-creation
fxbing commented on issue #4963: Add more config for auto-topic-creation URL: https://github.com/apache/pulsar/pull/4963#issuecomment-521877466 > Also change "partition" and "non-partition" to "partitioned" and "non-partitioned". It might be also worth considering adding an enum like `TopicType`? OK， I will make a change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing edited a comment on issue #4963: Add more config for auto-topic-creation
fxbing edited a comment on issue #4963: Add more config for auto-topic-creation URL: https://github.com/apache/pulsar/pull/4963#issuecomment-521877181 > @fxbing it is a nice motivation. but I am feeling that you didn't change the code in the right place. the change in fetchPartitionedTopicMetadataAsync will introduce unnecessary creation of partitioned topic. The `auto-creation` happens when a producer or a consumer connects to broker. so I think the change should be done in `BrokerService`. You can check the methods `getOrCreateTopic`. I first thought about making changes in the BrokerService, but when the client requests to create a Producer or Consumer, it will first get partitions info from zk, decide whether to create partitioned or non-partitioned. When the request arrives at the BrokerService, the client has decided to create a nonpartitioned Producer or Consumer. If the Broker's configuration requires automatic creation of a partitioned topic, Broker needs to send the configuration information to client, client re-establishes the partitioned Producer or Consumer, and the BrokerService updates the partitions in the zk. I think it's easier to make changes when the client creates the type that determines the creation, and need fewer communications. Do I need to modify it as I said above? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing commented on issue #4963: Add more config for auto-topic-creation
fxbing commented on issue #4963: Add more config for auto-topic-creation URL: https://github.com/apache/pulsar/pull/4963#issuecomment-521877181 > @fxbing it is a nice motivation. but I am feeling that you didn't change the code in the right place. the change in fetchPartitionedTopicMetadataAsync will introduce unnecessary creation of partitioned topic. The `auto-creation` happens when a producer or a consumer connects to broker. so I think the change should be done in `BrokerService`. You can check the methods `getOrCreateTopic`. I first thought about making changes in the BrokerService, but when the client requests to create a Producer or Consumer, it will first get `metedata.partitions`, decide whether to create partitioned or non-partitioned. When the request arrives at the BrokerService, the client has decided to create a nonpartitioned Producer or Consumer. If the Broker's configuration requires automatic creation of a partitioned topic, Broker needs to send the configuration information to client, client re-establishes the partitioned Producer or Consumer, and the BrokerService updates the partitions in the zk. I think it's easier to make changes when the client creates the type that determines the creation, and need fewer communications. Do I need to modify it as I said above? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on a change in pull request #4911: expose getLastMessageId method in ConsumerImpl
codelipenghui commented on a change in pull request #4911: expose
getLastMessageId method in ConsumerImpl
URL: https://github.com/apache/pulsar/pull/4911#discussion_r314576573
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiMessageIdImpl.java
##
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Objects;
+import lombok.Getter;
+import org.apache.pulsar.client.api.MessageId;
+import sun.reflect.generics.reflectiveObjects.NotImplementedException;
+
+/**
+ * A MessageId implementation that contains a map of .
+ * This is useful when MessageId is need for partition/multi-topics/pattern
consumer.
+ * e.g. seek(), ackCumulative(), getLastMessageId().
+ */
+public class MultiMessageIdImpl implements MessageId {
+@Getter
+private Map map;
Review comment:
Should be final?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new pull request #4968: Config
Jennifer88huang opened a new pull request #4968: Config URL: https://github.com/apache/pulsar/pull/4968 Fixes #4554 ### Motivation Add a new configure tutorial for new Pulsar Functions structure. ### Modifications Based on #4846, I'd added the Pulsar Functions configure content. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] pouledodue commented on issue #4943: pulsar-admin functions querystate => Reason: java.lang.NullPointerException: path is 'null'.
pouledodue commented on issue #4943: pulsar-admin functions querystate => Reason: java.lang.NullPointerException: path is 'null'. URL: https://github.com/apache/pulsar/issues/4943#issuecomment-521874218 it's ok when specifying a key so just needs a cosmetic fix for when the key is not specified ``` $ pulsar-admin functions querystate --fqfn public/default/yoshi -k goumba ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on a change in pull request #4950: Modify rest api post schema compatibility strategy
congbobo184 commented on a change in pull request #4950: Modify rest api post
schema compatibility strategy
URL: https://github.com/apache/pulsar/pull/4950#discussion_r314572145
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/SchemasResource.java
##
@@ -310,31 +310,49 @@ public void postSchema(
) {
validateDestinationAndAdminOperation(tenant, namespace, topic,
authoritative);
-pulsar().getSchemaRegistryService().putSchemaIfAbsent(
-buildSchemaId(tenant, namespace, topic),
-SchemaData.builder()
-.data(payload.getSchema().getBytes(Charsets.UTF_8))
-.isDeleted(false)
-.timestamp(clock.millis())
-.type(SchemaType.valueOf(payload.getType()))
-.user(defaultIfEmpty(clientAppId(), ""))
-.props(payload.getProperties())
-.build(),
-SchemaCompatibilityStrategy.FULL
-).thenAccept(version ->
-response.resume(
-Response.accepted().entity(
-PostSchemaResponse.builder()
-.version(version)
-.build()
-).build()
-)
-).exceptionally(error -> {
-if (error instanceof IncompatibleSchemaException) {
-
response.resume(Response.status(Response.Status.CONFLICT).build());
-} else if (error instanceof InvalidSchemaDataException) {
+NamespaceName namespaceName = NamespaceName.get(tenant, namespace);
+getNamespacePoliciesAsync(namespaceName).thenAccept(policies -> {
+SchemaCompatibilityStrategy schemaCompatibilityStrategy =
SchemaCompatibilityStrategy
+
.fromAutoUpdatePolicy(policies.schema_auto_update_compatibility_strategy);
+pulsar().getSchemaRegistryService().putSchemaIfAbsent(
+buildSchemaId(tenant, namespace, topic),
+SchemaData.builder()
+.data(payload.getSchema().getBytes(Charsets.UTF_8))
+.isDeleted(false)
+.timestamp(clock.millis())
+.type(SchemaType.valueOf(payload.getType()))
+.user(defaultIfEmpty(clientAppId(), ""))
+.props(payload.getProperties())
+.build(),
+schemaCompatibilityStrategy
+
+).thenAccept(version ->
+response.resume(
+Response.accepted().entity(
+PostSchemaResponse.builder()
+.version(version)
+.build()
+).build()
+)
+).exceptionally(error -> {
+if (error.getCause() instanceof IncompatibleSchemaException) {
+
response.resume(Response.status(Response.Status.CONFLICT).build());
+} else if (error instanceof InvalidSchemaDataException) {
+response.resume(Response.status(
+422, /* Unprocessable Entity */
+error.getMessage()
+).build());
+} else {
+response.resume(
+Response.serverError().build()
+);
+}
+return null;
+});
+}).exceptionally(error -> {
+if (error.getCause() instanceof RestException) {
response.resume(Response.status(
-422, /* Unprocessable Entity */
+404, /* Unprocessable Entity */
Review comment:
OK, I will change it then return the response
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] congbobo184 commented on a change in pull request #4950: Modify rest api post schema compatibility strategy
congbobo184 commented on a change in pull request #4950: Modify rest api post
schema compatibility strategy
URL: https://github.com/apache/pulsar/pull/4950#discussion_r314572145
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/SchemasResource.java
##
@@ -310,31 +310,49 @@ public void postSchema(
) {
validateDestinationAndAdminOperation(tenant, namespace, topic,
authoritative);
-pulsar().getSchemaRegistryService().putSchemaIfAbsent(
-buildSchemaId(tenant, namespace, topic),
-SchemaData.builder()
-.data(payload.getSchema().getBytes(Charsets.UTF_8))
-.isDeleted(false)
-.timestamp(clock.millis())
-.type(SchemaType.valueOf(payload.getType()))
-.user(defaultIfEmpty(clientAppId(), ""))
-.props(payload.getProperties())
-.build(),
-SchemaCompatibilityStrategy.FULL
-).thenAccept(version ->
-response.resume(
-Response.accepted().entity(
-PostSchemaResponse.builder()
-.version(version)
-.build()
-).build()
-)
-).exceptionally(error -> {
-if (error instanceof IncompatibleSchemaException) {
-
response.resume(Response.status(Response.Status.CONFLICT).build());
-} else if (error instanceof InvalidSchemaDataException) {
+NamespaceName namespaceName = NamespaceName.get(tenant, namespace);
+getNamespacePoliciesAsync(namespaceName).thenAccept(policies -> {
+SchemaCompatibilityStrategy schemaCompatibilityStrategy =
SchemaCompatibilityStrategy
+
.fromAutoUpdatePolicy(policies.schema_auto_update_compatibility_strategy);
+pulsar().getSchemaRegistryService().putSchemaIfAbsent(
+buildSchemaId(tenant, namespace, topic),
+SchemaData.builder()
+.data(payload.getSchema().getBytes(Charsets.UTF_8))
+.isDeleted(false)
+.timestamp(clock.millis())
+.type(SchemaType.valueOf(payload.getType()))
+.user(defaultIfEmpty(clientAppId(), ""))
+.props(payload.getProperties())
+.build(),
+schemaCompatibilityStrategy
+
+).thenAccept(version ->
+response.resume(
+Response.accepted().entity(
+PostSchemaResponse.builder()
+.version(version)
+.build()
+).build()
+)
+).exceptionally(error -> {
+if (error.getCause() instanceof IncompatibleSchemaException) {
+
response.resume(Response.status(Response.Status.CONFLICT).build());
+} else if (error instanceof InvalidSchemaDataException) {
+response.resume(Response.status(
+422, /* Unprocessable Entity */
+error.getMessage()
+).build());
+} else {
+response.resume(
+Response.serverError().build()
+);
+}
+return null;
+});
+}).exceptionally(error -> {
+if (error.getCause() instanceof RestException) {
response.resume(Response.status(
-422, /* Unprocessable Entity */
+404, /* Unprocessable Entity */
Review comment:
OK, I will change it then return the response status
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #4944: Python 3.7 in Docker
aahmed-se commented on issue #4944: Python 3.7 in Docker URL: https://github.com/apache/pulsar/issues/4944#issuecomment-521866219 We are just using the default python provided by the debian, if 3.7 is needed best fork to build a custom image. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se opened a new issue #4967: Static linking for c/c++ libraries broken for osx
aahmed-se opened a new issue #4967: Static linking for c/c++ libraries broken for osx URL: https://github.com/apache/pulsar/issues/4967 unable to generated statically linked libraries on osx. ``` cmake . -DLINK_STATIC=ON -DBUILD_TESTS=OFF -DPYTHON_LIBRARY=/usr/local/Frameworks/Python.framework/Versions/2.7/lib/libpython2.7.dylib -DPYTHON_INCLUDE_DIR=/usr/local/Frameworks/Python.framework/Versions/2.7/include/python2.7 ``` ``` [ 97%] Building CXX object python/CMakeFiles/_pulsar.dir/src/reader.cc.o [100%] Building CXX object python/CMakeFiles/_pulsar.dir/src/schema.cc.o [100%] Linking CXX shared library _pulsar.so Undefined symbols for architecture x86_64: "_BrotliDecoderCreateInstance", referenced from: _brotli_init_writer in libcurl.a(libcurl_la-content_encoding.o) "_BrotliDecoderDecompressStream", referenced from: _brotli_unencode_write in libcurl.a(libcurl_la-content_encoding.o) "_BrotliDecoderDestroyInstance", referenced from: _brotli_unencode_write in libcurl.a(libcurl_la-content_encoding.o) _brotli_close_writer in libcurl.a(libcurl_la-content_encoding.o) "_BrotliDecoderGetErrorCode", referenced from: _brotli_unencode_write in libcurl.a(libcurl_la-content_encoding.o) "_BrotliDecoderVersion", referenced from: _curl_version_info in libcurl.a(libcurl_la-version.o) _brotli_version in libcurl.a(libcurl_la-version.o) "_RTMP_Alloc", referenced from: _rtmp_setup_connection in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_Close", referenced from: _rtmp_disconnect in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_Connect1", referenced from: _rtmp_connect in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_ConnectStream", referenced from: _rtmp_do in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_Free", referenced from: _rtmp_setup_connection in libcurl.a(libcurl_la-curl_rtmp.o) _rtmp_disconnect in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_Init", referenced from: _rtmp_setup_connection in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_Read", referenced from: _rtmp_recv in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_SetBufferMS", referenced from: _rtmp_setup_connection in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_SetupURL", referenced from: _rtmp_setup_connection in libcurl.a(libcurl_la-curl_rtmp.o) "_RTMP_Write", referenced from: _rtmp_send in libcurl.a(libcurl_la-curl_rtmp.o) "_ber_free", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_idn2_check_version", referenced from: _idnconvert_hostname in libcurl.a(libcurl_la-url.o) _curl_version in libcurl.a(libcurl_la-version.o) _curl_version_info in libcurl.a(libcurl_la-version.o) "_idn2_free", referenced from: _conn_free in libcurl.a(libcurl_la-url.o) _create_conn in libcurl.a(libcurl_la-url.o) "_idn2_lookup_ul", referenced from: _idnconvert_hostname in libcurl.a(libcurl_la-url.o) "_idn2_strerror", referenced from: _idnconvert_hostname in libcurl.a(libcurl_la-url.o) "_ldap_err2string", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_first_attribute", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_first_entry", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_free_urldesc", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_get_dn", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_get_values_len", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_init", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_memfree", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_msgfree", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_next_attribute", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_next_entry", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_search_s", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_set_option", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_simple_bind_s", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_unbind_s", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_url_parse", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_ldap_value_free_len", referenced from: _Curl_ldap in libcurl.a(libcurl_la-ldap.o) "_nghttp2_http2_strerror", referenced from: _http2_handle_stream_close in libcurl.a(libcurl_la-http2.o) "_nghttp2_is_fatal", referenced from:
[GitHub] [pulsar] sijie commented on issue #4965: Fix: NPE while cleaning up namespace node
sijie commented on issue #4965: Fix: NPE while cleaning up namespace node URL: https://github.com/apache/pulsar/pull/4965#issuecomment-521865828 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #4966: [dashboard] integrate peek into messages page
sijie commented on issue #4966: [dashboard] integrate peek into messages page URL: https://github.com/apache/pulsar/pull/4966#issuecomment-521865942 @tuteng can you help review this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #4904: [Pulsar IO]Pulsar IO support automatic loading of connector
aahmed-se commented on issue #4904: [Pulsar IO]Pulsar IO support automatic loading of connector URL: https://github.com/apache/pulsar/issues/4904#issuecomment-521865789 you can submit connectors via res api as a nar file , is that what you are looking for ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #4950: Modify rest api post schema compatibility strategy
sijie commented on a change in pull request #4950: Modify rest api post schema
compatibility strategy
URL: https://github.com/apache/pulsar/pull/4950#discussion_r314567770
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/SchemasResource.java
##
@@ -310,31 +310,49 @@ public void postSchema(
) {
validateDestinationAndAdminOperation(tenant, namespace, topic,
authoritative);
-pulsar().getSchemaRegistryService().putSchemaIfAbsent(
-buildSchemaId(tenant, namespace, topic),
-SchemaData.builder()
-.data(payload.getSchema().getBytes(Charsets.UTF_8))
-.isDeleted(false)
-.timestamp(clock.millis())
-.type(SchemaType.valueOf(payload.getType()))
-.user(defaultIfEmpty(clientAppId(), ""))
-.props(payload.getProperties())
-.build(),
-SchemaCompatibilityStrategy.FULL
-).thenAccept(version ->
-response.resume(
-Response.accepted().entity(
-PostSchemaResponse.builder()
-.version(version)
-.build()
-).build()
-)
-).exceptionally(error -> {
-if (error instanceof IncompatibleSchemaException) {
-
response.resume(Response.status(Response.Status.CONFLICT).build());
-} else if (error instanceof InvalidSchemaDataException) {
+NamespaceName namespaceName = NamespaceName.get(tenant, namespace);
+getNamespacePoliciesAsync(namespaceName).thenAccept(policies -> {
+SchemaCompatibilityStrategy schemaCompatibilityStrategy =
SchemaCompatibilityStrategy
+
.fromAutoUpdatePolicy(policies.schema_auto_update_compatibility_strategy);
+pulsar().getSchemaRegistryService().putSchemaIfAbsent(
+buildSchemaId(tenant, namespace, topic),
+SchemaData.builder()
+.data(payload.getSchema().getBytes(Charsets.UTF_8))
+.isDeleted(false)
+.timestamp(clock.millis())
+.type(SchemaType.valueOf(payload.getType()))
+.user(defaultIfEmpty(clientAppId(), ""))
+.props(payload.getProperties())
+.build(),
+schemaCompatibilityStrategy
+
+).thenAccept(version ->
+response.resume(
+Response.accepted().entity(
+PostSchemaResponse.builder()
+.version(version)
+.build()
+).build()
+)
+).exceptionally(error -> {
+if (error.getCause() instanceof IncompatibleSchemaException) {
+
response.resume(Response.status(Response.Status.CONFLICT).build());
+} else if (error instanceof InvalidSchemaDataException) {
+response.resume(Response.status(
+422, /* Unprocessable Entity */
+error.getMessage()
+).build());
+} else {
+response.resume(
+Response.serverError().build()
+);
+}
+return null;
+});
+}).exceptionally(error -> {
+if (error.getCause() instanceof RestException) {
response.resume(Response.status(
-422, /* Unprocessable Entity */
+404, /* Unprocessable Entity */
Review comment:
if it is RestException, you need to return the status of the RestException,
no?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #4951: Fix pull request 4700
sijie commented on issue #4951: Fix pull request 4700 URL: https://github.com/apache/pulsar/pull/4951#issuecomment-521865084 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #4952: [Transaction] Introduce Transaction Client API
sijie commented on issue #4952: [Transaction] Introduce Transaction Client API URL: https://github.com/apache/pulsar/pull/4952#issuecomment-521864991 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie merged pull request #4962: Fix the StructSchema load reader cache invalid
sijie merged pull request #4962: Fix the StructSchema load reader cache invalid URL: https://github.com/apache/pulsar/pull/4962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: Fix StructSchema reader cache loading logic
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 0367f5f Fix StructSchema reader cache loading logic
0367f5f is described below
commit 0367f5f0a236b26cfec74b272ca44a4c77eceda1
Author: congbo <39078850+congbobo...@users.noreply.github.com>
AuthorDate: Fri Aug 16 10:46:42 2019 +0800
Fix StructSchema reader cache loading logic
### Motivation
StructSchema LoadingCache for cache reader, but key is byte[], it will
compare with the address's hashcode. So every decode will generate a new
reader so we should change the type of the key for LoadingCache
---
.../java/org/apache/pulsar/client/impl/schema/AvroSchema.java | 9 +
.../java/org/apache/pulsar/client/impl/schema/JSONSchema.java | 3 ++-
.../org/apache/pulsar/client/impl/schema/ProtobufSchema.java | 3 ++-
.../org/apache/pulsar/client/impl/schema/StructSchema.java| 11 ++-
.../pulsar/client/impl/schema/generic/GenericAvroSchema.java | 11 ++-
.../pulsar/client/impl/schema/generic/GenericJsonSchema.java | 11 ++-
6 files changed, 27 insertions(+), 21 deletions(-)
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
index 4f4ae5a..9eddee5 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
@@ -26,6 +26,7 @@ import org.apache.pulsar.client.api.schema.SchemaDefinition;
import org.apache.pulsar.client.api.schema.SchemaReader;
import org.apache.pulsar.client.impl.schema.reader.AvroReader;
import org.apache.pulsar.client.impl.schema.writer.AvroWriter;
+import org.apache.pulsar.common.protocol.schema.BytesSchemaVersion;
import org.apache.pulsar.common.schema.SchemaInfo;
import org.apache.pulsar.common.schema.SchemaType;
import org.slf4j.Logger;
@@ -99,16 +100,16 @@ public class AvroSchema extends StructSchema {
}
@Override
-protected SchemaReader loadReader(byte[] schemaVersion) {
-SchemaInfo schemaInfo = getSchemaInfoByVersion(schemaVersion);
+protected SchemaReader loadReader(BytesSchemaVersion schemaVersion) {
+SchemaInfo schemaInfo = getSchemaInfoByVersion(schemaVersion.get());
if (schemaInfo != null) {
log.info("Load schema reader for version({}), schema is : {}",
-SchemaUtils.getStringSchemaVersion(schemaVersion),
+SchemaUtils.getStringSchemaVersion(schemaVersion.get()),
schemaInfo.getSchemaDefinition());
return new
AvroReader<>(parseAvroSchema(schemaInfo.getSchemaDefinition()), schema);
} else {
log.warn("No schema found for version({}), use latest schema : {}",
-SchemaUtils.getStringSchemaVersion(schemaVersion),
+SchemaUtils.getStringSchemaVersion(schemaVersion.get()),
this.schemaInfo.getSchemaDefinition());
return reader;
}
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java
index 04b249c..90a288e 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java
@@ -29,6 +29,7 @@ import org.apache.pulsar.client.api.schema.SchemaDefinition;
import org.apache.pulsar.client.api.schema.SchemaReader;
import org.apache.pulsar.client.impl.schema.reader.JsonReader;
import org.apache.pulsar.client.impl.schema.writer.JsonWriter;
+import org.apache.pulsar.common.protocol.schema.BytesSchemaVersion;
import org.apache.pulsar.common.schema.SchemaInfo;
import org.apache.pulsar.common.schema.SchemaType;
@@ -58,7 +59,7 @@ public class JSONSchema extends StructSchema {
}
@Override
-protected SchemaReader loadReader(byte[] schemaVersion) {
+protected SchemaReader loadReader(BytesSchemaVersion schemaVersion) {
throw new RuntimeException("JSONSchema don't support schema
versioning");
}
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ProtobufSchema.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ProtobufSchema.java
index b40f2ef..23dde95 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ProtobufSchema.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ProtobufSchema.java
@@ -29,6 +29,7 @@ import org.apache.pulsar.client.api.schema.SchemaDefinition;
import org.apache.pulsar.client.api.schema.SchemaReader;
import
[GitHub] [pulsar] sijie commented on issue #4962: Fix the StructSchema load reader cache invalid
sijie commented on issue #4962: Fix the StructSchema load reader cache invalid URL: https://github.com/apache/pulsar/pull/4962#issuecomment-521864598 @congbobo184 Nice catch! I thought I have fixed that in #4836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] yittg opened a new pull request #4966: [dashboard] integrate peek into messages page
yittg opened a new pull request #4966: [dashboard] integrate peek into messages page URL: https://github.com/apache/pulsar/pull/4966 ### Motivation messages page is under huge load with full list if there are massive messages in backlog. ### Modifications render messages with a prompt and input to choose which message to peek instead of full backlog message list. and render message peeked within messages page. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-client-node] branch master updated (5132c8e -> 9bc6646)
This is an automated email from the ASF dual-hosted git repository. hrsakai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git. from 5132c8e Merge pull request #44 from massakam/fix-compilation-warn new 10e74d5 Introduce license-check-and-add module new c9cba42 Update modules new 9bc6646 Merge pull request #45 from massakam/introduce-license-check-and-add The 52 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .clang-format|3 +- .eslintignore| 19 + .gitignore | 19 + license-header.txt | 16 + package-lock.json| 2040 +- package.json | 64 +- tests/end_to_end.test.js | 35 +- 7 files changed, 1223 insertions(+), 973 deletions(-) create mode 100644 license-header.txt
[pulsar-client-node] branch master updated: Fix compilation warning
This is an automated email from the ASF dual-hosted git repository.
hrsakai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git
The following commit(s) were added to refs/heads/master by this push:
new e47d92d Fix compilation warning
new 5132c8e Merge pull request #44 from massakam/fix-compilation-warn
e47d92d is described below
commit e47d92da39fd70e9834bb2587ff0f5fc5f405af8
Author: Masahiro Sakamoto
AuthorDate: Thu Aug 15 17:16:16 2019 +0900
Fix compilation warning
---
src/MessageId.cc | 14 ++
src/ReaderConfig.h | 4 ++--
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/src/MessageId.cc b/src/MessageId.cc
index ee6952c..96c1d5f 100644
--- a/src/MessageId.cc
+++ b/src/MessageId.cc
@@ -27,14 +27,12 @@ Napi::Object MessageId::Init(Napi::Env env, Napi::Object
exports) {
Napi::HandleScope scope(env);
Napi::Function func = DefineClass(env, "MessageId",
-{
-StaticMethod("earliest",
::Earliest, napi_static),
-StaticMethod("latest",
::Latest, napi_static),
-StaticMethod("finalize",
::Finalize, napi_static),
-InstanceMethod("serialize",
::Serialize),
-StaticMethod("deserialize",
::Deserialize, napi_static),
-InstanceMethod("toString",
::ToString)
-});
+{StaticMethod("earliest",
::Earliest, napi_static),
+ StaticMethod("latest",
::Latest, napi_static),
+ StaticMethod("finalize",
::Finalize, napi_static),
+ InstanceMethod("serialize",
::Serialize),
+ StaticMethod("deserialize",
::Deserialize, napi_static),
+ InstanceMethod("toString",
::ToString)});
constructor = Napi::Persistent(func);
constructor.SuppressDestruct();
diff --git a/src/ReaderConfig.h b/src/ReaderConfig.h
index 1983459..69fc634 100644
--- a/src/ReaderConfig.h
+++ b/src/ReaderConfig.h
@@ -34,9 +34,9 @@ class ReaderConfig {
std::string GetTopic();
private:
- pulsar_reader_configuration_t *cReaderConfig;
- pulsar_message_id_t *cStartMessageId;
std::string topic;
+ pulsar_message_id_t *cStartMessageId;
+ pulsar_reader_configuration_t *cReaderConfig;
};
#endif
[GitHub] [pulsar] rdhabalia opened a new pull request #4965: Fix: NPE while cleaning up namespace node
rdhabalia opened a new pull request #4965: Fix: NPE while cleaning up namespace node URL: https://github.com/apache/pulsar/pull/4965 ### Motivation It fixes below NPE ``` 16:17:50.180 [main INFO org.apache.pulsar.broker.PulsarService - Starting name space service, bootstrap namespaces= 16:17:50.204 [main ERROR org.apache.pulsar.broker.namespace.NamespaceService - null java.lang.NullPointerException: null at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupSingleNamespaceNode(ServiceUnitZkUtils.java:156) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupNamespaceNodes(ServiceUnitZkUtils.java:134) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupNamespaceNodes(ServiceUnitZkUtils.java:137) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.initZK(ServiceUnitZkUtils.java:113) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.NamespaceService.(NamespaceService.java:151) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.lambda$getNamespaceServiceProvider$1(PulsarService.java:584) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] mingfang opened a new issue #4964: Broker unable to restart
mingfang opened a new issue #4964: Broker unable to restart URL: https://github.com/apache/pulsar/issues/4964 I have a working Broker cluster with 3 replicas. When I bounce any of the replicas, then they fail to start. Here is the error ``` 16:17:50.180 [main INFO org.apache.pulsar.broker.PulsarService - Starting name space service, bootstrap namespaces= 16:17:50.204 [main ERROR org.apache.pulsar.broker.namespace.NamespaceService - null java.lang.NullPointerException: null at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupSingleNamespaceNode(ServiceUnitZkUtils.java:156) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupNamespaceNodes(ServiceUnitZkUtils.java:134) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupNamespaceNodes(ServiceUnitZkUtils.java:137) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.initZK(ServiceUnitZkUtils.java:113) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.NamespaceService.(NamespaceService.java:151) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.lambda$getNamespaceServiceProvider$1(PulsarService.java:584) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.startNamespaceService(PulsarService.java:580) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.start(PulsarService.java:375) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.PulsarBrokerStarter$BrokerStarter.start(PulsarBrokerStarter.java:273) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.PulsarBrokerStarter.main(PulsarBrokerStarter.java:332) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 16:17:50.208 [main ERROR org.apache.pulsar.broker.PulsarService - java.lang.NullPointerException java.lang.RuntimeException: java.lang.NullPointerException at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.initZK(ServiceUnitZkUtils.java:116) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.NamespaceService.(NamespaceService.java:151) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.lambda$getNamespaceServiceProvider$1(PulsarService.java:584) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.startNamespaceService(PulsarService.java:580) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.PulsarService.start(PulsarService.java:375) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.PulsarBrokerStarter$BrokerStarter.start(PulsarBrokerStarter.java:273) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.PulsarBrokerStarter.main(PulsarBrokerStarter.java:332) [org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 Caused by: java.lang.NullPointerException at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupSingleNamespaceNode(ServiceUnitZkUtils.java:156) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupNamespaceNodes(ServiceUnitZkUtils.java:134) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.cleanupNamespaceNodes(ServiceUnitZkUtils.java:137) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 at org.apache.pulsar.broker.namespace.ServiceUnitZkUtils.initZK(ServiceUnitZkUtils.java:113) ~[org.apache.pulsar-pulsar-broker-2.4.0.jar:2.4.0 ... 6 more 16:17:50.209 [main ERROR org.apache.pulsar.PulsarBrokerStarter - Failed to start pulsar service. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] xixiss edited a comment on issue #4560: when authentication enabled pulsar-admin topics list will fail for nonpersistent topics
xixiss edited a comment on issue #4560: when authentication enabled pulsar-admin topics list will fail for nonpersistent topics URL: https://github.com/apache/pulsar/issues/4560#issuecomment-521677400 i write these in broker.conf: brokerClientAuthenticationPlugin=org.apache.pulsar.client.impl.auth.AuthenticationTls brokerClientAuthenticationParameters=tlsCertFile:/root/my-ca/broker.cert.pem,tlsKeyFile:/root/my-ca/broker.key-pk8.pem brokerClientTrustCertsFilePath=/root/my-ca/certs/ca.cert.pem but it still fail with error code 401 when i use pulsar-admin to list topic.And the TLS is work well in other situation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] xixiss commented on issue #4560: when authentication enabled pulsar-admin topics list will fail for nonpersistent topics
xixiss commented on issue #4560: when authentication enabled pulsar-admin topics list will fail for nonpersistent topics URL: https://github.com/apache/pulsar/issues/4560#issuecomment-521677400 i write these in broker.conf: brokerClientAuthenticationPlugin=org.apache.pulsar.client.impl.auth.AuthenticationTls brokerClientAuthenticationParameters=tlsCertFile:/root/my-ca/broker.cert.pem,tlsKeyFile:/root/my-ca/broker.key-pk8.pem brokerClientTrustCertsFilePath=/root/my-ca/certs/ca.cert.pem but it still fail with error code 401 when i use pulsar-admin to list topic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] fxbing opened a new pull request #4963: Add more config for auto-topic-creation
fxbing opened a new pull request #4963: Add more config for auto-topic-creation URL: https://github.com/apache/pulsar/pull/4963 Master Issue: #4926 ### Motivation Curently the partitioned-topic and non-partitioned topic is a little confuse for users. in PR #3450 we add config for auto-topic-creation. We could leverage this config to provide some more config for auto-topic-creation. ### Modifications - Add `allowAutoTopicCreationType` and `allowAutoTopicCreationNumPartitions` to configuration. - Users can use both configurations when they decide to create a topic automatically. - Add test. - Update doc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy removed a comment on issue #56: [Issue:30] Support seek logic and add test case
wolfstudy removed a comment on issue #56: [Issue:30] Support seek logic and add test case URL: https://github.com/apache/pulsar-client-go/pull/56#issuecomment-521595529 @sijie @jiazhai @merlimat PTAL thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #56: [Issue:30] Support seek logic and add test case
wolfstudy commented on issue #56: [Issue:30] Support seek logic and add test case URL: https://github.com/apache/pulsar-client-go/pull/56#issuecomment-521616474 @sijie @jiazhai @merlimat PTAL thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 opened a new pull request #4962: Fix the StructSchema load reader cache invalid
congbobo184 opened a new pull request #4962: Fix the StructSchema load reader cache invalid URL: https://github.com/apache/pulsar/pull/4962 ### Motivation StructSchema LoadingCache for cache reader, but key is byte[], it will compare with the address's hashcode. So every decode will generate a new reader so we should change the type of the key for LoadingCache Does this pull request potentially affect one of the following parts: If yes was chosen, please highlight the changes Dependencies (does it add or upgrade a dependency): (no) The public API: (no) The schema: (yes) The default values of configurations: (no) The wire protocol: (no) The rest endpoints: (no) The admin cli options: (no) Anything that affects deployment: (no) ### Documentation Does this pull request introduce a new feature? (yes / no) If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) If a feature is not applicable for documentation, explain why? If a feature is not documented yet in this PR, please create a followup issue for adding the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] ThirdLibResearch opened a new issue #4961: Third-Party Library Version Inconsistencies in your project
ThirdLibResearch opened a new issue #4961: Third-Party Library Version Inconsistencies in your project URL: https://github.com/apache/pulsar/issues/4961 We are currently investigating the usage of different versions of the same third-party library in different modules of a project (i.e., the library version inconsistency problem). It is a non-trivial and time-consuming task to maintain the evolving third-party libraries. In that sense, it seems necessary to harmonize the different versions of the same third-party library in different modules into one single version. Thus we developed a prototype tool to detect library version inconsistencies and suggest harmonized version with detailed maintenance efforts. We applied our tool on your GitHub project, and attached the generated report. We hope that the report could be useful for you to be aware of the library version inconsistencies in your project and to decide whether to harmonize inconsistent library versions. Here is the report: [apache incubator-pulsar.pdf](https://github.com/ThirdLibResearch/ThirdLibSource/blob/master/issues/report/apache%20incubator-pulsar.pdf) Some pictures may be too large to present in the pdf so we attach them below: [1344_org.projectlomboklombokjar_0.png](https://raw.githubusercontent.com/ThirdLibResearch/ThirdLibSource/master/issues/image/1344_org.projectlomboklombokjar_0.png) [1344_org.powermockpowermock-api-mockitojar_0.png](https://raw.githubusercontent.com/ThirdLibResearch/ThirdLibSource/master/issues/image/1344_org.powermockpowermock-api-mockitojar_0.png) [1344_org.powermockpowermock-module-testngjar_0.png](https://raw.githubusercontent.com/ThirdLibResearch/ThirdLibSource/master/issues/image/1344_org.powermockpowermock-module-testngjar_0.png) [1344_org.mockitomockito-corejar_0.png](https://raw.githubusercontent.com/ThirdLibResearch/ThirdLibSource/master/issues/image/1344_org.mockitomockito-corejar_0.png) [1344_org.testngtestngjar_0.png](https://raw.githubusercontent.com/ThirdLibResearch/ThirdLibSource/master/issues/image/1344_org.testngtestngjar_0.png) We will appreciate your comments very much. Best regards This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 opened a new pull request #4960: Consumer subscribe with AutoConsumeSchema will throw npe
congbobo184 opened a new pull request #4960: Consumer subscribe with AutoConsumeSchema will throw npe URL: https://github.com/apache/pulsar/pull/4960 ### Motivation To fix #4838 Does this pull request potentially affect one of the following parts: If yes was chosen, please highlight the changes Dependencies (does it add or upgrade a dependency): (no) The public API: (no) The schema: (yes) The default values of configurations: (no) The wire protocol: (no) The rest endpoints: (no) The admin cli options: (no) Anything that affects deployment: (no) ### Documentation Does this pull request introduce a new feature? (yes / no) If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) If a feature is not applicable for documentation, explain why? If a feature is not documented yet in this PR, please create a followup issue for adding the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #4950: Modify rest api post schema compatibility strategy
congbobo184 commented on issue #4950: Modify rest api post schema compatibility strategy URL: https://github.com/apache/pulsar/pull/4950#issuecomment-521599453 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #4910: [doc] Add a documentation page for metrics reference
Jennifer88huang commented on a change in pull request #4910: [doc] Add a documentation page for metrics reference URL: https://github.com/apache/pulsar/pull/4910#discussion_r314257392 ## File path: site2/docs/reference-metrics.md ## @@ -0,0 +1,243 @@ +--- +id: reference-metrics +title: Pulsar Metrics +sidebar_label: Pulsar Metrics +--- +
[GitHub] [pulsar] wolfstudy commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send
wolfstudy commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send URL: https://github.com/apache/pulsar/pull/4811#issuecomment-521595755 Ping @merlimat @rdhabalia @massakam If time is convenient, please review the pull request, thanks again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #56: [Issue:30] Support seek logic and add test case
wolfstudy commented on issue #56: [Issue:30] Support seek logic and add test case URL: https://github.com/apache/pulsar-client-go/pull/56#issuecomment-521595529 @sijie @jiazhai @merlimat PTAL thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #56: [Issue:30] Support seek logic and add test case
wolfstudy opened a new pull request #56: [Issue:30] Support seek logic and add test case URL: https://github.com/apache/pulsar-client-go/pull/56 Signed-off-by: xiaolong.ran Fixes #30 ### Motivation Support seek logic and add test case. In go, the unbuffered chan is a blocked channel. For blocked chan, it is required that someone must wait for reception before sending data to chan. In `partitionConsumer` and `partitionProducer`, the `eventsChan` is blocked when send data to it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-client-go] jiazhai merged pull request #55: Check `golint`, `gofmt` and `go import` for project
jiazhai merged pull request #55: Check `golint`, `gofmt` and `go import` for project URL: https://github.com/apache/pulsar-client-go/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar-client-go] branch master updated: Check `golint`, `gofmt` and `go import` for project (#55)
This is an automated email from the ASF dual-hosted git repository.
zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new a615761 Check `golint`, `gofmt` and `go import` for project (#55)
a615761 is described below
commit a61576168966d030e71d37a4a1dcd4cda023941b
Author: 冉小龙
AuthorDate: Thu Aug 15 18:01:10 2019 +0800
Check `golint`, `gofmt` and `go import` for project (#55)
* code format
Signed-off-by: xiaolong.ran
* fix seek logic
Signed-off-by: xiaolong.ran
---
examples/consumer/consumer.go | 77 +-
examples/producer/producer.go | 65 ++--
pkg/compression/compression_test.go| 9 ++--
pkg/compression/lz4.go | 2 +-
pulsar/consumer_test.go| 15 +--
pulsar/impl_client_test.go | 2 +-
pulsar/impl_consumer.go| 11 ++---
pulsar/impl_producer.go| 4 +-
pulsar/internal/checksum.go| 22 +-
pulsar/internal/checksum_test.go | 51 +++---
pulsar/internal/commands.go| 12 +++---
pulsar/internal/connection.go | 8 ++--
pulsar/internal/hash_test.go | 6 ++-
pulsar/internal/lookup_service_test.go | 4 +-
pulsar/internal/rpc_client.go | 8 ++--
pulsar/producer_test.go| 6 ++-
pulsar/test_helper.go | 3 +-
pulsar/unackMsgTracker_test.go | 63 ++--
util/error.go | 29 +++--
util/util_test.go | 7 ++--
20 files changed, 210 insertions(+), 194 deletions(-)
diff --git a/examples/consumer/consumer.go b/examples/consumer/consumer.go
index 3010853..c408386 100644
--- a/examples/consumer/consumer.go
+++ b/examples/consumer/consumer.go
@@ -18,45 +18,46 @@
package main
import (
-"context"
-"fmt"
-`github.com/apache/pulsar-client-go/pulsar`
-`log`
+ "context"
+ "fmt"
+ "log"
+
+"github.com/apache/pulsar-client-go/pulsar"
)
func main() {
-client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
-if err != nil {
-log.Fatal(err)
-}
-
-defer client.Close()
-
-consumer, err := client.Subscribe(pulsar.ConsumerOptions{
-Topic:"topic-1",
-SubscriptionName: "my-sub",
-Type: pulsar.Shared,
-})
-if err != nil {
-log.Fatal(err)
-}
-defer consumer.Close()
-
-for i := 0; i < 10; i++ {
-msg, err := consumer.Receive(context.Background())
-if err != nil {
-log.Fatal(err)
-}
-
-fmt.Printf("Received message msgId: %#v -- content: '%s'\n",
-msg.ID(), string(msg.Payload()))
-
-if err := consumer.Ack(msg); err != nil {
-log.Fatal(err)
-}
-}
-
-if err := consumer.Unsubscribe(); err != nil {
-log.Fatal(err)
-}
+ client, err := pulsar.NewClient(pulsar.ClientOptions{URL:
"pulsar://localhost:6650"})
+ if err != nil {
+ log.Fatal(err)
+ }
+
+ defer client.Close()
+
+ consumer, err := client.Subscribe(pulsar.ConsumerOptions{
+ Topic:"topic-1",
+ SubscriptionName: "my-sub",
+ Type: pulsar.Shared,
+ })
+ if err != nil {
+ log.Fatal(err)
+ }
+ defer consumer.Close()
+
+ for i := 0; i < 10; i++ {
+ msg, err := consumer.Receive(context.Background())
+ if err != nil {
+ log.Fatal(err)
+ }
+
+ fmt.Printf("Received message msgId: %#v -- content: '%s'\n",
+ msg.ID(), string(msg.Payload()))
+
+ if err := consumer.Ack(msg); err != nil {
+ log.Fatal(err)
+ }
+ }
+
+ if err := consumer.Unsubscribe(); err != nil {
+ log.Fatal(err)
+ }
}
diff --git a/examples/producer/producer.go b/examples/producer/producer.go
index 56b87b5..24ca58d 100644
--- a/examples/producer/producer.go
+++ b/examples/producer/producer.go
@@ -18,39 +18,40 @@
package main
import (
-`context`
-`fmt`
-`github.com/apache/pulsar-client-go/pulsar`
-`log`
+ "context"
+ "fmt"
+ "log"
+
+ "github.com/apache/pulsar-client-go/pulsar"
)
func main() {
-client, err := pulsar.NewClient(pulsar.ClientOptions{
-URL: "pulsar://localhost:6650",
-})
-
-if err != nil {
-log.Fatal(err)
-}
-
-defer client.Close()
-
-producer, err := client.CreateProducer(pulsar.ProducerOptions{
-Topic: "topic-1",
-})
-if err != nil {
-log.Fatal(err)
-}
-
-defer
[GitHub] [pulsar-client-go] jiazhai commented on issue #55: Check `golint`, `gofmt` and `go import` for project
jiazhai commented on issue #55: Check `golint`, `gofmt` and `go import` for project URL: https://github.com/apache/pulsar-client-go/pull/55#issuecomment-521588910 please also enable the check in jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui opened a new issue #4959: Pulsar admin always timeout until restart the broker
codelipenghui opened a new issue #4959: Pulsar admin always timeout until restart the broker URL: https://github.com/apache/pulsar/issues/4959 **Describe the bug** pulsar-admin be blocked until restart the broker. Check the broker log, some logs looks abnormal: ``` 11:18:28.793 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756812 xid:616893 sent:616893 recv:673431 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.44:8080 11:18:33.345 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756821 xid:616896 sent:616896 recv:673435 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.42:8080 11:18:40.207 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756833 xid:616901 sent:616901 recv:673441 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.41:8080 11:18:53.793 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756842 xid:616908 sent:616908 recv:673449 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.44:8080 11:18:58.345 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756851 xid:616912 sent:616912 recv:673454 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.42:8080 11:19:05.207 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756860 xid:616916 sent:616916 recv:673459 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.41:8080 11:19:18.793 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756885 xid:616925 sent:616925 recv:673469 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.44:8080 11:19:23.345 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756886 xid:616928 sent:616928 recv:673473 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.42:8080 11:19:28.793 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756887 xid:616932 sent:616932 recv:673478 queuedpkts:0 pendingresp:0 queuedevents:0] Received ZooKeeper watch event: Wa tchedEvent state:SyncConnected type:NodeDataChanged path:/loadbalance/brokers/172.30.91.44:8080 11:19:30.207 [pulsar-ordered-OrderedExecutor-1-0-EventThread] INFO org.apache.pulsar.zookeeper.ZooKeeperDataCache - [State:CONNECTED Timeout:3 sessionid:0x30034ce16030052 local:/172.30 .91.40:50486 remoteserver:172.30.91.42/172.30.91.42:2181 lastZxid:4298756896 xid:616934
[GitHub] [pulsar] zymap opened a new pull request #4958: [Transaction][Buffer] provide a transaction buffer client
zymap opened a new pull request #4958: [Transaction][Buffer] provide a transaction buffer client URL: https://github.com/apache/pulsar/pull/4958 ### Motivation *The Transaction coordinator needs a client to commit or abort transactions on the transaction buffer.* ### Modifications *Provide a transaction buffer client to commit or abort transactions.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] mingfang opened a new issue #4957: docker image needs to install 'less'
mingfang opened a new issue #4957: docker image needs to install 'less' URL: https://github.com/apache/pulsar/issues/4957 I'm getting this message when running `pulsar sql` ``` presto> show schemas in pulsar; ERROR: failed to open pager: Cannot run program "less": error=2, No such file or directory ``` I was able to temporarily resolve this by running `apt-get update && apt-get install -y less` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-translation] ireneontheway opened a new pull request #4: Update schedule.md
ireneontheway opened a new pull request #4: Update schedule.md URL: https://github.com/apache/pulsar-translation/pull/4 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number. Skip *Issue XYZ* if there is no associated github issue for this pull request. Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)* Master Issue: # ### Motivation *Explain here the context, and why you're making that change. What is the problem you're trying to solve.* ### Modifications *Describe the modifications you've done.* ### Verify this change - [ ] Make sure that the change is correct. - For how to check and verify, refer to [Translation and localization](https://github.com/apache/pulsar/tree/master/site2#translation-and-localization). ### Documentation - Is this pull request related to crowdin usage? (yes / no) - Is this pull request related to translation quality? (yes / no) - If yes, how to improve? - Is this pull request related to translation guidelines?(yes / no) - Is this pull request related to translation workflow?(yes / no) - If a sth is not documented yet in this PR, please create a followup issue for adding the documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar-translation] ireneontheway closed pull request #4: Update schedule.md
ireneontheway closed pull request #4: Update schedule.md URL: https://github.com/apache/pulsar-translation/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
