[pulsar] branch github_exp1 updated (06c0f29 -> 6fb9a14)

2019-08-23 Thread aahmed
This is an automated email from the ASF dual-hosted git repository.

aahmed pushed a change to branch github_exp1
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


 discard 06c0f29  Add Timeout to tests
 add 6fb9a14  Add Timeout to tests

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (06c0f29)
\
 N -- N -- N   refs/heads/github_exp1 (6fb9a14)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../java/org/apache/pulsar/broker/admin/NamespacesTest.java|  4 ++--
 .../apache/pulsar/broker/service/PersistentTopicE2ETest.java   |  2 +-
 .../java/org/apache/pulsar/client/api/InterceptorsTest.java|  6 +++---
 .../apache/pulsar/client/api/KeySharedSubscriptionTest.java| 10 +-
 .../client/api/NonPersistentKeySharedSubscriptionTest.java |  8 
 .../org/apache/pulsar/client/api/NonPersistentTopicTest.java   |  6 +++---
 .../org/apache/pulsar/client/api/ProducerConsumerBase.java |  2 +-
 .../pulsar/functions/worker/PulsarFunctionE2ESecurityTest.java |  4 ++--
 .../pulsar/websocket/proxy/ProxyPublishConsumeTlsTest.java |  6 +++---
 9 files changed, 24 insertions(+), 24 deletions(-)



[GitHub] [pulsar] sijie commented on issue #5031: [dashboard] fix format single message raw bytes

2019-08-23 Thread GitBox
sijie commented on issue #5031: [dashboard] fix format single message raw bytes
URL: https://github.com/apache/pulsar/pull/5031#issuecomment-524522479
 
 
   @tuteng please help review this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] tuteng opened a new pull request #5032: [website]Support multi version for swagger

2019-08-23 Thread GitBox
tuteng opened a new pull request #5032: [website]Support multi version for 
swagger
URL: https://github.com/apache/pulsar/pull/5032
 
 
   Fixes https://github.com/apache/pulsar/issues/3505
   
   Master Issue: https://github.com/apache/pulsar/issues/3505
   
   ### Motivation
   
   Currently, there is no version management in rest API, and the latest 
version will be returned every time. This is usually confusing, so add version 
management to rest API. The new URL is similar to this:  
   ```
   http://localhost:3000/functions-rest-api?version=2.4.0
   http://localhost:3000/functions-rest-api?version=2.3.0
   http://localhost:3000/functions-rest-api?version=master
   ```
   
   ### Modifications
   
   * Add version parse
   * Add version for link
   
   ### Verifying this change
   
   
![image](https://user-images.githubusercontent.com/1907867/63632607-2de10500-c66c-11e9-9c8f-dfc38cbeae00.png)
   
   When content is published, the folder below needs to be added according to 
the version number above.
   
   
![image](https://user-images.githubusercontent.com/1907867/63632604-0e49dc80-c66c-11e9-8239-8fba4aa1b71a.png)
   
   My local test did not generate JSON files before version 2.3, but it needs 
to be added when it is released.
   
   ### Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
 - If a feature is not applicable for documentation, explain why?
 - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch github_exp1 updated (07a905e -> 06c0f29)

2019-08-23 Thread aahmed
This is an automated email from the ASF dual-hosted git repository.

aahmed pushed a change to branch github_exp1
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


 discard 07a905e  Add Timeout to tests
 add 06c0f29  Add Timeout to tests

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (07a905e)
\
 N -- N -- N   refs/heads/github_exp1 (06c0f29)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)



[pulsar] branch github_exp1 updated (b34eb0f -> 07a905e)

2019-08-23 Thread aahmed
This is an automated email from the ASF dual-hosted git repository.

aahmed pushed a change to branch github_exp1
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


 discard b34eb0f  Add Timeout to tests
 add 07a905e  Add Timeout to tests

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (b34eb0f)
\
 N -- N -- N   refs/heads/github_exp1 (07a905e)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../pulsar/client/api/DeadLetterTopicTest.java   |  2 +-
 .../client/api/SimpleProducerConsumerTest.java   | 20 ++--
 .../client/api/v1/V1_ProducerConsumerTest.java   |  4 ++--
 3 files changed, 13 insertions(+), 13 deletions(-)



[pulsar] branch github_exp1 updated (f8f437d -> b34eb0f)

2019-08-23 Thread aahmed
This is an automated email from the ASF dual-hosted git repository.

aahmed pushed a change to branch github_exp1
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


 discard f8f437d  Add Timeout to tests
 add b34eb0f  Add Timeout to tests

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (f8f437d)
\
 N -- N -- N   refs/heads/github_exp1 (b34eb0f)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .../org/apache/pulsar/PulsarBrokerStarterTest.java | 18 +++---
 .../apache/pulsar/broker/SLAMonitoringTest.java|  8 +--
 .../broker/admin/AdminApiGetLastMessageIdTest.java |  2 +-
 .../pulsar/broker/admin/AdminApiOffloadTest.java   |  4 +-
 .../broker/admin/AdminApiSchemaAutoUpdateTest.java | 16 ++---
 .../pulsar/broker/admin/AdminApiSchemaTest.java| 10 +--
 .../admin/AdminApiSchemaValidationEnforced.java| 10 +--
 .../apache/pulsar/broker/admin/AdminApiTest.java   | 74 +++---
 .../apache/pulsar/broker/admin/AdminApiTest2.java  | 38 +--
 .../pulsar/broker/admin/AdminApiTlsAuthTest.java   | 26 
 .../pulsar/broker/admin/AdminResourceTest.java |  4 +-
 .../org/apache/pulsar/broker/admin/AdminTest.java  | 18 +++---
 .../broker/admin/BrokerAdminClientTlsAuthTest.java |  2 +-
 .../broker/admin/CreateSubscriptionTest.java   |  6 +-
 .../broker/admin/IncrementPartitionsTest.java  |  4 +-
 .../apache/pulsar/broker/admin/NamespacesTest.java | 48 +++---
 .../pulsar/broker/admin/PersistentTopicsTest.java  | 12 ++--
 .../pulsar/broker/admin/v1/V1_AdminApiTest.java| 70 ++--
 .../pulsar/broker/admin/v1/V1_AdminApiTest2.java   | 33 +-
 .../pulsar/broker/auth/AuthorizationTest.java  |  4 +-
 .../broker/cache/ResourceQuotaCacheTest.java   |  4 +-
 .../delayed/InMemoryDeliveryTrackerTest.java   |  4 +-
 .../AntiAffinityNamespaceGroupTest.java| 12 ++--
 .../loadbalance/BrokerVersionFilterTest.java   |  2 +-
 .../broker/loadbalance/LoadBalancerTest.java   | 30 -
 .../broker/loadbalance/LoadReportNetworkLimit.java |  2 +-
 .../loadbalance/ModularLoadManagerImplTest.java| 16 ++---
 .../ModularLoadManagerStrategyTest.java|  2 +-
 .../loadbalance/SimpleLoadManagerImplTest.java | 22 +++
 .../loadbalance/impl/OverloadShedderTest.java  | 12 ++--
 .../broker/lookup/http/HttpTopicLookupv2Test.java  |  8 +--
 .../namespace/NamespaceCreateBundlesTest.java  |  2 +-
 .../broker/namespace/NamespaceServiceTest.java | 16 ++---
 .../broker/namespace/NamespaceUnloadingTest.java   |  4 +-
 .../broker/namespace/OwnershipCacheTest.java   | 14 ++--
 .../broker/service/AdvertisedAddressTest.java  |  2 +-
 .../broker/service/BacklogQuotaManagerTest.java| 24 +++
 .../pulsar/broker/service/BatchMessageTest.java| 30 -
 .../broker/service/BrokerBkEnsemblesTests.java | 10 +--
 .../broker/service/BrokerBookieIsolationTest.java  |  6 +-
 .../pulsar/broker/service/BrokerServiceTest.java   | 32 +-
 .../service/BrokerServiceThrottlingTest.java   |  8 +--
 .../broker/service/DistributedIdGeneratorTest.java |  8 +--
 .../HashRangeStickyKeyConsumerSelectorTest.java|  8 +--
 .../pulsar/broker/service/MaxMessageSizeTest.java  |  2 +-
 .../broker/service/MessageIdSerialization.java | 10 +--
 .../broker/service/NonPersistentTopicE2ETest.java  |  8 +--
 .../pulsar/broker/service/PartitionKeyTest.java|  2 +-
 .../pulsar/broker/service/PeerReplicatorTest.java  |  2 +-
 .../PersistentDispatcherFailoverConsumerTest.java  | 14 ++--
 .../broker/service/PersistentFailoverE2ETest.java  | 10 +--
 .../service/PersistentMessageFinderTest.java   |  4 +-
 .../broker/service/PersistentQueueE2ETest.java | 12 ++--
 .../service/PersistentTopicConcurrentTest.java |  8 +--
 .../broker/service/PersistentTopicE2ETest.java | 72 ++---
 .../pulsar/broker/service/PersistentTopicTest.java | 58 -
 .../pulsar/broker/service/RackAwareTest.java   |  8 +--
 .../broker/service/ReplicatorGlobalNSTest.java |  4 +-
 .../broker/service/ReplicatorRateLimiterTest.java  |  8 +--
 .../pulsar/broker/service/ReplicatorTest.java  | 26 
 .../pulsar/broker/service/ReplicatorTlsTest.java   |  2 +-
 .../pulsar/broker/service/ResendRequestTest.java   |  4 +-
 .../pulsar/broker/service/ServerCnxTest.java   |  4 +-
 .../broker

[GitHub] [pulsar] yittg opened a new pull request #5031: [dashboard] fix format single message raw bytes

2019-08-23 Thread GitBox
yittg opened a new pull request #5031: [dashboard] fix format single message 
raw bytes
URL: https://github.com/apache/pulsar/pull/5031
 
 
   
   
   `format_single_message` method only receive bytes data


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] yittg opened a new pull request #5030: [dashboard] fix admin path

2019-08-23 Thread GitBox
yittg opened a new pull request #5030: [dashboard] fix admin path
URL: https://github.com/apache/pulsar/pull/5030
 
 
   
   
   access v1/v2 admin api by namespace name pattern


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch github_exp1 updated (ee08d7a -> f8f437d)

2019-08-23 Thread aahmed
This is an automated email from the ASF dual-hosted git repository.

aahmed pushed a change to branch github_exp1
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


 discard ee08d7a  Add Github CI workflow
 add 687406e  Admin pod should use broker service to discover broker pods 
(#4995)
 add 40fbf5d  support parse batch entry payload (#4992)
 add c3cb5eb  ### Motivation (#4991)
 add 9802307  Add Github CI workflow
 add f8f437d  Add Timeout to tests

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (ee08d7a)
\
 N -- N -- N   refs/heads/github_exp1 (f8f437d)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 dashboard/Dockerfile   |   6 +-
 .../django/stats/templates/stats/messages.html |  35 +--
 dashboard/django/stats/views.py| 114 +
 .../django/utils}/__init__.py  |   0
 .../{stats/apps.py => utils/import_utils.py}   |  11 +-
 dashboard/requirements.txt |   8 ++
 .../generic/k8s-1-9-and-above/admin.yaml   |   4 +-
 deployment/kubernetes/generic/original/admin.yaml  |   4 +-
 .../apache/pulsar/broker/SLAMonitoringTest.java|   4 +-
 .../broker/admin/AdminApiGetLastMessageIdTest.java |   6 +-
 .../pulsar/broker/admin/AdminApiOffloadTest.java   |   4 +-
 .../broker/admin/AdminApiSchemaAutoUpdateTest.java |   4 +-
 .../pulsar/broker/admin/AdminApiSchemaTest.java|   4 +-
 .../admin/AdminApiSchemaValidationEnforced.java|   4 +-
 .../apache/pulsar/broker/admin/AdminApiTest.java   |   4 +-
 .../apache/pulsar/broker/admin/AdminApiTest2.java  |   4 +-
 .../pulsar/broker/admin/AdminApiTlsAuthTest.java   |   4 +-
 .../org/apache/pulsar/broker/admin/AdminTest.java  |   4 +-
 .../broker/admin/BrokerAdminClientTlsAuthTest.java |   6 +-
 .../broker/admin/CreateSubscriptionTest.java   |   4 +-
 .../broker/admin/IncrementPartitionsTest.java  |   4 +-
 .../apache/pulsar/broker/admin/NamespacesTest.java |   6 +-
 .../pulsar/broker/admin/PersistentTopicsTest.java  |   6 +-
 .../pulsar/broker/admin/v1/V1_AdminApiTest.java|   4 +-
 .../pulsar/broker/admin/v1/V1_AdminApiTest2.java   |   4 +-
 .../pulsar/broker/auth/AuthorizationTest.java  |   4 +-
 .../broker/cache/ResourceQuotaCacheTest.java   |   4 +-
 .../AntiAffinityNamespaceGroupTest.java|   4 +-
 .../broker/loadbalance/LoadBalancerTest.java   |   4 +-
 .../broker/loadbalance/LoadReportNetworkLimit.java |   4 +-
 .../loadbalance/ModularLoadManagerImplTest.java|   4 +-
 .../loadbalance/SimpleLoadManagerImplTest.java |   4 +-
 .../broker/lookup/http/HttpTopicLookupv2Test.java  |   2 +-
 .../namespace/NamespaceCreateBundlesTest.java  |   4 +-
 .../broker/namespace/NamespaceServiceTest.java |   4 +-
 .../broker/namespace/NamespaceUnloadingTest.java   |   4 +-
 .../broker/namespace/OwnershipCacheTest.java   |   4 +-
 .../broker/service/AdvertisedAddressTest.java  |   4 +-
 .../broker/service/BacklogQuotaManagerTest.java|   4 +-
 .../pulsar/broker/service/BatchMessageTest.java|   4 +-
 .../broker/service/BrokerBkEnsemblesTests.java |   4 +-
 .../broker/service/BrokerBookieIsolationTest.java  |   4 +-
 .../pulsar/broker/service/BrokerServiceTest.java   |   4 +-
 .../service/BrokerServiceThrottlingTest.java   |   4 +-
 .../broker/service/DistributedIdGeneratorTest.java |   4 +-
 .../pulsar/broker/service/MaxMessageSizeTest.java  |   4 +-
 .../broker/service/NonPersistentTopicE2ETest.java  |   4 +-
 .../pulsar/broker/service/PartitionKeyTest.java|   4 +-
 .../pulsar/broker/service/PeerReplicatorTest.java  |   4 +-
 .../PersistentDispatcherFailoverConsumerTest.java  |   2 +-
 .../broker/service/PersistentFailoverE2ETest.java  |   4 +-
 .../broker/service/PersistentQueueE2ETest.java |   4 +-
 .../service/PersistentTopicConcurrentTest.java |   2 +-
 .../broker/service/PersistentTopicE2ETest.java |   4 +-
 .../pulsar/broker/service/PersistentTopicTest.java |   4 +-
 .../pulsar/broker/service/RackAwareTest.java   |   4 +-
 .../broker/service/ReplicatorGlobalNSTest.java |   6 +-
 .../broker/service/ReplicatorRateLimiterTest.java  |   6 +-
 .../pulsar/broker/service/ReplicatorTest.java  |   6 +-
 .../pulsar/broker/service/ReplicatorTlsTest.java   |   4 +-
 .../pulsar/broker/service/ResendRequestTest.java   |   4 +-
 .../p

[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524499939
 
 
   @congbobo184 
   
   > the exception seem to that client didn't send the schema version to broker
   
   The client does it by itself, it takes the latest version I guess. It's not 
a configuration of the consumer, right?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524499665
 
 
   Ok, so I removed the previous message because they finally were incorrects. 
So, v2.4.0 or v2.5.0 standalone work properly.
   
   I tested my bookies and brokers with v2.4.0 and v2.5.0-SNAPSHOT I still have 
the broker exception:
   
   ```
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]: 00:30:16.991 
[pulsar-io-22-5] WARN  org.apache.pulsar.broker.service.ServerCnx - 
[/192.168.10.15:42368] Got exception BufferUnderflowException : null
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]: 
java.nio.BufferUnderflowException: null
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
java.nio.Buffer.nextGetIndex(Buffer.java:506) ~[?:1.8.0_192]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
java.nio.HeapByteBuffer.getLong(HeapByteBuffer.java:412) ~[?:1.8.0_192]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage.versionFromBytes(BookkeeperSchemaStorage.java:206)
 ~[org.apache.pulsar-pulsar-broker-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
org.apache.pulsar.broker.service.schema.SchemaRegistryServiceImpl.versionFromBytes(SchemaRegistryServiceImpl.java:196)
 ~[org.apache.pulsar-pulsar-broker-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
org.apache.pulsar.broker.service.schema.validator.SchemaRegistryServiceWithSchemaDataValidator.versionFromBytes(SchemaRegistryServiceWithSchemaDataValidator.java:106)
 ~[org.apache.pulsar-pulsar-broker-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
org.apache.pulsar.broker.service.ServerCnx.handleGetSchema(ServerCnx.java:1334) 
~[org.apache.pulsar-pulsar-broker-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
org.apache.pulsar.common.protocol.PulsarDecoder.channelRead(PulsarDecoder.java:306)
 ~[org.apache.pulsar-pulsar-common-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:323)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:297)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1434)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:965)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
   Aug 23 00:30:16 yo-pulsar-c1-n1 pulsar-broker[21249]:  at 
io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:799)
 [io.netty-netty-all-4.1.32.Final

[GitHub] [pulsar] KannarFr removed a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr removed a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524494446
 
 
   I tested with v2.5.0-SNAPSHOT standalone. Will rollback brokers to v2.4.0 
and test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr removed a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr removed a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524351044
 
 
   I tested it on v2.4.0 pulsar standalone and no issue. So it's an issue on 
v2.5.0-SNAPSHOT brokers with v.2.4.0 bookies or just on v2.5.0-SNAPSHOT.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr removed a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr removed a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524494929
 
 
   It worked. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr removed a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr removed a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524496742
 
 
   Will update brokers and bookies to v2.5.0-SNAPSHOT.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr removed a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr removed a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524495287
 
 
   But I still have the initial issue.
   
   
   @jerrypeng so the bookies version has to be the same of brokers for the 
v2.5.0-SNAPSHOT changes (I rollbacked my brokers to v2.4.0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524496742
 
 
   Will update brokers and bookies to v2.5.0-SNAPSHOT.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr edited a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr edited a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524495287
 
 
   But I still have the initial issue.
   
   
   @jerrypeng so the bookies version has to be the same of brokers for the 
v2.5.0-SNAPSHOT changes (I rollbacked my brokers to v2.4.0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr opened a new issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr opened a new issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006
 
 
   **Describe the bug**
   I'm using pulsar4s (pulsar scala client) and `pulsar-client consume` to 
debug.
   
   When I produce and consume using pulsar4s-avro, I've got the following 
message using `pulsar-client consume`:
   
   ```
   - got message -
   Objavro.schema�
  
{"type":"record","name":"ApplicationLog","namespace":"models.logs.application_log_module","fields":[{"name":"syslog_pri","type":"string"},{"name":"syslog_facility","type":"string"},{"name":"syslog_facility_code","type":"int"},{"name":"syslog_severity_code","type":"int"},{"name":"syslog_severity","type":"string"},{"name":"version","type":"string"},{"name":"host","type":"string"},{"name":"zone","type":"string"},{"name":"tags","type":{"type":"array","items":"string"}},{"name":"timestamp","type":"string"},{"name":"ownerId","type":"string"},{"name":"data","type":"string"},{"name":"deploymentId","type":"string"},{"name":"program","type":"string"},{"name":"instanceId","type":"string"},{"name":"appId","type":"string"}]}avro.codenull




  >:k���HRC��30yoyoversiohoszontagtimeowneridatadeployid




prograinstanceid
   appId
>:k���HRC�
   ```
   This one is well parsed to the wanted type using pulsar4s subscription.
   
   Now, if I produce using pulsar-function Context like:
   
   ```
   ReflectData REFLECT = new ReflectData();
   Schema schema = REFLECT.getSchema(ApplicationLog.class);
   AvroSchema pulsarSchema = 
AvroSchema.of(SchemaDefinition.builder().withJsonDef(schema.toString()).withAlwaysAllowNull(false).build());
   ```
   
   I used this native avro method to ensure that I'm using exactly the same 
schema that works with pulsar4s produce. So both test have exactly the same 
`pulsar-admin schemas get` result.
   
   ```
   context.newOutputMessage(
   topic,
   pulsarSchema
   ).value(log).sendAsync();
   ```
   
   Using `pulsar-client consume` I've got:
   
   ```
   - got message -
   30
 daemon
   informational1pbinaries-yo-yo.services.yo.copar0tcp


appLogcustomers02019-08-20T14:32:37.058ZRorga_858600a8-74f4-4d75-a8a3-f5b868be093c02019-08-20T14:32:36.690Z^deployment_1760e083-9f7a-433f-bddf-8cac43a4768adeploy-node.shH6607e717-8dad-4551-bdab-d021792715acPapp_3b65d74f-66f2-4218-bc91-6bce8d1e486a
   ```
   
   And when I subscribe using pulsar4s, I've got `InvalidAvroMagicException: 
Not an Avro data file` during the avro decode. This is due to the incorrect 
avro's magic length. **Note that the subscription is done so the schema 
compatibility is already verified, just the decode fails**.
   
   I don't know if it's a bug or if I just have a bad usage during 
pulsar-function producing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr edited a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr edited a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524495287
 
 
   And the initial issue fixed too. @jerrypeng so the bookies version has to be 
the same of brokers for the v2.5.0-SNAPSHOT changes (I rollbacked my brokers to 
v2.4.0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr closed issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr closed issue #5006: AvroSchema in pulsar function producer doesn't 
output correct message
URL: https://github.com/apache/pulsar/issues/5006
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524495287
 
 
   And the initial issue too. @jerrypeng so the bookies version has to be the 
same of brokers for the v2.5.0-SNAPSHOT changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr edited a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr edited a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524495287
 
 
   And the initial issue fixed too. @jerrypeng so the bookies version has to be 
the same of brokers for the v2.5.0-SNAPSHOT changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524494929
 
 
   It worked. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524494446
 
 
   I tested with v2.5.0-SNAPSHOT standalone. Will rollback brokers to v2.4.0 
and test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on issue #4979: Update Function API Java docs

2019-08-23 Thread GitBox
merlimat commented on issue #4979: Update Function API Java docs
URL: https://github.com/apache/pulsar/issues/4979#issuecomment-524383799
 
 
   I think there's something broken in the website publish script. The 
javadoc/Doxygen/etc.. are apparently not being copied in the right place


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] merlimat commented on a change in pull request #5023: `hasMessageAvailable` should return false when Reader read from latest messages

2019-08-23 Thread GitBox
merlimat commented on a change in pull request #5023: `hasMessageAvailable` 
should return false when Reader read from latest messages
URL: https://github.com/apache/pulsar/pull/5023#discussion_r317209477
 
 

 ##
 File path: 
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ReaderTest.java
 ##
 @@ -111,6 +111,10 @@ private void testReadMessages(String topic, boolean 
enableBatch) throws Exceptio
 Assert.assertTrue(keys.remove(message.getKey()));
 }
 Assert.assertTrue(keys.isEmpty());
+
+Reader readLatest = 
pulsarClient.newReader().topic(topic).startMessageId(MessageId.latest)
+.readerName(subscription + 
"latest").create();
+Assert.assertFalse(readLatest.hasMessageAvailable());
 
 Review comment:
   Can you add the test for both the default case and when 
`startMessageInclusive()` is set?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vicaya commented on issue #3833: Error offloading:

2019-08-23 Thread GitBox
vicaya commented on issue #3833: Error offloading:
URL: https://github.com/apache/pulsar/issues/3833#issuecomment-524378899
 
 
   We ran into this issue in 2.4 as well. What's the current status/plan? Is 
this gonna be fixed in 2.4.1?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #4987: Trim deleted entries after recover cursor.

2019-08-23 Thread GitBox
sijie commented on issue #4987: Trim deleted entries after recover cursor.
URL: https://github.com/apache/pulsar/pull/4987#issuecomment-524375186
 
 
   @merlimat @rdhabalia PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie merged pull request #4991: [website] Fix the problem that tab click on the page did not response.

2019-08-23 Thread GitBox
sijie merged pull request #4991: [website] Fix the problem that tab click on 
the page did not response.
URL: https://github.com/apache/pulsar/pull/4991
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (40fbf5d -> c3cb5eb)

2019-08-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 40fbf5d  support parse batch entry payload (#4992)
 add c3cb5eb  ### Motivation (#4991)

No new revisions were added by this update.

Summary of changes:
 site2/website/core/Footer.js| 16 
 site2/website/static/js/pjax-api.min.js |  4 
 2 files changed, 20 deletions(-)
 delete mode 100644 site2/website/static/js/pjax-api.min.js



[GitHub] [pulsar] sijie closed issue #4990: [website]Tab page, click no response

2019-08-23 Thread GitBox
sijie closed issue #4990: [website]Tab page, click no response
URL: https://github.com/apache/pulsar/issues/4990
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (687406e -> 40fbf5d)

2019-08-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 687406e  Admin pod should use broker service to discover broker pods 
(#4995)
 add 40fbf5d  support parse batch entry payload (#4992)

No new revisions were added by this update.

Summary of changes:
 dashboard/Dockerfile   |   6 +-
 .../django/stats/templates/stats/messages.html |  35 +--
 dashboard/django/stats/views.py| 114 +
 .../django/utils}/__init__.py  |   0
 .../django/utils/import_utils.py   |  11 +-
 dashboard/requirements.txt |   8 ++
 pulsar-client-cpp/include/pulsar/Message.h |   3 +
 .../BoostHash.h => include/pulsar/MessageBatch.h}  |  35 ---
 pulsar-client-cpp/include/pulsar/MessageId.h   |  10 +-
 pulsar-client-cpp/lib/Commands.h   |   5 +-
 pulsar-client-cpp/lib/Message.cc   |   2 +
 pulsar-client-cpp/lib/MessageBatch.cc  |  57 +++
 pulsar-client-cpp/python/pulsar/__init__.py|  42 
 pulsar-client-cpp/python/src/message.cc|  17 +++
 pulsar-client-cpp/python/src/utils.h   |   1 +
 pulsar-client-cpp/tests/BatchMessageTest.cc|  61 ---
 16 files changed, 335 insertions(+), 72 deletions(-)
 copy {docker/pulsar-standalone/django/stats/templatetags => 
dashboard/django/utils}/__init__.py (100%)
 copy docker/pulsar-standalone/django/stats/apps.py => 
dashboard/django/utils/import_utils.py (85%)
 create mode 100644 dashboard/requirements.txt
 copy pulsar-client-cpp/{lib/BoostHash.h => include/pulsar/MessageBatch.h} (60%)
 create mode 100644 pulsar-client-cpp/lib/MessageBatch.cc



[GitHub] [pulsar] sijie merged pull request #4992: [pulsar-client-cpp/python, dashboard] support parse batch entry

2019-08-23 Thread GitBox
sijie merged pull request #4992: [pulsar-client-cpp/python,dashboard] support 
parse batch entry
URL: https://github.com/apache/pulsar/pull/4992
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie merged pull request #4995: Admin pod should use broker service to discover broker pods

2019-08-23 Thread GitBox
sijie merged pull request #4995: Admin pod should use broker service to 
discover broker pods
URL: https://github.com/apache/pulsar/pull/4995
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch master updated (958dcfe -> 687406e)

2019-08-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 958dcfe  Modify rest api post schema compatibility strategy (#4950)
 add 687406e  Admin pod should use broker service to discover broker pods 
(#4995)

No new revisions were added by this update.

Summary of changes:
 deployment/kubernetes/generic/k8s-1-9-and-above/admin.yaml | 4 ++--
 deployment/kubernetes/generic/original/admin.yaml  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)



[GitHub] [pulsar] sijie commented on a change in pull request #5008: [Pulsar IO]Support reload Source and Sink for Pulsar IO

2019-08-23 Thread GitBox
sijie commented on a change in pull request #5008: [Pulsar IO]Support reload 
Source and Sink for Pulsar IO
URL: https://github.com/apache/pulsar/pull/5008#discussion_r317203732
 
 

 ##
 File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
 ##
 @@ -897,6 +897,23 @@ void updateRequest(final FunctionMetaData 
functionMetaData) {
 return this.worker().getConnectorsManager().getConnectors();
 }
 
+public void reloadConnectors(String clientRole) {
+if (!isWorkerServiceAvailable()) {
+throwUnavailableException();
+}
+if (worker().getWorkerConfig().isAuthorizationEnabled()) {
+// Only superuser has permission to do this operation.
+if (!isSuperUser(clientRole)) {
+throw new RestException(Status.FORBIDDEN, "Need to admin 
authenticate to perform the request");
 
 Review comment:
   ```suggestion
  throw new RestException(Status.UNAUTHORIZED, "This operation 
requires super-user access");
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5014: [doc] Improve Pulsar Security Overview

2019-08-23 Thread GitBox
sijie commented on issue #5014: [doc] Improve Pulsar Security Overview
URL: https://github.com/apache/pulsar/pull/5014#issuecomment-524373267
 
 
   @Anonymitaet please review this


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on a change in pull request #5014: [doc] Improve Pulsar Security Overview

2019-08-23 Thread GitBox
sijie commented on a change in pull request #5014: [doc] Improve Pulsar 
Security Overview
URL: https://github.com/apache/pulsar/pull/5014#discussion_r317202427
 
 

 ##
 File path: site2/docs/security-overview.md
 ##
 @@ -4,28 +4,23 @@ title: Pulsar Security Overview
 sidebar_label: Overview
 ---
 
-Apache Pulsar is the central message bus for a business. It is frequently used 
to store mission-critical data, and therefore enabling security features are 
crucial.
+As the central message bus for a business, Apache Pulsar is frequently used 
for storing mission-critical data. Therefore, enabling security features in 
Pulsar is crucial.
 
-By default, there is no encryption, authentication, or authorization 
configured. Any client can communicate to Apache Pulsar via plain text service 
urls.
-It is critical that access via these plain text service urls is restricted to 
trusted clients only. Network segmentation and/or authorization ACLs can be used
-to restrict access to trusted IPs in such cases. If neither is used, the 
cluster is wide open and can be accessed by anyone.
+By default, Pulsar configures no encryption, authentication, or authorization. 
Any client can communicate to Apache Pulsar via plain text service urls. So we 
must ensure that Pulsar accessing via these plain text service urls is 
restricted to trusted clients only. In such cases, you can use Network 
segmentation and/or authorization ACLs to restrict access to trusted IPs. If 
you use neither, the state of cluster is wide open and anyone can access the 
cluster.
 
-Pulsar supports a pluggable authentication mechanism that Pulsar clients can 
use to authenticate with brokers and proxies. Pulsar
-can also be configured to support multiple authentication sources.
+Pulsar supports a pluggable authentication mechanism. And Pulsar clients use 
this mechanism to authenticate with brokers and proxies. You can also configure 
Pulsar to support multiple authentication sources.
 
-It is strongly recommended to secure the service components in your Apache 
Pulsar deployment.
+You'd better secure the service components in your Apache Pulsar deployment.
 
 ## Role Tokens
 
-In Pulsar, a *role* is a string, like `admin` or `app1`, that can represent a 
single client or multiple clients. Roles are used to control permission for 
clients
-to produce or consume from certain topics, administer the configuration for 
tenants, and more.
+In Pulsar, a *role* is a string, like `admin` or `app1`, which can represent 
one or more clients. You can use roles to control permission for clients to 
produce or consume from certain topics, administer the configuration for 
tenants, and so on.
 
-Apache Pulsar uses a [Authentication Provider](#authentication-providers) to 
establish the identity of a client and then assign that client a *role token*. 
This
-role token is then used for [Authorization and 
ACLs](security-authorization.md) to determine what the client is authorized to 
do.
+Apache Pulsar uses the [Authentication Provider](#authentication-providers) to 
establish the identity of a client and then assign a *role token* to that 
client. This role token is then used for [Authorization and 
ACLs](security-authorization.md) to determine what the client is authorized to 
do.
 
 ## Authentication Providers
 
-Currently Pulsar supports two authentication providers:
+Currently Pulsar supports three authentication providers:
 
 Review comment:
   yes


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5027: [doc] Improve Pulsar security-tls-transport

2019-08-23 Thread GitBox
sijie commented on issue #5027: [doc] Improve Pulsar security-tls-transport
URL: https://github.com/apache/pulsar/pull/5027#issuecomment-524372667
 
 
   @Anonymitaet ^^ Please review this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5028: Add Connector Admin CLI guide

2019-08-23 Thread GitBox
sijie commented on issue #5028: Add Connector Admin CLI guide
URL: https://github.com/apache/pulsar/pull/5028#issuecomment-524372078
 
 
   @tuteng please review this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr edited a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr edited a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524351044
 
 
   I tested it on v2.4.0 pulsar standalone and no issue. So it's an issue on 
v2.5.0-SNAPSHOT brokers with v.2.4.0 bookies or just on v2.5.0-SNAPSHOT.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr removed a comment on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr removed a comment on issue #5006: AvroSchema in pulsar function 
producer doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524312368
 
 
   When I curl to .../schemas I got the schemas list, there is one schema with 
version `0`, it's not a problem? The 0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524351044
 
 
   I tested it on v2.4.0 pulsar standalone and no issue. It's to be an issue 
v2.5.0-SNAPSHOT brokers with v.2.4.0 bookies or just v2.5.0-SNAPSHOT.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] sijie commented on issue #5018: Added powered-by page

2019-08-23 Thread GitBox
sijie commented on issue #5018: Added powered-by page
URL: https://github.com/apache/pulsar/pull/5018#issuecomment-524349573
 
 
   run integration tests
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] cdbartholomew opened a new pull request #5029: Clarification in DLQ documentation

2019-08-23 Thread GitBox
cdbartholomew opened a new pull request #5029: Clarification in DLQ 
documentation
URL: https://github.com/apache/pulsar/pull/5029
 
 
   The first question I had when I read this section is what is the name of the 
DLQ topic. I found the answer in the Java API docs, but I think it makes sense 
to include it in this section, especially since this feature now also works in 
the Websocket client. I added the name of the default dead letter queue and an 
example of how to specify the DLQ name.
   
   
   
   *(If this PR fixes a github issue, please add `Fixes #`.)*
   
   Fixes #
   
   *(or if this PR is one task of a github issue, please add `Master Issue: 
#` to link to the master issue.)*
   
   Master Issue: #
   
   ### Motivation
   
   
   *Explain here the context, and why you're making that change. What is the 
problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added integration tests for end-to-end deployment with large payloads 
(10MB)*
 - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API: (yes / no)
 - The schema: (yes / no / don't know)
 - The default values of configurations: (yes / no)
 - The wire protocol: (yes / no)
 - The rest endpoints: (yes / no)
 - The admin cli options: (yes / no)
 - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
 - If a feature is not applicable for documentation, explain why?
 - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] jiazhai commented on issue #5018: Added powered-by page

2019-08-23 Thread GitBox
jiazhai commented on issue #5018: Added powered-by page
URL: https://github.com/apache/pulsar/pull/5018#issuecomment-524328893
 
 
   lgtm. will add some other companies that not included after this is merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524312368
 
 
   When I curl to .../schemas I got the schemas list, there is one schema with 
version `0`, it's not a problem? The 0?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-08-23 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide
URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120
 
 
   PRs related to this issue:
   
   * Add Connector Admin CLI guide: https://github.com/apache/pulsar/pull/5028


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-08-23 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide
URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120
 
 
   PRs related to this issue:
   
   Add Connector Admin CLI guide: https://github.com/apache/pulsar/pull/5028


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-08-23 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide
URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120
 
 
   PRs related to this issue:
   
   https://github.com/apache/pulsar/pull/5028


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on issue #5028: Add Connector Admin CLI guide

2019-08-23 Thread GitBox
Anonymitaet commented on issue #5028: Add Connector Admin CLI guide
URL: https://github.com/apache/pulsar/pull/5028#issuecomment-524308371
 
 
   @sijie could you please help review? Thank you 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet opened a new pull request #5028: Add Connector Admin CLI guide

2019-08-23 Thread GitBox
Anonymitaet opened a new pull request #5028: Add Connector Admin CLI guide
URL: https://github.com/apache/pulsar/pull/5028
 
 
   
   * Remove connector related contents from Pulsar admin CLI guide
   * Add an independent guide: Connector Admin CLI 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] cdbartholomew commented on issue #5018: Added powered-by page

2019-08-23 Thread GitBox
cdbartholomew commented on issue #5018: Added powered-by page
URL: https://github.com/apache/pulsar/pull/5018#issuecomment-524297564
 
 
   Would you mind adding Kafkaesque to the list?
   
   `{
   name: 'Kafkaesque',
   url: 'https://kafkaesque.io/',
   logo: 
'https://kafkaesque.io/wp-content/uploads/2019/04/color_logo_with_background.svg'
   },`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] mingfang commented on issue #4890: [pulsar-sql] Handle schema not found

2019-08-23 Thread GitBox
mingfang commented on issue #4890: [pulsar-sql] Handle schema not found
URL: https://github.com/apache/pulsar/pull/4890#issuecomment-524275908
 
 
   You have to have some data into to see the error therefore you have to 
repeat step 1, run the generator for a minute and then kill it before running 
step 2 again.
   
   My wild guess is that the schema got deleted and is not getting recreated by 
the generator because the topic already exist when running after the first 
time.  If I change the topic name then it works again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Monica-zy opened a new pull request #5027: [doc] Improve Pulsar security-tls-transport

2019-08-23 Thread GitBox
Monica-zy opened a new pull request #5027: [doc] Improve Pulsar 
security-tls-transport
URL: https://github.com/apache/pulsar/pull/5027
 
 
   Motivation
   Improve the language and the overall descriptive style of the Transport 
Encryption using TLS document of Security chapter.
   
   Modifications
   Adjust the tone, personal pronouns, voice also some typo errors of some 
sentences in the document.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] KannarFr commented on issue #5006: AvroSchema in pulsar function producer doesn't output correct message

2019-08-23 Thread GitBox
KannarFr commented on issue #5006: AvroSchema in pulsar function producer 
doesn't output correct message
URL: https://github.com/apache/pulsar/issues/5006#issuecomment-524262430
 
 
   Yes V2.4.0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[pulsar] branch asf-site updated: Updated site at revision 958dcfe

2019-08-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 677af8b  Updated site at revision 958dcfe
677af8b is described below

commit 677af8b7b06a357418c15eed57e3be3ed8d0101e
Author: jenkins 
AuthorDate: Fri Aug 23 09:49:32 2019 +

Updated site at revision 958dcfe
---
 content/swagger/2.5.0-SNAPSHOT/swagger.json| 40 -
 .../swagger/2.5.0-SNAPSHOT/swaggerfunctions.json   | 52 +++---
 content/swagger/swagger.json   | 40 -
 content/swagger/swaggerfunctions.json  | 52 +++---
 4 files changed, 92 insertions(+), 92 deletions(-)

diff --git a/content/swagger/2.5.0-SNAPSHOT/swagger.json 
b/content/swagger/2.5.0-SNAPSHOT/swagger.json
index eced95a..1bab087 100644
--- a/content/swagger/2.5.0-SNAPSHOT/swagger.json
+++ b/content/swagger/2.5.0-SNAPSHOT/swagger.json
@@ -4784,7 +4784,7 @@
   "200" : {
 "description" : "successful operation",
 "schema" : {
-  "$ref" : "#/definitions/TopicStats"
+  "$ref" : "#/definitions/NonPersistentTopicStats"
 }
   },
   "401" : {
@@ -8866,6 +8866,21 @@
   "type" : "number",
   "format" : "double"
 },
+"underLoaded" : {
+  "type" : "boolean"
+},
+"overLoaded" : {
+  "type" : "boolean"
+},
+"loadReportType" : {
+  "type" : "string"
+},
+"cpu" : {
+  "$ref" : "#/definitions/ResourceUsage"
+},
+"directMemory" : {
+  "$ref" : "#/definitions/ResourceUsage"
+},
 "lastUpdate" : {
   "type" : "integer",
   "format" : "int64"
@@ -8886,21 +8901,6 @@
 },
 "memory" : {
   "$ref" : "#/definitions/ResourceUsage"
-},
-"cpu" : {
-  "$ref" : "#/definitions/ResourceUsage"
-},
-"directMemory" : {
-  "$ref" : "#/definitions/ResourceUsage"
-},
-"underLoaded" : {
-  "type" : "boolean"
-},
-"overLoaded" : {
-  "type" : "boolean"
-},
-"loadReportType" : {
-  "type" : "string"
 }
   }
 },
@@ -9068,10 +9068,10 @@
   "type" : "number",
   "format" : "double"
 },
-"connectedSince" : {
+"producerName" : {
   "type" : "string"
 },
-"producerName" : {
+"connectedSince" : {
   "type" : "string"
 },
 "clientVersion" : {
@@ -9739,10 +9739,10 @@
 "type" : "string"
   }
 },
-"connectedSince" : {
+"producerName" : {
   "type" : "string"
 },
-"producerName" : {
+"connectedSince" : {
   "type" : "string"
 },
 "clientVersion" : {
diff --git a/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json 
b/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
index d1dc384..908275f 100644
--- a/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
+++ b/content/swagger/2.5.0-SNAPSHOT/swaggerfunctions.json
@@ -1348,35 +1348,11 @@
 "Message" : {
   "type" : "object",
   "properties" : {
-"messageId" : {
-  "$ref" : "#/definitions/MessageId"
-},
 "replicated" : {
   "type" : "boolean"
 },
-"publishTime" : {
-  "type" : "integer",
-  "format" : "int64"
-},
-"eventTime" : {
-  "type" : "integer",
-  "format" : "int64"
-},
-"topicName" : {
-  "type" : "string"
-},
-"producerName" : {
-  "type" : "string"
-},
-"keyBytes" : {
-  "type" : "array",
-  "items" : {
-"type" : "string",
-"format" : "byte"
-  }
-},
-"replicatedFrom" : {
-  "type" : "string"
+"messageId" : {
+  "$ref" : "#/definitions/MessageId"
 },
 "sequenceId" : {
   "type" : "integer",
@@ -1403,6 +1379,30 @@
 "format" : "byte"
   }
 },
+"keyBytes" : {
+  "type" : "array",
+  "items" : {
+"type" : "string",
+"format" : "byte"
+  }
+},
+"publishTime" : {
+  "type" : "integer",
+  "format" : "int64"
+},
+"eventTime" : {
+  "type" : "integer",
+  "format" : "int64"
+},
+"producerName" : {
+  "type" : "string"
+},
+"topicName" : {
+  "type" : "string"
+},
+"replicatedFrom" : {
+  "type" : "string"
+},
 "data" : {
   "type" : "array",
   "items" : {
diff

[pulsar-client-node] branch master updated: 0.1.0-rc.0

2019-08-23 Thread nkurihar
This is an automated email from the ASF dual-hosted git repository.

nkurihar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git


The following commit(s) were added to refs/heads/master by this push:
 new c447201  0.1.0-rc.0
 new 3423f5a  Merge pull request #49 from massakam/bump-master-version
c447201 is described below

commit c447201f52ad5cb24d90715097819af2a5cc2445
Author: Masahiro Sakamoto 
AuthorDate: Fri Aug 23 13:58:15 2019 +0900

0.1.0-rc.0
---
 package-lock.json | 2 +-
 package.json  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 4a8725c..24e6f4f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "pulsar-client",
-  "version": "0.0.1-rc.0",
+  "version": "0.1.0-rc.0",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/package.json b/package.json
index 5798bec..c53a7bd 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pulsar-client",
-  "version": "0.0.1-rc.0",
+  "version": "0.1.0-rc.0",
   "description": "Pulsar Node.js client",
   "main": "index.js",
   "directories": {



[GitHub] [pulsar] jiazhai commented on issue #5016: Add support in cpp client for 1 partitioned topic

2019-08-23 Thread GitBox
jiazhai commented on issue #5016: Add support in cpp client for 1 partitioned 
topic
URL: https://github.com/apache/pulsar/pull/5016#issuecomment-524237012
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] vontikov opened a new issue #5026: Create ZooKeeper znodes under a dedicated parent

2019-08-23 Thread GitBox
vontikov opened a new issue #5026: Create ZooKeeper znodes under a dedicated 
parent
URL: https://github.com/apache/pulsar/issues/5026
 
 
   Apache Pulsar related znodes are placed under ZooKeeper root:
   _[admin, bookies, counters, ledgers, loadbalance, managed-ledgers, 
namespace, schemas, stream]_
   Placing them under a dedicated parent (someting like "/apache-pulsar") would 
simplify support in case of sharing ZooKeeper cluster between different apps
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Jennifer88huang commented on issue #4968: [doc] Pulsar Functions: CLI

2019-08-23 Thread GitBox
Jennifer88huang commented on issue #4968: [doc] Pulsar Functions: CLI
URL: https://github.com/apache/pulsar/pull/4968#issuecomment-524209261
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services