[GitHub] [pulsar] volfco commented on issue #5274: geo replicated subscribers

2019-09-29 Thread GitBox
volfco commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-536420130 The one thing I thought of in the background is that messages would have to be replicated with origin DC and origin ID or part of an Avro schema- as currentl

[GitHub] [pulsar] pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-29 Thread GitBox
pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329418689 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication ma

[GitHub] [pulsar] pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-29 Thread GitBox
pouledodue commented on a change in pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293#discussion_r329417867 ## File path: site2/docs/concepts-messaging.md ## @@ -411,4 +411,32 @@ Message deduplication ma

[GitHub] [pulsar] xujianhai666 opened a new pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery*

2019-09-29 Thread GitBox
xujianhai666 opened a new pull request #5293: [ISSUE #4675][docs] Add *Delayed Message Delivery* URL: https://github.com/apache/pulsar/pull/5293 * Add *Delayed Message Delivery* on concepts-messaging.md ### Motivation Add *Delayed Message Delivery* ### Modifications * A

[GitHub] [pulsar] merlimat commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-29 Thread GitBox
merlimat commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#issuecomment-536401698 > @massakam Got it, thanks. why don't we close the dispatcher at removeConsumer when consumers are remo

[GitHub] [pulsar] jiazhai commented on issue #5279: Support for python native logging from python wrapper

2019-09-29 Thread GitBox
jiazhai commented on issue #5279: Support for python native logging from python wrapper URL: https://github.com/apache/pulsar/pull/5279#issuecomment-536379209 @BlackJohnny, above comments "run integration tests" is a trigger for the jenkins integration tests, github will handle it. -

[GitHub] [pulsar] jiazhai commented on issue #5279: Support for python native logging from python wrapper

2019-09-29 Thread GitBox
jiazhai commented on issue #5279: Support for python native logging from python wrapper URL: https://github.com/apache/pulsar/pull/5279#issuecomment-536378962 run integration tests This is an automated message from the Apache

[GitHub] [pulsar] Anonymitaet commented on issue #5211: [Doc] Add *Kinesis source connector guide*

2019-09-29 Thread GitBox
Anonymitaet commented on issue #5211: [Doc] Add *Kinesis source connector guide* URL: https://github.com/apache/pulsar/pull/5211#issuecomment-536357165 run integration tests This is an automated message from the Apache Git Ser

[GitHub] [pulsar] aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx

2019-09-29 Thread GitBox
aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx URL: https://github.com/apache/pulsar/pull/5263#issuecomment-536347975 run integration tests This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-09-29 Thread GitBox
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-536305200 run java8 tests This is an automate

[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-09-29 Thread GitBox
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-536303116 run java8 tests This is an automate

[GitHub] [pulsar] congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-09-29 Thread GitBox
congbobo184 removed a comment on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-535804618 run java8 tests This is an automate

[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-09-29 Thread GitBox
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-536305200 run java8 tests This is an automated messag

[GitHub] [pulsar] congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer

2019-09-29 Thread GitBox
congbobo184 commented on issue #5227: [PIP-44] Separate schema compatibility checker for producer and consumer URL: https://github.com/apache/pulsar/pull/5227#issuecomment-536303116 run java8 tests This is an automated messag

[GitHub] [pulsar] massakam commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-29 Thread GitBox
massakam commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#issuecomment-536289579 @codelipenghui Hmm, if the cursor is not durable, the subscription is closed, so the dispatcher should also be

[GitHub] [pulsar] codelipenghui commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-29 Thread GitBox
codelipenghui commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#issuecomment-536284773 @massakam Got it, thanks. why don't we close the dispatcher at removeConsumer https://github.com/apache/p

[GitHub] [pulsar] Anonymitaet commented on issue #5292: [Doc] Add *Solr sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet commented on issue #5292: [Doc] Add *Solr sink connector guide* URL: https://github.com/apache/pulsar/pull/5292#issuecomment-536282962 @tuteng could you please help review? Thank you This is an automated message fr

[GitHub] [pulsar] Anonymitaet opened a new pull request #5292: [Doc] Add *Solr sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet opened a new pull request #5292: [Doc] Add *Solr sink connector guide* URL: https://github.com/apache/pulsar/pull/5292 Fix https://github.com/apache/pulsar/issues/5015 This is an automated message from the Apache

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-09-29 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 I've created the following PRs to resolve this issue: # Overview * https://github.com/apache/pulsar/pull/5183 * https://githu

[GitHub] [pulsar] massakam commented on a change in pull request #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-29 Thread GitBox
massakam commented on a change in pull request #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#discussion_r329348304 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDi

[GitHub] [pulsar] Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet commented on issue #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291#issuecomment-536280759 @tuteng could you please help review? Thank you This is an automated message f

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-09-29 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 I've created the following PRs to resolve this issue: # Overview * https://github.com/apache/pulsar/pull/5183 * https://githu

[GitHub] [pulsar] Anonymitaet opened a new pull request #5291: [Doc] Add *Redis sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet opened a new pull request #5291: [Doc] Add *Redis sink connector guide* URL: https://github.com/apache/pulsar/pull/5291 Fix https://github.com/apache/pulsar/issues/5015 This is an automated message from the Apache

[GitHub] [pulsar] massakam commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes

2019-09-29 Thread GitBox
massakam commented on issue #5288: [pulsar-broker] Close previous dispatcher when subscription type changes URL: https://github.com/apache/pulsar/pull/5288#issuecomment-536277568 @codelipenghui > I noticed if all consumer disconnected in a subscription, the topic will remove this subsc

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-09-29 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 I've created the following PRs to resolve this issue: # Overview * https://github.com/apache/pulsar/pull/5183 * https://githu

[GitHub] [pulsar] Anonymitaet opened a new pull request #5290: [Doc] Add *RabbitMQ sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet opened a new pull request #5290: [Doc] Add *RabbitMQ sink connector guide* URL: https://github.com/apache/pulsar/pull/5290 Fix https://github.com/apache/pulsar/issues/5015 This is an automated message from the Apa

[GitHub] [pulsar] Anonymitaet commented on issue #5290: [Doc] Add *RabbitMQ sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet commented on issue #5290: [Doc] Add *RabbitMQ sink connector guide* URL: https://github.com/apache/pulsar/pull/5290#issuecomment-536277065 @tuteng could you please help review? Thank you This is an automated messag

[GitHub] [pulsar] Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide

2019-09-29 Thread GitBox
Anonymitaet edited a comment on issue #5015: [Doc] Update Pulsar Connector Guide URL: https://github.com/apache/pulsar/issues/5015#issuecomment-524149120 I've created the following PRs to resolve this issue: # Overview * https://github.com/apache/pulsar/pull/5183 * https://githu

[GitHub] [pulsar] Anonymitaet commented on issue #5289: [Doc] Add *MongoDB sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet commented on issue #5289: [Doc] Add *MongoDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5289#issuecomment-536274513 @tuteng could you please help review? Thank you This is an automated message

[GitHub] [pulsar] Anonymitaet opened a new pull request #5289: [Doc] Add *MongoDB sink connector guide*

2019-09-29 Thread GitBox
Anonymitaet opened a new pull request #5289: [Doc] Add *MongoDB sink connector guide* URL: https://github.com/apache/pulsar/pull/5289 Fix https://github.com/apache/pulsar/issues/5015 This is an automated message from the Apac

[GitHub] [pulsar] jiazhai commented on issue #5279: Support for python native logging from python wrapper

2019-09-29 Thread GitBox
jiazhai commented on issue #5279: Support for python native logging from python wrapper URL: https://github.com/apache/pulsar/pull/5279#issuecomment-536274388 run integration tests This is an automated message from the Apache

[GitHub] [pulsar] aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx

2019-09-29 Thread GitBox
aahmed-se commented on issue #5263: Fix Cmake to build _pulsar for osx URL: https://github.com/apache/pulsar/pull/5263#issuecomment-536262389 run integration tests This is an automated message from the Apache Git Service. To r