[GitHub] [pulsar] wolfstudy commented on issue #5232: Upgrade dependencies for security fixes

2019-10-29 Thread GitBox
wolfstudy commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-547749472 > org.apache.pulsar.proxy.server.AuthedAdminProxyHandlerTest.testAuthenticatedProxyAsNonAdmin

[GitHub] [pulsar] wolfstudy commented on issue #5378: Trim messages which less than mark delete position for message redelivery

2019-10-29 Thread GitBox
wolfstudy commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-547749355 run java8 tests This is an automated

[GitHub] [pulsar] wolfstudy merged pull request #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays

2019-10-29 Thread GitBox
wolfstudy merged pull request #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays URL: https://github.com/apache/pulsar/pull/5499 This is an automated message from the Apache Git Service. To

[pulsar] branch master updated (43bc790 -> 01ca24b)

2019-10-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 43bc790 [TIEREDSTORAGE] Only seek when reading unexpected entry (#5356) add 01ca24b Fixed dispatcher skipping

[GitHub] [pulsar] wolfstudy merged pull request #5462: [pulsar-broker] fix broken custom auth-provider that uses authenticationData

2019-10-29 Thread GitBox
wolfstudy merged pull request #5462: [pulsar-broker] fix broken custom auth-provider that uses authenticationData URL: https://github.com/apache/pulsar/pull/5462 This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] wolfstudy merged pull request #5356: [TIEREDSTORAGE] Only seek when reading unexpected entry

2019-10-29 Thread GitBox
wolfstudy merged pull request #5356: [TIEREDSTORAGE] Only seek when reading unexpected entry URL: https://github.com/apache/pulsar/pull/5356 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated (ebaf97c -> 43bc790)

2019-10-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from ebaf97c [pulsar-broker] fix broken custom auth-provider that uses authenticationData (#5462) add 43bc790

[pulsar] branch master updated (734e748 -> ebaf97c)

2019-10-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 734e748 Return after triggering callback with empty result (#5500) add ebaf97c [pulsar-broker] fix broken custom

[GitHub] [pulsar] tuteng commented on issue #5496: [Doc]Fix document link error

2019-10-29 Thread GitBox
tuteng commented on issue #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496#issuecomment-547744136 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-go] merlimat merged pull request #79: Remove usage of global consumer vars.

2019-10-29 Thread GitBox
merlimat merged pull request #79: Remove usage of global consumer vars. URL: https://github.com/apache/pulsar-client-go/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please log

[pulsar-client-go] branch master updated: Remove usage of global consumer vars. (#79)

2019-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new d645f94 Remove usage of global

[GitHub] [pulsar] sijie merged pull request #5500: Return after triggering callback with empty result

2019-10-29 Thread GitBox
sijie merged pull request #5500: Return after triggering callback with empty result URL: https://github.com/apache/pulsar/pull/5500 This is an automated message from the Apache Git Service. To respond to the message, please

[pulsar] branch master updated (467ffab -> 734e748)

2019-10-29 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 467ffab Efficiency improvements for delay delivery tracker (#5498) add 734e748 Return after triggering

[GitHub] [pulsar] Jennifer88huang commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
Jennifer88huang commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482#issuecomment-547727606 @rocketraman One day after merging the PR. The website builds automatically every day. If it's urgent, we can build

[GitHub] [pulsar] rocketraman commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
rocketraman commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482#issuecomment-547722107 @Jennifer88huang how long does it take before this change causes this page to update?

[GitHub] [pulsar] wolfstudy commented on issue #5022: Fixed the cleanup of non-durable cursors when a reader is closed

2019-10-29 Thread GitBox
wolfstudy commented on issue #5022: Fixed the cleanup of non-durable cursors when a reader is closed URL: https://github.com/apache/pulsar/pull/5022#issuecomment-547710068 ping @merlimat again, please rebase master code, thanks.

[GitHub] [pulsar] wolfstudy commented on issue #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays

2019-10-29 Thread GitBox
wolfstudy commented on issue #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays URL: https://github.com/apache/pulsar/pull/5499#issuecomment-547709909 > org.apache.pulsar.functions.worker.PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser

[GitHub] [pulsar] wolfstudy commented on issue #5378: Trim messages which less than mark delete position for message redelivery

2019-10-29 Thread GitBox
wolfstudy commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-547709776 > org.apache.pulsar.client.api.BrokerServiceLookupTest.setup

[GitHub] [pulsar] wolfstudy commented on issue #5356: [TIEREDSTORAGE] Only seek when reading unexpected entry

2019-10-29 Thread GitBox
wolfstudy commented on issue #5356: [TIEREDSTORAGE] Only seek when reading unexpected entry URL: https://github.com/apache/pulsar/pull/5356#issuecomment-547709431 run cpp tests This is an automated message from the Apache

[GitHub] [pulsar] wolfstudy commented on issue #5232: Upgrade dependencies for security fixes

2019-10-29 Thread GitBox
wolfstudy commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-547709591 > org.apache.pulsar.proxy.server.AuthedAdminProxyHandlerTest.testAuthenticatedProxyAsNonAdmin

[GitHub] [pulsar] wolfstudy commented on issue #5462: [pulsar-broker] fix broken custom auth-provider that uses authenticationData

2019-10-29 Thread GitBox
wolfstudy commented on issue #5462: [pulsar-broker] fix broken custom auth-provider that uses authenticationData URL: https://github.com/apache/pulsar/pull/5462#issuecomment-547709238 run java8 tests This is an automated

[GitHub] [pulsar] wolfstudy merged pull request #5498: Efficiency improvements for delay delivery tracker

2019-10-29 Thread GitBox
wolfstudy merged pull request #5498: Efficiency improvements for delay delivery tracker URL: https://github.com/apache/pulsar/pull/5498 This is an automated message from the Apache Git Service. To respond to the message,

[pulsar] branch master updated (418362e -> 467ffab)

2019-10-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 418362e [Issue 5309][docs] Clarify wording around retention policies (#5482) add 467ffab Efficiency

[pulsar] branch master updated (de4bbe1 -> 418362e)

2019-10-29 Thread hjf
This is an automated email from the ASF dual-hosted git repository. hjf pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from de4bbe1 Updating Docker command to work on Windows properly (#5419) add 418362e [Issue 5309][docs] Clarify

[GitHub] [pulsar] Jennifer88huang merged pull request #5482: [Issue 5309][docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
Jennifer88huang merged pull request #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482 This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] Jennifer88huang closed issue #5309: [docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
Jennifer88huang closed issue #5309: [docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/issues/5309 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #5482: [Issue 5309][docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
Jennifer88huang commented on a change in pull request #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482#discussion_r340398697 ## File path: site2/docs/cookbooks-retention-expiry.md ## @@ -31,7 +31,7 @@ By

[GitHub] [pulsar] sijie commented on issue #5496: [Doc]Fix document link error

2019-10-29 Thread GitBox
sijie commented on issue #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496#issuecomment-547697352 @tuteng there are conflicts in this pull request. Can you please address the conflict? This

[GitHub] [pulsar] aahmed-se commented on issue #4028: Functions should make use of Schema Types that are available

2019-10-29 Thread GitBox
aahmed-se commented on issue #4028: Functions should make use of Schema Types that are available URL: https://github.com/apache/pulsar/pull/4028#issuecomment-547696831 @srkukarni can you address teh comments This is an

[GitHub] [pulsar] aahmed-se commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-10-29 Thread GitBox
aahmed-se commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#issuecomment-547696456 @jiazhai take a look please This is

[GitHub] [pulsar] aahmed-se commented on issue #5334: When building docker image, copy tarball at the end to use build cache

2019-10-29 Thread GitBox
aahmed-se commented on issue #5334: When building docker image, copy tarball at the end to use build cache URL: https://github.com/apache/pulsar/pull/5334#issuecomment-547695936 run java 8 tests This is an automated message

[GitHub] [pulsar] aahmed-se commented on issue #5390: Use pure-java Air-Compressor instead of JNI based libraries

2019-10-29 Thread GitBox
aahmed-se commented on issue #5390: Use pure-java Air-Compressor instead of JNI based libraries URL: https://github.com/apache/pulsar/pull/5390#issuecomment-547695652 @merlimat there is genuine issue here. ``` Error Message Could not initialize class io.airlift.slice.Slices

[pulsar] branch master updated (a2f5e30 -> de4bbe1)

2019-10-29 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a2f5e30 Fix broken io connector links. (#5409) add de4bbe1 Updating Docker command to work on Windows

[GitHub] [pulsar] aahmed-se merged pull request #5419: [Issue 5392][documentation] Updating Docker command to work on Windows properly

2019-10-29 Thread GitBox
aahmed-se merged pull request #5419: [Issue 5392][documentation] Updating Docker command to work on Windows properly URL: https://github.com/apache/pulsar/pull/5419 This is an automated message from the Apache Git Service.

[GitHub] [pulsar] aahmed-se merged pull request #5409: Fix broken io connector links.

2019-10-29 Thread GitBox
aahmed-se merged pull request #5409: Fix broken io connector links. URL: https://github.com/apache/pulsar/pull/5409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar] branch master updated (1419483 -> a2f5e30)

2019-10-29 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1419483 Fix broker function token authentication link (#5410) add a2f5e30 Fix broken io connector links.

[GitHub] [pulsar] jerrypeng commented on issue #5500: Return after triggering callback with empty result

2019-10-29 Thread GitBox
jerrypeng commented on issue #5500: Return after triggering callback with empty result URL: https://github.com/apache/pulsar/pull/5500#issuecomment-547694997 rerun java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] jerrypeng commented on issue #5497: fix misspelling and adjust code style

2019-10-29 Thread GitBox
jerrypeng commented on issue #5497: fix misspelling and adjust code style URL: https://github.com/apache/pulsar/pull/5497#issuecomment-547694832 rerun integration tests This is an automated message from the Apache Git

[GitHub] [pulsar] jerrypeng commented on issue #5498: Efficiency improvements for delay delivery tracker

2019-10-29 Thread GitBox
jerrypeng commented on issue #5498: Efficiency improvements for delay delivery tracker URL: https://github.com/apache/pulsar/pull/5498#issuecomment-547694161 rerun cpp tests This is an automated message from the Apache Git

[GitHub] [pulsar] jerrypeng commented on issue #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays

2019-10-29 Thread GitBox
jerrypeng commented on issue #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays URL: https://github.com/apache/pulsar/pull/5499#issuecomment-547694059 rerun java8 tests This is an automated

[GitHub] [pulsar] rocketraman commented on a change in pull request #5482: [Issue 5309][docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
rocketraman commented on a change in pull request #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482#discussion_r340388249 ## File path: site2/docs/cookbooks-retention-expiry.md ## @@ -31,7 +31,7 @@ By

[GitHub] [pulsar-client-go] cckellogg opened a new pull request #79: Remove usage of global consumer vars.

2019-10-29 Thread GitBox
cckellogg opened a new pull request #79: Remove usage of global consumer vars. URL: https://github.com/apache/pulsar-client-go/pull/79 Remove global variable usage in consumer code. This is an automated message from the

[GitHub] [pulsar] tuteng commented on issue #5496: [Doc]Fix document link error

2019-10-29 Thread GitBox
tuteng commented on issue #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496#issuecomment-547676700 run java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] volfco commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547643141 @merlimat Sure. ``` # TYPE pulsar_replicated_subscriptions_pending_snapshots gauge

[GitHub] [pulsar] volfco edited a comment on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco edited a comment on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547643141 @merlimat Sure. Prometheus Metrics: ```# TYPE pulsar_replicated_subscriptions_pending_snapshots gauge

[GitHub] [pulsar] volfco edited a comment on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco edited a comment on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547643141 @merlimat Sure. Prometheus Metrics: ```# TYPE pulsar_replicated_subscriptions_pending_snapshots gauge

[GitHub] [pulsar] merlimat commented on issue #5498: Efficiency improvements for delay delivery tracker

2019-10-29 Thread GitBox
merlimat commented on issue #5498: Efficiency improvements for delay delivery tracker URL: https://github.com/apache/pulsar/pull/5498#issuecomment-547639788 run cpp tests This is an automated message from the Apache Git

[GitHub] [pulsar] merlimat commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
merlimat commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547636971 Ok, that doesn't look correct then. Can you enable debug logs on

[GitHub] [pulsar] volfco edited a comment on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco edited a comment on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547626912 @merlimat These logs tell me that replication has been enabled: ``` 4:55:14.350 [bookkeeper-ml-workers-OrderedExecutor-3-0] INFO

[GitHub] [pulsar] volfco commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547626912 @merlimat These logs tel me that replication has been enabled: ``` 4:55:14.350 [bookkeeper-ml-workers-OrderedExecutor-3-0] INFO

[GitHub] [pulsar] merlimat commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
merlimat commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547624277 Can you check on the broker logs if it's enabling the replicated subscription on that topic?

[GitHub] [pulsar] merlimat commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
merlimat commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547624003 > This is not what I'm seeing. I can start the consumer in AUS, it'll start reading. I close it at message 10 and wait a few seconds and start an IAD

[GitHub] [pulsar] merlimat commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
merlimat commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547623316 Keep in mind that the subscription state in asynchronously replicated at configurable interval. Take a look at broker.conf: ``` #

[GitHub] [pulsar] merlimat commented on issue #5495: Add a reverse mapping from role to namespaces

2019-10-29 Thread GitBox
merlimat commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-547622905 I think that most AuthZ implementation won't be able to fulfill that info though

[GitHub] [pulsar] volfco edited a comment on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco edited a comment on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547617424 @sijie I've gotten a MVP cluster setup between two DCs that are ~40ms apart with replication between them. This is my code (I'm horrible at

[GitHub] [pulsar] volfco commented on issue #5274: geo replicated subscribers

2019-10-29 Thread GitBox
volfco commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-547617424 @sijie I've gotten a MVP cluster setup between two DCs that are ~40ms apart with replication between them. This is my code (I'm horrible at java):

[pulsar] branch master updated (2983175 -> 1419483)

2019-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2983175 [Issue 5415][docker build]Updating docker build for pulsar-standalone to use main dashboard sou… (#5420)

[GitHub] [pulsar] merlimat merged pull request #5420: [Issue 5415][docker build]Updating docker build for pulsar-standalone to use main dashboard sou…

2019-10-29 Thread GitBox
merlimat merged pull request #5420: [Issue 5415][docker build]Updating docker build for pulsar-standalone to use main dashboard sou… URL: https://github.com/apache/pulsar/pull/5420 This is an automated message from the

[GitHub] [pulsar] merlimat merged pull request #5410: Fix broker function token authentication link

2019-10-29 Thread GitBox
merlimat merged pull request #5410: Fix broker function token authentication link URL: https://github.com/apache/pulsar/pull/5410 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] merlimat commented on issue #5419: [Issue 5392][documentation] Updating Docker command to work on Windows properly

2019-10-29 Thread GitBox
merlimat commented on issue #5419: [Issue 5392][documentation] Updating Docker command to work on Windows properly URL: https://github.com/apache/pulsar/pull/5419#issuecomment-547578669 run java8 tests This is an automated

[pulsar] branch master updated (6df7cec -> 2983175)

2019-10-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6df7cec Python API: fix reader_listener option (#5487) add 2983175 [Issue 5415][docker build]Updating docker

[GitHub] [pulsar] jerrypeng closed pull request #5489: fix: bug in delayed messaging which prevented some messages from getting delivered

2019-10-29 Thread GitBox
jerrypeng closed pull request #5489: fix: bug in delayed messaging which prevented some messages from getting delivered URL: https://github.com/apache/pulsar/pull/5489 This is an automated message from the Apache Git

[GitHub] [pulsar] jerrypeng commented on issue #5489: fix: bug in delayed messaging which prevented some messages from getting delivered

2019-10-29 Thread GitBox
jerrypeng commented on issue #5489: fix: bug in delayed messaging which prevented some messages from getting delivered URL: https://github.com/apache/pulsar/pull/5489#issuecomment-547541983 withdrawing in favor of https://github.com/apache/pulsar/pull/5499

[GitHub] [pulsar] merlimat commented on issue #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays

2019-10-29 Thread GitBox
merlimat commented on issue #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays URL: https://github.com/apache/pulsar/pull/5499#issuecomment-547531373 This issue apparently was introduced in #5391

[GitHub] [pulsar] merlimat opened a new pull request #5500: Return after triggering callback with empty result

2019-10-29 Thread GitBox
merlimat opened a new pull request #5500: Return after triggering callback with empty result URL: https://github.com/apache/pulsar/pull/5500 ### Motivation While this doesn't appear to affect the correctness, we should just return empty after we trigger the callback.

[GitHub] [pulsar] merlimat commented on issue #5420: [Issue 5415][docker build]Updating docker build for pulsar-standalone to use main dashboard sou…

2019-10-29 Thread GitBox
merlimat commented on issue #5420: [Issue 5415][docker build]Updating docker build for pulsar-standalone to use main dashboard sou… URL: https://github.com/apache/pulsar/pull/5420#issuecomment-547524726 run java8 tests This

[GitHub] [pulsar] merlimat opened a new pull request #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays

2019-10-29 Thread GitBox
merlimat opened a new pull request #5499: Fixed dispatcher skipping delivery of a batch during concurrent replays URL: https://github.com/apache/pulsar/pull/5499 ### Motivation There is a race condition when replaying messages on the `PersistentDispatcherMultipleConsumers`. This is

[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5494: [WIP][Issue 5425][docs-website] Add coding guide for Apache Pulsar contributing guide

2019-10-29 Thread GitBox
Jennifer88huang edited a comment on issue #5494: [WIP][Issue 5425][docs-website] Add coding guide for Apache Pulsar contributing guide URL: https://github.com/apache/pulsar/pull/5494#issuecomment-547495725 Things to be confirmed: 1. In `Configuration` section: if users want to add docs

[GitHub] [pulsar] Jennifer88huang commented on issue #5494: [WIP][Issue 5425][docs-website] Add coding guide for Apache Pulsar contributing guide

2019-10-29 Thread GitBox
Jennifer88huang commented on issue #5494: [WIP][Issue 5425][docs-website] Add coding guide for Apache Pulsar contributing guide URL: https://github.com/apache/pulsar/pull/5494#issuecomment-547495725 Things to be discussed: 1. In `Configuration` section: if users want to add docs related

[GitHub] [pulsar] merlimat commented on issue #5410: Fix broker function token authentication link

2019-10-29 Thread GitBox
merlimat commented on issue #5410: Fix broker function token authentication link URL: https://github.com/apache/pulsar/pull/5410#issuecomment-547491123 run java8 tests run integration tests This is an automated message

[GitHub] [pulsar] merlimat opened a new pull request #5498: Efficiency improvements for delay delivery tracker

2019-10-29 Thread GitBox
merlimat opened a new pull request #5498: Efficiency improvements for delay delivery tracker URL: https://github.com/apache/pulsar/pull/5498 ### Motivation Improved the delayed messages tracker to avoid scheduling the timer more frequently than intended. Since we group

[GitHub] [pulsar] Jennifer88huang commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies

2019-10-29 Thread GitBox
Jennifer88huang commented on issue #5482: [Issue 5309][docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/pull/5482#issuecomment-547487570 run java8 tests This is an automated message from

[GitHub] [pulsar] PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces

2019-10-29 Thread GitBox
PierreZ commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-547480329 Thanks @jiazhai, where do you think I should put the implementation? I am hesitating between: * PulsarAuthorizationProvider *

[GitHub] [pulsar] merlimat commented on issue #5489: fix: bug in delayed messaging which prevented some messages from getting delivered

2019-10-29 Thread GitBox
merlimat commented on issue #5489: fix: bug in delayed messaging which prevented some messages from getting delivered URL: https://github.com/apache/pulsar/pull/5489#issuecomment-547479494 I think there's a much simpler fix to this issue. The root cause is we're getting out the messages

[GitHub] [pulsar] candlerb commented on issue #5488: Python API: Add test case for create_reader(is_read_compacted)

2019-10-29 Thread GitBox
candlerb commented on issue #5488: Python API: Add test case for create_reader(is_read_compacted) URL: https://github.com/apache/pulsar/pull/5488#issuecomment-547478080 ``` == ERROR: test_negative_acks

[GitHub] [pulsar] kevenYLi commented on issue #5497: fix misspelling and adjust code style

2019-10-29 Thread GitBox
kevenYLi commented on issue #5497: fix misspelling and adjust code style URL: https://github.com/apache/pulsar/pull/5497#issuecomment-547472219 run integration tests run cpp tests run java8 tests This is an automated

[GitHub] [pulsar] kevenYLi opened a new pull request #5497: fix misspelling and adjust code style

2019-10-29 Thread GitBox
kevenYLi opened a new pull request #5497: fix misspelling and adjust code style URL: https://github.com/apache/pulsar/pull/5497 ### Motivation - make the code easier for reading - fix misspelling ### Modifications - remove redundant keywords in interface, like

[GitHub] [pulsar] sijie merged pull request #5487: [Issue 5484] Python API: fix reader_listener option

2019-10-29 Thread GitBox
sijie merged pull request #5487: [Issue 5484] Python API: fix reader_listener option URL: https://github.com/apache/pulsar/pull/5487 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie commented on issue #5393: Support service mesh for pulsar

2019-10-29 Thread GitBox
sijie commented on issue #5393: Support service mesh for pulsar URL: https://github.com/apache/pulsar/issues/5393#issuecomment-547464843 @xujianhai666 I see. so it seems like a feature request adding Pulsar filter in envoy. The work seems to have be done at Envoy side though.

[GitHub] [pulsar] sijie closed issue #5484: Python API: create_reader() argument `reader_listener` causes exception

2019-10-29 Thread GitBox
sijie closed issue #5484: Python API: create_reader() argument `reader_listener` causes exception URL: https://github.com/apache/pulsar/issues/5484 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated (080d31e -> 6df7cec)

2019-10-29 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 080d31e Update getting-started-standalone.md (#5490) add 6df7cec Python API: fix reader_listener option

[GitHub] [pulsar] jiazhai commented on issue #5495: Add a reverse mapping from role to namespaces

2019-10-29 Thread GitBox
jiazhai commented on issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495#issuecomment-547464061 Thanks @PierreZ . This would also be useful for admin and other protocol implementations.

[GitHub] [pulsar] jm7647 commented on issue #5454: mysql JDBC Sink - consumer error

2019-10-29 Thread GitBox
jm7647 commented on issue #5454: mysql JDBC Sink - consumer error URL: https://github.com/apache/pulsar/issues/5454#issuecomment-547456603 **Tried to do localrun. Below is result from main broker log.** _(Notice "Closing consumer: 0" - next "Closing consumer: 1" - it will continue in a

[GitHub] [pulsar] tuteng opened a new pull request #5496: [Doc]Fix document link error

2019-10-29 Thread GitBox
tuteng opened a new pull request #5496: [Doc]Fix document link error URL: https://github.com/apache/pulsar/pull/5496 ### Motivation There are currently 404 links to some documents. Fix these problems. ### Modifications Use the correct file name

[GitHub] [pulsar] xujianhai666 commented on issue #5393: Support service mesh for pulsar

2019-10-29 Thread GitBox
xujianhai666 commented on issue #5393: Support service mesh for pulsar URL: https://github.com/apache/pulsar/issues/5393#issuecomment-547448353 > @xujianhai666 Can you provide more information? @sijie same work for kafka: https://github.com/envoyproxy/envoy/pull/8188/files. This is

[GitHub] [pulsar] PierreZ opened a new issue #5495: Add a reverse mapping from role to namespaces

2019-10-29 Thread GitBox
PierreZ opened a new issue #5495: Add a reverse mapping from role to namespaces URL: https://github.com/apache/pulsar/issues/5495 **Is your feature request related to a problem? Please describe.** I'm working on KoP, and I'm currently implementing security on it. I'm currently

[pulsar] branch master updated (f538c52 -> 080d31e)

2019-10-29 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f538c52 [docs] Update some links on Pulsar website (#5492) add 080d31e Update getting-started-standalone.md

[GitHub] [pulsar] sijie merged pull request #5490: [docs] Fix link issues in getting-started-standalone.md

2019-10-29 Thread GitBox
sijie merged pull request #5490: [docs] Fix link issues in getting-started-standalone.md URL: https://github.com/apache/pulsar/pull/5490 This is an automated message from the Apache Git Service. To respond to the message,

[pulsar] branch master updated (74ec920 -> f538c52)

2019-10-29 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 74ec920 move general schema hash to common module (#5466) add f538c52 [docs] Update some links on Pulsar website

[GitHub] [pulsar] wolfstudy merged pull request #5492: [docs] Update some links on Pulsar website

2019-10-29 Thread GitBox
wolfstudy merged pull request #5492: [docs] Update some links on Pulsar website URL: https://github.com/apache/pulsar/pull/5492 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] jiazhai commented on issue #5425: website page `coding_guide` return 404

2019-10-29 Thread GitBox
jiazhai commented on issue #5425: website page `coding_guide` return 404 URL: https://github.com/apache/pulsar/issues/5425#issuecomment-547413298 @gm7y8, since it's some kind of urgent, @Jennifer88huang is handling this issue.

[GitHub] [pulsar] jiazhai commented on issue #3414: pulsar-admin - HTTP 401 Authentication required / 500 Internal Server Error

2019-10-29 Thread GitBox
jiazhai commented on issue #3414: pulsar-admin - HTTP 401 Authentication required / 500 Internal Server Error URL: https://github.com/apache/pulsar/issues/3414#issuecomment-547390253 close for dup This is an automated

[GitHub] [pulsar] jiazhai closed issue #3414: pulsar-admin - HTTP 401 Authentication required / 500 Internal Server Error

2019-10-29 Thread GitBox
jiazhai closed issue #3414: pulsar-admin - HTTP 401 Authentication required / 500 Internal Server Error URL: https://github.com/apache/pulsar/issues/3414 This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] Jennifer88huang opened a new pull request #5494: [Issue 5425][docs-website] Add coding guide for Apache Pulsar contributing guide

2019-10-29 Thread GitBox
Jennifer88huang opened a new pull request #5494: [Issue 5425][docs-website] Add coding guide for Apache Pulsar contributing guide URL: https://github.com/apache/pulsar/pull/5494 Fixes #5425 ### Motivation The link navigates to coding guide does not work in Contributing guide.

[GitHub] [pulsar] wolfstudy commented on issue #5232: Upgrade dependencies for security fixes

2019-10-29 Thread GitBox
wolfstudy commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-547379842 > org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterInReplicationClusterListChange run java8 tests

[GitHub] [pulsar] wolfstudy commented on issue #5378: Trim messages which less than mark delete position for message redelivery

2019-10-29 Thread GitBox
wolfstudy commented on issue #5378: Trim messages which less than mark delete position for message redelivery URL: https://github.com/apache/pulsar/pull/5378#issuecomment-547379483 > org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterInReplicationClusterListChange

[GitHub] [pulsar] codelipenghui commented on issue #5388: [PIP-47] Introduce sticky consumer

2019-10-29 Thread GitBox
codelipenghui commented on issue #5388: [PIP-47] Introduce sticky consumer URL: https://github.com/apache/pulsar/pull/5388#issuecomment-547365563 run cpp tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] codelipenghui commented on issue #5388: [PIP-47] Introduce sticky consumer

2019-10-29 Thread GitBox
codelipenghui commented on issue #5388: [PIP-47] Introduce sticky consumer URL: https://github.com/apache/pulsar/pull/5388#issuecomment-547365506 run java8 tests run integration tests This is an automated message from the

[GitHub] [pulsar] codelipenghui commented on issue #5421: [Broker] Fix log message bug

2019-10-29 Thread GitBox
codelipenghui commented on issue #5421: [Broker] Fix log message bug URL: https://github.com/apache/pulsar/pull/5421#issuecomment-547365146 run integration tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] codelipenghui commented on issue #5423: [Test] Migrate deprecated Matchers to ArgumentMatchers

2019-10-29 Thread GitBox
codelipenghui commented on issue #5423: [Test] Migrate deprecated Matchers to ArgumentMatchers URL: https://github.com/apache/pulsar/pull/5423#issuecomment-547364999 run java8 tests This is an automated message from the

  1   2   >