[GitHub] [pulsar-helm-chart] mfuxi commented on pull request #360: add ingressClassName
mfuxi commented on PR #360: URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1534126328 Seems like a connectivity issue with the kind cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #360: add ingressClassName
michaeljmarshall commented on PR #360: URL: https://github.com/apache/pulsar-helm-chart/pull/360#issuecomment-1534099041 We'll need to figure out why CI is failing before we can merge this. The issue seems unrelated to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #358: Please add the missing 3.0.0 release artifact into releases page
michaeljmarshall commented on issue #358: URL: https://github.com/apache/pulsar-helm-chart/issues/358#issuecomment-1534092725 The helm chart index is hosted here: https://pulsar.apache.org/charts/index.yaml. The index points to https://downloads.apache.org/pulsar/helm-chart/3.0.0/pulsar-3.0.0.tgz for the 3.0.0 release, and the pattern should continue to be as you suggested. Does that solve your request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #360: add ingressClassName
michaeljmarshall commented on code in PR #360:
URL: https://github.com/apache/pulsar-helm-chart/pull/360#discussion_r1184536254
##
charts/pulsar/templates/dashboard-ingress.yaml:
##
@@ -36,6 +36,9 @@ metadata:
name: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
namespace: {{ template "pulsar.namespace" . }}
spec:
+ {{- with .Values.dashboard.ingress.ingressClassName }}
Review Comment:
I haven't used
[with](https://helm.sh/docs/chart_template_guide/control_structures/#modifying-scope-using-with)
before. That is very handy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #20030: [fix][broker] Fix the reason label of authentication metrics
gaoran10 commented on PR #20030: URL: https://github.com/apache/pulsar/pull/20030#issuecomment-1534084955 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #20030: [fix][broker] Fix the reason label of authentication metrics
gaoran10 commented on PR #20030: URL: https://github.com/apache/pulsar/pull/20030#issuecomment-1534083907 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] gaoran10 closed pull request #20030: [fix][broker] Fix the reason label of authentication metrics
gaoran10 closed pull request #20030: [fix][broker] Fix the reason label of authentication metrics URL: https://github.com/apache/pulsar/pull/20030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] liangyepianzhou opened a new pull request, #553: Release blog 2.10.4
liangyepianzhou opened a new pull request, #553: URL: https://github.com/apache/pulsar-site/pull/553 [Google doc](https://docs.google.com/document/d/1RgmfoC6lbQjm7wrX_neKr3lw_-5ICHVW5UM1LKmy5Yk/edit#) ### Documentation - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Sherlock113 commented on pull request #552: [BLOG]Update the 3.0 release blog post
Sherlock113 commented on PR #552: URL: https://github.com/apache/pulsar-site/pull/552#issuecomment-1534040203 @Anonymitaet @tisonkun PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch 2.10.4-release-note created (now 5208a8bfab5)
This is an automated email from the ASF dual-hosted git repository. xiangying pushed a change to branch 2.10.4-release-note in repository https://gitbox.apache.org/repos/asf/pulsar-site.git at 5208a8bfab5 release blog This branch includes the following new commits: new 5208a8bfab5 release blog The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[pulsar-site] 01/01: release blog
This is an automated email from the ASF dual-hosted git repository.
xiangying pushed a commit to branch 2.10.4-release-note
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
commit 5208a8bfab501e9f282bcbe10db5fdbd1f15ca3c
Author: xiangying <1984997...@qq.com>
AuthorDate: Thu May 4 11:04:49 2023 +0800
release blog
---
blog/2023-04-19-Apache-Pulsar-2-10-4.md | 59 +
data/release-pulsar.js | 2 +-
2 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/blog/2023-04-19-Apache-Pulsar-2-10-4.md
b/blog/2023-04-19-Apache-Pulsar-2-10-4.md
new file mode 100644
index 000..05978861af8
--- /dev/null
+++ b/blog/2023-04-19-Apache-Pulsar-2-10-4.md
@@ -0,0 +1,59 @@
+---
+title: "What’s New in Apache Pulsar 2.10.4"
+date: 2023-04-19
+author: "liangyepianzhou, Anonymitaet, momo-jun"
+---
+
+The Apache Pulsar community releases version 2.10.4! 37 contributors provided
improvements and bug fixes that delivered 12 commits. Thanks for all your
contributions.
+
+This blog walks through the most noteworthy changes. For the complete list,
including all feature enhancements and bug fixes, check out the [Pulsar 2.10.4
Release
Notes](https://pulsar.apache.org/release-notes/versioned/pulsar-2.10.4/).
+
+
+
+### Improve performance in Key_Shared subscriptions
([PR-19167](https://github.com/apache/pulsar/pull/19167))
+
+ Issue
+In earlier versions, Key_Shared subscriptions suffered from performance issues
due to the lack of a ref count for sticky hash.
+
+ Resolution
+A significant performance improvement has been made to the Key_Shared
subscriptions by adding a ref count for sticky hash. This optimization reduces
the time required to check if messages contain the hash from a given sticky
hash set, resulting in improved performance and efficiency.
+
+### AbstractBatchedMetadataStore - Use AlreadyClosedException instead of
IllegalStateException ([PR-19284](https://github.com/apache/pulsar/pull/19284))
+
+ Issue
+In earlier versions, when the broker was shutting down, the
`AbstractBatchedMetadataStore` would complete pending operations with a generic
`IllegalStateException`. However, code dependent on the `MetadataStore` usually
expected instances of `MetadataStoreException` and might not react properly to
this error.
+
+ Resolution
+This PR improves the error handling during broker shutdown by completing
pending operations with an `AlreadyClosedException` instead of
`IllegalStateException`. This ensures that the dependent code responds more
appropriately to the error, even if the broker is shutting down.
+
+### Fix open cursor with null-initialPosition, resulting in the earliest
position ([PR-18416](https://github.com/apache/pulsar/pull/18416))
+
+ Issue
+In earlier versions, called `ledger.openCursor("xxx", null)` with a null
`initialPosition` parameter would result in the cursor being set to the
earliest position, causing unexpected behavior. The root cause of this issue
was due to incorrect handling of the `initialPosition` in
`ManagedLedgerImpl.java`.
+
+
+ Resolution
+This PR fixes the issue by ensuring that the correct initial position is used
when opening a cursor with a null `initialPosition`. The code now sets the
cursor to the latest position, as expected.
+
+
+### Add isActive in ManagedCursorImpl
([PR-19341](https://github.com/apache/pulsar/pull/19341))
+
+ Issue
+In previous versions, when there were many concurrent subscriptions in a
topic, broker performance would degrade due to many io-threads waiting for the
lock, synchronized (activeCursors) while calling checkBackloggedCursors.
+
+ Resolution
+This PR adds an `isActive` variable in `ManagedCursorImpl` to minimize the
access to `activeCursors` in `ManagedLedgerImpl,` which reduces the contention
on the lock and improves the broker performance with many concurrent
subscriptions.
+
+### Support deleting partitioned topics with the keyword -partition-
([PR-19230](https://github.com/apache/pulsar/pull/19230))
+
+ Issue
+In earlier versions, although users could create partitioned topics using the
client when partitioned type auto-creation was enabled, there was no support
for deleting these partitioned topics.
+
+ Resolution
+This PR adds support for deleting partitioned topics using the keyword
`-partition-`, making it easier for users to manage their partitioned topics.
+
+# What’s Next?
+
+If you are interested in learning more about Pulsar 2.10.4, you can
[download](https://pulsar.apache.org/download/) and try it out now!
+
+For more information about the Apache Pulsar project and current progress,
visit the Pulsar website and follow the project.
diff --git a/data/release-pulsar.js b/data/release-pulsar.js
index 5994c54e580..ef93341d3ca 100644
--- a/data/release-pulsar.js
+++ b/data/release-pulsar.js
@@ -15,7 +15,7 @@ module.exports = [
"publishedAt": "2023-04-18T01:53:34Z",
"vtag":
[GitHub] [pulsar-site] Sherlock113 opened a new pull request, #552: Update the 3.0 release blog post
Sherlock113 opened a new pull request, #552: URL: https://github.com/apache/pulsar-site/pull/552 ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` Added a cover image and updated some wording for the 3.0 release blog post. Previews:   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #20210: [fix][broker] Fix Return value of getPartitionedStats doesn't contain subscription type
Technoboy- closed pull request #20210: [fix][broker] Fix Return value of getPartitionedStats doesn't contain subscription type URL: https://github.com/apache/pulsar/pull/20210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #20179: [fix][broker] Fix recentlyJoinedConsumers to address the out-of-order issue
poorbarcode commented on PR #20179:
URL: https://github.com/apache/pulsar/pull/20179#issuecomment-1534014762
@equanz
> Currently, the position is the readPosition. The readPosition is updated
when the read is completed, even if messages are not dispatched. In this PR, I
will change the position to the last sent position.
Scenario-2
| time | `process: add consumer` | `process: delivery messages to client` |
| --- | --- | --- |
| 1 | read position is `1:6` |
| 2 | Add new consumer into the selector |
| 3 | | Read entries `1:6 ~ 1:10` complete |
| 4 | | Set read position `1:11` |
| 5 | Add the new consumer into recently joined consumers |
| 6 | (Highlight)The max read-position of the new consumer
is `1:11`, but the exact correct value is `1:6` |
| 7 | | Choose consumer by the selector |
| 8 | | Delivery entries `1:6 ~ 1:10` to all consumers(includes old
consumers and the new consumer) |
This scenario is what you are saying, right?[Q-1]
If yes[Q-1], we have two solutions to fix it:
- Use `last send position` instead of `last read position`(what this PR does)
- Find a way to make the lock works for Scenario-1[scenario-1],
and add a lock for `set read position` for Scenario-2.
I also think solution-1 is better, but declaring the data structure of
`lastSentPosition` as a Map is an improvement, right[Q-2]?
If yes[Q-2], could you split this PR into two PR: one typed
"fix" and another one typed "improve"? And I think the PR which typed "improve"
should be submitted with a PIP because the mechanism of `Key_Shared` dispatcher
is so complicated now we need PIPs to trace the changes of it.
[scenario-1]:
https://github.com/apache/pulsar/pull/20179#pullrequestreview-1400545109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #20219: [improve][broker] Use bulk operation instead of iteration
AnonHxy commented on PR #20219: URL: https://github.com/apache/pulsar/pull/20219#issuecomment-1534005558 The `addAll()` will also has a iteration operation, I wonder will `addAll` will be more efficient than iteration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #18272: [Doc] Tracking issue for contribution guide
github-actions[bot] commented on issue #18272: URL: https://github.com/apache/pulsar/issues/18272#issuecomment-1533976369 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19316: [Bug] The data returned by the "/non-persistent/{tenant}/{namespace}" interface does not seem to be correct
github-actions[bot] commented on issue #19316: URL: https://github.com/apache/pulsar/issues/19316#issuecomment-1533975757 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19487: [fix][admin] Include non persistent partitioned topics while retreiving topics list (#19316)
github-actions[bot] commented on PR #19487: URL: https://github.com/apache/pulsar/pull/19487#issuecomment-1533975532 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19981: [Bug] Go Pulsar functions recieves message from only one topic even when provided multiple input topics
github-actions[bot] commented on issue #19981: URL: https://github.com/apache/pulsar/issues/19981#issuecomment-1533975031 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19998: [fix][broker] Fix incorrect remove bundles in bundleData when updateBundleData
github-actions[bot] commented on PR #19998: URL: https://github.com/apache/pulsar/pull/19998#issuecomment-1533974971 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #19997: should support IPv4/IPv6 dualstack
github-actions[bot] commented on issue #19997: URL: https://github.com/apache/pulsar/issues/19997#issuecomment-1533974998 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] jiangpengcheng added a comment to the discussion: "cannot be cast to class" in a pulsar function producing un new message
GitHub user jiangpengcheng added a comment to the discussion: "cannot be cast to class" in a pulsar function producing un new message @raymondBourges seems like you added the `pulsar-client` dependency in your function, you can try with `Schema.Avro(Personne.class)` instead of the `AvroSchema.of(Personne.class)` and remove the `pulsar-client` dependency GitHub link: https://github.com/apache/pulsar/discussions/19962#discussioncomment-5798140 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar-client-node] shibd commented on pull request #322: [feat]: Support client.getPartitionsForTopic (#320)
shibd commented on PR #322: URL: https://github.com/apache/pulsar-client-node/pull/322#issuecomment-1533964239 @XXXMrG Thanks for your contribution. Let's wait for your `TODO` list to be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-client-cpp] shibd commented on pull request #262: [feat] Support end-to-end encryption in C Reader API
shibd commented on PR #262: URL: https://github.com/apache/pulsar-client-cpp/pull/262#issuecomment-1533961858 Nice work! Can you fix the code format and add a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages
rdhabalia commented on PR #19944: URL: https://github.com/apache/pulsar/pull/19944#issuecomment-1533933252 @codelipenghui I have created PIP: https://github.com/apache/pulsar/issues/20221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] rdhabalia opened a new issue, #20221: PIP-266: Support multi-topic messageId deserialization to ack messages
rdhabalia opened a new issue, #20221: URL: https://github.com/apache/pulsar/issues/20221 # Motivation Pulsar api provides [MessageId](https://github.com/apache/pulsar/blob/master/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/MessageId.java) interface which is generally used by producer and consumer applications to manage topic offset. Sometimes, these applications would like to serialize and deserialize messageIds specifically consumer app which would like to persist messageId and ack with those messageIds by deserializing them. However, right now Pulsar doesn't support correct deserialization of multi-topic or partitioned-topic because of that 1acknowledge` API call fails for those topics with below error ``` org.apache.pulsar.client.api.PulsarClientException$NotAllowedException: Only TopicMessageId is allowed to acknowledge for a multi-topics consumer, while messageId is org.apache.pulsar.client.impl.BatchMessageIdImpl at org.apache.pulsar.client.api.PulsarClientException.unwrap(PulsarClientException.java:1083) at org.apache.pulsar.client.impl.ConsumerBase.acknowledge(ConsumerBase.java:418) at org.apache.pulsar.client.api.MultiTopicsConsumerTest.testMultiTopicAckWithByteMessageId(MultiTopicsConsumerTest.java:409) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ``` [MessageIdImpl](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java#L89) stores id metadata into `MessageIdData` which is doesn't contain context about topic name to find out which topic belongs to this MessageID. Thefore, we need to add topic-name into `MessageIdData` and allow multi-topic/partitioned topic to deserialize message correctly so, API like `acknowledge` can perform as expected. This issue is already implemented in this PR: https://github.com/apache/pulsar/pull/19944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet merged PR #544: URL: https://github.com/apache/pulsar-site/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet commented on code in PR #544: URL: https://github.com/apache/pulsar-site/pull/544#discussion_r1184405918 ## docs/functions-runtime-process.md: ## @@ -22,3 +22,37 @@ functionRuntimeFactoryConfigs: ``` For more details, see [code](https://github.com/apache/pulsar/blob/master/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/process/ProcessRuntimeFactoryConfig.java). + +### Set runtime parameter with configuration file + +Pulsar Functions now supports setting runtime parameters using a configuration file **in Python**. + +**Example** + +You can start a Python runtime using the configuration file `config.ini` with the following command. + +```shell +pulsar-admin functions localrun \ + --py /path/to/python_instance.py \ + --config-file /path/to/config.ini \ + --classname MyFunction \ + --logging_leve debug \ Review Comment: Oops! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #533: [fix][doc] MesssageListener inject link
Anonymitaet commented on code in PR #533:
URL: https://github.com/apache/pulsar-site/pull/533#discussion_r1184403671
##
docs/concepts-clients.md:
##
@@ -70,7 +70,7 @@ Messages are received from
[brokers](reference-terminology.md#broker) either syn
### Listener
-Client libraries provide listener implementation for consumers. For example,
the [Java client](client-libraries-java.md) provides a {@inject:
javadoc:MesssageListener:/client/org/apache/pulsar/client/api/MessageListener}
interface. In this interface, the `received` method is called whenever a new
message is received.
+Client libraries provide listener implementation for consumers. For example,
the [Java client](client-libraries-java.md) provides a
[MesssageListener](/api/client/org/apache/pulsar/client/api/MessageListener)
interface. In this interface, the `received` method is called whenever a new
message is received.
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [pulsar] GerMoranOverstock commented on pull request #19432: [improve] Allow to build and push multi-arch Docker images
GerMoranOverstock commented on PR #19432: URL: https://github.com/apache/pulsar/pull/19432#issuecomment-1533791031 I see this was merged, will arm64 images be generated now going forward for 3.0+. I can see images in dockerhub, but didn't see this issue referenced in the release notes?. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] hpvd commented on issue #17805: Pulsar needs opentelemetry agent plugin for tracing
hpvd commented on issue #17805: URL: https://github.com/apache/pulsar/issues/17805#issuecomment-1533539447 this seems to be related: > OpenTracing was recently merged with OpenCensus into the OpenTelemetry framework. https://github.com/apache/pulsar/issues/3727#issuecomment-557639560 > For people who are looking for open tracing integration, we have open-sourced our open-tracking interceptor for Pulsar client. > https://github.com/streamnative/pulsar-tracing https://github.com/apache/pulsar/issues/3727#issuecomment-634282445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[pulsar-site] branch main updated: [fix][misc] Update default version to 3.0.x
This is an automated email from the ASF dual-hosted git repository.
tison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 373cefa1cdd [fix][misc] Update default version to 3.0.x
373cefa1cdd is described below
commit 373cefa1cddce8d9bf298aff5484b73e16801491
Author: tison
AuthorDate: Thu May 4 02:24:26 2023 +0800
[fix][misc] Update default version to 3.0.x
BUILD_ALL_VERSION=1
This closes https://github.com/apache/pulsar/issues/20220.
---
static/.htaccess | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/static/.htaccess b/static/.htaccess
index 272ee541085..7cdcea35129 100755
--- a/static/.htaccess
+++ b/static/.htaccess
@@ -16,7 +16,7 @@ RewriteCond expr "%{REQUEST_URI} !~ m|^/docs/\d+\.\d+\.\d+|"
RewriteCond expr "%{REQUEST_URI} !~ m|^/docs/\d+\.\d+\.\d+/.*|"
RewriteCond expr "%{REQUEST_URI} !~ m|^/docs/\d+\.\d+\.x|"
RewriteCond expr "%{REQUEST_URI} !~ m|^/docs/\d+\.\d+\.x/.*|"
-RewriteRule "^docs/(.*)$" "/docs/2.11.x/$1" [R=301,DPI,L]
+RewriteRule "^docs/(.*)$" "/docs/3.0.x/$1" [R=301,DPI,L]
RewriteRule "^docs/(.+/)?develop-binary-protocol/?$"
"/docs/$1developing-binary-protocol" [R=301,DPI,L]
RewriteRule "^docs/(.+/)?administration-dashboard/?$"
"/docs/$1administration-pulsar-manager" [R=301,DPI,L]
[GitHub] [pulsar] tisonkun closed issue #20220: [Doc] The latest document should point to 3.x
tisonkun closed issue #20220: [Doc] The latest document should point to 3.x URL: https://github.com/apache/pulsar/issues/20220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on issue #20105: [Bug] ZKMetadataStore runs into deadlock
nodece commented on issue #20105: URL: https://github.com/apache/pulsar/issues/20105#issuecomment-1533492051 Closed by #20122. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece closed issue #20105: [Bug] ZKMetadataStore runs into deadlock
nodece closed issue #20105: [Bug] ZKMetadataStore runs into deadlock URL: https://github.com/apache/pulsar/issues/20105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece opened a new issue, #20220: [Doc] The latest document should point to 3.x
nodece opened a new issue, #20220: URL: https://github.com/apache/pulsar/issues/20220 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? 1. Open https://pulsar.apache.org/ 2. Click [QUICKSTART](https://pulsar.apache.org/docs) button ### What is your suggestion? The Pulsar 3.0.0 has been released, so the document should point to 3.x. ### Any reference? _No response_ ### Are you willing to submit a PR? - [ ] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #16171: [fix][client] Fix duplicate messages caused by seek
nodece commented on PR #16171: URL: https://github.com/apache/pulsar/pull/16171#issuecomment-1533379391 > Hey @nodece, why this PR was closed? Currently, there is no reviewer pushing this PR, so I decided to close this PR. If anyone is willing to push, I will reopen. > Does it it mean that this PR and #15568 will not be delivered to the maistream ? Right! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] liqiangcc opened a new pull request, #20219: [improve][broker] Use bulk operation instead of iteration
liqiangcc opened a new pull request, #20219: URL: https://github.com/apache/pulsar/pull/20219 ### Motivation Use bulk operation instead of iteration ### Modifications Use putAll,addAll method instead of forEach ### Verifying this change - [ ] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] liqiangcc commented on pull request #20217: [refactor][test] Replace Anonymous type with lambda.
liqiangcc commented on PR #20217: URL: https://github.com/apache/pulsar/pull/20217#issuecomment-1532933486 I suppose so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] clayburn commented on pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
clayburn commented on PR #20218: URL: https://github.com/apache/pulsar/pull/20218#issuecomment-1532891666 > Thanks for taking care of this @clayburn! No problem @tisonkun! Very fast approval, before I could even add a couple of explanatory comments . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] clayburn commented on a diff in pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
clayburn commented on code in PR #20218: URL: https://github.com/apache/pulsar/pull/20218#discussion_r1183582313 ## .github/workflows/pulsar-ci.yaml: ## @@ -721,11 +706,6 @@ jobs: - name: Tune Runner VM uses: ./.github/actions/tune-runner-vm - - name: Configure Gradle Enterprise Review Comment: I don't believe this was needed. This job does not seem to run a Maven build. ## .github/workflows/pulsar-ci.yaml: ## @@ -1208,11 +1177,6 @@ jobs: - name: Tune Runner VM uses: ./.github/actions/tune-runner-vm - - name: Configure Gradle Enterprise Review Comment: I don't believe this was needed. This job does not seem to run a Maven build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
tisonkun commented on PR #20218: URL: https://github.com/apache/pulsar/pull/20218#issuecomment-1532886641 Thanks for taking care of this @clayburn! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] clayburn opened a new pull request, #20218: [improve][ci] Replace handmade action to configure Gradle Enterprise
clayburn opened a new pull request, #20218: URL: https://github.com/apache/pulsar/pull/20218 ### Motivation After the PR https://github.com/apache/pulsar/pull/20187, the custom action at `.github/actions/gradle-enterprise/action.yml` simply sets the `GRADLE_ENTERPRISE_ACCESS_KEY` environment variable. Since this is the only step performed by this action, it makes sense to remove it to simplify workflows. This was mentioned in the review for https://github.com/apache/pulsar/pull/20187: https://github.com/apache/pulsar/pull/20187#pullrequestreview-1406899559 ### Modifications - Remove the custom `gradle-enterprise` action - Use the built in `env` configuration to set the `GRADLE_ENTERPRISE_ACCESS_KEY` where needed ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20217: [refactor][test] Replace Anonymous type with lambda.
tisonkun commented on PR #20217: URL: https://github.com/apache/pulsar/pull/20217#issuecomment-1532885612 In another direction, you can make any effective improvement, bug fix or new feature, apply your style on the fly when modifying related code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20217: [refactor][test] Replace Anonymous type with lambda.
tisonkun commented on PR #20217: URL: https://github.com/apache/pulsar/pull/20217#issuecomment-1532885081 Closing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] tisonkun closed pull request #20217: [refactor][test] Replace Anonymous type with lambda.
tisonkun closed pull request #20217: [refactor][test] Replace Anonymous type with lambda. URL: https://github.com/apache/pulsar/pull/20217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] liqiangcc opened a new pull request, #20217: [refactor][test] Replace Anonymous type with lambda.
liqiangcc opened a new pull request, #20217: URL: https://github.com/apache/pulsar/pull/20217 ### Motivation Replace Anonymous type with lambda. ### Modifications Replace Anonymous type with lambda. ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` - [ ] `doc-required` - [x] `doc-not-needed` - [ ] `doc-complete` ### Matching PR in forked repository PR in forked repository: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] AlvaroStream added a comment to the discussion: JVM metrics
GitHub user AlvaroStream added a comment to the discussion: JVM metrics Hello, that is not documented there maybe we can open an issue to include them. But you can see an example [here](https://github.com/apache/pulsar/blob/a22700df665a9ea0a8db98334b6d4337e5e490f3/pulsar-broker/src/test/resources/prometheus_metrics_sample.txt) and you can see the information for [bookeeper](https://github.com/apache/pulsar/blob/a22700df665a9ea0a8db98334b6d4337e5e490f3/grafana/dashboards/bookkeeper.json) of [zookeeper](https://github.com/apache/pulsar/blob/a22700df665a9ea0a8db98334b6d4337e5e490f3/grafana/dashboards/zookeeper.json#L8719) GitHub link: https://github.com/apache/pulsar/discussions/20215#discussioncomment-5789859 This is an automatically sent email for commits@pulsar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@pulsar.apache.org
[GitHub] [pulsar] tisonkun commented on issue #19877: [Doc] Add API doc for the C# client
tisonkun commented on issue #19877: URL: https://github.com/apache/pulsar/issues/19877#issuecomment-1532494933 Blocked by upstream issue https://github.com/dotnet/docfx/issues/8702. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
