[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-13 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1069231457 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar-site] Anonymitaet commented on pull request #378: [doc][improve] add instructions for REST API JSON files and fix 404 issues

2023-01-13 Thread GitBox
Anonymitaet commented on PR #378: URL: https://github.com/apache/pulsar-site/pull/378#issuecomment-1381608703 > Can we add a description about the api standard? openapi, swagger, or others? I think this is helpful for api tester to import the api right. @yuweisung do you mean adding

[GitHub] [pulsar-client-cpp] shibd commented on pull request #170: [feature] Support set ServiceUrlProvider when create client.

2023-01-13 Thread GitBox
shibd commented on PR #170: URL: https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1381605478 > We only need to support passing a std::function. The initialize and close methods are redundant. Yes, you are right. The initialize and close methods are redundant.

[GitHub] [pulsar] nodece commented on pull request #19203: [improve][websocket] Add ping support

2023-01-13 Thread GitBox
nodece commented on PR #19203: URL: https://github.com/apache/pulsar/pull/19203#issuecomment-1381561730 Ping @poorbarcode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar-client-cpp] RobertIndie commented on a diff in pull request #169: [feat] Add producer interceptor

2023-01-13 Thread GitBox
RobertIndie commented on code in PR #169: URL: https://github.com/apache/pulsar-client-cpp/pull/169#discussion_r1069152267 ## include/pulsar/ProducerConfiguration.h: ## @@ -532,6 +533,10 @@ class PULSAR_PUBLIC ProducerConfiguration { */ ProducerAccessMode

[GitHub] [pulsar] horizonzy commented on pull request #19156: [fix][broker] Support zookeeper read-only config.

2023-01-13 Thread GitBox
horizonzy commented on PR #19156: URL: https://github.com/apache/pulsar/pull/19156#issuecomment-1381542937 This is part 1, introduce `zooKeeperAllowReadOnlyOperations`. It should cherry-pick to branch-2.9, branch-2.10, branch-2.11. After the cherry-pick works done, I will submit a new pr

[GitHub] [pulsar-client-cpp] izumo27 commented on pull request #126: [fix] Fix hostname verification

2023-01-13 Thread GitBox
izumo27 commented on PR #126: URL: https://github.com/apache/pulsar-client-cpp/pull/126#issuecomment-1381515071 I added tests for invalid broker using another standalone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-client-node] massakam opened a new pull request, #285: Fix an issue where the latest client does not work on Rocky Linux 8

2023-01-13 Thread GitBox
massakam opened a new pull request, #285: URL: https://github.com/apache/pulsar-client-node/pull/285 ### Motivation The latest version of pulsar-client does not work on Rocky Linux 8. ```sh $ head -n 2 /etc/os-release NAME="Rocky Linux" VERSION="8.7 (Green Obsidian)"

[GitHub] [pulsar] lhotari merged pull request #19220: [improve][test] Run cleanup methods even when failfast mode is enabled

2023-01-13 Thread GitBox
lhotari merged PR #19220: URL: https://github.com/apache/pulsar/pull/19220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] Technoboy- commented on a diff in pull request #383: Add 2.11.0 release note link

2023-01-13 Thread GitBox
Technoboy- commented on code in PR #383: URL: https://github.com/apache/pulsar-site/pull/383#discussion_r1069082042 ## data/release-pulsar.js: ## @@ -1,4 +1,14 @@ module.exports = [ +{ +"author": "liangyepianzhou", Review Comment: fixed -- This is an

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #383: Add 2.11.0 release note link

2023-01-13 Thread GitBox
Anonymitaet commented on code in PR #383: URL: https://github.com/apache/pulsar-site/pull/383#discussion_r1069081057 ## data/release-pulsar.js: ## @@ -1,4 +1,14 @@ module.exports = [ +{ +"author": "liangyepianzhou", Review Comment: ```suggestion

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #383: Add 2.11.0 release note link

2023-01-13 Thread GitBox
Anonymitaet commented on code in PR #383: URL: https://github.com/apache/pulsar-site/pull/383#discussion_r1069081057 ## data/release-pulsar.js: ## @@ -1,4 +1,14 @@ module.exports = [ +{ +"author": "liangyepianzhou", Review Comment: ```suggestion

[GitHub] [pulsar] nodece commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-13 Thread GitBox
nodece commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1069076913 ## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] nodece commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-13 Thread GitBox
nodece commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1069074358 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -172,6 +174,16 @@ protected static String getErrorMessage(Exception

[GitHub] [pulsar-client-cpp] RobertIndie closed issue #167: Flaky test: ClientTest.testCloseClient

2023-01-13 Thread GitBox
RobertIndie closed issue #167: Flaky test: ClientTest.testCloseClient URL: https://github.com/apache/pulsar-client-cpp/issues/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-client-cpp] RobertIndie merged pull request #168: Fix segfault caused by socket I/O on a closed io_service

2023-01-13 Thread GitBox
RobertIndie merged PR #168: URL: https://github.com/apache/pulsar-client-cpp/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari merged pull request #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

2023-01-13 Thread GitBox
lhotari merged PR #19219: URL: https://github.com/apache/pulsar/pull/19219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-13 Thread GitBox
poorbarcode commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1069047064 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java: ## @@ -161,6 +161,9 @@ public class

[GitHub] [pulsar] codecov-commenter commented on pull request #19225: [fix][ci] Fix CI issue where ubuntu apt repository azure.archive.ubuntu.com isn't available

2023-01-13 Thread GitBox
codecov-commenter commented on PR #19225: URL: https://github.com/apache/pulsar/pull/19225#issuecomment-1381460010 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19225?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-client-python] eolivelli commented on a diff in pull request #81: Add a version attribute

2023-01-12 Thread GitBox
eolivelli commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1069048322 ## pulsar/__about__.py: ## @@ -0,0 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [pulsar] tisonkun commented on issue #19196: [Doc] 2.10* docs provide incorrect command for `namespace set-backlog-quota`

2023-01-12 Thread GitBox
tisonkun commented on issue #19196: URL: https://github.com/apache/pulsar/issues/19196#issuecomment-1381434775 Perhaps also place a `--limit 2G` above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] dave2wave opened a new issue, #17898: Only Index Docs from Currently Supported Versions

2023-01-12 Thread GitBox
dave2wave opened a new issue, #17898: URL: https://github.com/apache/pulsar/issues/17898 In Algolia there is a crawler configuration which skips "incubating" docs. I think that we should stop creating an index for versions of pulsar components which are no longer supporting. (1) We

[GitHub] [pulsar] tisonkun commented on issue #19196: [Doc] 2.10* docs provide incorrect command for `namespace set-backlog-quota`

2023-01-12 Thread GitBox
tisonkun commented on issue #19196: URL: https://github.com/apache/pulsar/issues/19196#issuecomment-1381433140 cc @labuladong @nodece -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on issue #17898: Only Index Docs from Currently Supported Versions

2023-01-12 Thread GitBox
tisonkun commented on issue #17898: URL: https://github.com/apache/pulsar/issues/17898#issuecomment-1381432449 I notice that the version config contains a option `noIndex` https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-docs#VersionsConfig to hint the search engine index

[GitHub] [pulsar-site] tisonkun merged pull request #382: Use server side redirection

2023-01-12 Thread GitBox
tisonkun merged PR #382: URL: https://github.com/apache/pulsar-site/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari opened a new pull request, #19225: [fix][ci] Fix CI issue where ubuntu apt repository azure.archive.ubuntu.com isn't available

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19225: URL: https://github.com/apache/pulsar/pull/19225 ### Motivation There's a problem with azure.archive.ubuntu.com apt mirror that causes many builds to fail. I reported it by adding a comment to an existing issue:

[GitHub] [pulsar-client-cpp] shibd commented on pull request #170: [feature] Support set ServiceUrlProvider when create client.

2023-01-12 Thread GitBox
shibd commented on PR #170: URL: https://github.com/apache/pulsar-client-cpp/pull/170#issuecomment-1381406248 > We only need to support passing a std::function. The initialize and close methods are redundant. The initialize and close methods are useful. We need pass `Client&` to

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #367: [blog] Add 2.10.3 release blog

2023-01-12 Thread GitBox
momo-jun commented on code in PR #367: URL: https://github.com/apache/pulsar-site/pull/367#discussion_r1068992548 ## blog/2023-01-09-Apache-Pulsar-2-10-3.md: ## @@ -0,0 +1,54 @@ +--- +title: "What’s New in Apache Pulsar 2.10.3" +date: 2023-01-09 +author: "liangyepianzhou,

[GitHub] [pulsar-client-cpp] shibd commented on pull request #168: Fix segfault caused by socket I/O on a closed io_service

2023-01-12 Thread GitBox
shibd commented on PR #168: URL: https://github.com/apache/pulsar-client-cpp/pull/168#issuecomment-1381385269 @RobertIndie Can you take a look? This error occurs frequently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar-site] Technoboy- commented on pull request #373: Update release note for 2.11.0

2023-01-12 Thread GitBox
Technoboy- commented on PR #373: URL: https://github.com/apache/pulsar-site/pull/373#issuecomment-1381384834 > @Technoboy- I did a couple of fixes when previewing this page:) Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar-site] Technoboy- merged pull request #373: Update release note for 2.11.0

2023-01-12 Thread GitBox
Technoboy- merged PR #373: URL: https://github.com/apache/pulsar-site/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] momo-jun commented on pull request #373: Update release note for 2.11.0

2023-01-12 Thread GitBox
momo-jun commented on PR #373: URL: https://github.com/apache/pulsar-site/pull/373#issuecomment-1381380238 @Technoboy- I did a couple of fixes when previewing this page:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-site] tisonkun merged pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-12 Thread GitBox
tisonkun merged PR #371: URL: https://github.com/apache/pulsar-site/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] tisonkun commented on pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-12 Thread GitBox
tisonkun commented on PR #371: URL: https://github.com/apache/pulsar-site/pull/371#issuecomment-1381364166 Merging... Thanks for your contribution @Sherlock113 and thanks to all reviewers! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] nodece commented on a diff in pull request #19197: [feat][broker] Update AuthenticationProvider to simplify HTTP Authn

2023-01-12 Thread GitBox
nodece commented on code in PR #19197: URL: https://github.com/apache/pulsar/pull/19197#discussion_r1068964150 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java: ## @@ -52,54 +49,12 @@ public AuthenticationFilter(AuthenticationService

[GitHub] [pulsar] nodece commented on a diff in pull request #19197: [feat][broker] Update AuthenticationProvider to simplify HTTP Authn

2023-01-12 Thread GitBox
nodece commented on code in PR #19197: URL: https://github.com/apache/pulsar/pull/19197#discussion_r1068952424 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -160,6 +163,20 @@ public String

[GitHub] [pulsar-site] tisonkun merged pull request #381: Manually generate 2.11.0 Javadoc

2023-01-12 Thread GitBox
tisonkun merged PR #381: URL: https://github.com/apache/pulsar-site/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece commented on a diff in pull request #19197: [feat][broker] Update AuthenticationProvider to simplify HTTP Authn

2023-01-12 Thread GitBox
nodece commented on code in PR #19197: URL: https://github.com/apache/pulsar/pull/19197#discussion_r1068942276 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java: ## @@ -138,10 +145,20 @@ default CompletableFuture

[GitHub] [pulsar-site] tisonkun opened a new pull request, #381: Manually generate 2.11.0 Javadoc

2023-01-12 Thread GitBox
tisonkun opened a new pull request, #381: URL: https://github.com/apache/pulsar-site/pull/381 Signed-off-by: tison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068932778 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -214,11 +227,18 @@ public synchronized boolean

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068929892 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068929892 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
poorbarcode commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068900015 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -214,11 +227,18 @@ public synchronized boolean

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #154: [feat] Support partitioned topic reader.

2023-01-12 Thread GitBox
shibd commented on code in PR #154: URL: https://github.com/apache/pulsar-client-cpp/pull/154#discussion_r1068899826 ## include/pulsar/ConsumerConfiguration.h: ## @@ -383,6 +383,26 @@ class PULSAR_PUBLIC ConsumerConfiguration { */ InitialPosition

[GitHub] [pulsar] horizonzy commented on pull request #19177: [improve][branch-2.8]Upgrade the bk version to 4.14.6

2023-01-12 Thread GitBox
horizonzy commented on PR #19177: URL: https://github.com/apache/pulsar/pull/19177#issuecomment-1381264712 > Please hold on to the upgrade due to the RocksDB issue. [apache/bookkeeper#3734](https://github.com/apache/bookkeeper/issues/3734) The issue concerns the bookie server;

[GitHub] [pulsar-site] tisonkun commented on pull request #371: [Blog] Add the Pulsar 2022 Year in Review blog

2023-01-12 Thread GitBox
tisonkun commented on PR #371: URL: https://github.com/apache/pulsar-site/pull/371#issuecomment-1381257026 Pending to merge... I'm going to merge this patch in hours if there are no more comments. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18273: [feat][txn] implement the SnapshotSegmentAbortedTxnProcessor

2023-01-12 Thread GitBox
congbobo184 commented on code in PR #18273: URL: https://github.com/apache/pulsar/pull/18273#discussion_r1067649532 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java: ## @@ -0,0 +1,651 @@ +/** + *

[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #367: [blog] Add 2.10.3 release blog

2023-01-12 Thread GitBox
tisonkun commented on code in PR #367: URL: https://github.com/apache/pulsar-site/pull/367#discussion_r1068868191 ## blog/2023-01-09-Apache-Pulsar-2-10-3.md: ## @@ -0,0 +1,54 @@ +--- +title: "What’s New in Apache Pulsar 2.10.3" +date: 2023-01-09 +author: "liangyepianzhou,

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068864518 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -243,6 +263,53 @@ public synchronized boolean

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068862483 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -144,7 +155,12 @@ private synchronized long

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068862368 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -308,6 +375,10 @@ public synchronized

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #367: [blog] Add 2.10.3 release blog

2023-01-12 Thread GitBox
momo-jun commented on code in PR #367: URL: https://github.com/apache/pulsar-site/pull/367#discussion_r1068861159 ## blog/2023-01-09-Apache-Pulsar-2-10-3.md: ## @@ -0,0 +1,54 @@ +--- +title: "What’s New in Apache Pulsar 2.10.3" +date: 2023-01-09 +author: "liangyepianzhou,

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068860037 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/ImmutableBucket.java: ## @@ -132,12 +131,26 @@ private void

[GitHub] [pulsar-site] Technoboy- commented on a diff in pull request #373: Update release note for 2.11.0

2023-01-12 Thread GitBox
Technoboy- commented on code in PR #373: URL: https://github.com/apache/pulsar-site/pull/373#discussion_r1068857083 ## release-notes/versioned/client-cpp-2.11.0.md: ## @@ -0,0 +1,35 @@ +--- +id: client-cpp-2.11.0 Review Comment: Removed, thanks -- This is an automated

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068855546 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -214,11 +227,18 @@ public synchronized boolean

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-12 Thread GitBox
mattisonchao commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1068855318 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -214,11 +227,18 @@ public synchronized boolean

[GitHub] [pulsar] github-actions[bot] commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1381219394 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18903: Support processingGuarantees "EFFECTIVELY_ONCE" in python function

2023-01-12 Thread GitBox
github-actions[bot] commented on issue #18903: URL: https://github.com/apache/pulsar/issues/18903#issuecomment-1381218064 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18908: [configuration between Pulsar and MongoDB Atlas not working]

2023-01-12 Thread GitBox
github-actions[bot] commented on issue #18908: URL: https://github.com/apache/pulsar/issues/18908#issuecomment-1381218031 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] codecov-commenter commented on pull request #19222: [fix][test] Fix flaky test CompactionReaderImplTest

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19222: URL: https://github.com/apache/pulsar/pull/19222#issuecomment-1381214261 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19222?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-client-node] shibd commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-12 Thread GitBox
shibd commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1381213324 @ericallam Hi, I [released](https://github.com/shibd/pulsar-client-node/actions/runs/3904096695) a hotfix version in my repository using this PR change, and I can use

[GitHub] [pulsar-site] Anonymitaet merged pull request #364: [fix][doc] Correct configuration requirements for the HDFS sinks

2023-01-12 Thread GitBox
Anonymitaet merged PR #364: URL: https://github.com/apache/pulsar-site/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #367: [blog] Add 2.10.3 release blog

2023-01-12 Thread GitBox
Anonymitaet commented on code in PR #367: URL: https://github.com/apache/pulsar-site/pull/367#discussion_r1068839021 ## blog/2023-01-09-Apache-Pulsar-2-10-3.md: ## @@ -0,0 +1,54 @@ +--- +title: "What’s New in Apache Pulsar 2.10.3" +date: 2023-01-09 +author: "liangyepianzhou,

[GitHub] [pulsar] codecov-commenter commented on pull request #19223: [improve][broker] Copy subscription properties during updating the topic partition number.

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19223: URL: https://github.com/apache/pulsar/pull/19223#issuecomment-1381209012 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19223?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #18810: [improve][broker] PIP-192: Implement broker registry for new load manager

2023-01-12 Thread GitBox
Demogorgon314 commented on code in PR #18810: URL: https://github.com/apache/pulsar/pull/18810#discussion_r1068833098 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/BrokerRegistryImpl.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-01-12 Thread GitBox
heesung-sn commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1068833055 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] [pulsar] Technoboy- closed pull request #19222: [fix][test] Fix flaky test CompactionReaderImplTest

2023-01-12 Thread GitBox
Technoboy- closed pull request #19222: [fix][test] Fix flaky test CompactionReaderImplTest URL: https://github.com/apache/pulsar/pull/19222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-01-12 Thread GitBox
Demogorgon314 commented on code in PR #19102: URL: https://github.com/apache/pulsar/pull/19102#discussion_r1068832278 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -55,6 +55,7 @@ import

[GitHub] [pulsar] mattisonchao closed pull request #19223: [improve][broker] Copy subscription properties during updating the topic partition number.

2023-01-12 Thread GitBox
mattisonchao closed pull request #19223: [improve][broker] Copy subscription properties during updating the topic partition number. URL: https://github.com/apache/pulsar/pull/19223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] dlg99 commented on a diff in pull request #19153: [improve] PIP-241: add TopicEventListener / topic events for the BrokerService

2023-01-12 Thread GitBox
dlg99 commented on code in PR #19153: URL: https://github.com/apache/pulsar/pull/19153#discussion_r1068812324 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicEventsListener.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] dlg99 commented on a diff in pull request #19153: [improve] PIP-241: add TopicEventListener / topic events for the BrokerService

2023-01-12 Thread GitBox
dlg99 commented on code in PR #19153: URL: https://github.com/apache/pulsar/pull/19153#discussion_r1068811806 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicEventsListener.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] mattisonchao opened a new pull request, #19223: [improve][broker] Copy subscription properties during updating the topic partition number.

2023-01-12 Thread GitBox
mattisonchao opened a new pull request, #19223: URL: https://github.com/apache/pulsar/pull/19223 ### Motivation we have supported creating a subscription with properties since #15503. It is a good way to support copy subscription properties during updating the topic partition

[GitHub] [pulsar] dlg99 opened a new issue, #19224: PIP-241: TopicEventListener / topic events for the BrokerService

2023-01-12 Thread GitBox
dlg99 opened a new issue, #19224: URL: https://github.com/apache/pulsar/issues/19224 ### Motivation Some Protocol Handlers may need to know about the topic-specific events to update internal caches and/or state. These mechanisms will be useful also for core Pulsar components

[GitHub] [pulsar] codecov-commenter commented on pull request #19221: [fix][test] Fix ProxyPrometheusMetricsTest flakiness and consistently close JAX-RS clients in tests

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19221: URL: https://github.com/apache/pulsar/pull/19221#issuecomment-1381129556 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19221?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] heesung-sn commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-12 Thread GitBox
heesung-sn commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1381121566 Raised a PR: https://github.com/apache/pulsar/pull/19222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] heesung-sn opened a new pull request, #19222: [fix][test] Fix flaky test CompactionReaderImplTest

2023-01-12 Thread GitBox
heesung-sn opened a new pull request, #19222: URL: https://github.com/apache/pulsar/pull/19222 Fixes https://github.com/apache/pulsar/issues/19214 ### Motivation Fixes https://github.com/apache/pulsar/issues/19214 ### Modifications Created

[GitHub] [pulsar] lhotari opened a new pull request, #19221: [fix][test] Fix ProxyPrometheusMetricsTest flakiness and consistently close JAX-RS clients in tests

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19221: URL: https://github.com/apache/pulsar/pull/19221 Fixes #19216 ### Motivation See https://github.com/apache/pulsar/pull/19217#issuecomment-1381096161 for details of the remaining problem in ProxyPrometheusMetricsTest ###

[GitHub] [pulsar] lhotari commented on issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics

2023-01-12 Thread GitBox
lhotari commented on issue #19216: URL: https://github.com/apache/pulsar/issues/19216#issuecomment-1381098258 Reopening the issue. After applying #19217, the actual problem shows up. ``` Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 15.921 s <<< FAILURE! -

[GitHub] [pulsar] lhotari commented on pull request #19217: [improve][test] Prevent "Failed to register Collector of type Counter"

2023-01-12 Thread GitBox
lhotari commented on PR #19217: URL: https://github.com/apache/pulsar/pull/19217#issuecomment-1381096161 Now the actual flakiness is coming to surface ``` Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 15.921 s <<< FAILURE! - in

[GitHub] [pulsar] codecov-commenter commented on pull request #19220: [improve][test] Run cleanup methods even when failfast mode is enabled

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19220: URL: https://github.com/apache/pulsar/pull/19220#issuecomment-1381095343 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19220?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari merged pull request #19215: [improve][client] Use Jackson's ObjectReader in Client's JSON readers

2023-01-12 Thread GitBox
lhotari merged PR #19215: URL: https://github.com/apache/pulsar/pull/19215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-12 Thread GitBox
lhotari commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1381085265 thank you @heesung-sn . I faced yet another one: https://github.com/apache/pulsar/actions/runs/3906374418/jobs/6674698961#step:11:540 -- This is an automated message from

[GitHub] [pulsar] lhotari commented on pull request #19217: [improve][test] Prevent "Failed to register Collector of type Counter"

2023-01-12 Thread GitBox
lhotari commented on PR #19217: URL: https://github.com/apache/pulsar/pull/19217#issuecomment-1381084031 There's a flaky assertion in the test case and after retry, the problem changed to the "Failed to register Collector of type Counter: test_counter_total is already in use by another

[GitHub] [pulsar] lhotari opened a new pull request, #19220: [improve][test] Run cleanup methods even when failfast mode is enabled

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19220: URL: https://github.com/apache/pulsar/pull/19220 ### Motivation - cleanup didn't happen for tests after failures when failfast mode is activated ### Modifications - ignore the failfast solution for @After* methods ###

[GitHub] [pulsar] lhotari closed issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics

2023-01-12 Thread GitBox
lhotari closed issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics URL: https://github.com/apache/pulsar/issues/19216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lhotari merged pull request #19217: [improve][test] Prevent "Failed to register Collector of type Counter"

2023-01-12 Thread GitBox
lhotari merged PR #19217: URL: https://github.com/apache/pulsar/pull/19217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari merged pull request #19212: [fix][ci] Fix PulsarFunctionLocalRunTest that broke after ClusterData validation changes

2023-01-12 Thread GitBox
lhotari merged PR #19212: URL: https://github.com/apache/pulsar/pull/19212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codecov-commenter commented on pull request #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19219: URL: https://github.com/apache/pulsar/pull/19219#issuecomment-1381059159 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on pull request #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

2023-01-12 Thread GitBox
lhotari commented on PR #19219: URL: https://github.com/apache/pulsar/pull/19219#issuecomment-1381045171 another case where this issue is happening: https://github.com/apache/pulsar/actions/runs/3905806139/jobs/6674164947#step:6:1875 -- This is an automated message from the Apache Git

[GitHub] [pulsar] lhotari opened a new pull request, #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19219: URL: https://github.com/apache/pulsar/pull/19219 ### Motivation The cache step in GitHub Actions workflows gets sometimes stuck. Example at https://github.com/apache/pulsar/actions/runs/3905696188/jobs/6673646325#step:6:17 ```

[GitHub] [pulsar] lhotari commented on pull request #19215: [improve][client] Use Jackson's ObjectReader in Client's JSON readers

2023-01-12 Thread GitBox
lhotari commented on PR #19215: URL: https://github.com/apache/pulsar/pull/19215#issuecomment-1380998956 > LGTM. @lhotari - do you have documentation indicating this is the preferred approach? Thanks. Do you mean the use of `ObjectReader` instead of `ObjectMapper`? Or the use of

[GitHub] [pulsar] lhotari commented on a diff in pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-12 Thread GitBox
lhotari commented on code in PR #19160: URL: https://github.com/apache/pulsar/pull/19160#discussion_r1068647149 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/LocalPoliciesResources.java: ## @@ -66,7 +66,7 @@ public CompletableFuture>> getLocalPolici

[GitHub] [pulsar] heesung-sn commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-12 Thread GitBox
heesung-sn commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1380982436 Ack. will work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-12 Thread GitBox
lhotari commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1380980081 @heesung-sn This test seems to be flaky. Do you have a chance to take a look at it? it was added by #18195 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] codecov-commenter commented on pull request #19215: [improve][client] Use Jackson's ObjectReader in Client's JSON readers

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19215: URL: https://github.com/apache/pulsar/pull/19215#issuecomment-1380979114 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19215?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] codecov-commenter commented on pull request #19217: [improve][test] Prevent "Failed to register Collector of type Counter"

2023-01-12 Thread GitBox
codecov-commenter commented on PR #19217: URL: https://github.com/apache/pulsar/pull/19217#issuecomment-1380979022 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19217?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-12 Thread GitBox
lhotari commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1380978378 another one: https://github.com/apache/pulsar/actions/runs/3905696188/jobs/6673192180#step:11:539 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] pgier opened a new issue, #19218: pulsar-shell CTRL-C should be interpreted as cancel the current command and should not exit the shell

2023-01-12 Thread GitBox
pgier opened a new issue, #19218: URL: https://github.com/apache/pulsar/issues/19218 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Motivation When running pulsar-shell, CTRL-C should

[GitHub] [pulsar] lhotari opened a new pull request, #19217: [improve][test] Prevent "Failed to register Collector of type Counter"

2023-01-12 Thread GitBox
lhotari opened a new pull request, #19217: URL: https://github.com/apache/pulsar/pull/19217 Fixes #19216 ### Motivation ProxyPrometheusMetricsTest is flaky. Please see #19216 for details. ### Modifications - unregister collector after the test - fix retries by

[GitHub] [pulsar] lhotari opened a new issue, #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics

2023-01-12 Thread GitBox
lhotari opened a new issue, #19216: URL: https://github.com/apache/pulsar/issues/19216 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

<    7   8   9   10   11   12   13   14   15   16   >