[GitHub] [pulsar] PierreZ commented on issue #5735: Provide raw counters metrics

2019-12-03 Thread GitBox 
PierreZ commented on issue #5735: Provide raw counters metrics
URL: https://github.com/apache/pulsar/issues/5735#issuecomment-561520933
 
 
   Thanks, I will do this  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] PierreZ commented on issue #5735: Provide raw counters metrics

2019-12-02 Thread GitBox 
PierreZ commented on issue #5735: Provide raw counters metrics
URL: https://github.com/apache/pulsar/issues/5735#issuecomment-560480210
 
 
   Found a naive solution, by creating a [Counter directly on the AbstractTopic 
class](https://github.com/apache/pulsar/commit/8625db717c021318d65f70b9b19b0c181ebbc64b).
 I am not sure if this is recommend though. What do you think @sijie?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] PierreZ commented on issue #5735: Provide raw counters metrics

2019-11-29 Thread GitBox 
PierreZ commented on issue #5735: Provide raw counters metrics
URL: https://github.com/apache/pulsar/issues/5735#issuecomment-559748757
 
 
   I started working on it. From what I see, the rate is computed through 
[Rate](https://github.com/apache/pulsar/blob/master/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/Rate.java),
 which seems to be hold by 
[Producer](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java)
 which `Represents a currently connected producer`. The rate is [polled 
frequently](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L383-L386).
 As the classes are representing by **connected** {Producer, Consumer} and the 
fact the update is async, we can miss events between two polls if a {Producer, 
Consumer} disconnects.
   
   I'm wondering if the metrics can be generated from a place less volatile, 
maybe at the opening of the managed ledger? What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] PierreZ commented on issue #5735: Provide raw counters metrics

2019-11-26 Thread GitBox 
PierreZ commented on issue #5735: Provide raw counters metrics
URL: https://github.com/apache/pulsar/issues/5735#issuecomment-558568942
 
 
   I like `pulsar_in_bytes_total`!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services