[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike sink connector guide*

2019-09-24 Thread GitBox
Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike 
sink connector guide*
URL: https://github.com/apache/pulsar/pull/5256#discussion_r327626634
 
 

 ##
 File path: site2/docs/io-aerospike-sink.md
 ##
 @@ -0,0 +1,25 @@
+---
+id: io-aerospike-sink
+title: Aerospike sink connector
+sidebar_label: Aerospike sink connector
+---
+
+The Aerospike sink connector writes messages from Pulsar topics to Aerospike 
clusters.
+
+## Configuration
+
+The configuration of the Aerospike sink connector has the following properties.
+
+### Property
+
+| Name | Type|Required | Default | Description 
+|--|--|--|-|-|
+| `seedHosts` |String| true | 3000 | The comma-separated list of one or more 
Aerospike cluster hosts.Each host can be specified as a valid IP 
address or hostname followed by an optional port number. | 
+| `keyspace` | String| true | |The Aerospike namespace. |
+| `columnName` | String | true| |The Aerospike column name. |
+|`userName`|String|false||The Aerospike username.|
+|`password`|String|false||The Aerospike password.|
+| `keySet` | String|false | | The Aerospike set name. |
+| `maxConcurrentRequests` |int| false | 100 | The maximum number of concurrent 
Aerospike transactions that a sink can open. |
+| `timeoutMs` | int|false | 100 | This property controls `socketTimeout` and 
`totalTimeout` for Aerospike transactions.  |
+| `retries` | int|false | 1 |The maximum number of retries before aborting a 
write transaction to Aerospike. |
 
 Review comment:
   OK, I've added.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike sink connector guide*

2019-09-24 Thread GitBox
Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike 
sink connector guide*
URL: https://github.com/apache/pulsar/pull/5256#discussion_r327486370
 
 

 ##
 File path: site2/docs/io-aerospike-sink.md
 ##
 @@ -0,0 +1,25 @@
+---
+id: io-aerospike-sink
+title: Aerospike sink connector
+sidebar_label: Aerospike sink connector
+---
+
+The Aerospike sink connector pulls messages from Pulsar topics to Aerospike 
clusters.
+
+## Configuration
+
+The configuration of the Aerospike sink connector has the following properties.
+
+### Property
+
+| Name | Type|Required | Default | Description 
+|--|--|--|-|-|
+| `seedHosts` |String| true | 3000 | The comma-separated list of one or more 
Aerospike cluster hosts.Each host can be specified as a valid IP 
address or hostname followed by an optional port number. | 
 
 Review comment:
   OK


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike sink connector guide*

2019-09-24 Thread GitBox
Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike 
sink connector guide*
URL: https://github.com/apache/pulsar/pull/5256#discussion_r327486370
 
 

 ##
 File path: site2/docs/io-aerospike-sink.md
 ##
 @@ -0,0 +1,25 @@
+---
+id: io-aerospike-sink
+title: Aerospike sink connector
+sidebar_label: Aerospike sink connector
+---
+
+The Aerospike sink connector pulls messages from Pulsar topics to Aerospike 
clusters.
+
+## Configuration
+
+The configuration of the Aerospike sink connector has the following properties.
+
+### Property
+
+| Name | Type|Required | Default | Description 
+|--|--|--|-|-|
+| `seedHosts` |String| true | 3000 | The comma-separated list of one or more 
Aerospike cluster hosts.Each host can be specified as a valid IP 
address or hostname followed by an optional port number. | 
 
 Review comment:
   OK, I've corrected.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike sink connector guide*

2019-09-23 Thread GitBox
Anonymitaet commented on a change in pull request #5256: [Doc] Add *Aerospike 
sink connector guide*
URL: https://github.com/apache/pulsar/pull/5256#discussion_r326997784
 
 

 ##
 File path: site2/docs/io-aerospike-sink.md
 ##
 @@ -0,0 +1,25 @@
+---
+id: io-aerospike-sink
+title: Aerospike sink connector
+sidebar_label: Aerospike sink connector
+---
+
+The Aerospike sink connector writes messages from Pulsar topics to Aerospike 
clusters.
+
+## Configuration
+
+The configuration of the Aerospike sink connector has the following properties.
+
+### Property
+
+| Name | Type|Required | Default | Description 
+|--|--|--|-|-|
+| `seedHosts` |String| true | 3000 | The comma-separated list of one or more 
Aerospike cluster hosts.Each host can be specified as a valid IP 
address or hostname followed by an optional port number. | 
+| `keyspace` | String| true | |The Aerospike namespace. |
+| `columnName` | String | true| |The Aerospike column name. |
+|`userName`|String|false||The Aerospike username.|
+|`password`|String|false||The Aerospike password.|
+| `keySet` | String|false | | The Aerospike set name. |
+| `maxConcurrentRequests` |int| false | 100 | The maximum number of concurrent 
Aerospike transactions that a sink can open. |
+| `timeoutMs` | int|false | 100 | This property controls `socketTimeout` and 
`totalTimeout` for Aerospike transactions.  |
+| `retries` | int|false | 1 |The maximum number of retries before aborting a 
write transaction to Aerospike. |
 
 Review comment:
   @tuteng what are the default values for line 18 to 22? 
   I don't find them in 
[AerospikeSinkConfig.java](https://github.com/apache/pulsar/blob/master/pulsar-io/aerospike/src/main/java/org/apache/pulsar/io/aerospike/AerospikeSinkConfig.java)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services