[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1539967517 > Thanks for your contribution @JooHyukKim! Would you mind updating the Javadoc for the `seek` and `seekAsync` methods to indicate what will happen if a user calls a seek method before a previous call completes? Will do! Later after work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1538222368 > @JooHyukKim May I ask what `#1` means? Oh... "#1" means My first ever contribution to Pulsar! I can remove the "#1" part from title if you think it will confuse the maintenance team. Just let me know~ @tisonkun > Thanks for your contribution! @tisonkun Thank you for great guidance on your part -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1538137187 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1538020452 Thank you @tisonkun, I made below two check style commands pass, "locally". My personal fork is not running CI. Is it supposed to run though? 樂樂 > ``` > mvn -B -T 8 -ntp initialize apache-rat:check license:check > mvn -B -T 8 -ntp initialize checkstyle:check > ``` > > Ping me once CI passed in your personal fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1538013120 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1537964007 > But any tool you searched is acceptable as long as the diagram is clear (with text, reviewers manually dump to diagram). Thank you for the tips! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1537476267 > I'd appreciate it if you can provide a timing diagram to prove the fix. You may refer to [apache/curator#430](https://github.com/apache/curator/pull/430) as a typical description. Np . May I ask what tool everyone conventionally uses? Or your suggestion @tisonkun ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1537453814 > @JooHyukKim BTW, edit comment won't send notification, I suggest you create new comment when you'd like to notify reviewers. Right, thank you for the reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar] JooHyukKim commented on pull request #20242: [fix][client] Java Client's Seek Logic Not Threadsafe #1
JooHyukKim commented on PR #20242: URL: https://github.com/apache/pulsar/pull/20242#issuecomment-1537265913 > Could you add a test for your changes? Sure! Will do in bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
