Technoboy- commented on code in PR #20321:
URL: https://github.com/apache/pulsar/pull/20321#discussion_r1193290156
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2164,7 +2161,7 @@ private CompletableFuture<Void> seekAsyncInternal(long
requestId, ByteBuf seek,
if (!duringSeek.compareAndSet(false, true)) {
log.warn("[{}][{}] Attempting to seek operation that is already in
progress, cancelling {}",
topic, subscription, seekBy);
- seekFuture.cancel(true);
+ seekFuture.completeExceptionally(new IllegalStateException());
Review Comment:
`new IllegalStateException()` -> `new
IllegalStateException("String.format("%s,%s attempting to seek operation that
is already in progress", topic, subscription))` may be better ?
@michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
