[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-24 Thread via GitHub
nodece commented on code in PR #19295: URL: https://github.com/apache/pulsar/pull/19295#discussion_r1086218698 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java: ## @@ -61,13 +80,47 @@ public AuthenticationDataSource

[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-21 Thread via GitHub
nodece commented on code in PR #19295: URL: https://github.com/apache/pulsar/pull/19295#discussion_r1083305247 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java: ## @@ -61,13 +80,47 @@ public AuthenticationDataSource

[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-20 Thread GitBox
nodece commented on code in PR #19295: URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082207478 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java: ## @@ -61,13 +80,47 @@ public AuthenticationDataSource

[GitHub] [pulsar] nodece commented on a diff in pull request #19295: [feat][broker] OneStageAuth State: move authn out of constructor

2023-01-20 Thread GitBox
nodece commented on code in PR #19295: URL: https://github.com/apache/pulsar/pull/19295#discussion_r1082207478 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java: ## @@ -61,13 +80,47 @@ public AuthenticationDataSource