[GitHub] [pulsar-client-node] shibd commented on pull request #322: [feat]: Support client.getPartitionsForTopic (#320)

2023-05-08 Thread via GitHub 


shibd commented on PR #322:
URL: 
https://github.com/apache/pulsar-client-node/pull/322#issuecomment-1539309252

   ```
   2023-05-09T02:41:35,995+ [pulsar-web-48-8] WARN  
org.eclipse.jetty.server.HttpChannelState - unhandled due to prior sendError
   javax.servlet.ServletException: javax.servlet.ServletException: 
java.lang.NumberFormatException: For input string: ""4""
at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:162)
 ~[org.eclipse.jetty-jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
at 
org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:181)
 ~[org.eclipse.jetty-jetty-server-9.4.48.v20220622.jar:9.4.48.v20220622]
   ```
   
   Maybe the request body format is invalid. Will cause the partition topic to 
create failed.
   
   1. You should assert the HTTP response code.
   2. You should be change request body format:
   
   ```diff
   -  data: '4',
   +  data: 4,
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-node] shibd commented on pull request #322: [feat]: Support client.getPartitionsForTopic (#320)

2023-05-08 Thread via GitHub 


shibd commented on PR #322:
URL: 
https://github.com/apache/pulsar-client-node/pull/322#issuecomment-1537981244

   > @shibd I have modified the code according to your comments. Also, I 
noticed the compile failed on Windows x86 platforms. I will check it later.
   
   Nice, Let's run ci look at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-client-node] shibd commented on pull request #322: [feat]: Support client.getPartitionsForTopic (#320)

2023-05-03 Thread via GitHub 


shibd commented on PR #322:
URL: 
https://github.com/apache/pulsar-client-node/pull/322#issuecomment-1533964239

   @XXXMrG Thanks for your contribution. Let's wait for your `TODO` list to be 
done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org