[GitHub] [pulsar-site] Anonymitaet commented on pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet commented on PR #544: URL: https://github.com/apache/pulsar-site/pull/544#issuecomment-1538266179 @tisonkun Oops! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet commented on PR #544: URL: https://github.com/apache/pulsar-site/pull/544#issuecomment-1527115499 @momo-jun @Huanli-Meng could you please help review? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet commented on PR #544: URL: https://github.com/apache/pulsar-site/pull/544#issuecomment-1527081114 > Yes Done, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet commented on PR #544: URL: https://github.com/apache/pulsar-site/pull/544#issuecomment-1525589407 @tpiperatgod thanks for your quick response! > it should be that the parameters passed in from the command line have a higher priority. Does that mean I can delete the 1st sentence and only keep the 2nd one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #544: [improve][fn] add docs for supporting reading config options from files in Python runner
Anonymitaet commented on PR #544: URL: https://github.com/apache/pulsar-site/pull/544#issuecomment-1524712753 Hi @tpiperatgod, I submit this PR since it's more convenient to show you my thoughts and preview. ### Preview  ### Doc changes explanations 2️⃣3️⃣ in the image above I've restricted the doc structure by "showing the example first" and then "explaining the details". Reasons: 1) Most developers are likely "learning by doing" rather than "learning by reading". Examples always attract them the most. "Hook them up" first and then they have more patience to read it through. 2) The doc structure is more clear. The beginning is the example, and the latter is the explanation. Splitting them up can increase readability. 1️⃣ Consolidate the note into running text to accommodate the new structure. I've also made other changes like updating all future tense to present tense since "[Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true](https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp)" in technical writing. ### Question 4️⃣ Seems that the explanations in this box is contradictory. The above indicates "--config-file" override "command-line", but the below says the opposite. Can you clarify a bit and give some examples? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
