[GitHub] [pulsar-site] Anonymitaet commented on pull request #565: Add CPP client table view doc.

2023-05-11 Thread via GitHub


Anonymitaet commented on PR #565:
URL: https://github.com/apache/pulsar-site/pull/565#issuecomment-1545063125

   > Thanks for your contribution!
   > 
   > 1. This PR ignores the 1st task in [[TableView-2] Implement all 
interfaces. pulsar-client-cpp#196 
(comment)](https://github.com/apache/pulsar-client-cpp/pull/196#issuecomment-1512418627)
 as we discussed before, any thoughts?
   > 2. Can you attach the related code PR in the doc PR description? So that 
reviewers will have more context, which can speed up the review process.
   
   Confirmed with @shibd,  the1st task can be skipped as compaction topics are 
enabled in TableView internally by default, and it is explained in 
https://pulsar.apache.org/docs/next/concepts-clients/#tableview  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-site] Anonymitaet commented on pull request #565: Add CPP client table view doc.

2023-05-09 Thread via GitHub


Anonymitaet commented on PR #565:
URL: https://github.com/apache/pulsar-site/pull/565#issuecomment-1541064214

   Thanks for your contribution!
   
   1. This PR ignores the 1st task in 
https://github.com/apache/pulsar-client-cpp/pull/196#issuecomment-1512418627, 
any thoughts?
   
   2. Can you attach the related code PR in the doc PR description? So that 
reviewers will have more context, which can speed up the review process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org