[GitHub] merlimat opened a new pull request #1157: Allow to override the auto-detected NIC speed limit

2018-01-30 Thread GitBox
merlimat opened a new pull request #1157: Allow to override the auto-detected NIC speed limit URL: https://github.com/apache/incubator-pulsar/pull/1157 ### Motivation In some cases the auto-detected NIC max speed reported by the OS does not correctly reflect the amount of bandwidth

[GitHub] merlimat commented on issue #1133: Property name in documentation is incorrect

2018-01-30 Thread GitBox
merlimat commented on issue #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361840449 retest this please This is an automated message from the Apache

[GitHub] merlimat closed pull request #1132: Explicitly set zookeeper version in broker

2018-01-30 Thread GitBox
merlimat closed pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Explicitly set zookeeper version in broker (#1132)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 55cb351 Explicitly set zookeeper

[GitHub] merlimat commented on issue #1132: Explicitly set zookeeper version in broker

2018-01-30 Thread GitBox
merlimat commented on issue #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#issuecomment-361827234 retest this please This is an automated message from the Apache

[GitHub] merlimat closed pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client

2018-01-30 Thread GitBox
merlimat closed pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client URL: https://github.com/apache/incubator-pulsar/pull/1029 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] merlimat closed issue #1017: Hashcode of message key is inconsistent between different language clients

2018-01-30 Thread GitBox
merlimat closed issue #1017: Hashcode of message key is inconsistent between different language clients URL: https://github.com/apache/incubator-pulsar/issues/1017 This is an automated message from the Apache Git Service.

[incubator-pulsar] branch master updated: Fix MessageRouter hash inconsistent on C++/Java client (#1029)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8d159ef Fix MessageRouter hash

[incubator-pulsar] branch master updated: Configure a max producer/consumer queue size enforced across partitions (#1123)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e783a58 Configure a max

[GitHub] merlimat closed pull request #1123: Configure a max producer/consumer queue size enforced across partitions

2018-01-30 Thread GitBox
merlimat closed pull request #1123: Configure a max producer/consumer queue size enforced across partitions URL: https://github.com/apache/incubator-pulsar/pull/1123 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] merlimat closed pull request #1077: Shade all broker dependencies

2018-01-30 Thread GitBox
merlimat closed pull request #1077: Shade all broker dependencies URL: https://github.com/apache/incubator-pulsar/pull/1077 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Fix bundler version error (#1155)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 94bbfda Fix bundler version error

[GitHub] merlimat closed pull request #1155: Fix bundler version error

2018-01-30 Thread GitBox
merlimat closed pull request #1155: Fix bundler version error URL: https://github.com/apache/incubator-pulsar/pull/1155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sschepens commented on issue #1141: Some clarifications on Retention documentation

2018-01-30 Thread GitBox
sschepens commented on issue #1141: Some clarifications on Retention documentation URL: https://github.com/apache/incubator-pulsar/pull/1141#issuecomment-361807703 :+1: This is an automated message from the Apache Git

[GitHub] merlimat commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls

2018-01-30 Thread GitBox
merlimat commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#discussion_r164941254 ## File path:

[GitHub] jai1 commented on issue #1123: Configure a max producer/consumer queue size enforced across partitions

2018-01-30 Thread GitBox
jai1 commented on issue #1123: Configure a max producer/consumer queue size enforced across partitions URL: https://github.com/apache/incubator-pulsar/pull/1123#issuecomment-361803242 retest this please This is an automated

[GitHub] merlimat closed pull request #1128: Use Optional instead of null checks when reading isolation policies

2018-01-30 Thread GitBox
merlimat closed pull request #1128: Use Optional instead of null checks when reading isolation policies URL: https://github.com/apache/incubator-pulsar/pull/1128 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: Use Optional instead of null checks when reading isolation policies (#1128)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 60a15f8 Use Optional instead of null

[GitHub] sijie opened a new pull request #1156: Introduce ConsumerGroupListener for realizing if a consumer is active in a failover subscription group

2018-01-30 Thread GitBox
sijie opened a new pull request #1156: Introduce ConsumerGroupListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156 ### Motivation This closes #1058 ### Modifications - introduce

[GitHub] lucperkins opened a new pull request #1155: Fix bundler version error

2018-01-30 Thread GitBox
lucperkins opened a new pull request #1155: Fix bundler version error URL: https://github.com/apache/incubator-pulsar/pull/1155 ### Motivation A CI issue emerged due to mismatched [Bundler](http://bundler.io/) versions between the build script in `site/scripts/build-all-versions.sh`

[GitHub] zhaijack commented on issue #1130: move all deployment related files into one directory?

2018-01-30 Thread GitBox
zhaijack commented on issue #1130: move all deployment related files into one directory? URL: https://github.com/apache/incubator-pulsar/issues/1130#issuecomment-361797413 seems has 1098 fix this. This is an automated

[GitHub] zhaijack closed issue #1130: move all deployment related files into one directory?

2018-01-30 Thread GitBox
zhaijack closed issue #1130: move all deployment related files into one directory? URL: https://github.com/apache/incubator-pulsar/issues/1130 This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat opened a new pull request #1154: Fixed use of static synchronized in LoadManagerShared

2018-01-30 Thread GitBox
merlimat opened a new pull request #1154: Fixed use of static synchronized in LoadManagerShared URL: https://github.com/apache/incubator-pulsar/pull/1154 ### Motivation This is an attempt to fix the issue in `ReplicatorTest` ( #1138 ) which is causing many CI builds to

[GitHub] merlimat commented on issue #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
merlimat commented on issue #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#issuecomment-361784841 @saandrews Change looks good. Just the comment on using `shared_ptr` instead of relying on user to keep the object alive.

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164924605 ## File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc ## @@ -74,4 +74,25 @@ void

[GitHub] merlimat closed issue #1075: Add documentation for Reader API

2018-01-30 Thread GitBox
merlimat closed issue #1075: Add documentation for Reader API URL: https://github.com/apache/incubator-pulsar/issues/1075 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] merlimat commented on issue #1075: Add documentation for Reader API

2018-01-30 Thread GitBox
merlimat commented on issue #1075: Add documentation for Reader API URL: https://github.com/apache/incubator-pulsar/issues/1075#issuecomment-361775983 Fixed in #1096 This is an automated message from the Apache Git Service.

[GitHub] merlimat closed pull request #1148: Use Apache dist server with HTTPS to link the release signatures

2018-01-30 Thread GitBox
merlimat closed pull request #1148: Use Apache dist server with HTTPS to link the release signatures URL: https://github.com/apache/incubator-pulsar/pull/1148 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Use Apache dist server with HTTPS to link the release signatures (#1148)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c86aeed Use Apache dist server with

[incubator-pulsar] branch master updated: Update maven compiler plugin to newest version (#1042)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0439a1f Update maven compiler plugin

[GitHub] merlimat closed pull request #1042: Update maven compiler plugin to newest version

2018-01-30 Thread GitBox
merlimat closed pull request #1042: Update maven compiler plugin to newest version URL: https://github.com/apache/incubator-pulsar/pull/1042 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164906083 ## File path: pulsar-client-cpp/lib/BatchMessageContainer.cc ## @@ -93,6 +93,10 @@ void

[GitHub] merlimat commented on issue #1120: Reader interface docs update

2018-01-30 Thread GitBox
merlimat commented on issue #1120: Reader interface docs update URL: https://github.com/apache/incubator-pulsar/pull/1120#issuecomment-361757176 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #1120: Reader interface docs update

2018-01-30 Thread GitBox
merlimat commented on issue #1120: Reader interface docs update URL: https://github.com/apache/incubator-pulsar/pull/1120#issuecomment-361757176 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #1148: Use Apache dist server with HTTPS to link the release signatures

2018-01-30 Thread GitBox
merlimat commented on issue #1148: Use Apache dist server with HTTPS to link the release signatures URL: https://github.com/apache/incubator-pulsar/pull/1148#issuecomment-361756861 retest this please This is an automated

[GitHub] merlimat commented on issue #1148: Use Apache dist server with HTTPS to link the release signatures

2018-01-30 Thread GitBox
merlimat commented on issue #1148: Use Apache dist server with HTTPS to link the release signatures URL: https://github.com/apache/incubator-pulsar/pull/1148#issuecomment-361756861 retest this please This is an automated

[GitHub] jai1 commented on issue #1002: Making Pulsar Proxy more secure

2018-01-30 Thread GitBox
jai1 commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361755903 retest this please This is an automated message from the Apache Git Service. To

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164898025 ## File path: pulsar-client-cpp/lib/ProducerImpl.cc ## @@ -50,7 +50,9 @@

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164894417 ## File path: pulsar-client-cpp/lib/ConsumerConfigurationImpl.h ## @@ -31,13 +31,18 @@ struct

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164889144 ## File path: pulsar-client-cpp/lib/BatchMessageContainer.h ## @@ -40,6 +40,7 @@ #include

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164889449 ## File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc ## @@ -74,4 +74,30 @@ void

[GitHub] merlimat commented on issue #1153: Fix increase partitions

2018-01-30 Thread GitBox
merlimat commented on issue #1153: Fix increase partitions URL: https://github.com/apache/incubator-pulsar/pull/1153#issuecomment-361752674 Note: this is based on #1151. For this PR just consider the 2nd commit. I'll rebase once the first PR is merged.

[GitHub] merlimat opened a new pull request #1153: Fix increase partitions

2018-01-30 Thread GitBox
merlimat opened a new pull request #1153: Fix increase partitions URL: https://github.com/apache/incubator-pulsar/pull/1153 ### Motivation Fixes #1143 Refactored the increase-partition REST handler to make use of the create-subscription operation to simplify the logic and

[GitHub] merlimat opened a new pull request #1151: Added REST handler to create a subscription on a topic

2018-01-30 Thread GitBox
merlimat opened a new pull request #1151: Added REST handler to create a subscription on a topic URL: https://github.com/apache/incubator-pulsar/pull/1151 ### Motivation Added a way to create a subscription on a topic, forcing the creation if the topic doesn't exist. This is

[GitHub] aahmed-se opened a new issue #1152: Change default pulsar stanalone behavior

2018-01-30 Thread GitBox
aahmed-se opened a new issue #1152: Change default pulsar stanalone behavior URL: https://github.com/apache/incubator-pulsar/issues/1152 Currently pulsar in standalone mode expects an advertised address to be passed to use localhost this is unnecessarily complicated , for cases such as

[GitHub] Licht-T commented on issue #1029: Fix MessageRouter hash inconsistent on C++/Java client

2018-01-30 Thread GitBox
Licht-T commented on issue #1029: Fix MessageRouter hash inconsistent on C++/Java client URL: https://github.com/apache/incubator-pulsar/pull/1029#issuecomment-361739523 @merlimat Now tests added! This is an automated

[GitHub] merlimat closed pull request #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine

2018-01-30 Thread GitBox
merlimat closed pull request #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine URL: https://github.com/apache/incubator-pulsar/pull/1047 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Add StatefulSet option for BookKeeper on Google Kubernetes Engine (#1047)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 53fa9d0 Add StatefulSet option for

[GitHub] cckellogg opened a new pull request #1150: No cluster name

2018-01-30 Thread GitBox
cckellogg opened a new pull request #1150: No cluster name URL: https://github.com/apache/incubator-pulsar/pull/1150 Building on this pull request. https://github.com/apache/incubator-pulsar/pull/1051 This is an

[GitHub] lucperkins commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine

2018-01-30 Thread GitBox
lucperkins commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine URL: https://github.com/apache/incubator-pulsar/pull/1047#issuecomment-361708691 retest this please This is an automated

[GitHub] merlimat commented on issue #1143: Errors in increasing number of partitions for a partitioned topic

2018-01-30 Thread GitBox
merlimat commented on issue #1143: Errors in increasing number of partitions for a partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1143#issuecomment-361701678 @rdhabalia I think the best way to solve the 2nd issue is to have a REST call to create the

[GitHub] merlimat closed pull request #1097: Validate expected types in Python code wrapper

2018-01-30 Thread GitBox
merlimat closed pull request #1097: Validate expected types in Python code wrapper URL: https://github.com/apache/incubator-pulsar/pull/1097 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat closed pull request #1122: Use Optional for returning least loaded broker

2018-01-30 Thread GitBox
merlimat closed pull request #1122: Use Optional for returning least loaded broker URL: https://github.com/apache/incubator-pulsar/pull/1122 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Validate expected types in Python code wrapper (#1097)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 53619ff Validate expected types in

[GitHub] merlimat opened a new issue #1149: Network interface max speed information can be unreliable on VMs

2018-01-30 Thread GitBox
merlimat opened a new issue #1149: Network interface max speed information can be unreliable on VMs URL: https://github.com/apache/incubator-pulsar/issues/1149 Expected behavior The Pulsar load manager is relying on the network traffic information of a broker to decide whether

[GitHub] merlimat opened a new pull request #1148: Use Apache dist server with HTTPS to link the release signatures

2018-01-30 Thread GitBox
merlimat opened a new pull request #1148: Use Apache dist server with HTTPS to link the release signatures URL: https://github.com/apache/incubator-pulsar/pull/1148 ### Motivation As pointed in #986, we're currently linking the release crypto signatures to the ASF mirrors, while

[GitHub] merlimat commented on issue #1138: Test Timeouts in ReplicatorTest

2018-01-30 Thread GitBox
merlimat commented on issue #1138: Test Timeouts in ReplicatorTest URL: https://github.com/apache/incubator-pulsar/issues/1138#issuecomment-361669521 After adding timeout in the setup/teardown phases: https://builds.apache.org/job/pulsar-pull-request/1349/ ```

[GitHub] merlimat commented on issue #1123: Configure a max producer/consumer queue size enforced across partitions

2018-01-30 Thread GitBox
merlimat commented on issue #1123: Configure a max producer/consumer queue size enforced across partitions URL: https://github.com/apache/incubator-pulsar/pull/1123#issuecomment-361664821 > Code changes look fine in general - except for once comment about using "throw" We're using

[incubator-pulsar] branch master updated: Publish pulsar-client-admin as a shaded artifact (#1095)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 650a6b8 Publish pulsar-client-admin

[GitHub] merlimat closed issue #1091: Provide shaded Jar for pulsar-admin

2018-01-30 Thread GitBox
merlimat closed issue #1091: Provide shaded Jar for pulsar-admin URL: https://github.com/apache/incubator-pulsar/issues/1091 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] merlimat closed pull request #1095: Publish pulsar-client-admin as a shaded artifact

2018-01-30 Thread GitBox
merlimat closed pull request #1095: Publish pulsar-client-admin as a shaded artifact URL: https://github.com/apache/incubator-pulsar/pull/1095 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Fix url option on client tool (#1146)

2018-01-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8c93ff8 Fix url option on client

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-01-30 Thread GitBox
ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r164794996 ## File path:

[GitHub] maskit commented on issue #1147: Add support for new configration interface to AuthenticaionTls

2018-01-30 Thread GitBox
maskit commented on issue #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#issuecomment-361596696 @merlimat I putted back the comment you removed on #1085 to deprecated the method since all plugins support the

[GitHub] maskit opened a new pull request #1147: Add support for new configration interface to AuthenticaionTls

2018-01-30 Thread GitBox
maskit opened a new pull request #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147 ### Motivation AuthenticationTls only supports the old configure interface but we should the new one as

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164596792 ## File path: pulsar-client-cpp/lib/MessageCrypto.h ## @@ -0,0 +1,95 @@ +/** + * Licensed to

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164596778 ## File path: pulsar-client-cpp/lib/MessageCrypto.h ## @@ -0,0 +1,95 @@ +/** + * Licensed to

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164597399 ## File path: pulsar-client-cpp/lib/ProducerImpl.cc ## @@ -262,12 +295,21 @@ void

[GitHub] saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-30 Thread GitBox
saandrews commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164597622 ## File path: pulsar-client-cpp/run-unit-tests.sh ## @@ -23,7 +23,9 @@ rm -rf ./pulsar-dist