[incubator-pulsar] branch master updated: Print periodic status of instances in localrun (#1734)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new cb648d2 Print periodic status of

[GitHub] sijie closed pull request #1734: Print periodic status of instances in localrun

sijie closed pull request #1734: Print periodic status of instances in localrun URL: https://github.com/apache/incubator-pulsar/pull/1734 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Move functions to use V2 style namespaces for internal data keeping (#1742)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a2f8aa8 Move functions to use V2

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387233604 @merlimat Okay, I understand what you're getting at now. Will change or delegate to Dave if necessary.

[GitHub] merlimat closed pull request #1742: Move functions to use V2 style namespaces for internal data keeping

merlimat closed pull request #1742: Move functions to use V2 style namespaces for internal data keeping URL: https://github.com/apache/incubator-pulsar/pull/1742 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186574681 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java ## @@ -205,7 +205,8 @@ public

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186575830 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BytesSchema.java ## @@ -21,15 +21,17 @@

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186575966 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java ## @@ -43,18 +44,19 @@

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186576446 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StringSchema.java ## @@ -37,19 +37,16 @@

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186575900 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BytesSchema.java ## @@ -21,15 +21,17 @@

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186576324 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/StringSchema.java ## @@ -37,19 +37,16 @@

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186576051 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/JSONSchema.java ## @@ -43,18 +44,19 @@

[GitHub] srkukarni commented on issue #1745: Seperate cmd line connector interface to explicit source and sink

srkukarni commented on issue #1745: Seperate cmd line connector interface to explicit source and sink URL: https://github.com/apache/incubator-pulsar/pull/1745#issuecomment-387232528 @sijie @jerrypeng This is an automated

[GitHub] srkukarni opened a new pull request #1745: Seperate cmd line connector interface to explicit source and sink

srkukarni opened a new pull request #1745: Seperate cmd line connector interface to explicit source and sink URL: https://github.com/apache/incubator-pulsar/pull/1745 ### Motivation The current cli interface is createSource/deleteConnector and createSink/deleteConnector. This is a

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387230526 @merlimat I've restructured the schema interface to use `ByteBuffer` instead of byte arrays, but I'm not sure if this is what you're looking for. If not,

[GitHub] srkukarni commented on issue #1744: Remove usage() call on ParameterException

srkukarni commented on issue #1744: Remove usage() call on ParameterException URL: https://github.com/apache/incubator-pulsar/pull/1744#issuecomment-387217225 Having been bit by this behavior many times, +100 for this change

[GitHub] merlimat closed pull request #1738: PIP-17: fix index entry offset error in OffloadIndexBlock

merlimat closed pull request #1738: PIP-17: fix index entry offset error in OffloadIndexBlock URL: https://github.com/apache/incubator-pulsar/pull/1738 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat closed pull request #1729: Include Jackson modules in shaded jar as well

merlimat closed pull request #1729: Include Jackson modules in shaded jar as well URL: https://github.com/apache/incubator-pulsar/pull/1729 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Include Jackson modules in shaded jar as well (#1729)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2de8548 Include Jackson modules in

[incubator-pulsar] branch master updated: fix idnex entry offset (#1738)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8f705be fix idnex entry offset

[GitHub] merlimat commented on a change in pull request #1743: ByteBuffer schema

merlimat commented on a change in pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#discussion_r186559436 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/ByteBufferSchema.java ## @@ -0,0 +1,41 @@

[GitHub] lucperkins opened a new pull request #1744: Remove usage() call on ParameterException

lucperkins opened a new pull request #1744: Remove usage() call on ParameterException URL: https://github.com/apache/incubator-pulsar/pull/1744 As it stands, the `pulsar-admin` tool (in particular the `functions` command) provides full usage output whenever a `ParameterException` is

[GitHub] lucperkins closed pull request #1261: Pulsar CLI help changes

lucperkins closed pull request #1261: Pulsar CLI help changes URL: https://github.com/apache/incubator-pulsar/pull/1261 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] merlimat closed pull request #1733: allow custom sources and sink to run on connector framework

merlimat closed pull request #1733: allow custom sources and sink to run on connector framework URL: https://github.com/apache/incubator-pulsar/pull/1733 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: allow custom sources and sink to run on connector framework (#1733)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 97829ef allow custom sources and

[GitHub] lucperkins opened a new pull request #1743: ByteBuffer schema

lucperkins opened a new pull request #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743 This PR adds a [`ByteBuffer`](https://docs.oracle.com/javase/7/docs/api/java/nio/ByteBuffer.html) schema to the slate of "default" schemas.

[incubator-pulsar] branch master updated: Add Commons Logging bridge to broker (#1740)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new cc77e6c Add Commons Logging bridge

[GitHub] merlimat closed pull request #1740: Add Commons Logging bridge to broker

merlimat closed pull request #1740: Add Commons Logging bridge to broker URL: https://github.com/apache/incubator-pulsar/pull/1740 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] srkukarni commented on issue #1742: Move functions to use V2 style namespaces for internal data keeping

srkukarni commented on issue #1742: Move functions to use V2 style namespaces for internal data keeping URL: https://github.com/apache/incubator-pulsar/pull/1742#issuecomment-387153493 @jerrypeng @sijie @merlimat This is an

[GitHub] srkukarni opened a new pull request #1742: Move functions to use V2 style namespaces for internal data keeping

srkukarni opened a new pull request #1742: Move functions to use V2 style namespaces for internal data keeping URL: https://github.com/apache/incubator-pulsar/pull/1742 ### Motivation In https://github.com/apache/incubator-pulsar/pull/1735 we moved to using apis for creating

[GitHub] srkukarni commented on a change in pull request #1734: Print periodic status of instances in localrun

srkukarni commented on a change in pull request #1734: Print periodic status of instances in localrun URL: https://github.com/apache/incubator-pulsar/pull/1734#discussion_r186422524 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[GitHub] ivankelly commented on issue #1741: BlockAwareSegmentInputStream should only return unsigned bytes

ivankelly commented on issue #1741: BlockAwareSegmentInputStream should only return unsigned bytes URL: https://github.com/apache/incubator-pulsar/pull/1741#issuecomment-387056965 Depends on #1739, which needs to go in first.

[GitHub] ivankelly opened a new pull request #1741: BlockAwareSegmentInputStream should only return unsigned bytes

ivankelly opened a new pull request #1741: BlockAwareSegmentInputStream should only return unsigned bytes URL: https://github.com/apache/incubator-pulsar/pull/1741 The contract for InputStream expects that read() returns a positive int, except in the case of EOF, when it returns -1. In

[GitHub] ivankelly opened a new pull request #1740: Add Commons Logging bridge to broker

ivankelly opened a new pull request #1740: Add Commons Logging bridge to broker URL: https://github.com/apache/incubator-pulsar/pull/1740 The AWS SDK, which we use for S3 offload uses commons logging as its logging API. For slf4j to be able to pick up this logs, we need to use the

[GitHub] ivankelly opened a new pull request #1739: Allow padding at end of last BlockAwareSegmentInputStream

ivankelly opened a new pull request #1739: Allow padding at end of last BlockAwareSegmentInputStream URL: https://github.com/apache/incubator-pulsar/pull/1739 Previous to this patch, we expected that the last block for an offloaded ledger would have its size calculated externally,

[GitHub] sijie closed pull request #1723: Skeleton code for S3 offload

sijie closed pull request #1723: Skeleton code for S3 offload URL: https://github.com/apache/incubator-pulsar/pull/1723 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #1729: Include Jackson modules in shaded jar as well

sijie commented on issue #1729: Include Jackson modules in shaded jar as well URL: https://github.com/apache/incubator-pulsar/pull/1729#issuecomment-386996735 @mgodave can you take a look at @merlimat 's comments? This is an

[GitHub] sijie closed pull request #1730: Make BlockAwareSegmentInputStream extend InputStream

sijie closed pull request #1730: Make BlockAwareSegmentInputStream extend InputStream URL: https://github.com/apache/incubator-pulsar/pull/1730 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Make BlockAwareSegmentInputStream extend InputStream (#1730)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c570fb1 Make

[incubator-pulsar] branch asf-site updated: Updated site at revision 1ab1e28

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 4219f44 Updated site at revision

[GitHub] sijie commented on a change in pull request #1734: Print periodic status of instances in localrun

sijie commented on a change in pull request #1734: Print periodic status of instances in localrun URL: https://github.com/apache/incubator-pulsar/pull/1734#discussion_r186358316 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[GitHub] zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock

zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock URL: https://github.com/apache/incubator-pulsar/pull/1738#issuecomment-386994095 retest this please This is an automated message

[GitHub] sijie commented on issue #1733: allow custom sources and sink to run on connector framework

sijie commented on issue #1733: allow custom sources and sink to run on connector framework URL: https://github.com/apache/incubator-pulsar/pull/1733#issuecomment-386982790 @rdhabalia can you review this again? I think @jerrypeng has addressed your comment.

[GitHub] zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock

zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock URL: https://github.com/apache/incubator-pulsar/pull/1738#issuecomment-386977907 retest this please === org.apache.pulsar.broker.service.ReplicatorTest.testCloseReplicatorStartProducer

[GitHub] zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock

zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock URL: https://github.com/apache/incubator-pulsar/pull/1738#issuecomment-386977907 retest this please This is an automated message

[GitHub] zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock

zhaijack commented on issue #1738: PIP-17: fix index entry offset error in OffloadIndexBlock URL: https://github.com/apache/incubator-pulsar/pull/1738#issuecomment-386977907 retest this please === org.apache.pulsar.broker.service.ReplicatorTest.testCloseReplicatorStartProducer