[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-09 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387955956 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] srkukarni commented on issue #1751: Allow ability to specify resources to functions

2018-05-09 Thread GitBox
srkukarni commented on issue #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#issuecomment-387936678 retest this please This is an automated message from the

[GitHub] srkukarni commented on issue #1751: Allow ability to specify resources to functions

2018-05-09 Thread GitBox
srkukarni commented on issue #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#issuecomment-387933484 retest this please This is an automated message from the

[incubator-pulsar] branch master updated: Have the ability to provide source/sink config in cmdline for sources/sinks (#1757)

2018-05-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8b2dfd0 Have the ability to provide

[GitHub] merlimat closed pull request #1757: Have the ability to provide source/sink config in cmdline for sources/sinks

2018-05-09 Thread GitBox
merlimat closed pull request #1757: Have the ability to provide source/sink config in cmdline for sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/1757 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[incubator-pulsar] branch master updated: BlockAwareSegmentInputStream should only return unsigned bytes (#1741)

2018-05-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 114be44 BlockAwareSegmentInputStream

[GitHub] merlimat closed pull request #1741: BlockAwareSegmentInputStream should only return unsigned bytes

2018-05-09 Thread GitBox
merlimat closed pull request #1741: BlockAwareSegmentInputStream should only return unsigned bytes URL: https://github.com/apache/incubator-pulsar/pull/1741 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions

2018-05-09 Thread GitBox
jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187213424 ## File path: conf/window_example.yml ## @@ -0,0 +1,33 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] merlimat commented on a change in pull request #1758: Windowing for Pulsar Functions

2018-05-09 Thread GitBox
merlimat commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187212999 ## File path: conf/window_example.yml ## @@ -0,0 +1,33 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] jerrypeng opened a new pull request #1758: Windowing for Pulsar Functions

2018-05-09 Thread GitBox
jerrypeng opened a new pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] srkukarni commented on a change in pull request #1750: Show stacktrace when Function fails

2018-05-09 Thread GitBox
srkukarni commented on a change in pull request #1750: Show stacktrace when Function fails URL: https://github.com/apache/incubator-pulsar/pull/1750#discussion_r187206998 ## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/Reflections.java

[GitHub] jaoki commented on issue #1750: Show stacktrace when Function fails

2018-05-09 Thread GitBox
jaoki commented on issue #1750: Show stacktrace when Function fails URL: https://github.com/apache/incubator-pulsar/pull/1750#issuecomment-387905288 @srkukarni how does it look like now? This is an automated message from the

[GitHub] merlimat closed pull request #1756: Throw exception of source/sink

2018-05-09 Thread GitBox
merlimat closed pull request #1756: Throw exception of source/sink URL: https://github.com/apache/incubator-pulsar/pull/1756 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Throw exception of source/sink (#1756)

2018-05-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f535627 Throw exception of

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-09 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387471749 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-09 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387811222 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-09 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387484239 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-09 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387465846 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat closed pull request #1754: Fix exception in offload index block for consistency

2018-05-09 Thread GitBox
merlimat closed pull request #1754: Fix exception in offload index block for consistency URL: https://github.com/apache/incubator-pulsar/pull/1754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Fix exception in offload index block for consistency (#1754)

2018-05-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 374075e Fix exception in offload

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187134438 ## File path:

[GitHub] ivankelly commented on issue #1755: Inject AmazonS3 into S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on issue #1755: Inject AmazonS3 into S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1755#issuecomment-387833950 retest this please This is an automated message from the

[GitHub] srkukarni commented on a change in pull request #1756: Throw exception of source/sink

2018-05-09 Thread GitBox
srkukarni commented on a change in pull request #1756: Throw exception of source/sink URL: https://github.com/apache/incubator-pulsar/pull/1756#discussion_r187124755 ## File path:

[GitHub] srkukarni opened a new pull request #1757: Have the ability to provide source/sink config in cmdline for sources/sinks

2018-05-09 Thread GitBox
srkukarni opened a new pull request #1757: Have the ability to provide source/sink config in cmdline for sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/1757 ### Motivation Explain here the context, and why you're making that change. What is the problem you're

[GitHub] srkukarni commented on issue #1757: Have the ability to provide source/sink config in cmdline for sources/sinks

2018-05-09 Thread GitBox
srkukarni commented on issue #1757: Have the ability to provide source/sink config in cmdline for sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/1757#issuecomment-387822036 @jerrypeng @sijie This is an

[GitHub] merlimat commented on a change in pull request #1756: Throw exception of source/sink

2018-05-09 Thread GitBox
merlimat commented on a change in pull request #1756: Throw exception of source/sink URL: https://github.com/apache/incubator-pulsar/pull/1756#discussion_r187118203 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java

[GitHub] srkukarni commented on issue #1756: Throw exception of source/sink

2018-05-09 Thread GitBox
srkukarni commented on issue #1756: Throw exception of source/sink URL: https://github.com/apache/incubator-pulsar/pull/1756#issuecomment-387815941 @jerrypeng @sijie This is an automated message from the Apache Git Service.

[GitHub] srkukarni opened a new pull request #1756: Throw exception of source/sink

2018-05-09 Thread GitBox
srkukarni opened a new pull request #1756: Throw exception of source/sink URL: https://github.com/apache/incubator-pulsar/pull/1756 ### Motivation If source/sink open fails, we need to bubble up that exception right away because otherwise the function will be in zombie state.

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-09 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387811222 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187073441 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187073606 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187073232 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187075521 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187076087 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187069001 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187072157 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187070366 ## File path:

[GitHub] ivankelly opened a new pull request #1755: Inject AmazonS3 into S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly opened a new pull request #1755: Inject AmazonS3 into S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1755 Rather than creating it directly in the offloader, inject the AmazonS3 object so that it can be mocked for testing. Master Issue:

[GitHub] ivankelly opened a new pull request #1754: Fix exception in offload index block for consistency

2018-05-09 Thread GitBox
ivankelly opened a new pull request #1754: Fix exception in offload index block for consistency URL: https://github.com/apache/incubator-pulsar/pull/1754 One number was being printed with 0x, the other wasn't. Added 0x for both, and changed it to use String.format() to avoid string

[GitHub] ivankelly opened a new pull request #1753: S3Offload datablock magic word should be negative

2018-05-09 Thread GitBox
ivankelly opened a new pull request #1753: S3Offload datablock magic word should be negative URL: https://github.com/apache/incubator-pulsar/pull/1753 When reading in a bunch of blocks, we need to know when we've hit the next block or padding. To identify padding, we just check if the

[GitHub] srkukarni commented on issue #1751: Allow ability to specify resources to functions

2018-05-09 Thread GitBox
srkukarni commented on issue #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#issuecomment-387666455 @jerrypeng updated This is an automated message from the

[GitHub] ivankelly commented on issue #1741: BlockAwareSegmentInputStream should only return unsigned bytes

2018-05-09 Thread GitBox
ivankelly commented on issue #1741: BlockAwareSegmentInputStream should only return unsigned bytes URL: https://github.com/apache/incubator-pulsar/pull/1741#issuecomment-387662918 @sijie done This is an automated message

[GitHub] jai1 closed pull request #1752: Fixed backporting errors and lombok license

2018-05-09 Thread GitBox
jai1 closed pull request #1752: Fixed backporting errors and lombok license URL: https://github.com/apache/incubator-pulsar/pull/1752 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch branch-1.22 updated: Fixed backporting errors and lombok license (#1752)

2018-05-09 Thread jai1
This is an automated email from the ASF dual-hosted git repository. jai1 pushed a commit to branch branch-1.22 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/branch-1.22 by this push: new 0093a80 Fixed backporting