[GitHub] merlimat commented on issue #1764: WIP - Pulsar Go client library

merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-388268109 @bruth Thanks for great comments. I'll go through them in detail This is an

[GitHub] merlimat closed pull request #1751: Allow ability to specify resources to functions

merlimat closed pull request #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Encode the path for download (#1765)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 14e893a Encode the path for download

[incubator-pulsar] branch master updated: Allow ability to specify resources to functions (#1751)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e2b95f2 Allow ability to specify

[GitHub] merlimat closed pull request #1765: Encode the path for download

merlimat closed pull request #1765: Encode the path for download URL: https://github.com/apache/incubator-pulsar/pull/1765 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] srkukarni commented on a change in pull request #1758: Windowing for Pulsar Functions

srkukarni commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187523451 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java

[GitHub] srkukarni commented on issue #1765: Encode the path for download

srkukarni commented on issue #1765: Encode the path for download URL: https://github.com/apache/incubator-pulsar/pull/1765#issuecomment-388233535 @jerrypeng @sijie This is an automated message from the Apache Git Service. To

[GitHub] srkukarni opened a new pull request #1765: Encode the path for download

srkukarni opened a new pull request #1765: Encode the path for download URL: https://github.com/apache/incubator-pulsar/pull/1765 ### Motivation At upload time, we are doing Codec.encode(path). We need to do the same for download as well. ### Modifications Describe the

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187492773 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187496341 ## File path: pulsar-client-go/examples/reader/reader.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187495531 ## File path: pulsar-client-go/examples/consumer/consumer.go ## @@ -0,0 +1,54 @@ +// +// Licensed to the

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187495247 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187493077 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187493612 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187496372 ## File path: pulsar-client-go/examples/reader/reader.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187496277 ## File path: pulsar-client-go/examples/reader/reader.go ## @@ -0,0 +1,48 @@ +// +// Licensed to the Apache

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187495993 ## File path: pulsar-client-go/examples/consumer/consumer.go ## @@ -0,0 +1,54 @@ +// +// Licensed to the

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187495185 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187495637 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187495855 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187494121 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] bruth commented on a change in pull request #1764: WIP - Pulsar Go client library

bruth commented on a change in pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#discussion_r187493466 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go ## @@ -0,0 +1,55 @@ +// +//

[GitHub] merlimat opened a new pull request #1764: WIP - Pulsar Go client library

merlimat opened a new pull request #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764 ### Motivation Go client library implemented on top of existing C++ client lib. TODOs: * Add tests * Package C++ client lib binaries as

[GitHub] merlimat closed pull request #1761: In C API add context pointer to callbacks

merlimat closed pull request #1761: In C API add context pointer to callbacks URL: https://github.com/apache/incubator-pulsar/pull/1761 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: In C API add context pointer to callbacks (#1761)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 40a5aa5 In C API add context pointer

[GitHub] sschepens commented on issue #1737: Bookies at 100% CPU

sschepens commented on issue #1737: Bookies at 100% CPU URL: https://github.com/apache/incubator-pulsar/issues/1737#issuecomment-388197249 @merlimat could you help us with this please? We're seeing the the locations folder tends to grow a lot and after rebuilding the index, the size

[GitHub] merlimat commented on issue #1761: In C API add context pointer to callbacks

merlimat commented on issue #1761: In C API add context pointer to callbacks URL: https://github.com/apache/incubator-pulsar/pull/1761#issuecomment-388185684 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1761: In C API add context pointer to callbacks

merlimat commented on issue #1761: In C API add context pointer to callbacks URL: https://github.com/apache/incubator-pulsar/pull/1761#issuecomment-388185684 retest this please This is an automated message from the Apache Git

[GitHub] srkukarni commented on a change in pull request #1763: Document Python dependencies

srkukarni commented on a change in pull request #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763#discussion_r187451571 ## File path: site/docs/latest/functions/quickstart.md ## @@ -212,6 +212,14 @@ If you see `Deleted

[GitHub] merlimat commented on issue #1761: In C API add context pointer to callbacks

merlimat commented on issue #1761: In C API add context pointer to callbacks URL: https://github.com/apache/incubator-pulsar/pull/1761#issuecomment-388174136 > I would suggest adding a Test for the C APIs As I mentioned in the past PR, I'll be adding tests from Go to cover both APIs

[GitHub] lucperkins opened a new pull request #1763: Document Python dependencies

lucperkins opened a new pull request #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763 In order to use Pulsar Functions for Python you need to install the `grpc` and `protobuf` libraries. This PR adds instructions to the docs.

[GitHub] srkukarni commented on issue #1751: Allow ability to specify resources to functions

srkukarni commented on issue #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#issuecomment-388156419 retest this please This is an automated message from the

[GitHub] lucperkins opened a new pull request #1762: [WIP] Tiered storage documentation

lucperkins opened a new pull request #1762: [WIP] Tiered storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1762 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions

jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187419648 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@

[GitHub] jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions

jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187415981 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/Pair.java ##

[GitHub] jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions

jerrypeng commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187412107 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@

[GitHub] merlimat closed pull request #1759: Base class for S3 testing

merlimat closed pull request #1759: Base class for S3 testing URL: https://github.com/apache/incubator-pulsar/pull/1759 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Base class for S3 testing (#1759)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 778fd74 Base class for S3 testing

[GitHub] merlimat opened a new pull request #1761: In C API add context pointer to callbacks

merlimat opened a new pull request #1761: In C API add context pointer to callbacks URL: https://github.com/apache/incubator-pulsar/pull/1761 ### Motivation Since in plain C we cannot add closures on a callback function (eg: by using `boost:bind()`), we need to pass an opaque

[GitHub] lucperkins opened a new pull request #1760: [WIP] Pulsar Functions resource docs

lucperkins opened a new pull request #1760: [WIP] Pulsar Functions resource docs URL: https://github.com/apache/incubator-pulsar/pull/1760 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] lucperkins commented on a change in pull request #1758: Windowing for Pulsar Functions

lucperkins commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187376630 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@

[GitHub] mgodave commented on a change in pull request #1758: Windowing for Pulsar Functions

mgodave commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187375718 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/Pair.java ## @@

[GitHub] lucperkins commented on a change in pull request #1758: Windowing for Pulsar Functions

lucperkins commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187375279 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/Pair.java ##

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-388097238 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-387955956 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] srkukarni commented on a change in pull request #1751: Allow ability to specify resources to functions

srkukarni commented on a change in pull request #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#discussion_r187372630 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[GitHub] massakam commented on a change in pull request #1751: Allow ability to specify resources to functions

massakam commented on a change in pull request #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#discussion_r187310654 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[GitHub] ivankelly commented on issue #1759: Base class for S3 testing

ivankelly commented on issue #1759: Base class for S3 testing URL: https://github.com/apache/incubator-pulsar/pull/1759#issuecomment-388003260 retest this please // ReplicatorGlobalNSTest.testRemoveLocalClusterOnGlobalNamespace

[GitHub] ivankelly commented on issue #1759: Base class for S3 testing

ivankelly commented on issue #1759: Base class for S3 testing URL: https://github.com/apache/incubator-pulsar/pull/1759#issuecomment-387991961 @zhaijack @sijie @merlimat This is an automated message from the Apache Git

[GitHub] ivankelly opened a new pull request #1759: Base class for S3 testing

ivankelly opened a new pull request #1759: Base class for S3 testing URL: https://github.com/apache/incubator-pulsar/pull/1759 Moves the setting up of the mock and s3 client into a base class so that it can be shared by multiple tests. Includes a switch, that can be flipped with

[incubator-pulsar] branch asf-site updated: Updated site at revision e695c82

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new bacb2b4 Updated site at revision

[GitHub] sijie commented on a change in pull request #1758: Windowing for Pulsar Functions

sijie commented on a change in pull request #1758: Windowing for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1758#discussion_r187249092 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@ -219,7

[GitHub] sijie closed pull request #1753: S3Offload datablock magic word should be negative

sijie closed pull request #1753: S3Offload datablock magic word should be negative URL: https://github.com/apache/incubator-pulsar/pull/1753 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: S3Offload datablock magic word should be negative (#1753)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e695c82 S3Offload datablock magic

[GitHub] sijie closed pull request #1755: Inject AmazonS3 into S3ManagedLedgerOffloader

sijie closed pull request #1755: Inject AmazonS3 into S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1755 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Inject AmazonS3 into S3ManagedLedgerOffloader (#1755)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c7117a3 Inject AmazonS3 into

[GitHub] srkukarni commented on issue #1751: Allow ability to specify resources to functions

srkukarni commented on issue #1751: Allow ability to specify resources to functions URL: https://github.com/apache/incubator-pulsar/pull/1751#issuecomment-387960626 retest this please This is an automated message from the